The `Background` template report (added in 3d04e4488) has been reported
in some instance to have CSS which could cause an empty page at the end
of the report.
This is caused by the following CSS rule which allow to have the
background at the bottom of the content:
.o_report_layout_background {
min-height: 1000px;
}
this is probably caused by a difference in header/footer height, font or
version of wkhtmltopdf (this has been reproduced on wkhtml 0.12.1).
A fix is hard to do for this and keeping the background at the bottom of
the report content because of how wkhtml behave. So to mitigate (and
hopefully it doesn't come back) the issue, this commit just change the
CSS min-height.
opw-726546
opw-743315
closes#17072
If an exception during the merges (such as a file descriptor overrun), we
would otherwise depend on the next garbage collection to close the
files. But the next GC may never come.
For example if we ran out of OS file descriptors during merge, all future
requests will crash for the same reason, and the process will never recover
because the GC will never run.
Much easier to explicitly close the files all the time.
The RPC system was not completely satisfactory, we decided to prepare
the future and do it properly. This commit introduces the new rpc
system, which replace the previous new one. We now simply have a
method, this._rpc, which takes a dictionary of parameters. The idea is
that depending on the parameters, it is able to add correct default
value when necessary.
For situations where we don't have the this._rpc method, we can use the
rpc.query method, which takes the same arguments, but directly calls
ajax.rpc instead of triggering up some events.
When editing a report, the editor is launched in an iframe with an
environment which is different from backend and frontend. The problem
here is that the editor uses the `Dialog` API while the report editor
was not loading the associated xml file this API needs to work. Indeed,
when clicking on the "Discard" button for example, nothing seemed to
happen as a dialog was supposed to be opened.
This worked before as the editor was not using the `Dialog` API until
commit 62fb1bb924.
Unfortunatly, this commit adapted "iframe.js" to load the associated
xml file but forgot to adapt the report editor. In a future
amelioration, this "iframe.js" file could be added to the report editor
so that all "iframe editor" environement work properly with the same
adaptation code.
opw-724784
Olivier Dony