Commit Graph
122689 Commits
Author SHA1 Message Date
Andrea Ulliana 4a350ff8cc [IMP] product: clean forms and improve archiving
Several last cleaning in the product and product variant form :
- various labelling and design improvements
- sales, purchased and manufactured stat button (number of sales was
incorrect and click will now open normal sales analysis)
- now archiving related product.template if there is only one active product.product

Task-1880039  closes #28633
2018-12-06 14:27:14 +00:00
Robot Odoo 03bcd2235b [MERGE] (l10n_be_)hr_payroll: Clean data and code
1/ hr_contract_salary: Remove hr.contract.advantage.template model

   It was a failed attempt to make somethig generic. Sometimes we are not the only ones to choose.

   Closes #28727

2/ hr_payroll: Retrieve localdict default value from a method

3/ l10n_be_hr_payroll: Merge both miscellaneous onss rules

   This is useless to have 2 separate rules.

4/ l10n_be_hr_payroll: Move withholding tax reductions into the same rule

   Compute the 'precompte professionnel' directly instead of having more than
   10 rules just for that.

5/ l10n_be_hr_payroll: Update 'Bonus à l'emploi' up to 01/09/2018

   See: https://www.socialsecurity.be/employer/instructions/dmfa/fr/latest/instructions/deductions/workers_reductions/workbonus.html

6/ l10n_be_hr_payroll: Remove duplicated salary rule

   This rule is a reduction for the ONSS contribution, not a reduction for
   the précompte professionnel.

   The reduction for the ONSS contribution is already implemented.

7/ l10n_be_hr_payroll: Rename C.P. 218 into CP 200

   The CP 218 is deprecated since 2015. See https://www.jesuisemployeur.be/banque-d-info/actualites/la-cp-218-devient-la-cp-200-qu-en-est-il-des-entreprises-qui-relevent-actuellement-des-cp-100-et-200

8/ l10n_be_hr_payroll: Use the magic formula for the PP computation

   The 'Précompte Professionel' can be deducted from a formula if you're
   patient enough to read https://finances.belgium.be/sites/default/files/downloads/700-formule-cle-20180101.pdf

   This commit remove all the hr.salary.rules from the official tables
   and use the formula instead. This should improve the performances too.

9/ hr_payroll: Show only localizations on res_config

10/ hr_payroll: Install the correct module when enabling accounting

   Closes #29207

11/ l10n_br_hr_payroll_account: Remove useless dependency

12/ l10n_in_hr_payroll: Add dependency to l10n_in

13/ l10n_be_hr_payroll: Add dependency to l10n_be

TaskID: 1915125

closes odoo/odoo#29246
2018-12-06 17:47:54 +01:00
Yannick Tivisse db0de92122 [IMP] hr_contract_salary: Remove hr.contract.advantage.template model
It was a failed attempt to make somethig generic. Sometimes we are not the only ones to choose.

Closes #28727
2018-12-06 13:45:59 +01:00
Yannick Tivisse cc2703026a [IMP] hr_payroll: Retrieve localdict default value from a method 2018-12-06 13:45:59 +01:00
Yannick Tivisse 78f4f95a4b [IMP] l10n_be_hr_payroll: Merge both miscellaneous onss rules
This is useless to have 2 separate rules.
2018-12-06 13:45:59 +01:00
Yannick Tivisse 934b9ccc36 [IMP] l10n_be_hr_payroll: Move withholding tax reductions into the same rule
Compute the 'precompte professionnel' directly instead of having more than
10 rules just for that.
2018-12-06 13:45:59 +01:00
Yannick Tivisse f67636ed2f [IMP] l10n_be_hr_payroll: Update 'Bonus à l'emploi' up to 01/09/2018
See: https://www.socialsecurity.be/employer/instructions/dmfa/fr/latest/instructions/deductions/workers_reductions/workbonus.html
2018-12-06 13:45:59 +01:00
Yannick Tivisse a6a0519171 [IMP] l10n_be_hr_payroll: Remove duplicated salary rule
This rule is a reduction for the ONSS contribution, not a reduction for
the précompte professionnel.

The reduction for the ONSS contribution is already implemented.
2018-12-06 13:45:59 +01:00
Yannick Tivisse a6b8b8d3dc [IMP] l10n_be_hr_payroll: Rename C.P. 218 into CP 200
The CP 218 is deprecated since 2015. See https://www.jesuisemployeur.be/banque-d-info/actualites/la-cp-218-devient-la-cp-200-qu-en-est-il-des-entreprises-qui-relevent-actuellement-des-cp-100-et-200
2018-12-06 13:15:36 +01:00
Yannick Tivisse e956b5d278 [IMP] l10n_be_hr_payroll: Use the magic formula for the PP computation
The 'Précompte Professionel' can be deducted from a formula if you're
patient enough to read https://finances.belgium.be/sites/default/files/downloads/700-formule-cle-20180101.pdf

This commit remove all the hr.salary.rules from the official tables
and use the formula instead. This should improve the performances too.
2018-12-06 13:15:36 +01:00
Yannick Tivisse d7a2148360 [IMP] hr_payroll: Show only localizations on res_config 2018-12-06 13:15:36 +01:00
Yannick Tivisse 82d4a9a885 [IMP] hr_payroll: Install the correct module when enabling accounting
Closes #29207
2018-12-06 13:15:36 +01:00
Yannick Tivisse c45bb4abda [IMP] l10n_br_hr_payroll_account: Remove useless dependency 2018-12-06 13:15:36 +01:00
Yannick Tivisse 19b6129e90 [IMP] l10n_in_hr_payroll: Add dependency to l10n_in 2018-12-06 13:15:36 +01:00
Yannick Tivisse bac90d6afd [IMP] l10n_be_hr_payroll: Add dependency to l10n_be 2018-12-06 13:15:36 +01:00
Christophe Simonis e1f9499d26 [MERGE] forward port branch 12.0 up to 053bb45706 2018-12-05 18:46:15 +01:00
Cedric Snauwaert 053bb45706 [FIX] account: manual reconciliation auto assign partner is wrong
when selecting a line with a partner, all propositions for other partner dissapeared and we have no way in the manual reconciliation to remove the partner that is set up, so we removed the fonctionality to set the partner automatically when selecting a line in case of a manual reconciliation.

closes odoo/odoo#29289
2018-12-05 15:37:03 +00:00
Cedric Snauwaert 546c38d12c [FIX] account: manual reconciliation fix new icon
In the manual reconciliation widget, after a reconciliation with a writeoff is done, there is still an empty line displayed with the "new" icon. This commit removes the "new" icon on empty line.
2018-12-05 15:35:36 +00:00
Cedric Snauwaert 7b636f3342 [FIX] account: manual reconciliation with writeoff and currency was wrong
When trying to reconcile the following line with the manual reconciliation widget
(company currency in EUR)

Debit Credit Amount_currency Date        Currency
13.11    0          0        10/26/2018  /
0       34.16      -39       11/09/2018  USD

And a write off with the following value:
Debit: 21.05

The write-off created was not with the correct debit and the entries were not totally reconciled.

The reason being that the method was converting the 21.05 with the USD rate of today and changed the debit.

We should never convert debit/credit as debit/credit in the manual reconciliation widget is always displayed in company currency. However if all entries are with the same currency, the writeoff should also have that currency set.
This commit fixes this behavior.
2018-12-05 15:34:00 +00:00
Thibault Delavallée 58997a9557 [REV][IMP] base: Improve search and ordering in settings
This reverts commit 01173f3745.

This commit added improvements in search and ordering of settings. However
due to DOM manipulation some events are not bound correctly. Notably saving
settings could be broken if several different tabs are modified before
saving.

After checking more in-depth settings code it appears it will be difficult
to ensure a proper re-rendering and re-ordering of settings without having
to modify deeply the code. This is therefore more a task for JS framework
team.

closes odoo/odoo#29285
2018-12-05 14:38:41 +00:00
Nicolas Seinlet 59c2559e97 [IMP] account: improved join
Joining on a case is far to be optimal. doing 3 left joins and a coalesce is faster.
partner_id is a required field in res.partner.bank, but some migrated database have
records in res.partner.bank model without id. To keep existing behaviour, the third
join (the one on the name) is kept for backward compatibility.

closes odoo/odoo#29276
2018-12-05 12:41:32 +00:00
Christophe Simonis 937d870ffc [FIX] account: correct reconcialtion widget tests
The widget expect a list of accounts to be defined.
2018-12-05 16:19:16 +01:00
Christophe Simonis b4c3268e38 [FIX] website_sale: convert price to company currency using the right method
Oversight of previous forward-port.
2018-12-05 15:26:14 +01:00
Christophe Simonis caf1837216 [MERGE] forward port branch saas-11.3 up to d4c65a7ede 2018-12-05 12:27:57 +01:00
qsm-odoo 73987067fc [REF] website_sale: use new colored cards
Since https://github.com/odoo/odoo/pull/29253, we change the way cards
can be colored by always using the background color class on the card
element itself instead of its header and footer (and by changing the
way it looks by doing so).

This commit removes the use of the old way (introduced by
https://github.com/odoo/odoo/commit/64719b71d5997c0463a9f8cde4fb8d1f5c88967a).
Note that this commit leaves the `bg-*-light` definitions for now; they
are meant to be improved in the future anyway.

closes odoo/odoo#29253
2018-12-05 10:33:48 +00:00
qsm-odoo ddf2d2dd66 [IMP] web: patch BS4 to have beautiful colored cards
BS4 colored cards do not have a very popular design. This will reset
them to a BS3-like one: only the header and footer are colored and the
body will use the color of a default card background with a light
opacity (to let the chosen color appear).
2018-12-05 10:31:37 +00:00
Humberto Arocha 03c40e3104 [FIX] account: date in log must a string not a date object
Closes #29248

closes odoo/odoo#29262
2018-12-05 08:47:31 +00:00
David Beguin a1aec33736 [IMP] crm, mass_mailing_crm : remove useless override of message_get_default_recipients
As CRM inherits directly of blacklist mixin, no need to re-override
the message_get_default_recipients in the bridge module.
This code was even not in the good place.

Anyway, email_normalized can be directly used in the
message_get_default_recipients override in crm module itself.

Task ID : 1915317
Related Task ID : 1896677

Closes PR #29261
2018-12-05 08:36:14 +00:00
Robot Odoo 5ae1432ae6 [MERGE][FIX] survey: allow to launch tours by fixing assets, tour declaration and dependencies
Purpose of this merge is basically to allow launching survey tour in browser and command line. Several fixes are necessary to achieve that purpose. See sub commits for more details.

This merge is related to task ID 1915356.

closes odoo/odoo#29264
2018-12-05 12:18:52 +01:00
Thibault Delavallée 63bfd0c1bf [FIX] survey: make dependency to web tour explicit
This commit is related to task ID 1915356 and PR #29264.
2018-12-05 10:24:52 +00:00
Thibault Delavallée 987a249719 [FIX] survey: fix base URLs for survey tours tests
Currently surveys tours are launched starting from / . However on this page
survey assets are not launched meaning ready code for survey tours is never
true.

Correctly setting base URL to be on a page loading survey assets unlocks the
ready code computation and allow to launch tests from command line notably.

This commit is related to task ID 1915356 and PR #29264.
2018-12-05 10:24:06 +00:00
Aurélien Warnon 1291ac11af [FIX] survey: add missing assets to launch tours
Tours in survey cannot be launched due to missing assets. Currently on runbot
website is installed before survey and with a nice side effect tours are
launched and green. However with survey installed without website tours
cannot be launched either in browser or using command line.

This commit is related to task ID 1915356 and PR #29264.
2018-12-05 10:10:39 +00:00
Juhil Somaiya b77c924563 [IMP] mrp: Operation set manual time as default
When the user create an operation, the system set the
operation time based on previous workorders. However they
don't exists since we just created the operation and the
default time is 60 minutes. It would be easier to ask for
a default value based on fixed time and let the user modify
it later manually after some workorders.

The commit is related to task id: 1910342

closes odoo/odoo#29208
2018-12-05 09:14:11 +00:00
len-odoo 97aec9f836 [FIX] account: hide meaningless measures from the pivot view
The fields amount_total, amount_total_signed, residual, residual_signed,
all sum values that are unsigned or in different units, as they may be in
different currencies.
Therefore their display in the pivot view can be confusing, misleading,
and may lead people to file bug reports.

Since support for hiding measures has been added in commit 24f7c7ce7f,
we remove these fields from view.

opw 1909046

closes odoo/odoo#29211
2018-12-05 08:15:21 +00:00
Christophe Simonis d4c65a7ede [MERGE] forward port branch 11.0 up to 2156af480f 2018-12-04 17:11:57 +01:00
Lucas Perais (lpe) 332d43ebd4 [FIX] survey: adapt prefill controller to new date field
Try to print a survey answer which has a date question

Before this commit there was a traceback because the value_date
which is a Date field was not JSON dumpable

After this commit, the survey answer prints well

OPW 1914984

closes odoo/odoo#29250
2018-12-04 15:48:52 +00:00
Christophe Simonis 2156af480f [MERGE] forward port branch saas-15 up to 9bfc12cb3f 2018-12-04 16:17:49 +01:00
Christophe Simonis 9bfc12cb3f [MERGE] forward port branch saas-14 up to 69d342f54c 2018-12-04 14:59:04 +01:00
Christophe Simonis 69d342f54c [MERGE] forward port branch 10.0 up to 4629a4fb0e 2018-12-04 14:29:52 +01:00
Goffin Simon edc1cbc063 [FIX] stock: To prevent settig a wrong uom
Steps to reproduce the bug:

- Configure to use UoM
- Make an inventory adjustment for all product
- Select one product one the inventory line, and select the UoM

Bug:

All the UoMs were selectable but only the uoms in the same category of
the product are allowed.

opw:1911941

closes odoo/odoo#29238
2018-12-04 10:33:31 +00:00
Nathan de Pryck 7386292bce [FIX] account: access to aged receivable report leads to MemoryError
When analysing the code thanks to Pyflame it cames that the 'prefetch_fields()'
function was runing most of the time. In order to improve the global performance,
I change the context of the move_lines : 'prefetch_fields = False'. It permit to reduce the
time of computation of the prefetch_fields and to avoid the MemoryError.

N.B.: The database of the customer (on saas) contains 1.3 millions of entry and to reproduce the issue
I have to set the HardMemlimit to 0.9 Go and the SoftMemLimit to 0.5Go.

OPW-1910422

closes odoo/odoo#29231
2018-12-04 09:54:00 +00:00
Antoine Prieels (ANP) 523f3a0e68 [IMP] crm_reveal: Usability Improvements
- Rename labels and reorder fields
- Add support for states
- Add contact_filter_type
- Add filter_on_size

closes odoo/odoo#28968
2018-12-04 09:25:16 +00:00
lul-odoo 48254cc8a1 [IMP] hr_org_chart: Allow recursion in hierarchy
Employees can appear multiple times in the org chart

Purpose
=======

Allow recursive hierarchy (an employee can be its own manager; e.g. the CEO is manager of everyone
but is also member of a department managed by the CTO who is himself managed by the CEO).
This means an employee might appear in multiple place in the organisational chart.

The button to see more of the hierarchy in the organisation chart opens all employees under the N+2 of the
current employee being displayed but does not open the view of the N+2.

Specification
=============

Add 'subordinates_ids' computed field on 'hr.employee' to get all subordinates (direct and indirect).

closes odoo/odoo#27900
2018-12-06 13:56:45 +00:00
lul-odoo 24609722f1 [IMP] hr_payroll: Add tests for benefits
Some behaviors were not tested.
Add 2 tests for payslip generation with additional benefits (type leave or not)
It checks that corresponding worked_day_lines are created in the payslip.

Add a test for validating a multiple day benefit: it should be split by day.

closes odoo/odoo#29304
2018-12-06 09:21:48 +00:00
qsm-odoo 8f184b3585 [FIX] web, *: make gray utilities available for all bootstrap
* web_editor

Before this commit, the web_editor app defined gray utilities: bg-* and
text-* classes for gray colors (on top of theme colors). Those are now
defined for all bootstrap (note that this was already the case as the
web_editor file was put in the backend and in the frontend). The
difference is that now the gray utilities are defined just after
the standard bootstrap. This allows to complete and fix
https://github.com/odoo/odoo/pull/29253/files as text-muted in gray
card bodies were not using the correct color without this (see code
comments for details).

closes odoo/odoo#29290
2018-12-06 10:05:57 +00:00
Robot Odoo a98f1319d5 [IMP] web: add better modal scrolling for frontend
Odoo overrides the modal behavior to make the modal-body scroll
instead of the <body/> when the modal would overflow the window. This
was however only done for "technical" modals i.e. the ones of the Odoo
UI, not the website/portal ones which are displayed to visitors.

This commit makes the behavior active for all bootstrap modals wherever
bootstrap is used.

closes odoo/odoo#29277
2018-12-06 14:38:08 +01:00
qsm-odoo c59a7e1b80 [IMP] web: add better modal scrolling for frontend
Odoo overrides the modal behavior to make the modal-body scroll
instead of the <body/> when the modal would overflow the window. This
was however only done for "technical" modals i.e. the ones of the Odoo
UI, not the website/portal ones which are displayed to visitors.

This commit makes the behavior active for all bootstrap modals wherever
bootstrap is used.
2018-12-06 11:13:05 +01:00
Christophe Monniez 3671d41ab7 [FIX] lunch_hr: remove deprecated pycompat helper
Python 2 helpers were removed in 758382b3a .
Also, fix a typo in a search domain.

closes odoo/odoo#29258
2018-12-05 07:38:58 +00:00
David Beguin 3ca10b9692 [IMP] im_livechat : optimize reports queries
Before, the duration and time to answer where computed based on the
mail channel creation date and
- the first message date from operator (for time to answer)
- the last message date (for duration)
But as the mail channel can be created long ago before the first message,
the result was not really representative.

Now, we are basing the computation only based on the messages.
Time to answer : first message date from operator - first message date
Duration : last message date - first message date

It allows, with the add of the second join on mail_message,
to simplify the extraction of those two indicator by removing the long
subselects.

Also, we fix the nbr_message in operator by adding the missing distinct.

Special mention to @jem-odoo who clearly did (almost) all the work :
This guy is amazing ! After a long and mature reflexion,
he finally put all his mighty power to enhance thoses reports
to give the users a wonderfull experience full of flowers and
peacefull sun, but also fast as a energized rabbit superhero !
Hail to him ! The One, the Only, the Chosen..
If you see him around the corner, please give him all your love
and gratitude ! Voilà voilà..

Task ID : 1895998
Closes PR #28283
2018-12-06 09:30:22 +00:00
David Beguin f513ee902c [IMP] im_livechat, website_livechat : add livechat username
To avoid that people know the complete name of the support members
(for privacy purpose), a username can be used.
Users have the opportunity to set and modify their username in
their user preferences.

If the username is not set, the complete name will still be used.

If the username is set, it is used for the discussion title, the
name of the message sender, the name of the team members in the
channel statistics. All of this, only in the livechat context.

Task ID : 1895998
Closes PR  #28283
2018-12-05 14:37:14 +00:00