Commit Graph
127534 Commits
Author SHA1 Message Date
Kevin Baptiste 83aaea9e5c [IMP] base: Add option on image widget to enable zoom
Purpose
=======

As the employee picture on a form view is often too small,
it should be possible to zoom on it like for products in eCommerce.

Specification
=============

Added new bool options on FieldBinaryImage: `zoom` and `background`.

`zoom` will call zoomOdoo.js and display a popup with the zoomed out
image.

`background` is used to either display the image as a div element with
a background-url (to be used e.g. in a kanban view) or as a standard
img element.

closes odoo/odoo#33839

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-26 06:56:17 +00:00
Hetal Dhanak 2f34aea528 [FIX] mrp: hide button scrap on done WO
There is no such state as "confirmed" in 'mrp.workorder'. Hence changed
it to be 'done' instead as we don't want to scrap a done WO.

Task-2003916

closes odoo/odoo#33789

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-06-10 13:21:02 +00:00
Hetal Dhanak a29ce9bf90 [FIX] mrp: hide button "continue production" on done WO
previously button "continue production" was visible on work orders which
were in done state. Which was not ideal. Fixed it by hiding it.

Task-2003916
2019-06-10 13:21:02 +00:00
Antoine Prieels c80b5333b6 [FIX] hw_escpos: Avoid crashes on error
Two different problems on the box and resulted in the crash of the Odoo
instance running on the IoT Box:

When `usblp` had troubles communicating with a printer, a NoDeviceError
was raised. The `printer` variable was still set from the last time the
loop was processed, so we tried to close it, resulting in an error.

The code handling generic execptions was broken.

closes odoo/odoo#34300

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-06-21 12:07:01 +00:00
Prakash Prajapati 92ae9687e8 [IMP] generic: add field company_id on tree view
Now that the multi company mode is much more easier to
activate, it is needed to display this information on the
tree views, to help people to know on which company is
set some records in list view.

task-1997637
Closes: #3397

closes odoo/odoo#33976

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-26 07:54:39 +00:00
Martin Geubelle 372475e7ae [IMP] test_lint: raise max es version
ESNext is now supported in master so the max version number has been raised.
Note that es-check is still used but not for the original purpose ; it is
still useful for JS syntax checking.

closes odoo/odoo#34362

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-06-25 13:26:28 +00:00
Lucas Lefèvre ee1776dc5f [IMP] hr_attendance: Display checked in hours today
Purpose
======
When an empoyee wants to check out, he does not know the number of hours he worked today.

Specification
==========
In the check out view, display how many hours the employee was checked in today.

closes odoo/odoo#33974

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-26 06:52:31 +00:00
Mitali Patel 242be00429 [IMP] sale,account: automatic salesteam selection
This commit adds the automatic selection of the salesteam
for sale.order and account.invoice objects so that changing
the salesperson will automatically changes the team if the new
salesperson has one. If they are not part of a team, the current
value is left unchanged.

This will avoid having the manually correct the salesteam
every time the salesperson is modified.

task-1984950 closes-#33618

closes odoo/odoo#33618

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-06-24 12:37:33 +00:00
Kishan Gajjarandqsm-odoo 34c4b3ad8a [IMP] website_mass_mailing, *: improve newsletter snippets
* website, mass_mailing, web_editor

This commit adds various improvements in newsletter snippets as follow:

- Improves UI for newsletter popup.

- We only had one popup for all websites. Now, we can have a different
popup for each website.

- The popup was not appearing on mobile/tablet devices. Now, in
mobile/tablet devices, the popup appears automatically after 5secs.

- Added the ability to customize the whole editor popup like any
editable area (background colors, etc).

- User needed to enable popup snippet from the settings. We removed that
setting so now popup snippet will always be available.

- Added new snippet "Newsletter block".

- Display notification after successful subscription the same way for
all newsletter snippets.

Closes https://github.com/odoo/odoo/pull/29353
task-1903256

closes odoo/odoo#29353

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>


Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-06-25 09:20:35 +00:00
Kishan Gajjar 2ad49ec93e [IMP] web: add new options to the Dialog widget
Now we can display dialogs with or without header / footer / backdrop
and we can force the DOM to be put elsewhere than the body.

Part of https://github.com/odoo/odoo/pull/29353
task-1903256
2019-06-25 08:56:58 +00:00
Sébastien Theys 3e6bbe93af [IMP] mail: call _get_tracked_fields in batch
Before this commit `_get_tracked_fields` was not called in batch because it took
the `updated_fields` parameter, but this parameter is not used.

By removing the parameter and calling the method in batch, creating 1000
products takes 20% less time.

Part of task-1918881

closes odoo/odoo#34347

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2019-06-25 08:47:31 +00:00
Mohammed Shekha 37a82e62a2 [FIX] hr_org_chart: Render org chart even if no data
currently if no data given to hr_org_chart it throws traceback
because hr_org_chart template always expect that there will be
managers and children key in qweb rendering context, always pass
managers and children in qweb context if _getOrgData method returns
nothing still hr_org_chart should be rendered and should not throw
traceback

task-2000269

closes odoo/odoo#34152

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-25 08:04:32 +00:00
Shreya Modi e092060dfe [FIX] hr_org_chart: Fix traceback on employee creation
While creating employee and selecting a company other than the current company,
saving record shows a traceback.

Currently xml template expects managers and children key returned from
/get_org_chart controller but /get_org_chart was returning blank dict, and which
is used as qweb context to render template.

Return {'managers': [], 'children': []} if _check_employee returns False

task-2000269
2019-06-25 08:04:08 +00:00
jbm-odoo ccf4fc244a [IMP] hr_expense: Allow modifications depending on the stage
Purpose
=======

When an Expense report hits the "Approved" stage, the Accountant can no
longer edit the account / tax / analytic account fields. However, this
information can still be modified from the Expense itself, impacting
directly the related Expense report anyway. In any case, it makes sense
for an accountant to be able to edit this type of information, as it is
likely that an employee or a manager will input the wrong accounts.

On the other hand, once the Journal entries are posted, the Expense
report should not be editable anymore.

Specifications
==============

For the Expense report (hr.expense.sheet model):

If the report is in the "Approved" stage AND the user has at
least the Accounting / Accountant access right level

The following fields should be editable
- Taxes (tax_ids)
- Bill reference (reference)
- Account (account_id)
- Analytic account (analytic_account_id)

If the user has a lower access right level => the fields listed above remain
in read only.

If it is in the "Posted" stage (regardless of the access right level of the user):

The following fields should be in read only:
- Taxes (tax_ids)
- Account (account_id)
- Analytic account (analytic_account_id)

The "Bill reference" (reference) field should still be editable (current behavior).

Based on the Expense report's stage and the access right level of the user,
the fields of the related Expenses should also be editable (or not).

closes odoo/odoo#32918

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-25 10:28:26 +00:00
jbm-odoo 1e8db02368 [IMP] resource: Manage calendars over 2 weeks
Purpose
=======

In Belgium, we need to support some partial time on 2 weeks.
For instance, a mid time, means you could work on monday, tuesday
and wednesday on week1 and monday and tuesday on week 2. Others payroll
softwares manage this.

Specification
=============

Add a checkbox on resource calendar to manage 2 weeks. --> Consider even/odd weeks.
Add sections on calendars (Like sales orders)
Modify methods in resources to apply this behavor generically.

Check that attendances aren't overlapped

Write an integration test for holidays - benefits - payslip
to check all this, + "credit temps" and wage modification.

Note
====

For the sake of simplicity, we only manage calendars over 2 weeks
to consider the odd/even weeks and keep an easy implementation.
For more complicated calendars (eg: over a months with specific targetted days),
it's better to create specific allocation requests and apply specific leaves
for those days, as it would be the case for parental leaves.

closes odoo/odoo#31674

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-25 08:02:14 +00:00
Jinal Patel faf67303b3 [REF] stock: default warehouse
In a bunch of places, a default warehouse is selected to make an operation:
- default warehouse on a sale order
- default location of an unbuild order
- default location of an inventory adjustment

Before this commit, the warehouse that was created first was always selected.
Now, we introduce a sequence field and a widget handle so that the user can
chose the default one as he wishes.

Task- 2001671

closes odoo/odoo#34085

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-06-25 04:48:43 +00:00
svs-odoo 3520220268 [IMP] stock: generate multiple SN/LN for SML
Adds a button in stock move form view to generate multiple serial number
and assigns them to stock move lines.
Through a wizard, the user enter the first SN. Then, starting with this
number, iterates to assign and increment the SN on each move line who
doesn't have already one.

Task #1832645

closes odoo/odoo#33466

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-06-24 12:56:02 +00:00
jbm-odoo 0e69cd996d [IMP] hr_holidays: Compute real hours
The number of hours in time off were computed based on a mean of
number of hours in a week. It can engendre problem if an employee
doesn't work with the same number of hours every day.

Now the number of hours are computed based on employee's calendar
and so the real number of hours are used.

closes odoo/odoo#33137

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-24 11:38:20 +00:00
RomainLibert e4101e3857 [IMP] hr_holidays: avoid taking leave only on the week-end
In demo data, Marc demo was taking a sick leave during the first and
second of the month, the problem is that when the current month starts
with a saturday this leave ends up being placed only during the
week-end hence no leave should have been taken.
In order to avoid having this weird leave, Marc demo will now take three
days of sick leave

closes odoo/odoo#34318

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-06-24 08:32:23 +00:00
Aaron Bohy 17f5fa8a3b [FIX] web: fix layout when banner and search_panel
Before this rev., the layout was broken when a search_panel
was used alongside the onboarding banner in a kanban view. Note
that this usecase doesn't exist in standard.

Closes #31986

closes odoo/odoo#34303

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-06-21 14:11:58 +00:00
Varun Raval a5b6946940 [IMP] account: disallow company discrepancies B/W aml and account.move
Purpose of the commit is when multi-company is active and company A is a parent of company B.
When a user creates an account move with a Journal of company A and adds account move lines they are created with company A. But now user changes
the journal and select journal of different company and save the record system allows having the different company in account move and account move line.

After this commit when account move and account move line have different company and user tries to save, it will show a warning.

task-1970459

closes odoo/odoo#34244

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-06-21 13:33:37 +00:00
Varun Raval 58c8d1ed37 [FIX] account: fix inconsistency of vendor bill refunds in views
In vendor bill refunds they are not showing fields 'amount_untaxed' and
'amount_tax' with signed computation on views so there is inconsistency
in credit notes and vendor bill refunds.

After this commit in vendor bill refunds, fields are shown with signed
computation on views.

task-2008613

closes odoo/odoo#34086

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-06-21 08:37:46 +00:00
Mitali Patel b7504cc2e2 [IMP] sale: no variant creation from stat button action
Purpose of this commit is to prevent creating and
importing new variants from the variant list view
when you open it with the variant state button
becuase record not save while creating a new
variants on the fly from a product template.

task-1916037

closes odoo/odoo#33619

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-06-17 13:03:36 +00:00
MaxLarue 4ba1925a24 [IMP] sale_timesheet: improve demo data
previously sale_timesheet created orphans task. This commit links them to a project and adds stages to that project and it's tasks.

related task #1985386

closes odoo/odoo#33208

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-06-17 08:02:42 +00:00
shreya thakrarandAaron Bohy e264eca71a [IMP] web: searchpanel: use child_of operator for categories
When a category value is selected, we search for records matching this
category OR one of its children categories

task-1974632
closes: #33701

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>


Co-authored-by: Aaron Bohy <aab@odoo.com>
2019-06-20 12:32:46 +00:00
shreya thakrar 8385dc49d4 [FIX] hr: remove 'tag' filter from employee searchpanel
In employee searchpanel (left) view, In 'tag' selection,  their could be a lot
of records so it seems useless. That's why it has been removed by this commit.

task-1974632
closes: #33701
2019-06-20 12:32:46 +00:00
Xavier Morel 05746b7068 [IMP] *: script-safe JSON serialisation
* add a json_scriptsafe module, which re-exports the stdlib's json but
provides a script-safe `dumps` function, because of the way it works
the script-safe version is fine / safe to use outside script
contexts, so there's no need to provide different functions to qweb
contexts
* make the json.dumps in qweb contexts <script>-safe (should be
rendered using t-raw)
* update callsites to properly dump json:
- dump in template, not in the python code
- dump the entire structure at once, not bits and bobs inside a JSON
literal

Task 1999158

closes odoo/odoo#33682

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-06-19 13:47:35 +00:00
Xavier Morel 411abff388 [FIX] core: != / not ilike failing to match null records
As odoo makes little difference, one would expect `(field, !=, 'foo')`
or `(field, 'not ilike', 'foo')` to have the same behaviour when field is
empty, and provide the opposite result as the "positive" operators.

However because NULL <OP> <value> returns NULL which is generally
assimilated to false, the sections above would fail to match records
whose field is null (they would match records whose field is *empty*
though).

Fix this by wrapping the operation in a coalesce falling back
to (hopefully) the correct value if the result is null.

See also: odoo/odoo#22879

closes odoo/odoo#33959

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2019-06-07 08:07:13 +00:00
Gert Pellin ace7766971 [FIX] pos_restaurant: missing fields note, mp_skip
The note and mp_skip field of pos.order.line only exist in the frontend
application, this causes errors in some task of the PoS and IoT teams.

This pr adds the fields to the database, resolving these problems.

closes odoo/odoo#34210

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-06-18 08:50:13 +00:00
Jinal PatelandMohammed Shekha 756aa60ecf [IMP] web, project: improve examples background on kanban quick create column
This commit makes the use of the kanban more intuitive by changing the view's
example background columns labels.

kanbanExamplesRegistry will have object as a value instead of array,
ghostColumns and examples will be the key where ghostColumns defines column
titles for example background on column quick create and examples will be array
of examples which will be displayed on click of See Examples link in quick
create column
If ghoseColumns are not defined then dynamically ghost columns will be generated
with titles like Column 1, Column2...

task- 1937198

closes odoo/odoo#30911

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>


Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-06-18 09:28:23 +00:00
Juhil Somaiya 7bf0994e19 [IMP] purchase: added more meaningful error message
While confirming the quotation if there is no seller
who's matching the requirements at that time error
message was not clean.
So that, changed that message to a more meaningful
new message.

TaskID - 1948751

closes odoo/odoo#32644

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-06-04 08:37:44 +00:00
Sapan Zaveri 2e3b6b144d [FIX] payment_alipay: fix the broken alipay tests
The test case of alipay payment is going to failed due to:

1) Now the redirect_url from the return_url is removed in commit :
https://github.com/odoo/odoo/commit/0aefe72b773a21bdd38fdc86779d3030bd5127c6
but it's still it's there in test cases so removed from test case.

2) To make the transaction done it must be in  draft, pending or authorised
state but in first test case payment process the transaction state is set to
cancel and in another payment process use the same transaction again to set
it success so before use the same transaction again just set the state to draft.

task- 2005926
closes- #34132

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-06-14 09:17:11 +00:00
Christophe Simonis 9035fb8a2a [MERGE] forward port branch saas-12.4 up to 618ea1ab67 2019-06-18 10:24:25 +02:00
Robot Odoo 0fc33c37c3 [MERGE][IMP] *_timesheet: customer portal for timesheets
Impacted modules: hr_timesheet and sale_timesheet

This merge provides the customer portal part to display timesheets. Timesheets
can be seen from 3 differents points of view: list of timesheets, timesheets on
tasks, and timesheet linked to invoices (only for delivered qty policy).

When tracking time (sale_timesheet not installed), all timesheets can be displayed
to portal. When sale_timesheet is installed, if the timesheet is billed (billable_type
field), we only display the ones coming from a delivered qty policy selling. Indeed,
it makes no sense to display the 'ordered qty' timesheets, as it can reveal you sold
more time than required to your customer.

To do, we decided to remove access rules for portal user: timesheet (analytic line
model) is now technical and is given with `sudo` to portal. Admin can still restore
some of them to allow third part application with XML RPC.

See subcommits for more details

Task-1932488

closes odoo/odoo#31703

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-06-17 20:15:26 +02:00
Christophe Simonis 618ea1ab67 [FIX] test_mail: bump query count
For unknown reason (I didn't manage to find the culprit), the previous
forward-port generate more queries than before.
2019-06-17 18:27:28 +02:00
Christophe Simonis 0da246ef55 [FIX] core: not all falsy objects have an origin attribute
It avoid `X.browse([0]).exists()` to blow up.
2019-06-17 14:44:25 +02:00
Christophe Simonis 93b0f9ad2a [FIX] uom: define reference UoM first 2019-06-17 14:15:58 +02:00
Christophe Simonis 8fa477cbd9 [FIX] web_editor: use only ES5 compatible code 2019-06-17 14:10:03 +02:00
Christophe Simonis b6f7fe9a81 [IMP] test_lint: correctly format es-check error message 2019-06-17 14:09:31 +02:00
Christophe Simonis 65cc06e3ab [FIX] mail: use defined variable
Oversight of previous forward-port.
2019-06-17 14:08:45 +02:00
Hiral Bhavsar 3cd7ed07a2 [IMP] *: remove 'view_type' on window actions.
The old tree views don't really exist anymore, this odd pseudo-flag to
dispatch between "list" and "tree" tree views has no reason to remain.

Task 1937686

closes odoo/odoo#31243

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-06-17 11:34:17 +00:00
Christophe Simonis 25e3f27062 [MERGE] forward port branch saas-12.3 up to 48a9f5a633 2019-06-17 13:20:35 +02:00
Andrea Ulliana 3ab5612e4f [IMP] website_forum: add sequences
When you had several forums, they were displayed according to the
creation order. Now, you can define a sequence on them and order forums.

task-2007173

closes odoo/odoo#34184

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-17 11:02:38 +00:00
Sébastien Theys e05442fe19 [IMP] product, *: clean test and demo set up with attribute lines
* = account, mrp, purchase_stock, sale, sale_product_configurator,
stock_account, website_sale

It is always better to create the product template attribute lines before
creating the variants. In a following commit, this will become mandatory.

The variants that are created should always match the combination of attributes
set on the template.

Finally explicitly call `create_variant_ids` when possible instead of reassigning
the attribute lines to implicitly call `create_variant_ids`.

closes odoo/odoo#34122

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-17 10:52:01 +00:00
Odoo Translation Bot 48a9f5a633 [I18N] Update translation terms from Transifex 2019-06-16 06:15:35 +02:00
Christophe Simonis ced0e5becf [FIX] test_lint: also ignore js files in static/src/tests directory 2019-06-14 18:09:58 +02:00
Christophe Simonis 131e478ae6 [FIX] account: avoid usage of this in closure
Oversight of previous forward-port.
2019-06-14 17:29:51 +02:00
Christophe Simonis 34a8754d4f [MERGE] forward port branch saas-12.2 up to 498b4b4350 2019-06-14 15:20:01 +02:00
sri-odoo 498b4b4350 [FIX] website_slides: add missing <h1> tag (seo)
closes odoo/odoo#34137

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-14 10:16:58 +00:00
Jeremy Kersten 856685d640 [FIX] website_slides: use bigger image for shared content
Before this commit, share a slide was done with a small picture and so ugly

closes odoo/odoo#34133

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-14 09:42:03 +00:00