Commit Graph
108688 Commits
Author SHA1 Message Date
Wolfgang Taferner 236a24de96 [FIX] account: handling of text domains in _query_get
1df72cb01b added a stringification of
the domain parameter to handle situations where an actual
domain (list/tuple) is being provided rather than a string, however
this causes issues when the string input is text (unicode) containing
non-ascii data as in Python 2 `str()` will then raise a
UnicodeEncodeError.

Rather than stringify the input, bypass safe_eval when the input is
already a proper domain.

Closes #19367
2017-09-12 11:20:09 +02:00
Nicolas Martinelli 80ad2a370c [FIX] account_asset: deferred revenue account
- Associate a product with a "Deferred Revenue Type"
- Create a customer invoice and add the product => the account of the
  deferred revenue is used.
- Create a SO with the same product, and generate the invoice => the
  account of the deferred revenue is NOT used.

opw-769254
2017-09-12 11:06:12 +02:00
Cédric Pigeon 280d9986fd [FIX] prevent calling costful methods on empty recordset
Some methods are called on empty recordset causing lacking of performance.

opw:769720
2017-09-11 16:39:35 +02:00
Nicolas Martinelli 0327f3e467 [FIX] report: paper format
Make paper format mandatory on the company. If no paper format is
defined, the PDF created may have an unexpected format.

opw-770173
2017-09-11 15:46:53 +02:00
Goffin Simon 2e292a21e6 [FIX] mrp: Singleton expected in action_unbuild
In some cases, the consumed quants can be more than one.
In this case the check for the lot must be done just on the first
consumed quant. Courtesy of @jco.

opw:748472
2017-09-11 14:47:14 +02:00
Nicolas Martinelli d23667262b [FIX] account: future payment
- Create a vendor bill
- Register a payment in the future (e.g. Bank payment)

On the dashboard, this payment in the future is taken into account,
while it shows a graph up to today. Moreover, when clicking on
"Difference", the report is opened at today's date.

opw-768155
2017-09-11 13:35:30 +02:00
Nicolas Martinelli 7d72a72905 [FIX] calendar, web_calendar: change date
- Change the date of an event through the form view
  => a mail is sent to the attendees.
- Change the date of an event thanks to the drag and drop of an event
  => the mail is not sent.

It is necessary to introduce a context key in the write call so we can
make the distinction between the write triggered from the drag and drop
and the write triggered by a recomputation of fields. Indeed, when the
form view is used to change the date, `write` is called several times.
We should avoid sending the same email each time.

opw-766295
2017-09-11 13:27:23 +02:00
Christophe Simonis 7d7e94c6ef [MERGE] forward port branch 9.0 up to 46e3e739c5 2017-09-11 11:37:46 +02:00
Christophe Simonis 46e3e739c5 [MERGE] forward port branch saas-6 up to ddbc2da847 2017-09-11 11:24:25 +02:00
Christophe Simonis ddbc2da847 [MERGE] forward port branch 8.0 up to 7805cf5fef 2017-09-11 11:22:33 +02:00
Odoo Translation Bot c2866f17ff [I18N] Update translation terms from Transifex 2017-09-10 04:41:07 +02:00
Odoo Translation Bot 6740879407 [I18N] Update translation terms from Transifex 2017-09-10 00:30:05 +02:00
Fabien Meghazi 6fa705399b [FIX] http/db: handle case when db_filter is empty in the config file
In such a case the db filtering won't be applied on an empty regex so
we use the list of databases passed to `db_name` (--database) as
the database list (and we also avoid to list all the databases present
on the postgresql cluster)

As a side effect, this patch allows to strengthen the postgresql security
by preventing Odoo to list all the databases present on the cluster.
2017-09-08 18:29:26 +02:00
Nicolas Martinelli cbee332bb1 [FIX] mrp_repair: default location in multi-company
1. Create a new company
2. Create a user with access to this company and with access to repair
3. Connect as the new user
4. Try to create a new repair and the stock.warehouse access error
   should appear

opw-769160
2017-09-08 13:14:36 +02:00
Lucas Perais (lpe) 825c7c1ed6 [FIX] website_forum: fix display of images in a post
Before this commit, the images were messing up the layout of the post, with text uglily lying on their right
This commit solves the issue at rendering of the post, to ensure that current posts on prods be affected in a reversible manner.
Also, we want this commit to have minimal impact

OPW 769721

closes #19322
2017-09-08 09:44:30 +02:00
Lucas Perais (lpe) 7805cf5fef [FIX] tools: fix amount to text in fr and nl
Correct rendering of 70 and 90 in french
And manage inversion [unit]-en-[tens] in nl

opw 757048

closes #19297
2017-09-08 09:40:56 +02:00
Yenthe V.G 1d769ad5a7 [FIX] web: Don't show buttons when model has readonly access
PR #19314
2017-09-08 09:23:44 +02:00
Goffin Simon 55b8a454c9 [FIX] mrp: Unbuild order with serial number
When unbuilding an order with serial number, the quant with the right
serial number must be found in the system either it raises an UserError
explaining  what's the problem.

PS: A problem was found when we tried to unbuild two times the same MO.
After the first unbuild, we deleted it and recreated the same one.

opw:748472
2017-09-07 16:39:58 +02:00
Nicolas Martinelli 6879409723 [FIX] im_livechat: unsupported locale
- Set the browser to language 'Spanish (Latin America)' ('es-419')
- As a public user, open a livechat session.

The session doesn't open.

The root cause is the creation of a mail channel which contains
translatable fields (e.g. name). This attempts to create translations
in the 'es_419' language. However, this locale doesn't exist in Odoo,
and it triggers the constraint 'lang_fkey_res_lang'.

In this specific case, there is no real reason to translate the channel
name. Therefore, we simply avoid it thanks to a context key.

opw-766489
2017-09-07 15:54:26 +02:00
Nicolas Lempereur 73edebc371 [FIX] web_editor: enter remove or duplicate node
There is some odd behavior especially inside a editable containing
newlines.

For example in the sale description on an ecommerce item, lines could
contain newline (it is editable from backend) but as an effect of other
use case, pressing enter could have a range of unwanted side effects:

- removing all the content,
- duplicating the editable (should never happen, if we have one field
  "description_sale" we don't want to duplicate it, this has no sense)

In a product name which is in the same use case, there is no newline so
the problem is not apparent, and ENTER do nothing. This is the behavior
we should want in every instance.

If we still want a newline, we have to force it with SHIFT + ENTER key,
also this is regarding field that may or could be present in the backend
views, so it could also be edited in backend.

This change make ENTER ignored when we are editing a node directly child
of an node being edited.

A second part of the issue was that dom.removeBetween (used to remove
content inside a range) could remove the ancestor node that was an
editable. This is not wanted.

For example if we did CTRL + A inside a field with `<br />` then ENTER
or pasting something, the field would be removed and not just emptied
and could not be gotten back without editing the template manually.

This was sometimes mitigated because if a `<br />` was at the end of an
element, it would stay in this use case avoiding the issue.

note: not necessary after saas-16

fixes #17445
opw-751360
closes #19313
2017-09-07 09:38:56 +02:00
Nicolas Martinelli 18d63d4717 [FIX] delivery: zip code comparison
Some countries, such as Canada, are using letters in their zip code.
When we check if the zip code is within the accepted range, we should
make sure to normalize it by making it case insensitive.

opw-767866
2017-09-06 17:31:02 +02:00
Nicolas Martinelli 60dbf05750 [FIX] stock: performance issue
Commit 6a366b216b introduces a subquery when fetching translations in
order to avoid fetching duplicates. On large a `ir.translation` table
(~500000 records), this can cause a major performance degradation when
the user is not using the English language.

A typical example is a `read_group` call such as:
```
self.env['stock.quant'].with_context(lang='fr_BE').read_group([
    ('location_id', 'child_of', self.env.ref('stock.stock_location_stock').id)],
    ['product_id', 'qty'], ['product_id'], limit=80)
```

When no `orderby` parameter is used, the `groupby` fields are
implicitly used for ordering. While this makes sense for direct calls
from the web client, this implicit order might be problematic for
programmatic calls (such as computed fields). Indeed, in case of
grouping by product, the subquery mentioned earlier is used to sort by
product name. This is costly, and in most of the cases useless.

The workaround is to explicitely order by `id`, to avoid the use of the
subquery. For the upcoming version, a cleaner fix should be made in
order to prevent duplicated translations, and get rid of the subquery.

opw-767532
2017-09-06 17:14:45 +02:00
Goffin Simon ce9bbf6c10 [FIX] web: Setting ir.values for computed fields
Setting ir.values for computed fields is useless as the function onchange
in models.py will set to False all the computed fields with a modified dependence.

opw:767942
2017-09-06 16:30:05 +02:00
Lucas Perais (lpe) 45e0cd564a [FIX] web_editor, website_forum: allow to post videos on the forum
The commit 8749410b10 corrected the way the iframe was rendered to display a video in v9.0.
In v10 though, the html sanitizer is a bit more severe and cleans data-src attributes, preventing the iframe to have a src

This commit works around that and allows the src of the video to be saved in db

OPW 761424

closes #19125
2017-09-06 13:52:03 +02:00
Goffin Simon 8fd5951fbe [FIX] base_import: Specified Date Format in Import Statment is not recognized
Steps to reproduce the bug:

1. Import a bank statement with the shown dateformad DDMMYYYY (without headers)
2. Specify this date format in the advanced options
3. Try to find the date column to assign.

Bug:

The date format is not suggested for the fields with format DDMMYYYY.

opw:769118
2017-09-06 13:45:16 +02:00
Nicolas Martinelli a4bcb66bfc [FIX] base_import: headerless import
- Import a CSV file without header
- Untick the option 'The first row contains the label of the column'

An error is reported.

If no header, the method `_match_headers` should return consistent
object types.

opw-769117
2017-09-05 16:37:48 +02:00
Nicolas Martinelli d522a796d3 [FIX] calendar: all day event
- Set the TZ as 'America/Martinique'
- In the calendar (month view), click on a date D.
- Fill in the topic, then click on "Edit"

The date is set to D-1.

Commit 09066fbbd5 makes the date consistent when the user sets an
event as an all day event by taking into account the appropriate
timezone.

However, in the case of an event created from the month view, this TZ
modification should not be applied.

opw-766638
2017-09-05 16:33:04 +02:00
Christophe Simonis 80ca45b161 [MERGE] forward port branch 9.0 up to e300a587b3 2017-09-05 12:14:05 +02:00
Christophe Simonis e300a587b3 [MERGE] forward port branch saas-6 up to 0099074ab2 2017-09-05 11:27:58 +02:00
Christophe Simonis 0099074ab2 [MERGE] forward port branch 8.0 up to ce12a7397f 2017-09-05 11:26:19 +02:00
Lucas Perais (lpe) e14ab69772 [FIX] point_of_sale: control if a cashier is in localstorage
Before this commit, we could temporarily change cashier from A to B, and back to A seamlessly just by refreshing the page.
This could be a security issue for a cashier is held responsible for its sales.

This commit stores the cashier in localstorage, and with the right sets of methods, corrects the issue.

OPW 767827

closes #19207
2017-09-05 08:41:33 +02:00
Olivier Dony ce12a7397f [FIX] base: remove early size limit on author field
The default size limits set in base.sql are eventually superseded by the
actual limits (or absence of) when the DB schema is synchronized with
the Python model definitions.

However the list of modules (name, authors, descriptions, dependencies)
is loaded before this can happen. The length of the author field is one
case that can easily crash the database bootstrap process at that point,
should a module with a long author name be present in the addons path.

After schema sync, that size limit is lifted entirely (although Odoo Apps
does limit the max author name length to 512 at the moment, to prevent
abuse).

Fixes #5850
2017-09-05 01:46:47 +02:00
Olivier Dony 53bd1266b6 [FIX] doc: mention psycogreen dependency for gevent worker 2017-09-05 01:45:26 +02:00
Christophe Simonis abb726d4df [MERGE] forward port branch saas-11 up to 431b30b478 2017-09-04 18:46:46 +02:00
Christophe Simonis 431b30b478 [MERGE] forward port branch saas-10 up to aab6bdd54a 2017-09-04 18:38:25 +02:00
Elkasitu c5df78f38b [FIX] ir_model: Don't prefetch unnecessary fields
Do not prefetch unnecessary fields during the uninstallation of modules.

Previous to this commit, prefetching of unnecessary fields would cause server crashes
on some modules that add a field on ir_model_fields.
i.e. website_form
2017-09-04 15:46:19 +02:00
Elkasitu 8862bb01b9 [FIX] ir_model: Don't prefetch unnecessary fields
Do not prefetch unnecessary fields during the uninstallation of modules.

Previous to this commit, prefetching of unnecessary fields would cause server crashes
on some modules that add a field on ir_model_fields.
i.e. website_form
2017-09-04 14:57:13 +02:00
Christophe Simonis dad095de30 [MERGE] forward port branch 9.0 up to dc88a1ac42 2017-09-04 11:58:43 +02:00
Patel Jalpesh dc88a1ac42 [FIX] l10n_fr: migrate tags on taxes
Closes #19231
2017-09-04 11:55:45 +02:00
Lucas Perais (lpe) f98bb2b86b [FIX] website_sale: correct images of product and variants
Before this commit, when trying to edit through the website editor the product image, it was in fact the product variant that we edited.

This commit corrects it and when an image is displayed, the model it comes from is reliable

OPW 767539

closes #19168
2017-09-04 10:19:25 +02:00
Nicolas Martinelli abea8d3513 [FIX] crm: expected closing
Complement of commit 9d2f48dc7f

opw-724375
2017-09-04 10:13:12 +02:00
Lucas Perais (lpe) d22d4dcc23 [FIX] website_crm: fix lead creation through website_form
Before this commit, a message received through the contact us form did create a Lead, but any notification was impossible (even if a user was a follower of the relevant sales team.
This was because the default sales team is integrated in the values for create in models.py, which mail_thread can't see, but needs in order to notify

This commit corrects the behavior which now converge with standard lead creation by adding the default sales_team earlier in the values for create

OPW 762651

closes #19180
2017-09-04 10:09:06 +02:00
Goffin Simon 23f0fb6168 [FIX] website_sale: product category tree not clickable in eCommerce
When  the last selected category or search criteria in eCommerce had
no products(No product defined), the website category tree was not
clickable.

opw:767021
2017-09-04 09:39:05 +02:00
Nicolas Martinelli 8813e9cffc [FIX] website_sale_delivery: disable 'Pay Now' button
- Enable several shippers
- Enable Paypal acquier
- Buy a product on the eCommerce, go to payment page
- Change the shipper

While the page is reloading, the user has time to click on the 'Pay Now'
button.

opw-748467
2017-09-04 09:12:47 +02:00
Nicolas Martinelli 04990288a5 [FIX] website_sale: archived products
Archived products still published on the website will trigger a
traceback when accessed (the link might still exist in a search engine
results).

opw-767740
2017-09-04 08:46:46 +02:00
Wolfgang Taferner 85213a49b5 [FIX] mrp: generating raw move based on bom line should copy sequence
Closes #19182
opw-769259
2017-09-04 08:40:25 +02:00
Wolfgang Taferner bfa6394383 [FIX] hr_attendance: only if the check_out is later than the check_in
You can not create a check-in at 09:00 in case you have an attendance
where you checked out at 09:00.

Complement of bfa55e42f9

Closes #19226
opw-769773
2017-09-04 08:28:32 +02:00
Nicolas Martinelli 5d1dafbf9b [FIX] hr_expense: prevent deletion of posted expense
Prevent the deletion of expense or expense sheet if they are linked to a
journal entry.

Closes #19128
Closes #19044

opw-767549
2017-09-04 08:22:40 +02:00
Odoo Translation Bot 0e0771e319 [I18N] Update translation terms from Transifex 2017-09-03 04:40:05 +02:00
Odoo Translation Bot 11ce4d228d [I18N] Update translation terms from Transifex 2017-09-03 00:30:50 +02:00