100 Commits
Author SHA1 Message Date
Maximilien (malb) aec2529593 [ADD] l10n_rw: basic package
Add the basic package to the Rwanda localisation.

-COA
-Taxes
-Default settings
-Tax report
-Fiscal position

task-3584127

closes odoo/odoo#153501

Related: odoo/enterprise#57099
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2024-04-26 08:22:49 +00:00
Maximilien (malb) 2d323aa80e [FIX] l10n_din5008: size of the footer
General scaling of the footer font is too big. Normal Sized company names cannot
be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
This commit will reduce the size of the footer.

task-3192117

closes odoo/odoo#162557

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2024-04-19 23:49:53 +00:00
Maximilien (malb) 28fdcaabda [IMP] l10n_din5008: address display
Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

Task: 3817563
Part-of: odoo/odoo#162557
2024-04-19 23:49:53 +00:00
Maximilien (malb) 7e9a87388e [IMP] account: adding id
This pr will add an id on a div to be able to do a xpath on it.

closes odoo/odoo#157648

Task: 3756179
Related: odoo/enterprise#58640
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2024-04-05 12:18:13 +00:00
Maximilien (malb) 99701e7923 [FIX] sale,purchase,account,hr_expense: prevent wrap of taxes
Before this commit, it happens that the taxes display on the pdf were wrap,
specially when the description in the pdf were too long. This commit will add a
text-nowrap on the taxes when the len of the taxes is shorter than 10 characters

closes odoo/odoo#158774

Task: 3754824
X-original-commit: 95d0bd1794418ac8bdb4464c54304d3dcd0cb523
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2024-03-22 13:02:05 +00:00
Maximilien (malb) 98ff6909a7 [FIX] l10n_fr: translation issues
During this commit: https://github.com/odoo/odoo/commit/8bee46f117b1e6822429e8688f70cb27cc237bb4
We have translated the l10n_fr localisation, but we made a mistake on a line.
This PR will correct the translation issue

Task: 3792865
opw-3754691

closes odoo/odoo#157027

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2024-03-08 11:17:48 +00:00
Maximilien (malb) 109d6e14f2 [IMP] l10n_lu: Taxes update
In Luxembourg, during the year 2023, the VAT rates were decreased by 1%
temporarily. Now that we are in 2024, we need to deactivate the taxes added
previously. We will not remove them so that client can still use them if needed.

closes odoo/odoo#157015

Task: 3635758
X-original-commit: 75cb238785c4979846a2db434bb5a715fec44867
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2024-03-08 11:17:47 +00:00
Maximilien (malb) f587ca1b94 [IMP] l10n_lu: Adding tags
In this commit we will adds tags to some accounts. The tags added correspond to
a mapping that was added in this PR: https://github.com/odoo/enterprise/commit/81c427ba1a505e1e9d4a64dd6227bbb747214142
This mapping was useful to separate the tax and net amount and then use it in
the appendix A of the annual report.

We decided the use tags instead of this mapping so that it's clearer for the
users and to give control to them.

closes odoo/odoo#149752

Task: 3646832
Related: odoo/enterprise#54525
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
2024-03-06 08:41:53 +00:00
Maximilien (malb) 8ff33b212d [FIX] account: analytic widget UX
On the analytic widget, when putting an Analytic Account, a floppy disk appear
on top of the wizard.
This button is used to create a new analytic distribution template. It is
confusing for users that thinks that the purpose of the button is to save the
analytic distribution.

This PR will replace the button to be a link called "New model".

Also, this pr will fill some field (partner_id, account_prefix and product_id)
if there are populated.

closes odoo/odoo#155611

Task: 3736786
X-original-commit: c44367a2f67f305052d28a3b9e313ad63ff46907
Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2024-02-29 16:00:31 +00:00
Maximilien (malb) a49b1b8d84 [IMP] l10n_nl: translation
It appears that some user need to have the german translation on the dutch
localisation. This commit will translate the following files:
- COA
- Taxes
- Fiscal position
- Tax group
- Tax report

closes odoo/odoo#151296

Task: 3682464
Related: odoo/enterprise#55207
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2024-02-08 15:07:55 +00:00
Maximilien (malb) 2f86fb973a [IMP] l10n_ro_edi, base_vat: TIN numbers
There are multiple types of Identification Numbers in Romania and if you invoice
to a natural person, you are also required to send an electronic invoice.

Thus, we will add a check to allow the two TIN numbers that needs to be correct.

Example of valid tax number 'RO1234567897 or 'xyyzzaabbxxxx' or '9000xxxxxxxx'.
-Tin1: For xyyzzaabbxxxx, 'x' can be any number, 'y' is the two last digit of a
year (in the range 00…99), 'a' is a month, b is a day of the month, the number 8
 and 9 are Country or district code
-Tin2: 9000xxxxxxxx, start with 9000 and then is filled by number (range 0 to 9)

Also stdum also checks the CUI or CIF (Romanian company identifier). So a number
like '123456897' will pass.

This commit will remove some test that are not relevant anymore since we can't
apply a vat number that don't follow the legal convention.

closes odoo/odoo#152649

Task: 3716671
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2024-02-07 09:18:53 +00:00
Maximilien (malb) fda5d5f8d1 [FIX] l10n_in: Change Label
This commit will change the label to avoid the clash with account audit trail
module.

Also updating the pot of the localisation.

closes odoo/odoo#145149

Task: 3627720
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2024-02-05 12:20:56 +00:00
Maximilien (malb) b604767fd4 [IMP] l10n_dk_audit_trail: adding account_trail dependency
In the context of the bookkeeping act in denmark, we need to record all the
modification and delete of all the input, so we should by default install the
audit_trail module.
Since they need this in 17.0 we will make a bridge module.

Task: 3627720
Part-of: odoo/odoo#145149
2024-02-05 12:20:56 +00:00
Maximilien (malb) e5097a183a [IMP] account: payment term - Days end of month
This commit add a new delay_type that will add to the date the nb_days then go
the end of the month and finally add a new field called days_next_month.

This field is a Char because we want the field to be of size 2. Also, we added a
constraint that this field must be numeric and between 0 and 31.

Ex of use with Invoice date the 25/11/2023, if we have a payment term with 90
for the nb_days and 10 for the days_next_month:

+90 days = 23/02/2024
End of month = 29/02/2024
+10 days = 10/03/2024

(Also, there is a special case handling when the day of the month is 29, 30 or
31 to avoid exceeding the next month's end. For instance, with a payment term of
30 days end of month and using the 31st of a month, prevent calculation from
moving beyond the end of the next month (e.g., early March instead of end
February)

closes odoo/odoo#143758

Task: 3609320
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-12-15 11:40:43 +00:00
Maximilien (malb) e7e3e52cc0 [IMP] l10n_br_website_sale, portal, website_sale: translation
Currently, when using the website, you can input your information either during
the first checkout (website_sale) or in the profile (portal). The problem was
that the translation of the VAT was confusing for the user, as they may not
understand what "VAT" is.

We also added a field in the two forms, so it needed translation too.

This commit will change the translation in l10n_br_website_sale, website_sale
and portal to make it more clear for the user, helping them know what to input.

closes odoo/odoo#142165

Task: 3576516
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-12-08 09:53:38 +00:00
Maximilien (malb) c003cac091 [IMP] l10n_br_website_sale: vat required + identification type latam
At the moment, there are two possible flows to modify the personal information
of the user. Either during the first checkout (website_sale) or by modifying
the information on the account present on the website (portal).

For both of these flows, when the client and the website are Brazilian, the
input for the VAT must be required.
This commit will override the corresponding function to make the input required
under these conditions.

Also, we have added a new field on the two forms. Just before the vat input, we
can now find the l10n_latam_identification_type_id.

Task: 3576516
Part-of: odoo/odoo#142165
2023-12-08 09:53:38 +00:00
Maximilien (malb) 1be6866b15 [IMP] portal: country read-only
Before this commit, when a client had 1+ posted invoice he could still modify
his address, including his country. The country can have as much fiscal
implications for the Accounting as the Tax ID (both fields are used in the
Fiscal Positions mapping). For that reason, once an invoice has been made for a
customer, we should not let him change his country freely. This can still be
done in the back-end, but should not be possible in the front-end.

Also changing a bit the message to include the new read only on the country.

closes odoo/odoo#142910

Task: 3603353
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-12-06 11:22:03 +00:00
Maximilien (malb) a42f975df2 [IMP] l10_dk_bookkeeping: rate at transaction
Following the Bookkeeping Act Request we needed to have the conversion rate at
the time of the move (only when having a move with a currency different as the
one of the company) on the header of the form view.

This pr will add a new compute stored field, that will be displayed on the
header of the move only when the current company is Danemark, when the company
currency is different as the move currency and if there is at least a line.

The information we will display is the currency_rate of the first line since on
invoice and bill the currency_rate is the same for all the lines.

We also added a related on account_move_line to be able to see the rate on the
journal items list view.

closes odoo/odoo#141954

Task: 3592881
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-12-04 08:51:53 +00:00
Maximilien (malb) 34453bafc8 [FIX] account: report description
Before this commit, when creating a move with a product having no label. The
label will be automatically fill with "Bacon Burger" in the report.
By adding a condition on the span, the span will be empty if the label is empty
and can still be modified in studio if needed.

closes odoo/odoo#143050

Task: 3604617
X-original-commit: c0ddba176e9837ed1808b772237dff51c99a430d
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-11-22 07:43:10 +00:00
Maximilien (malb) 8b3394bcd3 [IMP] l10_dk: New tags
Following the Bookkeeping Act Request we needed to add a tag on each account of
the standard CoA. In this PR, we created a tag for each account and updated the
coa accordingly.

closes odoo/odoo#141976

Task: 3593628
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-11-15 15:03:53 +00:00
Maximilien (malb) 2087582500 [REV] point_of_sale: remove xpath
In this commit https://github.com/odoo/odoo/commit/00dcc575b8af5bee5204c45b80290a8e59fe10f9
they added an invisible condition of the accounting tabs (in the product view).

After discussion with the PoS product owner, there is still some doubts on how
combos product will be manage for the accounting tab (specially with
localisation). But if we remove the Accounting/Invoicing tab, the user will be
completely incapable to configure sales and taxes when combo products include
products with different taxes.

As we have doubts, we prefer keeping the tab by default no matter what the
product type is.

closes odoo/odoo#140896

Task: 3581797
Signed-off-by: William André (wan) <wan@odoo.com>
2023-11-06 18:11:31 +00:00
Maximilien (malb) d6bd6d5eec [IMP] hr_expense: attachment expense sheet
The goal of this pr is to remove the name of the file on the expense report.

closes odoo/odoo#141226

Task: 3473105
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
2023-11-06 15:36:58 +00:00
Maximilien (malb) 44c5c0ea35 [IMP] account_reports: composite reports
The goal of this pr is to add a tooltip to the use_sections field.

closes odoo/odoo#140973

Task: 3569038
Related: odoo/enterprise#50142
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-11-04 06:43:21 +00:00
Maximilien (malb) 3bc350a0e0 [IMP] account: swap date and invoice_date
We currently have two date fields, "date" and "invoice_date". Before this pr,
the "date" column was before the "invoice_date" field. We think it's more
logical to have "invoice_date" before the other, since it's the legal date.

What has been done:
- Swap in the tree view the two columns
- Swap in the search view the two columns

closes odoo/odoo#140878

Related: odoo/enterprise#50107
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-11-04 05:35:40 +00:00
Maximilien (malb) c123b676da [FIX] l10n_ar: traceback filter
It seems that the invisible is not working on filter and so the fiscal
country_code cannot be evaluated which causes a Traceback when trying to access
the res_partner form view.

closes odoo/odoo#139698

Task: 3270458
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-10-25 19:37:35 +00:00
Maximilien (malb) 7428dc9e0b [IMP] stock_account: country_code in the view
In some localisation (example: latam) we put company dependant field on the
stock.view_picking_form view. This commit will add the country_code in the form
view so that we can use it to hide information depending on the company.
Also removing the useless country_code field.

closes odoo/odoo#134617

Task: 3270458
Related: odoo/enterprise#47043
Related: odoo/upgrade#5266
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-10-20 11:22:01 +00:00
Maximilien (malb) 66820dc18d [FIX] l10n_ar: remove patch tour
Since we now make the fields of l10n_ar invisible for other companies, the
accounting tour is failing and the test is no really useful, so we decided to
delete it

 task: 3270458

Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) e28a9a74a3 [IMP] l10n_mx: UI clean up
This commit aims at changing a tooltip

Task: 3270458
Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) 45cb6818f8 [IMP] l10n_{ar,mx,ec,pe}: translation
This commit will contains all the PO and POT for the localisation that needed to
 be improved

Task: 3270458
Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) 97882a9190 [IMP] l10n_cl: UI clean up
This commit aims at changing a tooltip.

Task: 3270458
Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) 7a20638136 [IMP] l10n_pe: UI clean up
This commit aims at changing some tooltip and labels.

Task: 3270458
Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) ba63c09622 [IMP] l10n_ar: UI clean up
This commit aims at changing some tooltip, labels and changing the place of some
 fields. Also adding some invisible tags to avoid the fields to be displayed on
 other companies

 task: 3270458

Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) cc1ede9868 [IMP] l10n_ec: UI clean up
This commit aims at changing some tooltip to help the users

Task: 3270458
Part-of: odoo/odoo#134617
2023-10-20 11:22:01 +00:00
Maximilien (malb) 530f53635c [IMP] base_vat: vat validation Hungary
In Hungary, the tax id can be valid in different distinct ways. Either by
putting a vat number looking like 'HU12345678' (EU VAT) or '12345678-1-12'
(native format) or 8071592153 (Indiviual). To do the different check we added
regex to check if it matches one of the three ways, otherwise a validation error
 will be thrown.

closes odoo/odoo#139183

Task: 3522940
X-original-commit: 0504d98165c79499ee5d6c4263a33f66d96f9489
Signed-off-by: William André (wan) <wan@odoo.com>
2023-10-19 18:02:16 +00:00
Maximilien (malb) 655d375af8 [IMP] account, purchase, sale, l10n_br_sales, l10n_{ar,cl}: Ui fix
In this pr: https://github.com/odoo/enterprise/pull/30853 we've merged two
settings into one to make Tax calculation & display more coherent. In the case
of a "Tax per line" computation, the column "Tax Included" is optional=hide in
the backend, but we've elected to put it in the PDF all the time.

This task we will only change the pdf and portal (preview):
1. Remove the "Tax Incl" column on all relevant templates (pdf/portal).
2. Rename the "Tax Excl" column to "Amount".

task-3552656

closes odoo/odoo#138624

Related: odoo/enterprise#48923
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-10-18 12:05:15 +00:00
Maximilien (malb) dc7328ff0f [IMP] account_reports: hide line at 0
In the enterprise PR, we allow to have a new options on reports that can hide
line that are equals to zero under certain condition.

A line should be visible depending on its value and the ones of its children.
For parent lines, it's visible if there is at least one child with a value different from zero
or if a child is visible, indicating it's a parent line.
For leaf nodes, it's visible if the value is different from zero.

This commit add the filter in the account_reports model.

closes odoo/odoo#130897

Task: 3359936
Related: odoo/enterprise#45291
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-10-13 17:00:44 +00:00
Maximilien (malb) 01666d9c21 [IMP] account_report: trade account rework
Before this PR, the trade partner filter was using a boolean instead of a
selection field. This PR will change the type of the field to a selection.

closes odoo/odoo#135129

Task-id: 3499156
Related: odoo/enterprise#47288
Related: odoo/upgrade#5135
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-10-02 12:58:49 +00:00
Maximilien (malb) 15929134df [FIX] l10n_de: shipping address traceback
Before this PR, when there is no shipping address, the pdf show an empty
"Shipping Address" header. By changing the colspan dynamically we can manage to
keep the layout like it was and remove the useless section.

closes odoo/odoo#134435

Task-id: 3262408
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-09-28 09:04:08 +00:00
Maximilien (malb) 87b067adfe [FIX] l10n_de: din5008
In the din5008, there has been problem in the display of the paper format either
in the pdf or the preview.

In the preview we had a part of the page on the right that wasn't used caused by
the negative margin and the width of 180mm. But by removing that the pdf is
broken, the header is hiding some information.

To deal with that, we will add the width and negative margin only for the pdf
by adding a conditional css classes.

Also,it seems the footer with the company details can go out of page, by adding
a text-wrap on it, it solves this issue.

(In this commit, we override part of those commit:
https://github.com/odoo/odoo/commit/481f442f4ef176072edf3261415dbb06f8a3bc6f
https://github.com/odoo/odoo/commit/f7812ae848e0a79adcd11f936f6cd7890da00112)

closes odoo/odoo#136500

X-original-commit: 6512069880407e5c48b0a07c0b5a74fc74633c9c
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-09-25 15:20:27 +00:00
Maximilien (malb) 49d6bdb675 [IMP] hr_expense: expense report
This pr aim to improve the pdf of the expense report. we have changed the design
 of the header of the report, the table and also added an annex with the
 different attachments.

 For the attachments, when it's a pdf it's simply merge to the actual pdf but
 when it's an image we use a new template to display the name of the expense
 link to that image.

closes odoo/odoo#133611

Task: 3443413
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-09-14 15:50:16 +00:00
Maximilien (malb) 1fa963d55f [FIX] l10n_de: din5008
During this pr (https://github.com/odoo/odoo/pull/121413), we have made a few
css changes on the din5008 format, some of them needed to be revert because they
 broke the layout.

closes odoo/odoo#135000

Task: 3495712
X-original-commit: 650606708ae863fbc7f7c04903891047776fc903
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-09-12 07:12:37 +00:00
Maximilien (malb) d6d468e5f1 [IMP] hr_expense: readability expense receipts
The goal of this PR is to improve the readability of expense receipts on
hr_expense and hr_expense_sheet.
This PR do the following:
- Add the expense name next to the filename
- Vertically center the receipt on both model (was previously done in hr_expense
 but not for the sheet)
- Make sure the title doesn't get hidden by the image (was previously done in
hr_expense but not for the sheet)

Also, to achieve the first point we had to modify the attachment so that we can
retrieve easily the information of which line the attachment is attached.

closes odoo/odoo#130181

Task: 3443067
Signed-off-by: William André (wan) <wan@odoo.com>
2023-09-07 16:16:04 +00:00
Maximilien (malb) 16488e5603 [IMP] l10n_sk,l10n_cz: invoice layout legal imp
before this PR, some legal information were missing from our invoice layout,
for the l10n_cz and l10n_sk localization.

For l10n_cz:
- On move we add a taxable supply date
- On the company we add a trade registry field
- On report template we add the company_registry, the vat number

For l10n_sk:
- On move we add a taxable supply date
- On the company we add a trade registry field and income tax id
- On report template we add the company_registry, the vat number and income tax
id

closes odoo/odoo#126837

Task: 3374969
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
2023-08-08 22:41:00 +02:00
Maximilien (malb) 56ea931f32 [FIX] l10n_fr: adding description
In the taxonomy PR: odoo#114638, we changed the
name of the taxes but the description wasn't modified so the users have
difficulty understanding what the codes means. In this pr, we added a
description in english and in french so that people can have a better
understanding.

closes odoo/odoo#130996

Task: 3398682
X-original-commit: ea85cae2275fde939e63eebed73d3453c6b9dcd9
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-08-07 12:32:52 +02:00
Maximilien (malb) e3f4651c52 [FIX] * : Display improvement
This PR will introduce multiple display improvements. Here is the list:

- In the accounting settings, the fiscal localization section has a button that
was oddly placed. This PR solves that issue.

- On the dashboard, when clicking the three dots on a card, the options "remove
from favorites" and "configuration" were not aligned.

- In ir_attachment, the label and field of "datas" will be aligned, and a gap
will be added between the icons.

- In the settings, the button links were inconsistent in terms of padding. This
PR resolves that.

- In the payment providers, two button links had text wrapping issues. By adding
 Bootstrap classes, this has been resolved.

closes odoo/odoo#130522

Task-id: 3342969
X-original-commit: d4ba0c1f69212bfb0030036951c2888e935bbdf0
Related: odoo/enterprise#45060
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-08-02 17:29:27 +02:00
Maximilien (malb) 182c8b0b84 [FIX] hr_expense: Fill payment_mode
When creating a new expense sheet the payment_mode is empty by default. When adding a new expense to it, the payment mode of the expense itself should be filled with 'own_account' but if the payment mode of the expense sheet is set, the payment_mode of the expense related will be the same as the expense sheet.

closes odoo/odoo#130372

Task: 3382023
X-original-commit: 662c98fb19aeef331f110d6dc4a3d68890af7df4
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-08-02 06:18:06 +02:00
Maximilien (malb) b59e4f73b9 [FIX] account: automatic entries crash
When having a python format in the ref (or memo) of a payment, going to journal
items, select the move and doing an automatic entries, when changing the account
 a traceback appears.

 In the _format_new_transfer_move_log, we create a format that will be put in
 the chatter. In this message we use python format without considering the
 possibility that we can have one in the link of the move.

 By putting the python format before formatting the link, the issues is solved.

 task: 3434131

closes odoo/odoo#130091

X-original-commit: 12e0e6a492a010d61a8a1f763c72e25765654511
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-08-01 04:31:56 +02:00
Maximilien (malb) bedfa27e3d [IMP] base: Rename states in their mother language in the data.
In Switzerland, states are really important. Each  state has its rules, its
language, its culture, its parliament, etc. It's quite frowned upon to send an
invoice/offer or even to have backend management using German terms when we're
in a very French-speaking state.

So in this PR, we will add states in the missing languages

closes odoo/odoo#128954

Task: 3268058
X-original-commit: f309fd06cd46a767fee742ec9f634b46a2edf70f
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-07-19 09:12:42 +02:00
Maximilien (malb) a6414b9dde [IMP] sale: tooltip change
Change of tooltip for "expense_policy"

task-3342969

closes odoo/odoo#124683

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2023-07-14 20:34:47 +02:00
Maximilien (malb) 82383c0ad3 [IMP] account: add reversal info in the chatter
Before this commit, when an invoice is reversed we used to put the message
"this entry has been duplicated from XXXX" but the message that we log in the
chatter was not very clear and also to have the info on the invoice that it has
been reversed you add to go on the credit note itself.

Now when an entry is reversed, the link to the credit note is put in the chatter
of the invoice and the message on the credit note has been changed.

closes odoo/odoo#124060

Task-id: 3326780
Signed-off-by: William André (wan) <wan@odoo.com>
2023-07-14 15:34:44 +02:00
Maximilien (malb) ea8acc17b4 [FIX] account,sale: Sale person and team
When creating a Vendor Bill, the default Sales Team & Person of the company is
assigned to the Vendor Bill. The field isn't even displayed, it's hidden, you
can only display it with Studio and can't even change it.

The fact is : purchases and sales are two completely different roles and
business in companies. This has the indirect consequence that any user that
follows the default Sales Team will get notified of any new Vendor Bill created
in Accounting, which he very likely does not need/want to see.

This PR correct that by adding a condition on the filling of these fields. These
 fields will be filled when the move is a sale document.

closes odoo/odoo#120628

Task-id: 3279233
Related: odoo/enterprise#44034
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-07-13 16:52:46 +02:00
Maximilien (malb) 929f6288ec [REV] purchase: ensure all vendor bills are gathered from purchase order
With the recent change made in this task:
https://www.odoo.com/web#id=3279233&menu_id=4720&cids=1&action=333&active_id=967&model=project.task&view_type=form
The following commit can be reverted. (@Whenrow confirm to me that this commit
is no longer useful).
https://github.com/odoo/odoo/commit/e3101d92187946b2bd539e05956e4e83cd9c9097

opw-3214033

Part-of: odoo/odoo#120628
2023-07-13 16:52:45 +02:00
Maximilien (malb) f4e96bf3a6 [IMP] l10n_gcc: Payment Reference
When working on incoterm and the placement on the invoice, we saw that the
payment reference was weirdly displayed. This commit put the payment reference
on the right with the same display as the invoice date or due date.

closes odoo/odoo#118954

Task-id: 3273460
Related: odoo/enterprise#43363
Related: odoo/upgrade#4598
Signed-off-by: William André (wan) <wan@odoo.com>
2023-07-12 21:45:44 +02:00
Maximilien (malb) 9ddc128d7b [IMP] sale, purchase, account: incoterm location
Before this PR, the incoterm location was not present in the account module.

This pr does multiple things:
- Add the Incoterm Location field in Accounting on Customer Invoices and Vendor
Bills. The field already exists on Sale Orders and Purchase Orders. When you
create an Invoice from a Sales Order, or a Vendor Bill from a PO, copy the value
of the field on the invoices.

- Update the PDF to display the field value if present, and remove the useless
duplication

- Remove incoterm setting on sale

- Remove useless xpath since now it is displayed directly on invoice when
incoterm field is fill.

Task-id: 3273460
Part-of: odoo/odoo#118954
2023-07-12 21:45:44 +02:00
Maximilien (malb) e410bed643 [IMP] l10n_fi: Adding account + translation
Before this PR, a lot of account were missing from the finnish COA.
The goal of this PR was to add those missing account following this spreadsheet:
https://docs.google.com/spreadsheets/d/1hpQndK24UJ9efvl_Vyp5p-UczonIm_FxPnakf_Ugm68/edit#gid=1134177820

Also adding the according translations

closes odoo/odoo#128001

Task: 3241121
X-original-commit: 6833ba3b86df5ce3a28696e99c56aa186375a680
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-07-11 09:10:21 +02:00
Maximilien (malb) a638c06f8e [IMP] l10n_dk: invoice label translate
In the translation PR (#111044), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

closes odoo/odoo#125017

Task: 3369579
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-07-10 15:32:29 +02:00
Maximilien (malb) 5d9ee9f0d2 [IMP] l10n_es: invoice label translate
In the translation PR (odoo#115968), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:29 +02:00
Maximilien (malb) bd632c6872 [IMP] l10n_nl: invoice label translate
In the translation PR (odoo#108954), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:29 +02:00
Maximilien (malb) 24c8000335 [IMP] l10n_ve: invoice label translate
In the translation PR (odoo#109494), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:28 +02:00
Maximilien (malb) 221e8af75a [IMP] l10n_gt: invoice label translate
In the translation PR (odoo#110661), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:28 +02:00
Maximilien (malb) 2553bbb1fd [IMP] l10n_hn: invoice label translate
In the translation PR (odoo#110938), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:28 +02:00
Maximilien (malb) 16245f3f3a [IMP] l10n_ec: invoice label translate + taxonomy
In the translation PR (odoo#109147), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Also in this commit i've redone the taxonomy that has been overwritten by another
PR.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:28 +02:00
Maximilien (malb) 25c3f8ea96 [IMP] l10n_no: invoice label translate
In the translation PR (odoo#110986), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:27 +02:00
Maximilien (malb) 950c87cdab [IMP] l10n_cl: invoice label translate
In the translation PR (odoo#112160), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:27 +02:00
Maximilien (malb) fc3144eed4 [IMP] l10n_jp: invoice label translate
In the translation PR (odoo#111656), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:27 +02:00
Maximilien (malb) 3922148442 [IMP] l10n_cr: invoice label translate
In the translation PR (#110930), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:26 +02:00
Maximilien (malb) 6bd3e2bb31 [IMP] l10n_skr04: invoice label translate
In the translation PR (odoo#106324), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:26 +02:00
Maximilien (malb) aaae983296 [IMP] l10n_skr03: invoice label translate
In the translation PR (odoo#106324), we translated the tax group and
invoice label but for the invoice label we didn't added to translation it needed
to have. This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:26 +02:00
Maximilien (malb) 16a9483835 [IMP] l10n_uy: invoice label translate
In the translation PR (odoo#109504), we translated the tax group and invoice
label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:26 +02:00
Maximilien (malb) 1347abbe89 [IMP] l10n_fi: invoice label translate
In the translation PR (odoo#111107), we translated the tax group and invoice
label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:25 +02:00
Maximilien (malb) 11f8ba6160 [IMP] l10n_pa: invoice label translate
In the translation PR (#110656), we translated the tax group and invoice label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:25 +02:00
Maximilien (malb) 6ef8808d4d [IMP] l10n_mx: invoice label translate
In the translation PR (odoo#108725), we translated the tax group and invoice label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:25 +02:00
Maximilien (malb) 71db3ba8b9 [IMP] l10n_fr: invoice label translate
In the translation PR (odoo/enterprise#35296), we translated the tax group and invoice label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:24 +02:00
Maximilien (malb) 843b004ba4 [IMP] account: invoice label translate
This commit allow the invoice label to be translated

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:24 +02:00
Maximilien (malb) 5c1e4a325e [IMP] l10n_ar: invoice label translate
In the translation PR (#112803), we translated the tax group and invoice label
but for the invoice label we didn't added to translation it needed to have.
This commit fix that.

Task: 3369579
Part-of: odoo/odoo#125017
2023-07-10 15:32:24 +02:00
Maximilien (malb) dab9b3d349 [FIX] account: Error when installing module demo data
Before this commit, when trying to install the l10n_sa or l10n_ae localization,
we get an error in the chart template resulting in no demo data installed. In
fact, when doing a Command.update to link the account to the journal in the
files template_sa and template_ae. The "values" dict was always filled no matter
 the Command, this mistake had repercussion on the "deref" method.

 In the deref method we do a loop on values items, but in the case we are facing
 the last_part variable was filled with an integer.
 When doing the recursion in case command is a "create" or an "update", the new
 values is the last_part, so the loop on values items raised an error since we
 cannot do a .items() on an integer.

closes odoo/odoo#116643

Related: odoo/upgrade#4687
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-07-10 15:32:08 +02:00
Maximilien (malb) 2fcaca2127 [FIX] account: menu label
In this pr https://github.com/odoo/odoo/pull/121601, we did some modification on
 the payment form but by doing that we change the label of the menu item.
So this PR will change the menu item back to what is used to be but keeping the
change on the action.

closes odoo/odoo#127626

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-07-07 12:10:03 +02:00
Maximilien (malb) ea7e0a16ab [IMP] l10n_dk,l10n_eu_oss: add tax + oss
Following the new accounting act of 2023 in Danemark, by checking the list of
taxes we saw that one particular tax was missing and for the other either they
can be associated to existing ones or have minor uses and so no need to add them

Also, we added a mapping for OSS to map in the section "Category B (Not to be
reported for EU sales without VAT)"

I have also changed some name where the translation were a bit shaky.

closes odoo/odoo#125720

Task: 3334595
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-07-06 17:51:58 +02:00
Maximilien (malb) f0abbc3c6a [IMP] account: change placeholder terms
Currently, if we have a look at the field "Due date" Or "payment terms", the placeholder "terms" seems confusing, no one knows that it will open the "payment terms" list from there as a label of the field is "Due date"

closes odoo/odoo#126362

Task-id: 3340547
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2023-06-26 21:10:34 +02:00
Maximilien (malb) 51b3b5b360 [IMP] account_edi: change banner
Goal of this pr is to improve the banner on top of all e-invoicing by shorten
the text and make it one line

task:3374897

closes odoo/odoo#125574

Signed-off-by: Josse Colpaert <jco@odoo.com>
2023-06-21 20:10:01 +02:00
Maximilien (malb) 832c271197 [FIX] account,l10n_es: Adding company registry
For the l10n_es localisation, we needed to print on the invoice the company id
of the partner we send the invoice to. To do that, I had to add some id to make
the xpath work.

Task-3281337

closes odoo/odoo#125596

X-original-commit: 845b275846e49a923a9e181ad37cee3c691f16d0
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-06-19 16:40:09 +02:00
Maximilien (malb) cf00ac4be7 [IMP] l10n_es: default chart template
When you create a new Spanish DB, by default the installed localization package
is the one for non-profit localization. This is probably the most convenient,
as the most normal usage for standard Odoo is the PYMEs one. This PR modify the
demo data and also change the order of how they are displayed in the fiscal
position setting.

In the ir_module, the added line will get the order of module of the init file,
and will sort the template with that order so that we can prioritize some
template.

closes odoo/odoo#122254

Task-id: 3336598
Signed-off-by: William André (wan) <wan@odoo.com>
2023-06-13 12:48:58 +02:00
Maximilien (malb) 96f22bd8f0 [FIX] web: company details
In Odoo editor when a html field is empty, we add en empty <br> inside the <p>.
This change broke all if statement checking that company details is empty.

In this commit, we add a function is_empty_company_details that return True if
the company details field contains only a <br> and False otherwise. With this
method, we can check that company details is empty and displaying other thing
that just an empty line break.

closes odoo/odoo#124440

Task-id: 3168705
X-original-commit: 2aaca9afb6c54be3ef87ea38646af90a2599aa6b
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-06-09 13:50:08 +02:00
Maximilien (malb) 7833e01255 [IMP] web: invoice layout
Before this PR, when multi vat was activated and a foreign vat number was set on
 a fiscal position it was not printed on the invoice for the following layout:
 Striped, light and boxed. The Bold layout is not impacted since it does not use
 company details.

 This PR adds the foreign vat on the invoice when it's necessary.

Task-id: 3248767
X-original-commit: 181bd158d149530d085b6da7e1c5ca3003f36bd3
Part-of: odoo/odoo#124440
2023-06-09 13:50:08 +02:00
Maximilien (malb) cdf8ec6751 [IMP] l10n_dk: Rework COA
The danish administration create a standardized COA.
In this PR, we have rework completely the chart of account of the localisation
to match the document given by the government.

closes odoo/odoo#121186

Task-id: 3251723
Related: odoo/enterprise#40956
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-06-07 20:20:12 +02:00
Maximilien (malb) 2eca114f52 [FIX] hr_expense: padding setting
Before this pr the label and the field were way too close, by adding a padding
start the setting become way more readable.

closes odoo/odoo#123887

Task-id: 3338500
X-original-commit: 33d2cf77434c27f3ac382dc45888f7824dbb6bb5
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
2023-06-06 13:10:42 +02:00
Maximilien (malb) c91d9c5190 [IMP] base: adding margin bottom paperformat to wkhtmltopdf
Before this PR, it wasn't possible to add a custom margin bottom into specific paperformat args.

closes odoo/odoo#123872

Task-id: 3171683
X-original-commit: 0ea1af531ce8887434893f670b1c1e9f075e88c3
Related: odoo/enterprise#42004
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-06-06 13:10:39 +02:00
Maximilien (malb) 3845ec0742 [IMP] account: bank sync community
Before this PR, there was a button in the onboarding dashboard to do a bank
synchronisation. But this step in the onboarding is not useful in invoicing app.
It is only relevant for enterprise accounting.
So this PR remove the step from the onboarding panel

closes odoo/odoo#120678

Task-id: 3302325
Signed-off-by: William André (wan) <wan@odoo.com>
2023-06-06 13:10:19 +02:00
Maximilien (malb) 441d779a43 [IMP] account: tax filter
Before this pr, it was not possible to do a search on the description of the
taxes. I've added the search filter for the tree view.

Also correcting a forgotten "or" in another search view and a missing uppercase.

closes odoo/odoo#123773

Task-id: 3332762
X-original-commit: 5e2e52f10131f0de19638c47347dbcc445a8c531
Signed-off-by: William André (wan) <wan@odoo.com>
2023-06-06 09:19:28 +02:00
Maximilien (malb) 0d0ee1c40a [FIX] account: payment view
The payment form for customer or vendor are very similar. To make it more clear
for user we have made a few changes.

- The breadcrumbs are renamed from "Payments" to "Customer Payments" or "Vendor
Payments"
- Remove warning and put it next to the checkbox instead
- Add placeholder for destination_journal_id
- Cancel button is only displayed when the payment is saved

closes odoo/odoo#121601

Task-id: 3326704
Signed-off-by: William André (wan) <wan@odoo.com>
2023-06-05 13:31:15 +02:00
Maximilien (malb) 1c6a8a2975 [FIX] hr_expense: css issue on attachment
Before this pr, when attaching an image to an expense, the image was misplaced.
By adding a display flex and justify the content in the center, the image is now
vertically align in the center.

closes odoo/odoo#121607

Task-id: 3329707
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-05-23 18:01:43 +02:00
Maximilien (malb) 72c8a06f88 [FIX] base: missing form view
Before this PR when a demo data error occurred (and the errors is too big). You could click on the error and a form view appeared. But if the error was too big, the text for module_id and wizard_id were impacted and were way too small to be readable (like a missing colspan). By adding a form view form this specific model it seems to solve the issues.

closes odoo/odoo#122031

Task-id: 3252698
X-original-commit: a7a6887a01491a42c610ee5019cb6d5feba25f7f
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
2023-05-23 14:52:14 +02:00
Maximilien (malb) aafb5523eb [FIX] account: list view tax definitions
With the recent changes "Odoo Milk", the tax definition view was a bit broken,
the list view was taking half the space she needed.

closes odoo/odoo#121439

Task-id: 3326941
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-05-17 14:47:18 +02:00
Maximilien (malb) 52ba78e07d [IMP] l10n_vn: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the taxes name so that it's more clear for the users

closes odoo/odoo#115093

Task-id: 3052677
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-05-12 09:21:49 +02:00
Maximilien (malb) 7f9cba90da [IMP] l10n_at: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

During the previous pr to modify the taxonomy, some taxes (with same tax type)
had the same name, which is obviously wrong. Now every name is unique.

closes odoo/odoo#121126

Task-id: 3052677
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-05-11 18:25:38 +02:00
Maximilien (malb) 4b3d47b6a5 [IMP] l10n_lu: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the tax name to be more clear for users

closes odoo/odoo#114597

Task-id: 3052677
Related: odoo/enterprise#37911
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-05-11 18:24:53 +02:00
Maximilien (malb) 70adc0f607 [IMP] l10n_ae: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the taxes names so that it's more clear for users

closes odoo/odoo#114559

Task-id: 3052677
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-05-11 18:24:51 +02:00
Maximilien (malb) a367da37f4 [IMP] l10n_bo: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the taxes name so that it's more clear for the users

closes odoo/odoo#115525

Task-id: 3052677
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-05-11 13:54:59 +02:00
Maximilien (malb) dc1a49d39d [IMP] l10n_cl: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the taxes name so that it's more clear for the users

closes odoo/odoo#115483

Task-id: 3052677
Related: odoo/enterprise#38286
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-05-11 13:54:53 +02:00
Maximilien (malb) 2677e269ed [IMP] l10n_mn: taxes
We want to invigorate a Tax Name Taxonomy so that tax names are as codified as possible. This allow for a better display on Invoice Description, and allowed us to implement a smart name_search.

In this PR, we change the taxes name so that it's more clear for the users

closes odoo/odoo#115324

Task-id: 3052677
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-05-11 13:54:51 +02:00