242: These future expenses must be deferred on the company’s balance
sheet until the moment in time they can be recognized, at once or over a
defined period, on the Profit and Loss statement.
6274, 6414, 6424: Fixed asset depreciation not expense
closesodoo/odoo#146802
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
- Replaces a randomly failing test by a simpler test.
As reported by XDO (https://github.com/odoo/odoo/pull/123237#discussion_r1410620206), executing web requests asynchronously during the execution of a tour which does an RPC is randomly failing.
The fix consists in not testing the full online payment flow with the cashier frontend interface, but instead simulate an order saved on the server and simulate real customer web requests for paying online for that order.
- Simplifies the way payment portal URLs are build.
closesodoo/odoo#145595closesodoo/odoo#146029
Task-id: 3632217
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Théo Vincent (thvi) <thvi@odoo.com>
There are various cases where we observe crons which systematically
face a CPU / memory limit. In a setup where a single worker cron is
launched, a failing cron will prevent subsequent crons to run.
This happens because the limits are evaluated at the worker level: the
worker is killed, then starts over with the same job list order.
If the vacuum cron cannot be run anymore, it leads to tables not
garbage collected anymore (e.g. `bus_bus`), causing performance issues.
To avoid this, we give a higher priority to the vacuum cron.
closesodoo/odoo#144210
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.
This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).
closesodoo/odoo#147809
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
This is breaking since 2024-01-01, disabling the test waiting for a
proper fix.
closesodoo/odoo#147846
X-original-commit: 56cdb8a4ad4a4650df2399305ed6210833b325b5
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
When we have more than one draft move for the same journal,
it shows the gap sequence warning on the dashboard. Even if there
is no gap sequence.
It is caused by the fact that we used the sequence_prefix field
on account move to check if a sequence exists.
The aim of this commit is fixing the part of the sql
query modified in 61c9bd69bb0342d845608ad0671e36c70f64fbd3 by
verifying that the name != '/' like we did for the sql query
that computes the made_sequence_hole field.
task-3648745
closesodoo/odoo#147792
X-original-commit: 90ec2ed2043d90e5632d02416b9806c2c87e69c7
Signed-off-by: William André (wan) <wan@odoo.com>
For countries where the financial year is not from January to December
so the sequence may contain two years like 2022-2023 where 2022 is the financial year start and 2023 is the financial year end and this sequence is reset when the financial year ends.
so in this commit, we add support for this type of sequence
* INV/2022-2023/00001
* INV/22-23/00001
* INV/2022-23/00001
closesodoo/odoo#147785
X-original-commit: 072085b32c435fa88d6765469cb0908b9b5c3074
Signed-off-by: William André (wan) <wan@odoo.com>
The kanban view used to display message history of livechats sessions is
replaced by Discuss for a smooth and consistent user experience.
Minimum viable version for Task-3497801
closesodoo/odoo#146800
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Since commit [1], we've applied a style to the badges (Bootstrap badge)
which display extra prices next to a product's variants.
However, this style unintentionally affected certain badges that should
not have been affected since this other commit [2].
Steps to reproduce the bug:
- Open the Website app.
- Go to "Configuration" in the main navbar.
- Select "Payment Providers" in the dropdown.
- Pick the "Demo" payment provider.
- Change the state to "Test Mode."
- Set "Bank" as the "Payment Journal".
- Go to the "/shop" page.
- Click on a product.
- Click on "Add to Cart" on the product page.
- Go to the cart and click on "Process Checkout".
- Bug: On the "/shop/payment" page, notice a slight text misalignment in
the badges next to the Payment Providers selector.
In this commit, we've adjusted the CSS rule to ensure that only product
configurator "extra price" badges receive this styling.
[1]: https://github.com/odoo/odoo/commit/3e03bd9a399d607d0f36c7e7652ee743a7cfe61a
[2]: https://github.com/odoo/odoo/commit/611e2f20f975c590eb75d64379be84dd4cc472ef
task-3626728
closesodoo/odoo#147755
X-original-commit: d30a081016d8547dd9bc7bff1d47d78ef2ceb2cb
Signed-off-by: Guillaume Dieleman (gdi) <gdi@odoo.com>
This reverts the following commits : https://github.com/odoo/odoo/commit/fe508c6b2cb1b92d7b063cc194a3dad37f4eb255
The behavior for tracked products is different; the quantity is modified
in a wizard by adding other `stock.move.line`, which does not trigger
the change of the 'picked' field to true and makes the behavior
different from non-tracked products.
We prefer to remove this fix and keep the same behavior for all types
of products. The user can manually select the checkbox for the 'picked'
field.
Update the optional show for the field “picked” in the MO form
closesodoo/odoo#147695
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
An ormcache has been added to a method that takes lists as parameters but
lists are not hashable.
steps to reproduce:
- go to apps and click on on 'Industries'
before this commit:
- a warning is raised in the logs:
WARNING industry odoo.tools.cache: cache lookup error on ('ir.module.module', <function IrModule._get_modules_from_apps at 0x7f99e842fc70>, ['icon', 'icon_flag', 'to_buy', 'name', 'state', 'summary', 'website', 'application', 'module_type', 'shortdesc'], 'industries', False, ['&', '!', ['name', '=like', 'theme_%'], '&', ['application', '=', True], ['module_type', '=', 'industries']], 80, 0)
Traceback (most recent call last):
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/cache.py", line 99, in lookup
r = d[key]
File "<decorator-gen-5>", line 2, in __getitem__
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/lru.py", line 34, in __getitem__
a = self.d[obj]
TypeError: unhashable type: 'list'
after this commit:
- ormcache is properly used
opw-3660052
closesodoo/odoo#147730
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
step to reproduce:
- go to recruitment
- create a job with a title with a abnormally long title
-> the title is not limited & overflows
Bug explaination:
The parent has no defined width, so the title cannot be limited by
the original css rule.
Expected behavior:
The title size should be limited or be able to wrapped.
Bug resolution:
Remove the o_text_overflow class and thus permit the title to be
wrapped.
behavior after this commit:
The title is able to be wrapped.
task-3598895
closesodoo/odoo#142480
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Threads are automatically marked as pinned when they are opened but this
behavior is not always desirable. They are now implicitly pinned when it
makes sense to do so.
closesodoo/odoo#146841
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this PR the "Can handle im_status of unknown partner" test was
sometimes failing. This test is not related to im_status: it tests
that receiving a `mail.record/insert` notification properly inserts
the data in the store. This flow is already thoroughly tested as many
discuss functionalities rely on this mechanism. This PR removes this
test.
fixes runbot-52628
closesodoo/odoo#147705
X-original-commit: 39a368238f5fc9b8d8d4115f14a05499322e92e6
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
_l10n_ec_get_identification_type will get called quite often in a loop
in the ATS report, so it's important that it gets orm-cached. This
reimplementation removes calls to ref() and replaces them with calls
to _xmlid_to_res_model_res_id() which is entirely orm-cached.
closesodoo/odoo#147723
X-original-commit: f95540bb8b92e795b1331910049d0d6de7da120c
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>
Related fields created when using composition based inheritance are
created without the 'definition' attribute which leads to errors if
you try to read it.
steps to reproduce:
in an odoo 17 shell (it's easier to reproduce in 17 because there is
an example of a problematic field)
self.env["product.product"].search_read([], ["product_properties"])
before this commit:
an error is raised:
TypeError: tuple indices must be integers or slices, not NoneType
after this commit:
the field product_properties is read from product.template
opw-3618178
closesodoo/odoo#147729
X-original-commit: bd012785fe3081aa14a556a94702373cfce4f5db
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Nicolas Danhier (nda) <nda@odoo.com>
Steps to reproduce:
- Create product FNS, storable, avco
- Create product CMP, storable, avco, cost=$100, add 10 unit in stock
- Set resply subcontractor route in inventory tab
- Create BoM for FNS: subcontracted, cmp=1 unit of CMP, vendor=Azure Interior
- Add "Azure Interior" to the vendor list of FNS (under Purchase tab) with a price of $20
- Create purchase for 1 unit of FNS to "Azure Interior"
- Confirm: Receipt should show subcontracted
- Validate Receipt: Valuation of FNS should be $120
- Create vendor Bill, Validate
=> Product Valuation is overwritten, cost become $-80.0
Bug:
when checking price difference unit component price is suvtracted but
since they are out moves their valuation is already negtaive
opw-3618767
closesodoo/odoo#146538
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Currently, the polish chart of account is not up to date and is therefore
underused by user since it is not relevant.
This PR aims to improve the polish chart of accounts, account groups and
fiscal position in order to make it usable by users.
This new chart of account and other elements linked to it that are modified
by the PR are based on the documents available on the gofin.pl website. The
chart of account is based on the one available at this link :
https://plankont.gofin.pl/ which was consulted on the 2nd of August 2023.
The polish chart of account should now be relevant and useable.
task-3332731
closesodoo/odoo#146452
Related: odoo/enterprise#52874
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Steps to Reproduce
===================
1. Go to website slides.
2. Open any Course.
3. Click on 'Add a review' or 'Edit your review'.
-> Message box border is not visible.
After this commit
=================
The message box border will be visible
around the text area.
Task-3623765
closesodoo/odoo#146159
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
In [1], a context object was added to websocket requests to subscribe
to guests channels on cors live chats. However, the common mechanism
to subscribe to record channels is to pass a string channel that will
then be validated by the `_subscribe` method of `ir_websocket`. This
approach works with OdooSH out of the box while the other one does
not.
This PR removes the mechanism introduce in [1] in favor of the string
approach.
[1]: https://github.com/odoo/odoo/pull/130052closesodoo/odoo#147114
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Steps to reproduce the bug:
Go to inventory > reporting > valuation
The total value is hidden and the remaining is shown
Solution:
displaying total value as optional show and remaining_value as optional
hidden
opw-3644799
closesodoo/odoo#147661
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Currently, when replenishing a product using a supplier that has a discount, the purchase order created didn't take the discount into account. It was set to zero.
Fix in `purchase` module, test in `purchase_stock` module.
Steps to reproduce:
-------------------
* Go to ´Inventory´ > ´Products´
* Select any product
* Configure the product:
* - Product type: storable
* - Enable ´can be purchased´
* - Under the ´Purchase´ tab, add a vendor with a discount price
* - Save
* Select ´Replenish´
* Select the vendor previously added
* Confirm
* Check the PO created
Why the fix:
------------
After debugging, I discovered that
```python
po_line_values.append(self.env['purchase.order.line']._prepare_purchase_order_line_from_procurement(
procurement.product_id, procurement.product_qty,
procurement.product_uom, procurement.company_id,
procurement.values, po))
```
in `/home/odoo/odoo/addons/purchase_stock/models/stock_rule.py` would loose the discount value.
Discount can be found in `procurement.values.supplier.discount`.
Further investigation revealed that function `_prepare_purchase_order_line(self, product_id, product_qty, product_uom, company_id, supplier, po)` in `/home/odoo/odoo/addons/purchase/models/purchase_order_line.py` would not make use of the discount value.
In this function, we use the discount value from the seller instead of the supplier as the seller is computed in order to use the smallest discounted_price.
opw-3640396
closesodoo/odoo#147555
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
This commit fixes a non-deterministic error in the bus module. Testing
the bus service is difficult because it relies heavily on async code.
Until now, `nextTick` was used but there is no guarantee that this is
enough. This commit introduces the `waitForChannels` method that
awaits the channel subscriptions to be done before resolving.
fixes runbot-21942,54467
closesodoo/odoo#147616
X-original-commit: 429a0668a4bed52eff1c7b8cd0c5c66261678699
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
In this commit,
- I have made the field `Place Of Supply` Selection only.
- Now, the User will require to set the `Tin Number` on the
`Place Of Supply(State)`. Otherwise, it will raise `UserError`.
- It is required to avoid errors given in the task description which isn't
understandable for a user to understand.
- I have stopped the creation of a new state at the time of invoice creation.
So, if the user wants to add a new state they can do so by
`Contacts --> Fed. state`.
Task-id:- 3339099
closesodoo/odoo#147558
X-original-commit: b3a11e500a678f37f202d864a7726b1426f88d71
Signed-off-by: Josse Colpaert <jco@odoo.com>
Before this commit, errors were introduced when optimizing the synchronization by limiting it to the calendar's view range. For users different than the first to synchronize its calendar, when trying to create events in Odoo before or after the synchronized view range (e.g. 1 month), these events were being auto-archived in Odoo right after their creation in Outlook. This happens because the first range to be sent to Microsoft Outlook is currently defining how much time in the past and in the future the events will be synchronized.
After this commit, the previous approach of defining a range of two years for the delta synchronization (events that were last updated) in the future is back temporarily, now with one year in the past. This behavior must be improved considering the calendar view range and must be flexible with the first synchronized view range.
Issue from: 3525764
closesodoo/odoo#147366
X-original-commit: 2a503c1b08bd31c9ac0098e774eea8dd5b5c2c1e
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Signed-off-by: Gabriel de Paula Felix (gdpf) <gdpf@odoo.com>
Steps to reproduce:
- Add a "Form" snippet on the website.
- Select the first field.
- Try to toggle the "description" option of the field.
-> Problem: there is no description added on the field.
The problems appeared since [this PR] and comes more precisely from
[this commit]. The problem is that one condition required to fill the
`default_description` parameter is that `field.type === "description"`.
This should not be the case. Indeed, here was the flow before
[this commit]; When the user toggled the description option,
`toggleDescription` assigned `field.description` to `true`. The field
was then rendered trough `renderField()`. During this rendering, the
system called the `website.form_field_description` template through
`website.form_field` independently of the field type. Because
`field.description` was set to `true`, a `div` with the description
"Describe your field here." was added on the rendered field. To solve
the problem, the `field.type === "description"` condition has been
removed as a condition to set the `default_description` parameter. Now,
as it was the case before [this commit], this parameter is filled either
if `field.description` is set, either if the field name is `email_cc` or
`email_to`.
The error probably comes from the fact that the name of the template
used to render the field is `"website.form_field_" + field.type`. As the
name of the template in charge of rendering the description is
`website.form_field_description`, the author probably thought that this
template should only be called when `field.type === "description"`. This
is not the case; the template `website.form_field_description` is always
called when rendering a field (independently of the field type through
the template `website.form_field`) but is only relevant if
`default_description` is set.
Note that this fix fixes also another bug:
- Add a "Form" snippet on the website.
- Add a field which is of type "Cc".
-> Problem: there should be a description of type "Separate email
addresses with a comma." on the field.
This commit also adapts the `website_form_editor_tour` tour to verify
that the description option works as wanted.
[this PR]: https://github.com/odoo/odoo/pull/130467
[this commit]: https://github.com/odoo/odoo/commit/363251986dcd753796b4b037a2da2e118b3e8e35
opw-3630348
opw-3604548
closesodoo/odoo#146115
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
`onDuplicate` was marked as optional while it never was. If you don't
specify it, the call to `this.props.onDuplicate();` will still be
executed and will crash:
`Uncaught Promise > this.props.onDuplicate is not a function`
Randomly spotted while reviewing PR about duplicate button in list view
related to opw-3640878. But it's not related to it.
closesodoo/odoo#147647
X-original-commit: 296feaa9aa16cdb1766ce8d2f5ae8126d74f881b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit is fixing a last minute error in commit [1] after a push
force which move its code above the existing line `vals['url'] = url`.
After the code move, `vals['url']` was not the updated url value (which
went through slugify and unique path functions).
- Create a /test page, publish it.
- Set /test as homepage url directly on the website (in the settings)
- Go to that page
- Open the page properties and change its URL from /test to /test_un
-> The page url is /test-un but the website homepage_url is still
/test_un (not slugified) in the website settings
[1]: https://github.com/odoo/odoo/commit/374a1b31f70a3209b1ae11db8e5886350579c7f9closesodoo/odoo#147641
X-original-commit: 3c8a58b654418fc2fc0dc9bc28420c7dcb1bafee
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Steps to reproduce
====================
1 Open the course and try to retake the quiz.
2 Traceback while submitting the quiz.
Technical
===========
Due to missing closing square bracket in the attribute selector of jquery.
After this commit
==================
There will be no traceback while submitting the quiz.
Task-3633410
closesodoo/odoo#147611
X-original-commit: eea7da64de4e6b70ea4d6b1fc277b36b278ad329
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Steps to reproduce:
-------------------------
- Install project and sale_timesheet module
- Open the Project module
- Go to task's timesheet notebook
- Add a new line
- Set empty in so_line field, raises traceback
Issue:
--------
- In timesheet notebook, when we set so_line as an empty .it will raises
traceback.
Cause:
---------
- #145821 when set empty so_line field there is undefined value read.
Fix:
-------
- On a field change, compare the so_line field value with proper record id check
with new value.
task-3642371
closesodoo/odoo#147546
X-original-commit: ed2417225975001dd7b6ec1d3655fe880fe2c108
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Prior, if the time off type needed second approval, there was no activity generated for the responsible.
This commit fixes that. Moreover we also organize the code by taking
references out of the loop.
task - 3584190
closesodoo/odoo#142327
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
In case more that one leave record in passed to message _subscribe
in will throw "Expected singleton" ValueError.
This commit fixed the issue.
Part-of: odoo/odoo#142327
- Adds some permissions to protect sensitive pos_adyen data and methods.
- Reduces the risks of abuses of the pos_adyen features.
Those changes are not optimal. The whole system should be changed.
- Fixes the printing of Adyen receipts data in the receipt.
- Fixes an error when receiving a successful Adyen payment notification for the kiosk.
- Fixes an error when Adyen returns an error for a payment for kiosk.
- Fixes an error when requesting adjustment/capture to Adyen (pos_restaurant_adyen and kiosk).
- Removes unused handling of adyen_latest_diagnosis field (the field will be removed in master).
closesodoo/odoo#140327
Task-id: 3500598
Signed-off-by: Théo Vincent (thvi) <thvi@odoo.com>
Steps to reproduce the issue:
- Have two companies in your database.
- Create a partner:
- Set "receipt_reminder_email" to True for Company 1.
- Set "receipt_reminder_email" to False for Company 2.
- Create a Purchase Order with Company 2.
Problem:
The field "receipt_reminder_email" is a related field, so its value
is False. However, if you switch the current company to "Company 1"
while keeping the Purchase Order in Company 2, the
"receipt_reminder_email" is updated to True.
Solution:
The field should be computed instead. the readonly for this field in not
neccessary anymore so the inverse is not mandoatory.
opw-3593577
closesodoo/odoo#147648
X-original-commit: 2211e08f69eed7af9be20f178f659f6a71fb6ac4
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Each date in the timeline snippet was displayed with the time line going
through them. The line is supposed to be cut around the date. This
occurs since [1] which made it so `<span>` elements are automatically
removed by the editor if they do not have any attributes. Unfortunately,
this snippet relied on such a span, since [2]. This commit solves the
issue by making the snippet better (and the XML structure will further
be improved in the master forward-ported version). Unfortunately, this
is not entirely stable, even though it leads to the exact same result
provided no custom code tweaks the snippet. It will also solve existing
timeline snippets in current databases.
Note: [1] was obviously a mistake to merge in stable, although it might
be kept seeing the delay since it was merged and nothing critical seems
to have happened.
[1]: https://github.com/odoo/odoo/commit/a26e27c85e6a0685b6cf4d2dbab90453899df34c
[2]: https://github.com/odoo/odoo/commit/fbe38fb41dfdb76878748a1149f93700b566d228
task-3657771
closesodoo/odoo#147598
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
*: website_event_sale, website_sale_slides, website_event_booth_sale
In website_sale, we have a setting to prevent the sale of zero priced products.
It works fine but triggers also on order of free events, free event booths and
free courses.
This is unwanted behavior and a check has been added to still allow those three
product types to be sold for 0.
Task-3388254
closesodoo/odoo#147589
X-original-commit: ab839650be3f04422aab8af81b72af475c0b6fd7
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Steps to reproduce the bug:
- Create a storable product “P1”:
- Tracked by: SN
- BoM:
- product qty: 1
- Component: consumable product qty:1
- Create a MO to produce 12 unit of P1
- Update the qty of the consumable product to 31
- Confirm the MO
- Click on “Mass produce”
Problem:
An user error is triggered:
“It is not possible to unreserve more products of Consu than you have in stock”
The product is a consumable, we should not update its reserved quantity.
opw-3620437
closesodoo/odoo#147571
X-original-commit: 33728387925439eaf4971dc732ff46fd19432f2c
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
To reproduce (on runbot):
- Enable "debug" mode
- Switch to company "My Begian Company"
- Go to: Payroll / Configuration / Contracts / Template
- Create a new contract template:
* Name: Student contract template
* Salary structure: Belgian Student
* Job position: Student
- Create a new applicant for job position (Student)
- name: John Doe
- email: john@example.com
- Click "Generate Offer":
- Contract Template: Student contract template
- Click "Save"
- On the offer, click "Salary Configurator"
=> by default student has only 1 benefic in kind (regular pay) but on
the salary configurator you see many more entries listed (ex: 13th Month)
that are coming from another salary structure (Belgian Employee).
During the simulation as no employee exists (it's an applicant), a new
"temporary" employee is created and assignee to the contract; this
update the company which trigger a recomputation of the `structure_type_id`
field (since odoo/odoo@21aca4704) resetting its value to the country's
default.
This commit ensure we only reset that field when the country do change
closesodoo/odoo#147079
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Several tests are non deterministic because they are using
`assert.verifySteps` at the wrong moment. Helpers such as
`afterNextRender`, `nextTick`, `Deferred` are used but those are
either not reliable or cumbersome to setup.
This PR introduces an asynchronous API on top of
`assert.step`/`assert.verifyStep`. This will wait until steps are
executed or until the timeout is reached.
fixes runbot-52660,54471,52794
closesodoo/odoo#147455
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Previous PR odoo/odoo#143570 moved some move line ordering logic from the
model to the view to avoid recomputing of these fields since it was
causing issues with the computes occurring at the wrong time.
Unfortunately every field used in the `default_order` in the view has to
be present in the view and since v16 any fields that have a groups
attribute that isn't met isn't loaded in the view.
Therefore we have to force the `result_package_id` to always be in the
view even if `stock.group_tracking_lot` is not true (i.e. packages are
active)
Steps to reproduce:
- create +save a receipt with a tracked product
- click on the burger button to open the detailed operations of the
tracked product
- add 2 move lines + Confirm
Expected behavior:
the move lines save
Actual behavior:
JS traceback due to trying to sort on a field that isn't present in the
view
closesodoo/odoo#147188
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
When orderpoint.qty_multiple is decimal, then remainder may be wrong. The applied formula is: qty_to_order % qty_multiple = remainder
Examples:
510 % 10 = 0
51% 1 = 0
5.1 % 0.1 = 0.09999999999999937 which is rounded to 0.1 > 0
0.51 % 0.01 = 0.009999999999999998 which is rounded to 0.01 > 0
This PR fixes it.
closesodoo/odoo#147521
X-original-commit: e8f35a63fac9e9c3613c2b56fd6d65e79b64d6e9
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
The `calendar notification` tests patch the `setTimeout` function.
This sometimes leads to infinite recursion when the `multi_tab`
service has enough time to initialize: this service make use of
`setTimeout` to call the `heartbeat` method repeatedly. Moreover,
patching the `setTimeout` method is not a good idea since it makes
this method synchronous which totally changes the flow that is tested.
This PR fixes this issue by using the `contains` helper instead: this
method will wait for the element to be inserted in the DOM and perform
the assertion afterwards.
closesodoo/odoo#147503
X-original-commit: 973db5a
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Description of the issue/behavior this commit addresses:
When 2FA is on on a user and he tries to use an API key to do a xmlrpc request,
the request fails. This is due to the system which choses whether or not to
send an alert via mail to look in the request's values while there is actually
no url request in that case.
Desired behavior after this commit is merged:
This commit adds a check to make sure a request is available before checking
its values.
opw-3645609
closesodoo/odoo#147475
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
PDF written with scribus (and some other software) have a problem when filling fields: the output
does not work as expected. The replaced value is there, but hidden behind a blue overlay, shown
only when clicking on it.
We now show the field value and ensure filled fields are read only.
Additionally, some readers only allow a single value per field name. Even if the values were
different on the documents, only one would be shown. We now rename the fields to ensure they are
different when they have different values.
task-3626047
closesodoo/odoo#145163
Signed-off-by: Morgane Demesmaeker <edm@odoo.com>
Steps to produce
========================
- Activate QR code in pos config
- Open session
- Make an order for a certain partner (do not invoice)
- At receipt, scan the QR code
- Sign in as a normal user (like admin)
bug - Invoice is created for admin and not the partner in the order
After this commit
========================
The partner of the created invoice will be the partner of the pos order.
task - 3497301
closesodoo/odoo#147484
X-original-commit: 2b45e8732e39f13a6293ffda7bf9fed9e8d951f8
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Parth Solanki (paso) <paso@odoo.com>
Trinh Ngoc Hung