Future changes will require a different order of the code in that file.
This commit only reorganises the file to make future code review easier.
Part of https://github.com/odoo/odoo/pull/52211
Related to task-2197038
closesodoo/odoo#52211
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Instead of the text of the selected option displayed as label, we may
want another text (especially if the choice has long text). This can
be defined on buttons with 'data-select-label'.
Part of https://github.com/odoo/odoo/pull/52211
Related to task-2197038
Don't know how this test worked before but it will stop working with
next updates. This just make it more robust using the same trick as
other tests: wait for the colorpicker to be opened before actually
using it.
Part of https://github.com/odoo/odoo/pull/52211
Related to task-2197038
The goal is to reduce loadings as much as possible but there will
always be some. So that loadings do not appear as bugs and give users
some feedback that they are ongoing, this commit adds a loading effect
during the loading of some actions.
Part of https://github.com/odoo/odoo/pull/52211
Related to task-2197038
The module l10n_generic_coa was installed in every single case when
loading a new db from the console because the country is US by default.
If we have a `-i l10n_*`, we dont need to install another CoA based on
the country.
The fact that it is installed was messing with the demo data because we
were searching for a type of account not necessary present in the CoA
installed on the company.
closesodoo/odoo#52190
X-original-commit: d3ad353c86f7b148946f9e36457f6b002cc118c1
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>
Inverse fields are stored in a `set` and `set` is not ordered. It depends on the memory address of its elements which change each time the registry is rebuilt.
Inverse `_set_move_ids_without_package` set the .move_lines on the record
Inverse `_set_scheduled_date` set the scheduled_date on the move_lines
If `_set_scheduled_date` is called first, then the record doesn't contain any move_lines, the scheduled date is ignored and set to default (now)
This fix ensures that if a scheduled_date is set, it is applied after `_set_move_ids_without_package`.
OPW-2212391
closesodoo/odoo#52173
X-original-commit: 7f59fc89afd403534cc7ab9d06c2c6b458666a03
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Before this commit, the options of the tooltip where set inline.
After this commit, the options are returned by a function.
This allow us to adapt these options in another module.
Task ID: 2152124
closesodoo/odoo#52170
Related: odoo/enterprise#10864
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Security rules are added in the sale module for transactions and tokens,
but it is entirely possible to have the payment module without those,
and preventing invcoicing users from accessing transactions is
functionnaly stupid - they are often required to check payment statuses,
references, etc.
closesodoo/odoo#52139
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Actuin `relate_partner_opportunities` and its window views is not used anymore
in codebase. It can be removed, allowing some cleaning.
closesodoo/odoo#46676
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The quotation template edition allows to save and use the description
of an optional product.
But when a quotation template is set, the description of optional
product is lost so we the optional product description was never used.
opw-2260457
closes#52133closesodoo/odoo#52167
X-original-commit: 81d13f4097e7fca9fbb623839a2c90b04bd9ec29
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Issue
When pressing UP or DOWN arrow in search bar with empty text a traceback
occurs.
Step to Reproduce
- Install website_sale "eCommerce" application
- Go to Website
- Go to Shop
- Click in Search Bar
- Press Up or Down Key
Cause
When no text is entered in the search bar, the $menu is undefined
so trying to access children causes the error
Solution
Test that $menu is defined prior to try accessing its children
task id-2252923
closes odoo/odoo#52161
Forward-port-of: #51920
X-original-commit: 30785e68852fa3cd18be11fcbaad4e886d01301c
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Enabling sub tasks is done through the general settings
but it should be possible to disable/enable it on specific projects.
The current implementation does not allow that since the field
enabling the feature is a readonly, user dependent field.
Task 2192763
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#49917
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose
=======
When switching from questions to questions, if the next question's content
takes more or less vertical space than previous question, the timer moves
because the whole screen content adapts to the question size.
Specifications
==============
Set the timer at the upper right of the screen.
So that it won't move at each question change, no matter the question size.
Task ID: 2232973
closesodoo/odoo#49195
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
[IMP] uniformized way to import/export EDI documents
In details, this is achieved by
- Adding a generic framework module to import/export EDI documents
- Adapting existing EDI modules to it
- Fix PyPDF2 to manage multiple embedded files
- Adding E-FFF standard in a separated module (belgian EDI export)
- Fix UBL move line price import.
Task ID 2154703
closesodoo/odoo#49011
Related: odoo/upgrade#1108
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
PURPOSE
Improve the Email Marketing tour and onboarding to create a "wow effect" when
users test the app.
SPECIFICATIONS
Create a tour for mass_mailing to let user visit Odoo Email Marketing through
a simple mailing creation flow.
This require the following functional changes
* by default, if user chooses to contact mailing lists and there is a single
mailing list available, add it as default value for chosen list;
* create a master mailing list data containing the admin user so that he can
easily follow the tour and test the mailing application;
LINKS
Task ID 2194876
Community PR odoo/odoo#48259
Upgrade PR odoo/upgrade#983
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
visibility_group was used for visibility, we now use the groups_id field.
groups_id is a M2M field while visibility_group was a M2O field resulting
in an issue to display the M2M field in the frontend. We decided to
allow editing the groups as a M2O in the frontend. If there is more
than one group the user will have to go through the backend to edit.
task-2264580
closesodoo/odoo#51846
Related: odoo/upgrade#1260
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Purpose
Update the Marketing Apps list views to the new Framework possibilities.
Specifications
Decorations like color in badges used for state with widget badge likewise,
widgets remaining_days, many2one_avatar_user, date.
LINKS
closes odoo/odoo#51447
Pr: #51447
Task-id: 2250285
Related: odoo/enterprise#10637
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
- Support for account_edi workflows (only import) + fattura_pa as an account.edi.format.
- XML containing multiple invoices cannot be imported from the chatter.
- E-FFF import moved from l10n_be_edi into a generic UBL import.
- [FIX] when importing if LineExtensionAmount is set but not PriceUnit on a move line, the price was not imported.
- Added export to generic UBL 2.1.
- account_edi is the base module to manage EDIs. It manages the generic worflow of import/export and defines the methods for import/export that should be overridden by each types of EDI (in different modules).
- On export, the files are added as attachment and can be embeded into pdf (format specific).
- On export, the exported format are set on the journal to allow different settings based on journal (different companies, countries, etc).
- On import, depending on the import method (from message_post or upload button in invoice tree view) a new invoice is created or an existing one is updated (only allowed draft invoices with no invoice lines).
- Adapted factur-x
Purpose of this commit is to update the list views of event according
to the new framework possibilities for better UX/UI.
This commit utilises the latest framework features available from task 2195254
to represent the information in better way and/or adds some useful fields
List of the tree views improved are:
- Event - event.view_event_tree
For detailed specification, you can visit pad of the task.
Task-id: 2250285
Purpose of this commit is to update the list views of mass_mailing and
mass_mailing_sms according to the new framework possibilities for better UX/UI.
This commit utilises the latest framework features available from task 2195254
to represent the information in better way and/or adds some useful fields
List of the tree views improved are:
- Email Marketing - mass_mailing.view_mail_mass_mailing_tree
- SMS Marketing - mass_mailing_sms.mailing_mailing_view_tree_sms
For detailed specification, you can visit pad of the task.
Task-id: 2250285
Before this commit: hovering on graph legend shows cursor default
here hovering on legend should display cursor pointer, so user
can easily understand it is clickable element
After this commit, hovering on graph legend will display cursor
pointer.
task-2263703
closesodoo/odoo#52030
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Currently, when the session expired then it generates the popup that
"Your odoo session expired. Please refresh the current page."
Now once you click on the "Ok" button only close the popup and user have to
manually do refresh the page.
with this commit, we have changed the text of the popup to
"Your odoo session expired. The current page is about to be refreshed." and
when user click on "Ok" button forcefully refresh the page.
Task : 2241744
closesodoo/odoo#50710
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Adjacent buttons in the arch are now displayed in a single column
in list views (main and x2many views). As soon as there is a node
in-between (even if it is invisible="1"), the rule doesn't apply
anymore and buttons placed before/after that node are rendered in
a separated column.
Task 2261774
closesodoo/odoo#51970
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Before this commit, We had two filters which filters Active/Inactive record were named as Opened/Closed.
In this commit, We remove those dummy filters and add `Archived` filter like all other search views.
closesodoo/odoo#46675
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
The ace editor library was loaded as soon as the theme tab was opened
while it is only useful for the related <head/> option in there -> we
now load it only if that option is used. This was introduced with the
feature at [1].
[1]: https://github.com/odoo/odoo/commit/560e3af48ab9327b49a8cf44a9b0416dfb5b95declosesodoo/odoo#52124
X-original-commit: 989c256aabeaa55d7b5ecb26614cc2c2578f71e6
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: web_editor
When clicking on the theme tab on an empty page, a scrollbar appeared
and stayed. This was because the fake `<theme/>` element was focused and
the overlay positioned randomly outside of the page.
This commit fixes that by simplifying the code and always hiding the
related overlay. This commit also makes sure the onFocus/onBlur method
of the theme options are called consistently, even though they are
probably not useful.
Part of https://github.com/odoo/odoo/pull/52081closesodoo/odoo#52114
X-original-commit: 7760898de4e14fa30db1db87dfa05276bfcaa2bb
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, the onBlur function of snippet options was not
called if the blur occured because of a click on the 'Blocks' tab.
Part of https://github.com/odoo/odoo/pull/52081
X-original-commit: 85049e2dcf68c40218bd0f4ed7401a4f979951d4
As the colorpalette has very big chances to have to be loaded when the
user enters edit mode (any click on a text will require the colorpalette
to be available), this commit makes it so the dependencies are loaded as
soon as the editor is started, without actually waiting for them until
the colorpalette are used.
This allows to make the first click on a text or on the theme tab a bit
faster to react.
closesodoo/odoo#52116
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Steps to reproduce the bug:
- Go to settings => Purchase
- Enable Dropshipping
- Go to Inventory => Configuration => Warehouse Management => Operations Types
- Open Dropship
- Remove the sequence (field is not required)
- Go to Inventory => Master Data => Products
- Let's consider product P (Inventory tab: Check "Dropship" and "Buy" and vendor V as supplier)
- Create Quotation Q with customer C and product P
- Confirm Q (a PO has been created for V)
- Confirm PO
Bug:
A traceback was raised because the sequence was not defined on Operation Type dropship
opw:2263799
closesodoo/odoo#52115
X-original-commit: 25ae1f6900712dcf13341fdb0855e3cbe2fa98af
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commit d5d2c5524c improved the UrlWidget s.t. it automatically
prefixes the url with 'http://' if no protocol is specified (except
for own website paths).
In addition, it removed a logic specific to model res.partner that
automatically prefixes the saved website values with 'http://'.
However, the second part should not have been done: those urls can
be displayed without UrlWidget (e.g. on the website), and in this
case, the protocol wouldn't be set, meaning that it would behave
like a relative link.
closesodoo/odoo#52113
X-original-commit: 5a8690bb64cb3dc01ee8d4f9af3a6ab91eee8b99
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
This commit fixes two bugs with pos_six:
- When the cashier manually clicked on "Cancel" or switched order,
the payment was correctly canceled, but the POS still showed the
error popup saying that the transaction was not processed
correctly.
- The TIM API manages differently rounds amounts and amounts with
decimals. Sending an amount of 1 was considered as 0.01€, while an
amount of 1.01 was considered as 1.01€. To fix this, we always sent
the amount in minor units.
closesodoo/odoo#52102
X-original-commit: a5125b92c11bd9dbf1b536e1eb1b467be446718f
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
It was outdated and did not contained account.tax.report.line references
Raised by opw-2261376
closesodoo/odoo#52085
X-original-commit: 81cccec510c4540126503a79d8844f14cb65bb7d
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
1. Activate receipt in 3 steps
2. Make a PO of 50
3. Receive 20 (pick 1), backorder
4. Receive 29 (pick 2), backorder
5. Receive 1 (pick 3)
6. Transfer to quality check location 45 (pick 4), backorder (pick 5)
7. Go to pick 5, unreserve the quantity
8. Go to pick 3, return 1 => the quantity suggested by the return wizard is 1
The return is not able to reserve the necessary quantity.
This happens because 45 units are considerd out (from pick 4), but only
1 unit is considered in (pick 3). Therefore, in the following:
https://github.com/odoo/odoo/blob/23511dffb9e3f597a7df9bb834d008f74abb07b8/addons/stock/models/stock_move.py#L1276
we have `quantity = -44.0` and `available_quantity = 5.0`, so we can't
reserve.
We count as `move_orig_ids` all the siblings coming from
`move_dest_ids`.
opw-2261473
closesodoo/odoo#52084
X-original-commit: ba89e26750baab2309cccc4ffd0b3ade804d19ce
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Issue
- Have IE 11 or not chromium-based Edge
- Install Contacts
- Add a salesperson on any contact
- Save
- Try to remove the salesperson with
the cross icon on the input
- Save
The value comes back
Cause
We do not handle this feature in dropdowns
Solution
Remove the dropdown cross icon
OPW-2262749
closesodoo/odoo#52083
X-original-commit: cdb072372bfaa3cdc85e7b6d79ad848e8d071e00
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
As without configuration of mail servers,
the only thing it does, is making sure we
can export/import FatturaPA invoices.
closesodoo/odoo#52066
X-original-commit: 19072db87e20ac13221b7a39ac9e8ca25a87b172
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Josse Colpaert <jco@openerp.com>
QR-bills could only be generated for ISR-compliant invoices, which is wrong and would have caused issues in the future, as ISR will slowly disappear.
Furthermore, doing it this way avoids raising an error after commit 719f087 , when trying to print an ISR-compliant invoice if the module hadn't been updated (it used to raise because the QR-bill report didn't exist, and it tried generating it).
closes odoo/odoo#51858
Forward-port-of: #51340
Forward-port-of: #50744
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
A NULL value in the database column is considered as
a False value for boolean fields in Odoo.
Hence the sql constraint should reflect this semantic.
Otherwise, the constraint might not be applicable when
installing the sale_timesheet module.
Task 2192763
Enabling sub tasks is done through the general settings
but it should be possible to disable/enable it on specific projects.
The current implementation does not allow that since the field
enabling the feature is a readonly, user dependent field.
Task 2192763
The description of the model is used in sentences like
This <model> has been created from: <link>
All model descriptions should be singular
Courtesy of Erwin van der Ploeg for raising the issue
closesodoo/odoo#51837
X-original-commit: e0acef778272abb748dacfe4460b3536b3c30a82
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Don't try to save bytes, make longer sentences, easier to translate
instead of splitting it into small blocks of one word.
https://www.odoo.com/documentation/13.0/reference/translations.html#blocks
Courtesy of Erwin van der Ploeg for raising the issue
X-original-commit: 737ee6393cd99b0c41272f6cfa9a0acb68276744
- Create a user with only Point of Sale / User rights
- Open a POS session
An AccessError is raised on `account.cash.rounding`.
We add he access right: the user should be able to read the cash
rounding configuration.
opw-2258719
closesodoo/odoo#51816
X-original-commit: 61915c33e4e0e7979d10dee01fa80a6511498f33
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
qsm-odoo