Commit Graph
122174 Commits
Author SHA1 Message Date
Nicolas Lempereur cad04fa0ea [FIX] mail: have signature in chatter by default
The signature is shown by default when sending a mail and in particular
case it is not shown.

In c8d283a592 there was a small regression that in some instance the
signature that was shown before is not shown anymore. This is because
the default in those instance is to not show signature.

eg. a message sent in a chatter would not have signature in sent emails

With this commit, the previous behavior is reintroduced.

opw-1903001
opw-1896262
closes #29088
2018-11-29 13:48:51 +00:00
jem-odoo 798b77bbd3 [FIX] sale_timesheet: missing onchange
The onchange is defined on the projduct.template, but the user
can edit the product configuration from a SO: it will be the
form view of product.product.
This commit applies the onchange of the product template
on the product product.

closes odoo/odoo#29140
2018-11-29 10:47:55 +00:00
Toufik Ben Jaa e8b5ef5b5e [FIX] purchase: crash on portal when no product image
- Since commit https://github.com/odoo/odoo/commit/8108a60dc38432243bef4f934784b119c77cf91d the purchase order crashes if a
  `purchase.order.line` product has no image.

  This is due to the fact that we pass a boolean value (False) to the
  function `image_data_uri` on the template `purchase.portal_my_purchase_order`
  which crashes.

closes odoo/odoo#29137
2018-11-29 11:24:16 +00:00
Olivier Dony 52a970bce3 [FIX] base: make demo install warning more prominent
Users may not notice the warning and carry the risk of irreversibly
damaging their production database. Making the warning message more
frightening should help avoid this.

closes odoo/odoo#29128
2018-11-29 11:13:39 +00:00
jem-odoo 3f8519f1a4 [FIX] hr_timesheet: project stat button on analytic account
Before this commit, when more than 1 projects are linked to
a same analytic account, clicking on the stat button from the
form view of analytic account, nothing happens.
This commit fixes this case by displaying the kanban view
of all the project linked to this analytic account.

closes odoo/odoo#29131
2018-11-29 09:42:26 +00:00
len-odoo a48a4b1c0b [FIX] web_editor: remove embed video option when composing an email
Embedding a video can't work because it embeds an iframe, which is not supported
by most email clients for security reasons.
(What happens when Gmail shows embedded videos in displayed emails, is that you
send a link in the email body, and it is at rendering that Gmail adds the iframe
into the page.)

In true bugfix fashion, we hide the button.
When the "res_model" is "mail.compose.message", we generate a widget with the
noVideo option.

Essentially a foward-port of v11 commit: 264f89f63f

opw 1905497

closes odoo/odoo#28912
2018-11-29 07:58:40 +00:00
Robot Odoo 05d31187d4 [MERGE] account: Improve partner suggestion in the reconciliation widget
See commits for more details.

-task:
https://www.odoo.com/web#id=1909317&model=project.task&view_type=form&menu_id=
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#28758
2018-11-29 12:32:26 +01:00
Hetashree Chauhan a5f31c324b [FIX] sale: reload targeted value
Before this commit:
when user set any target invoicing value he/she needs to refresh the
page.

After this commit:
As soon as user set the target invoice value it shows on the dashboard,
no need to refresh the page.

This commit is related to master bug

opw-1902250

closes odoo/odoo#29129
2018-11-29 09:08:50 +00:00
Robot Odoo 5a57420e48 [MERGE][FIX] portal, *: stop breaking behaviors on dblclick
* web, website, payment, website_sale

See sub-commits for details.

closes odoo/odoo#29001
2018-11-29 11:28:28 +01:00
qsm-odoo 02dcef80c9 [FIX] portal, *: stop breaking behaviors on dblclick
* payment, website_sale

This commit solves the problem described in the issues mentioned below
by using the new system introduced by the parent commit.

That new system is even more integrated with website "animations" but
the mentioned issues' features are not yet converted to use those (this
will be a master task to make "Website Widget" be defined in portal to
use all of those integrated features). This commit however converts an
already protected behavior of website_sale using that "animation"
integration.

Closes https://github.com/odoo/odoo/issues/27976
Closes https://github.com/odoo/odoo/issues/28704
2018-11-28 16:11:24 +00:00
Lucas Perais (lpe) c432667fbf [FIX] base,web_editor: get_view_id should return singleton
Because of 9a98a4d60e
and since the key of an ir.ui.view cannot be unique
(multiwebsite), duplicating views made several parts of Odoo crash

After this commit, we limit to one the views that are searched with their key
Responsibility is given to the user to change the priority and/or the key
in order to predict which view will be taken

OPW 1913335,1913100,1913186,1913112,1913240

closes odoo/odoo#29105
2018-11-28 15:26:48 +00:00
qsm-odoo 4f3635b2b1 [IMP] website, *: add event handler possibilities
* web

This commit introduces helpers for async handlers, especially for button
clicks. Those helpers are now used automatically for website widgets
(animations) if the 'async' word is placed in front of a handler name
in the `events` key definition.
2018-11-28 15:00:42 +00:00
Laurent Smet 11180de96d [IMP] account: Add constraint on statement line currency
When importing a bank statement, we need to prevent the case that an inconsistent
currency_id is set on statement line (= statement currency).

E.g. Your company is EUR, your journal is EUR, your statement is imported with a csv having
currency_id = EUR.

The amount currency will be used in the reconciliation widget instead of the
amount. Furthermore, if you are not in the multi-currency group, the currency_id is invisible and
then, it becomes difficult to understand the reconciliation propositions in the widget.

-task: 1909317
2018-11-20 13:30:51 +00:00
Laurent Smet bd90026c67 [IMP] account: check match_partner in the default reconcile rule 2018-11-19 16:01:02 +00:00
Laurent Smet bce66c1a00 [FIX] account: Set the partner if missing in reconciliation model
- Suppose a bank statement line with partner_name = x and partner = None.
- Create a reconciliation model with write-off suggestion and auto-validate = True.
- Open the reconciliation Widget.
- Check the lines created automatically: The partner_id is missing.
2018-11-16 13:14:05 +00:00
Laurent Smet 671e243fe2 [IMP] account: Set partner from partner_map in the reconciliation widget
- Suppose a bank statement line with partner_name = x.
- Create a partner with name = x.
- Open the reconciliation widget: The partner is set by default thanks to this commit.
2018-11-16 12:45:22 +00:00
Laurent Smet 6053daadb3 [FIX] account: Search res.partner.bank before creating it
- Import 2 bank statement lines having acc_number set but no res.partner.bank having this account
number.
- Reconcile the first one with a line: a res.partner.bank is created.
- Reconcile the second one with a line: UserError('Account number must be unique!')
2018-11-14 11:59:18 +00:00
Nikunj Ladava 293dbe267a [FIX] payment: fix invalid param on rpc fail
This commit is related to Task ID 1891721

closes odoo/odoo#27555
2018-10-09 05:42:29 +00:00
Nimesh Jethva fb460f8800 [IMP] stock: hide PO/SO on lot view during create&edit
It's not needed to see the many2many of PO and SO during the create and
edit since the lot could not be already sell or buy during its creation.

Task 1909002

closes odoo/odoo#28817
2018-11-29 06:03:39 +00:00
Robot Odoo 00e7de8079 [MERGE][FIX] im_livechat: correct configuration path and improved sentence
In the form view of a livechat, the instructions to configure with Odoo
website CMS was still referring to "Website Admin", instead of
"Website".

In addition to fixing this error, the sentence has been slightly improved,
as we have to regenerate the term anyway.

closes odoo/odoo#29115
2018-11-28 20:35:34 +01:00
Yenthe V.G 548268c82c [FIX] im_livechat: update translation term for improved sentence 2018-11-28 18:26:15 +00:00
Yenthe V.G 7a3c05cea7 [FIX] im_livechat: show correct path for configuration and improve sentence 2018-11-28 18:25:04 +00:00
Romain Derie a3210dc314 [FIX] base: fix asset generation when there is .less files
Since commit f7130556bb the compiled assets would be returned in a loop
before executing the rest of the `preprocess_css` method.
But every loop would override the previous one as it is `=` and not `+=`.

Fixes #27922

closes odoo/odoo#29109
2018-11-28 16:17:43 +00:00
Robot Odoo 0fb85032a7 [FIX] website_forum: show correct title on hover over accept answer
Description of the issue/feature this PR addresses: Fix wrong title on hover

Current behavior before PR: When hovering over the icon to accept an answer on the forum it will show the text "Send answer":
![image](https://user-images.githubusercontent.com/6352350/49157862-1a914b00-f321-11e8-8cd0-d98175ab9741.png)

Desired behavior after PR is merged:
The text says "Accept answer" as you're accepting an answer, not sending one.
![image](https://user-images.githubusercontent.com/6352350/49157238-97bbc080-f31f-11e8-81f7-c36950f7138e.png)

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#29101
2018-11-28 18:53:36 +01:00
Yenthe V.G 135d3d61e0 [FIX] website_forum: update .pot file with correct translation 2018-11-28 14:07:51 +00:00
Yenthe V.G ba75ffde80 [FIX] website_forum: show correct title on hover over accept answer 2018-11-28 14:07:00 +00:00
Nicolas Lempereur dbe0337555 [FIX] mail: mention escape let original intact
When selecting a mention we will add a mention in a list of selection
from the list of mention.

In 10f0766b3 that mention in list of selection was escaped so this would
match the text that would be escaped when the mention was searched in
it.

But the object are the same so the change modified the original list.

Modified test failed with:

```
  10. first partner mention should still display the correct partner
      name (Expected: "ЅpëciãlUser<&>\"`' ツ" Result:
      "ЅpëciãlUser<&>\"`' &lt;&amp;&gt;&quot;&#x60;&#x27; ツ")
```

opw-1909300
closes #29098
2018-11-28 12:33:17 +00:00
Pierre Paridans 3b0a6a6c35 [FIX] crm: form field alignment
In the Lead form view, properly align "Planned Revenue" and "Probability" fields
side-by-side and adjust their styling in mobile.

Related to task 1891955

closes odoo/odoo#28763
2018-11-22 10:34:22 +00:00
Nicolas Lempereur e942c3520b [FIX] hr_org_chart: 3 level num subordinate right
On the third level of a organization chart, the number of subordinates
on the right but over the container boundary.

For the second level there was already a special case:

  padding-left: $tmp-gap-base;

So for the third a fix could have been:

  padding-left: $tmp-gap-base*2;

But this changeset replaces margin by padding so invisible content does
not create a horizontal scrollbar (since we had 100% width with
margin-left that busted it out of its container).

opw-1912437
closes #29043
2018-11-28 12:39:14 +00:00
XavierDo 136fee6fcf [FIX] mail_bot: only display odoobot once in mention suggestions
Before this commit odoobot was appearing twice in mention
suggestions when talking to odoobot.

The initial need to be able to ping odoobot from everywhere led to the
override of channel_fetch_listeners. This is not usefull anymore.

This fix simply removes this override to avoid this problem since we
don't have a real use case where we need to ping odoobot in another
channel.

Task 1907142

closes odoo/odoo#28791
2018-11-28 11:35:12 +00:00
Olivier Colson db21ef7578 [FIX] l10n_de, l10n_mx, l10n_nl: isolate account.tag creation by country
Before that, the specific account tags created in l10n modules were not only assigned when the company was in the right country.

closes odoo/odoo#29030
2018-11-26 13:17:10 +00:00
Martin Trigaux cb097e05ea [FIX] mail: invite: use proper translation terms
Fix translation placeholders in invite wizard, to make them easier to
understand for translators. Also rework the message generation code
to ensure proper XML structure.
2018-11-03 18:11:59 +01:00
XavierDo 863f3275d2 [FIX] mail: verify attachment access early to avoid errors later 2018-11-02 11:35:10 +01:00
len-odoo 7d2fd1d1b4 [FIX] board: do not display the no_content_create div
That div has been given an absolute position, which does not work inside another
div on the dashboard.
If there are other dashboard elements below, there are unusable since they are
covered by the no_content_create div.
Moreover, there is no create button on the dashboard, so we shouldn't even see
it.
It also spares us from seeing that hideous clippy-inspired smiling paper sheet.

opw 1907650

closes odoo/odoo#29076
2018-11-27 15:08:34 +00:00
Romain Derie a67553c9d2 [FIX] website_event: website menu on event not working
Commit 7077f18e3 tried to fix the website event menu issue.
But the fix was wrong and fixed only the event having a website_id set.
After the 7077f18e3 fix, event with a website_id set are working as expected
but the ones without a website_id are not working.
Indeed, it will create a website.menu without a website_id which will result in
the menu being duplicated for each website (multi-website rule).
The required on website_id when activating website menu on event was trying to
hide that new issue but it was problematic since:
1. We were removing a feature for no reason as it would not be possible anymore
   to create a generic event (no website) with website menu activated.
2. The required would only work in form view, demo data or custo data loaded
   through xml without a website_id but having website menu activated would
   still bug and would not have a menu. Worst, the menu would be duplicated for
   every website and added to the website navbar.

Now, regardless of the event having a website_id set or not, activating or
deactivating event menu will work.

closes odoo/odoo#29036
2018-11-26 15:04:57 +00:00
Alexandre Kühn 6f37e2cc5d [FIX] mail: increment messaging menu counter once per unread preview
Before this commit, the total amount of unread messages of a
channel was considered in the computation of the messaging
menu counter.

As a result, if the channel contains 100 unread messages,
the messaging menu was displaying a counter of more than 100.

The intended behaviour is to increment the messaging menu
counter once per unread channel, thus the example above should
incremented the counter only once. The channel preview itself
should still display that there are 100 unread messages.

Task-ID 1913080

closes odoo/odoo#29080
2018-11-27 15:06:23 +00:00
Goffin Simon 77a8d92196 [FIX] mrp: BOM recursion with different variants
Fine tuning of 00bf6709a8.

Let's consider two variants V1 and V2

The function check_cycle was too restrictive, it didn't allow
to create a BOM for V1 with a dependence to V2.

But a common use case could be for example:

A black T-shirt made  from a white T-shirt and black color.

opw:1911622

closes odoo/odoo#29075
2018-11-27 14:13:03 +00:00
Yenthe V.G b5e32b8318 [FIX] fleet: make fleet vehicle state translatable
closes odoo/odoo#28999
2018-11-27 13:48:23 +00:00
Laurent Smet eaf76bff5a [FIX] account: Fix regex matching rule in reconciliation model
Before:

Suppose 'invoices 2018/0002 and 2018/0003' that becomes '2018000220180003' after
REGEXP_REPLACE(st_line.name, '[^0-9]', '', 'g').

'2018000220180003' ~ '20180002' match: OK
'2018000220180003' ~ '2018' match: NOT OK
'2018000220180003' ~ '' match: NOT OK

After this commit:

move.name/move.ref giving an empty string are filtered out.

'invoices 2018/0002 and 2018/0003'
becomes ' 20180002 20180003' after REGEXP_REPLACE(st_line.name, '[^(0-9|\s)]', '', 'g')
and becomes {"",2018001,2018002} after the regexp_split_to_array.
Then, the matching is now done by a comparison instead of a pattern matching between the move
and this array of potential candidates.

'20180002' = ANY({"",2018001,2018002}) match: OK
'2018' = ANY({"",2018001,2018002}) not match: OK
'' is filtered out: OK

closes odoo/odoo#28962
2018-11-22 13:37:13 +00:00
Rémi Rahir 879a719478 [IMP] base: update phone codes on res.countries
closes odoo/odoo#28580
2018-11-27 13:03:58 +00:00
Rémi Rahir 191665f45a [FIX] crm_reveal: increase timeout of external server request
every request on the IAP-service server sends a batch of 25 views to
process. Each of them takes around 1.5 second to be processed, thus a
full batch will exceed the default timeout of 15 seconds.

In addition, we removed the config parameter that allowed to choose the
batch size as an high value could provoke another timeout error that
would evade the user's attention.

closes odoo/odoo#28967
2018-11-22 15:19:44 +00:00
Xavier Morel 14ff69a46c [IMP] web: keep ?query on becoming superuser
Being in debug mode is necessary to become superuser (whether on the
login page or within the client), however because the becoming
endpoint would straight redirect to the _login_redirect result the
debug mode would be lost, which is commonly inconvenient.

Replace the redirect_with_hash call by local_redirect, which goes
through great pains to conserve the ?debug by default.

Task 1908202

closes odoo/odoo#29058
2018-11-27 09:32:57 +00:00
Alexandre Kühn 9df8e88046 [FIX] mail, test_mail: make mail_tour work
This tour was broken since the following refactoring:
https://github.com/odoo/odoo/commit/cd34f6de727d5b3858420cff3c9d3c5995c4e75c

With this commit, mail_tour should work correctly, and
is automatically run on runbot.

Note that the tour is automatically run in the module `test_mail`,
so that the tips are not displayed by installing Discuss.

Task-ID 1912730

closes odoo/odoo#29040
2018-11-26 16:26:34 +00:00
Goffin Simon 00bf6709a8 [FIX] mrp: BOM recursion with different variants
Let's consider two variants V1 and V2

The function check_cycle was too restrictive, it didn't allow
to create a BOM for V1 with a dependence to V2.

But a common use case could be for example:

A black T-shirt made  from a white T-shirt and black color.

opw:1911622

closes odoo/odoo#29038
2018-11-26 14:22:17 +00:00
Lucas Perais (lpe) 034a27f630 [FIX] web: customizing filter doesn't close dropdown
Have a many2one, click on search more

Open the filter menu of the search view

Add custom filter

Click to select a field

Before this commit, the whole dropdown closed

After this commit, it doesn't

OPW 1911337

closes odoo/odoo#28969
2018-11-26 14:47:44 +00:00
Alexandre Kühn 6f7a04be0b [FIX] mail: reply message from inbox
Revision on https://github.com/odoo/odoo/commit/cd34f6de727d5b3858420cff3c9d3c5995c4e75c

Before the commit above, it was possible to reply to a message
from Inbox. Those messages were linked to a document, and replying
to any of them put a response in the related document.

This feature has been broken since the commit above: the reply
icon was only shown on messages linked to a channel, instead of
message linked to a document. Also, it was erroneously prompting
that the message was sent to the channel, even though it was not
the case.

This commit fixes the issue by toggling the visibility of the
reply icon, so that it is shown only for messages that come from
a document. Also, since posting a message requires a thread, this
commit added the possibility to post a message from a mailbox,
which instead posts the message to the related document thread.

Task-ID 1912647

closes odoo/odoo#29028
2018-11-26 14:12:50 +00:00
Lucas Perais (lpe) 889bdd3569 [FIX] web: fielddate[time] should select their value when entering them
Before this commit, when focusing on a date[time] field, the value was not selected
In v11.0, it was

This is due mostly because of the migration to BootStrap 4

After this commit, the value inside the input is selected

OPW 1911333

closes odoo/odoo#28989
2018-11-26 14:51:09 +00:00
Goffin Simon b27c5e0c36 [FIX] base: Wrong view displayed
Steps to reproduce the bug:

- Go to Contact app
- click on Configuration > Bank accounts
- Create a new one

Bug:

It was impossible because the field partner_id was hidden.
The form view view_company_partner_bank_form was displayed instead
of view_partner_bank_form.

opw:1908114

closes odoo/odoo#28916
2018-11-26 12:25:11 +00:00
Goffin Simon a9c9a3d8e4 [FIX] maintenance: Access rights with admin
When only installing in a new instance the app maintenance,
the admin was not in the group 'group_equipment_manager'.
So when going to Maintenance > Equipment, the button create
was not available

opw:1912453

closes odoo/odoo#29026
2018-11-26 12:06:10 +00:00
Nicolas Lempereur 6d7a085040 [FIX] sale: de translation can ecommerce wired
There was an issue in translation that broke the mail template "Sales
Order: Send by email" in german. This prevented to do a wired sale on
the ecommerce in german.

This has been fixed in https://transifex.com/odoo/ but is done in this
PR to fix it more speedily than next week.

opw-1911419
opw-1911696
closes #29033
2018-11-26 17:21:02 +00:00