Commit Graph
130881 Commits
Author SHA1 Message Date
Jeremy Kersten be8fc2296b [IMP] base, http_routing, website: allow custom routing rule
After this commit, you will be able (in technical mode) to update the url for
the python controllers.

Eg.
You can now rename /shop in /garden and /shop/product/ in /garden/vegetable/

Most of urls will be replaced at fly in the renderd qweb, with the function
url_for but all old urls will keep available. So if you access url /shop you
will be automatically redirected to /garden (308 Permanent Redirect).

As for cdn and other post-process of att, the automatically replacement in the
rendered qweb is only done when you will be not website editor. But the new
dispatch of URL will be applied in all cases.

For developper, since it is Permanent Redirect, don't forget to clear cache or
open chrome debug tool (with option 'Disable cache while DevTools is Open) to
see your lasts changes.

closes odoo/odoo#36555

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-09-30 13:58:14 +00:00
Damien Bouvy b6b42ef73f [IMP] sale_*: multi-editable list views
closes odoo/odoo#37547

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 13:34:36 +00:00
Damien Bouvy 652ebb96e5 [FIX] tests: correctly handle invisible fields in form proxy
The form proxy will raise an error if a required field is not filled,
even when the web client would let it pass through. Indeed, the web
client (correctly) assumes that a user cannot fill in an invisible
field and that something will probably be done on the server to handle
that (e.g. an override of the write/create or simply a command-handling
code by the ORM). Since invisible fields do not even get a widget
instaciated for them, no validation takes place whatsoever.

Since it is sometimes (for obscure reasons) necessary to include all
kinds of invisible fields in tree view (e.g. to get correct values for
related stored fields, somehow), it is possible that required fields
in a view are in fact not really required since they are ignored
by the web client and then correctly handled/modified server-side.

This commit adapts the test proxies to behave similarly to the web client
(since that is, after all, the goal of these proxies) and to ignore
invisible fields when validating views.

closes odoo/odoo#37432

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 16:20:51 +00:00
Victor Feyens b32132973c [IMP] payment : save related company_id on payment.token 2019-09-30 16:20:40 +00:00
Victor Feyens 0c4bae5b5e [IMP] sale*: multi company checks 2019-09-30 16:20:40 +00:00
qdp-odoo 3c034e04d4 [FIX] account: fix CoA installation with only billing rights
When the only app installed is 'invoicing', people were getting an error while trying to generate the account.reconcile.model from its template. Could have done it in sudo(), truth is: account.reconcile.model object is not security critical

closes odoo/odoo#37622

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-30 15:03:01 +00:00
Laurent Smet 3850303385 [FIX] account: Fix creation of invoices through journal mail alias
Restore override of message_new lost during the account-pocalypse.

closes odoo/odoo#37610

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-09-30 13:41:47 +00:00
Simon Lejeune 6e61595055 [FIX] stock_landed_costs: tests across two days
Two testcases failed when ran at 23h59 and 50 seconds because of a wrong
order on date.

closes odoo/odoo#37599

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-09-30 13:00:47 +00:00
wan f701070177 [IMP] account: display the product in the name_get of account.move.line
It is difficult to select an account.move.line of an invoice if there is a product but no label on the line. By showing the name of the product, we know what line we are choosing

closes odoo/odoo#37596

X-original-commit: cf53f9c1909f85bdcb34f9acf79df1c8dc2a2da5
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-30 12:30:08 +00:00
Raphael Collet 338997d7a1 [FIX] test_mail: adapt query counts
closes odoo/odoo#37577

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-30 15:43:27 +00:00
Raphael Collet 439ebff0f5 [FIX] test_mail: wrong way to check many2many values 2019-09-30 15:43:27 +00:00
Raphael Collet 8606fb3df8 [FIX] models: copy() should recursively copy inactive records 2019-09-30 15:42:36 +00:00
Raphael Collet 4b1cb41cf7 [FIX] models, fields: cache consistency for one2many fields
Issue: after many2one updates, the cache of the corresponding one2many
fields was inconsistent when the latter depends on `active_test`.  One
of the values in cache was updated, while the other was left intact.

We simplify the cache by not making the field depend on context: the
cache value contains all the records in the relation (corresponding to
`active_test=False`).  The value of the field is automatically filtered
by the `active` field when the value is accessed.

This makes it easier to maintain the cache value, guarantees its
consistency, and avoids queries to read the one2many field with
`active_test=False`, after having set it with `active_test=True`.
2019-09-30 15:42:36 +00:00
Pierre Rousseau 333f1087cf [FIX] stock_sms: do not send mail notifications
The aim of this commit is to remove the mail notifications when there is no more credits on IAP accounts for SMS integration with stock.

Task-ID 2077783

closes odoo/odoo#37559

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2019-09-30 12:32:06 +00:00
Pierre Rousseau 3469821b73 [FIX] crm_iap_lead: set status readonly
The aim of this commit is to set the state readonly in the tree view.

Task-ID 2077783
2019-09-30 12:24:24 +00:00
David Beguin fed533bcf2 [FIX] livechat : fix rating per user in livechat frontend view
rating_per_user was instanciated the wrong way, as all the key pointed to the
same reference. Once a value was modified in the value dict, all the other
values in rating_per_user were also updated.

Task ID: 2076656
PR #37511

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-30 15:54:51 +00:00
David Beguin c7d6fc84a8 [FIX] rating : set rating_last_image/feedback to readonly
It's a non sense to be able to write on rating_last_image/feedback field as it is a related
to a computed field based on the last rating, given by someone.
We should not even try to corrupt data !

Task ID: 2076656
PR #37511
2019-09-30 15:54:51 +00:00
David Beguin 41b2d9cc86 [FIX] livechat : use main rating image instead of white one for livechat frontend view.
As the percentage bar is translucid, white rating icon is not really easy to see.
Using the main rating image - red for :(, orange for :| and green for :) - is more
convenient.

Also, this fixes the height of rating chart as the bottom border was not visible when 0%.

Task ID: 2076656
PR #37511
2019-09-30 15:54:50 +00:00
David Beguin 8d359aa5a5 [FIX] livechat : use visitor name when visitor start livechat
If the visitor starts a livechat session, his anonymous name was 'Visitor'.
Since visitor info are now stored, we can use the visitor name instead, if a visitor
can be retreived.

Task ID: 2076656
PR #37511
2019-09-30 15:54:48 +00:00
David Beguin 74fa5c2955 [FIX] livechat : add placeholder to receive conversation copy and fix translation
This commit adds a placeholder to the field where the visitor has to put his email
to be more self speaking. (Otherwise, the visitor could not know what to put on this field)

Task ID: 2076656
PR #37511
2019-09-30 15:51:20 +00:00
David Beguin f15a4a31cf [FIX] livechat : do not close livechat after feedback-rating, positive or negative
Since there is now a possibility for the user to ask a copy of the conversation,
livechat window should not be closed after feedback, to let the user choose to
receive a copy.

The behaviour was no aligned between positive and neutral/negative feedback.
Before, when sending a positive rating, the rating was not sent as a message on the channel
and the window didn't close.
But for neutral/negative feedback, the window was sending the rating as a message on the channel
but the chatter closed immediately.

Now, the rating is sent as a message for any type of rating.
If this is a neutral / negative rating, the reason field appears.
After sending the reason, the window stays opened.

Task ID: 2076656
PR #37511
2019-09-30 08:07:41 +00:00
Katherine Zaoral 8de9ce5f7a [FIX] l10n_ar: data and demo data
- AFIP code in UOMS saved as char
- fix missing account_id in demo data
- Remove demo data that was throwing error
- merge res country data to csv file.
- move res currency AFIP code data to csv file

closes odoo/odoo#37457

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-09-30 15:02:00 +00:00
Julien Mougenot 652414ca4e [FIX] web: grouped list multi edit with m2m
Before this commit, m2m fields were not updated when multi editing
in a grouped list.

Now, the fields are updated no matter how many levels of groupBys
are applied to the list.

Part of task 2078807

closes odoo/odoo#37589

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-09-30 12:53:18 +00:00
Romeo Fragomeli 53bb1387b5 [FIX] web: control panel: error by clicking on padding on mobile
o_control_panel have this layout:
 +-------------------------------------+
 |  PADDING                            |
 |  +----------------------------------+
 |  |  breadcrumb      o_cp_searchview |
 |  |  o_cp_left       o_cp_right      |
 |  +----------------------------------+
 +-------------------------------------+
As you can see, there is a padding on the edge of the widget.

In Odoo 12.0, before the control panel refactoring (odoo/odoo@40dd121938)
the search view was a widget by itself (addons/web/static/src/js/views/search/search_view_mobile.js).
Note that in this case, once the following condition:
"ev.target === this.el" was reach the normal behavior
was executed.

But now the search view is embedded in the control panel.
There is a side effect: clicking on the padding of the control panel
triggers the "_onOpenMobileSearchView" and the condition is always true.
Therefore we try to open the search more even if it doesn't exist.
But anyway, the search view (full) shouldn't be opened when we click on
the control panel.

After this commit, the listener is scoped to o_toggle_searchview_full,
to avoid this side effect.

Steps to reproduce:
* Open any app with a control panel (e.g. accounting)
* Select a record (e.g. an invoice)
* Click on the padding of the control panel (BUG)

closes odoo/odoo#37587

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-09-30 12:27:57 +00:00
oco-odoo fdc3555c8d [IMP] account: filter receivable and payable accounts so that they are not selectable as tax accounts on repartition lines
closes odoo/odoo#37572

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-30 09:21:36 +00:00
oco-odoo 2727b383b9 [IMP] account: filter tax tags on account.move form view
So that we only allow chosing the ones that are available for taxes, in the right country.
2019-09-30 08:48:33 +00:00
Antoine Vandevenne (anv) 897a4baecf [IMP] product(_matrix): clean demo product for matrix
Before this commit, the product 'My Company Tshirt' had too much PTAL and PTAV which lead to an overloaded matrix.

This commit removes the 'Sleeves' attribute, reorder the other attributes and remove the Size attributes '2XL' and '3XL'.

task-2052537

closes odoo/odoo#37543

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 11:57:18 +00:00
Antoine Vandevenne (anv) 06bd183ec2 [IMP] product(_matrix), *: add configurator hint to template name
Before this commit, it wasn't easy to find a demo product template that opens either with the product configurator or with the matrix from a list view.

To fix that, this commit appends '(CONFIG)' to the name of all demo product templates that open with the product configurator and '(GRID)' to all demo product templates that open with the matrix.

task-2052537
2019-09-30 11:56:24 +00:00
Romain Derie 3408c4dd1e [FIX] http_routing: restrict lang matching to installed lang
When accessing an URL, there is some computation to check if you try to access
a lang. Part of this job is to get the closest language available.
For instance, you could try to get `/fr_BE/..` and it would redirect to
`/fr_FR/..` if french is installed but not belgian french.

There is a known issue when loading files/assets from a module starting by the
same letter than a lang, in debug assets.
Only reported case was `hr_XXX` modules which would be redirected to `hr_HR`
lang (croatian).

So, the issue would only occur when:
1. Debug assets is enabled
2. hr_HR lang is activated
3. only hr_XX modules would be impacted

But since 269aa59411, the issue would appear even if `hr_HR` was not activated.

This commit restore the issue to its minimal case, when `hr_HR` lang is
activated.

closes odoo/odoo#37494

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2019-09-30 14:04:07 +00:00
ryv-odoo 8d7004b5d4 [FIX] mass_mailing_sms : fix display name contact list
- In the sms marketing app, the count of valid sms
recipient for contact list was not consistent in all app.
Fix by appling the mailing_sms context value also in the
mailing mailing form.

TASK_ID : 2075733

closes odoo/odoo#37248

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-30 14:28:30 +00:00
ryv-odoo 32a74bea01 [FIX] mass_mailing : move name for mass mailing.
The name for a mass mailing is now automatically generated, then
put the name field in settings and only visible/editable on debug mode.

TASK_ID : 2075733
2019-09-30 14:28:30 +00:00
ryv-odoo 0d513785f7 [FIX] mass_mailing : fix editable tree view
- Now tree view is editable, because of that it was possible to change
subject and targeted model in mass mailing. Fix make it readonly explicitly.

TASK_ID : 2075733
2019-09-30 14:28:30 +00:00
ryv-odoo 100249f172 [FIX] mass_mailing_sms : sms on record chatter
- For the sms marketing, by default the sms is now log
on the chatter of the record (like with the sms composer).
But can be disable it with keep arhives unchecked (in debug mode only).

TASK_ID : 2075733
2019-09-30 14:28:30 +00:00
ryv-odoo b002973f0e [IMP] sms - mass_mailing_sms : unsubscribe sms improvement
- In the sms marketing, the sms_allow_unsubscribe is now False by default
and move the field in the setting page.

- Improve the unsubscribe link for the sms : adding "\nSTOP SMS : "
message before the link.

TASK_ID : 2075733
2019-09-30 14:28:28 +00:00
ryv-odoo 2d5260e11b [FIX] sms - mass_mailing(_sms) : small fixes
- In the mail/sms marketing, when we send a mass mailing (sms or not)
with the mailing list selected, all the mailing list is take in account,
domain is not correctly modify. Fix the onchange function.

TASK_ID : 2075733
2019-09-30 09:37:11 +00:00
ryv-odoo e572187af3 [FIX] mass_mailing_sms : small view bugfixes
- In the sms marketing form view, a space is missing between the text
and a next_departure field -> Fix

- In the sms marketing form view, the sms content is now required
order to fix traceback due to a empty sms (when the sms was send).

- In the the sms marketing tree view : change the name field
with the subject field
(due to the change with name -> subject of mailing)

TASK_ID : 2075733
2019-09-30 09:31:59 +00:00
ryv-odoo 70519489e9 [IMP] mass_mailing(_sms) : improve mail/sms marketing forms
- In the mail/sms marketing form, compress all blue ribbons into
one to avoid multiple space between ribbons.

- In the sms marketing form, we add a clicked stat button to have
the same information that the kanban view.

- In the mail marketing form (when sms is enabled), when the state is in draft, stat buttons
opened and replied was present for no reason (only with sms marketing installed).
Fix by adding correct invisible condition.

TASK_ID 2075733
2019-09-30 09:27:17 +00:00
ryv-odoo eebeefcf8b [IMP] mass_mailing(_sms) : revamp/fix mail marketing views
- Revamp the kanban view of the mass mailing (and mass SMS)
model to be more concise and readable. Also fix the issue of no border progress
bar in community version (same view).

- In the kanban view of mail marketing, when mailing list model is
targerted, the count of record was not correct.
Create a display condition if mailing list is used to fix the issue.

TASK_ID : 2075733
2019-09-30 09:17:29 +00:00
Lucas Lefèvre d43a63d5f6 [FIX] hr_holidays: Automatically set leave dates with 2 week calendar
Commit c7f11aa fixed computation leave length but
forgot to adapt the code when a 2 week calendar is used.
This leads to a traceback when creating a leave for an employee
with a 2 week calendar.

This commit rectifies this.

closes odoo/odoo#37566

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-09-30 12:29:58 +00:00
Simon Lejeune ad31097d8e [FIX] stock, delivery: put in pack and discard
rev[0] writes the qty done on the move lines directly in put_in_pack,
meaning hitting discard in the delivery wizard left the move lines with
a changed qty_done. We fix that by editing the quantities in
_put_in_pack in the stock module and getting the right move lines in the
delivery modules: meaning, get the normal or suggested ones (a fix
missed by rev[1]) then with quantities or 0 quantities.

[0] e03c1a836f
[1] f6d88a2e8d

closes odoo/odoo#37563

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-30 11:58:38 +00:00
Jigar Vaghela 92d57bafd5 [IMP] l10n_in: GSTIN number value from journal gstin partner insted of company vat
closes odoo/odoo#37471

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-09-27 11:39:39 +00:00
Jigar Vaghela ea9e8a37d6 [IMP] l10n_in*: multi GSTIN Using journal
=======
Purpose
=======

    government rule that "GST registration should be obtained by a taxable person under GST in each of the State or Union Territory, from where the taxable supply of goods or services is made"
    So we managed this using journal
    User create journal and partner for other states
    After user can select journal in Sale order, Purchase order and warehouse

========
Solution
========

    -Add a field on the journal to define the GSTIN
    -Add sale and purchase journal field in warehouse
    -On the SO/PO, add the journal field and based on the warehouse journal it set automatically fill if warehouse journal is set.

task 1917619
2019-09-27 11:39:39 +00:00
RomainLibert 85eeaccf06 [FIX] tools: use user friendly message in case of error
closes odoo/odoo#37058

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-09-18 10:14:12 +00:00
wan f60acb4f49 [FIX] account_bank_statement_import: unused variable
There was a useless variable left at the refactoring of https://github.com/odoo/odoo/commit/97c3f0f0257774af0e064b0085e2b6c5b65d9efe

closes odoo/odoo#37020

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-30 11:25:59 +00:00
Simon Lejeune 971c376c5c [REV] mrp: Explicitely label by-products
This reverts commit 42834e4eb3.

finished_workorder_line_ids contains finished products and by products.
Naming the section by-products is not clear when the settings isn't
enabled.

closes odoo/odoo#37588

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-30 11:31:03 +00:00
Debauche Stéphane 2dc1f2ea73 [FIX] rating, typo error in `_compute_rating_image`
closes odoo/odoo#37583

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-30 11:08:34 +00:00
qsm-odoo bd701e1e03 [REF] website_theme_install: remove dead code in theme install code
closes odoo/odoo#37569

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-09-30 10:00:51 +00:00
Xavier Morel 0c7f7b186d [FIX] web, mail: move admin login warning to mail
Fixes #33254:

* was in mail despite using mail.channel (which breaks if mail is not
  installed, and web doesn't depend on mail)
* changes to sudo() broke previous behaviour (of having odoobot
  message the admin, we ended up with the admin messaging themselves)
  so fix that
* also get the channel and message with the user's context, otherwise
  since we're during the login procedure the context could be as
  little as just the lang from the browser and apparently channel_get
  automatically creates a translation which would break if the
  browser's lang is not installed in Odoo

closes odoo/odoo#37580

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-09-30 10:34:42 +00:00
Jairo Llopis 974913c316 [IMP] Support psycopg2.sql module
[`psycopg2` includes a submodule called `sql`][1] which provides more safety and comfort when dealing with raw SQL queries.

As of today, it works fine with Odoo unless SQL query logging is enabled.

This patch fixes that problem, allowing usage of that module.

[1]: http://initd.org/psycopg/docs/sql.html

closes odoo/odoo#37561

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-30 08:08:07 +00:00
Vincent Schippefilt e06117bd85 [FIX] web: multi-hell-ditable list
only activate multi-edit on list with specific attribute.
When the attribute multi_edit="1" is set on the tree view the user
can select a/some records and it will activate the multi-edit
with confirmation dialog (even for a single record).
Also, on-change are not applied when using multi-edit

closes odoo/odoo#37525

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-09-30 08:57:23 +00:00