Commit Graph
130927 Commits
Author SHA1 Message Date
Jorge Pinna Puissant 79afa204e0 [FIX] mail: missing attachment icon
Since 1d766c067d the attachment icon was
missing when it wasn't a pdf or image type file.

opw-2064128

closes odoo/odoo#37687

X-original-commit: c44cec7e5ed9de3be495eb44b351eda6b0f6aeee
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-10-01 11:34:05 +00:00
Damien Bouvy d69ded69cc [FIX] payment_test: allow to disable it
closes odoo/odoo#37621

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 15:11:18 +00:00
Damien Bouvy ad94c1e712 [IMP] payment_stripe: sca completitude
Althought most of the SCA compliance stuff was already there,
the flow was slighlty changed to better support some flows in 12.0

Reflect this changes in 12.5.
2019-09-30 15:11:16 +00:00
Antony Lesuisse 4ddce229c4 [IMP] l10n_generic_coa: improve chart
Renamed xml ids of the main accounts (in prepartion for a future multi l10n
demo system). Change account numbering to match quickbook and other US GAAP
convention and recommendations.

closes odoo/odoo#37606

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-01 13:09:50 +00:00
ryv-odoo 3bca1d52a0 [FIX] mass_mailing_sms : fix KPI in draft
There is the % Clicked stat button in SMS marketing form view when it
is on draft or test. Fix to be only visible
when the state is not in draft or test

TASK_ID : 2078918

closes odoo/odoo#37615

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-01 11:14:04 +00:00
ryv-odooandStéphane Debauche a7489feed0 [FIX] mass_mailing: mail template become invisible after saving
Bug
===
In the mailing mailing form view, after saving the email and creating it, the body is invisible and one needs to edit and save again to see the content
The view has two fields with the same name

Fix
===
At the end, we have only one field and some condition on the attributes (class, widget)

TASK_ID : 2078918

Co-authored-by: Stéphane Debauche <std@odoo.com>
2019-10-01 11:04:10 +00:00
ryv-odoo 43a880eb6c [FIX] mass_mailing_sms : diplay count pf contact list incorrect
In the sms marketing, the display name of the contact list was wrong
during the search of the many2one widget (contact list field,
count of valid number was the count of valid email).
Add a context attribute on the widget depending of the global context
to force the rigth count.

TASK_ID : 2078918
2019-10-01 11:04:10 +00:00
ryv-odoo f422cfdbb9 [FIX] mass_mailing_sms : the sms_allow_unsubscribe field invisible for mailing marketing
The field sms_allow_unsubscribe field was visible and checkable on the
email marketing app, but this field is reserved to the
sms marketing. Add a invisible condition.

TASK_ID : 2078918
2019-10-01 11:04:10 +00:00
Samuel Degueldre 74e23b2e2b [IMP] Prevent reverse tabnabbing in plaintext2html, linkify, _makeLink
These functions convert plain text links into clickable hyperlinks.
These open in new tabs but did not have the "noreferrer noopener" rel
attributes, which made them susceptible to reverse tabnabbing.

A lot of attack vectors were available to unregistered, uninvited
anonymous users and presented a significant phishing threat (such as
posting links in the instant-chat, through a mail-alias, in a forum post
or in a twitter post) and leading the operator to believe he had been
disconnected from odoo in the original tab, prompting them to enter
their credentials.

while these three places will add the noreferrer and noopener attributes
on the anchor tags generated by them, there are still many places that
create hyperlinks without the use of these functions, although most of
them are static links, they still represent a transitive security
vulnerability to the linked sites.

There are also a few modules and widgets that roll out their own links
or open new tabs unsafely using window.open(), these will need to be
patched separately.

closes odoo/odoo#37591

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2019-10-01 08:24:59 +00:00
Laurent Smet e121bacbd0 [FIX] account: Fix editable fields on editable grouped list views
Nothing is editable on account.move.line tree view.
On grouped tree views, only account_id, name, ref, tag_ids, date_maturity are editable.
The account hierarchy must not be visible on the partner ledger view.

closes odoo/odoo#37528

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-01 08:02:25 +00:00
Laurent Smet 790da8b463 [FIX] account: Prevent messing invoices when writing account_id
When writing an account from the editable groupby list view, prevent
the user to messing up the invoices by writing receivable accounts everywhere.
2019-09-30 14:31:22 +00:00
Nicolas Bayet 14116b3b9e [IMP] add ability to unlink databases from subscription more easily
closes odoo/odoo#37431

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
2019-10-01 07:58:02 +00:00
Gorash b1503c7ee0 [FIX] web_editor: remove image style when change to an other than image
closes odoo/odoo#37343

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2019-09-24 08:52:43 +00:00
Benjamin Vray 6eaf5da98a [FIX] sms: avoid error when resending sms
avoid a traceback when resending a SMS
It was because arguments of the js function setSmsStatus
were undefined in this case

closes odoo/odoo#36907

Task-id: 2070836
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
2019-10-01 11:45:27 +00:00
Benjamin Vray 2a7796cbaf [FIX] stock_sms: Change class of disable sms button
Change class of disable sms button in secondary

task-id: 2070836
2019-10-01 11:45:27 +00:00
Benjamin Vray 5be43f8c1e [FIX] stock_sms: add order number in sms
Add order number in the sms wich indicates
that the order has been shipped

task-id: 2070836
2019-10-01 11:45:27 +00:00
Benjamin Vray 39f4920039 [FIX] crm_sms: bug when send SMS in batch
It was no longer possible to send SMS in batch in the list view
This is because it was missing the default_res_ids  key in the action context

task_id: 2070836
2019-10-01 11:45:27 +00:00
Yenthe666 24435c876d [IMP] resource: add missing sheet on form view
closes odoo/odoo#35966

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-01 12:34:51 +00:00
Muhammad Awais 750bff8c39 [CLA] signature for herawais
closes odoo/odoo#37685

X-original-commit: 65d8d3fb5e5d592ef0a0cb49c37baf5ed34298fd
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-01 11:28:55 +00:00
Laurent Smet 8f6e383397 [FIX] account: Fix invoice report template
- Description is no longer needed since it provides the same info as the header.
- The ref field will be used to set a custom description on any invoice (not just vendor bills).
- Don't display the name on the report if the move hasn't been posted.

closes odoo/odoo#37683

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-01 11:15:52 +00:00
qsm-odoo 18854caedd [FIX] website_event: prevent crash if clicking on register too soon
Since https://github.com/odoo/odoo/commit/02dab5dc88112fd5f5ee43882ca022529acb4abf,
the JS is now lazy loaded. As the "Register Now" button on each event
page relies on JavaScript to perform a RPC, it needs the JS to be loaded
to be able to work properly when clicking on it. In this case, clicking
on it while the JS is not loaded yet performs a standard form submit,
which lands on a route which cannot handle a standard form submit which
then results in a 400 error page.

This commit fixes the problem by adding the 'o_wait_lazy_js' class on
the button which simply prevents click on elements during lazy loading.

Discovered while working on task-2043872

closes odoo/odoo#37675

X-original-commit: https://github.com/odoo/odoo/commit/5e885436f9a77b4c387cd0b1eb07102ff85bec03
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-01 11:49:53 +00:00
David Monjoie 5f65f1e0c8 [FIX] web: fix optional fields invisible overflow
Before this commit, the "renderer with search panel" have a max-height
of 100% but no min-height. Because of this, it is possible that the
list view optinal fields dropdown would be smaller than the "renderer
with search panel" container. Since this particular container has to
be in overflow: auto (see the comment on the line above the change),
it hides the overflow of the optional fields dropdown.

This commit sets the height of the "renderer with search panel"
container to 100% such that it does not truncate the optional fields
dropdown. The bug was observed on the General Ledger menu of Accounting,
and the change does not look to change anything other than correctly
displaying the optional fields dropdown without truncating it.

closes odoo/odoo#37660

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2019-10-01 08:46:58 +00:00
qsm-odoo bf0b3a400b [FIX] website_event: restore 'local events' snippet in edit mode
Since https://github.com/odoo/odoo/commit/335a505d1f9b6a978c0fe0f6ea760a45b0d0a67f,
the frontend widgets are not used in edit mode by default. The local
events snippet's one had to be explicitly enabled.

Discovered while working on task-2043872

closes odoo/odoo#37672

X-original-commit: 5424a4b590e73d2cf3cfb39bbbe656e908db2b46
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-01 10:02:30 +00:00
Geoffroy Larue 0e94c675ef [IMP] account: make reverse wiazrd extendable
This commit sets the call to default method on move field in reversal
wizard as lambda to ensure that the right method
is called when it is inherited (as in helpdesk_account module).

It also changes the form view so other module can use it to refund
invoices (move_id field first in the view as it will determine if refund
method should be visible or not).

Task-2047999

closes odoo/odoo#37635

X-original-commit: bcda50aeca44b292417024a5e422ffb8698e0c99
Signed-off-by: gla-odoo <gla-odoo@users.noreply.github.com>
2019-10-01 09:47:59 +00:00
RomainLibert 44a500c8d0 [FIX] hr: make the email field visible again
You DO want to be able to change your user's email address from the
employee profile

closes odoo/odoo#37674

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-10-01 10:16:05 +00:00
Jigar Vaghela 672cad0af2 [FIX] l10n_in: Fix report line in tax
Before this commmit:
   Show wrong value in Tax report

After this commit:
   Show right value of taxes in Tax report

closes odoo/odoo#37673

X-original-commit: 67ad5e1ecbcb9aee3f47c400b82b9df989c05d78
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-01 10:04:40 +00:00
Jigar Vaghela 8bdddcbe80 [IMP] l10n_in: Set parent in tax report
closes odoo/odoo#37671

X-original-commit: d4dc7ae8285e6ab65f168e61650ef89ebdb2268d
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-01 10:00:06 +00:00
Pierre Masereel 8f91e81065 [FIX] l10n_fr_pos_cert: move sale closing on pos
The report sale closing that was working on journal and takes the sales
total and cumulative total on periods of 'day', 'month' and 'years'. Is
now based on the pos orders and moved to the pos certification module.

closes odoo/odoo#36967

Task-id: 47990
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-01 10:02:50 +00:00
Pierre Masereel 82e06a9f50 [FIX] l10n_fr_pos_cert: inalterability check report
We've added a repport that guarantee that the blockchain of hash has not
been altered. It recompute the hash and check that they are the same as
the one stored.

TASK-ID: 47990
2019-10-01 10:02:50 +00:00
Pierre Masereel 78994b55b6 [FIX] l10n_fr_pos_cert: avoid editing orders
Once an order is created in the french certification, we cannot modify
it wihout traces, so we've disabled the edtition of the order lines in
the frontend, disable the price changing, and the deletion of orders.

So when we want to decrease the quantity, a line with negative quantity
should be done.

TASK-ID: 47990
2019-10-01 10:02:50 +00:00
Pierre Masereel 5b8f86a3eb [FIX] point_of_sale: remove datas_fname field
Since the field datas_fname doesn't exist anymore, we should not set it
anymore.

rev: c212cfe899
2019-10-01 10:02:50 +00:00
Pierre Masereel 00a30e1d07 [FIX] l10n_fr_pos_cert: display hash in debug mode
We now display the pos order hash, on the order form view when we are in
debug mode.

TASK-ID: 47990
2019-10-01 10:02:50 +00:00
Pierre Masereel 9e5ea29e34 [FIX] l10n_fr_pos_cert: display hash on receipt
When an order is sent to the server from the point of sale, a unique
hash is generated by the server. This hash must be printed on the
receipt to allow the comparison between the receipt and the data on the
server and guarantee the unalterability of the data on the server.

TASK-ID: 47990
2019-10-01 10:02:49 +00:00
Pierre Masereel b213c9ee3c [FIX] point_of_sale, pos_restaurant: print bill with correct template
Until now, the ticket printed from the web or to the printer were
different because one was using the OrderReceipt template and removed
some fields, and the other was using the BillReceipt.

We are now using only the bill receipt, to avoid to maintain multiple
template showing the same thing.

TASK-ID: 47990
2019-10-01 10:02:49 +00:00
Pierre Masereel 69dc97c698 [FIX] point_of_sale, pos_reprint: write duplicata on reprint
When a receipt is reprinted, the word 'DUPLICATA' is printed at the
bottom of the receipt.

We are also allowing to reprint ticket even if no printer is selected on
the POS config as nothing prevent to do this.

TASK-ID: 47990
2019-10-01 10:02:49 +00:00
Raphael Collet 72d5761730 [FIX] base: do not flush during model setup
Retrieving selection data for a custom field while setting up a model
should not flush() fields in `ir.model.fields.selection`.

closes odoo/odoo#37667

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-10-01 09:25:02 +00:00
jbm-odoo b4616b7339 [FIX] event: Fix onchange on category
Fix onchange on category, it must write on event mail

closes odoo/odoo#37654

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-10-01 07:42:15 +00:00
Laurent Smet 9af5516e16 [FIX] account: Fix non-determinist matching-rules tests
If the current date changes when creating the invoices (e.g. nightly builds)
the results are not always in the same order because the matching rules propositions are
sorted by date in the descendant order.

closes odoo/odoo#37653

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-01 07:34:16 +00:00
Louis Baudoux 1f0d28591d [FIX] l10n_generic_coa: fix demo invoice with wrong journal
The 'Miscellaneous Operations' journal was used instead of the 'Vendor
Bills' journal for that demo invoice, which lead to a crash when
processing it with the OCR.

closes odoo/odoo#37618

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-10-01 07:07:32 +00:00
Simon Lejeune 12824cb432 [FIX] stock: width on buttons
closes odoo/odoo#37617

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-30 14:39:51 +00:00
Pierre Rousseau cef2bbd12f [FIX] partner_autocomplete: display insufficient credit notification.
Before this commit the error 'Insufficient Credit' was not triggered by the python side, so the notification was never displayed.

closes odoo/odoo#37649

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2019-10-01 06:42:52 +00:00
Yenthe666 3bd70d91fe [CLA] remove Yenthe from Odoo Experts
closes odoo/odoo#37637

X-original-commit: 028def41de94e6f123f816ee6fcd4ef31a7033f0
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-09-30 19:24:13 +00:00
Eric Channey 3ecd6a6155 [CLA] signature for ezchan
closes odoo/odoo#37628

X-original-commit: ab2655912e017cbe0fcfadc937eaef44eaaa91f7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-09-30 15:59:01 +00:00
Florian Gilbert 87bc2e1547 [FIX] Remove "inalterable_hash" from account move view (put in enterprise).
closes odoo/odoo#37603

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-30 13:11:16 +00:00
Humberto Arocha 1deca4917a [FIX] l10n_mx: Sequencing Template Taxes in order promote them.
Before this commit when installing l10n_mx chart of accounts taxes for
0% and 4% were the ones assigned by default in products or in invoices
for sales and purchase, respectively.

Reason was wrong sequence in the Template of Taxes, combined with order
of creation, ids.

now the two ones with lowest sequence are the 16% Taxes.

closes odoo/odoo#37642

X-original-commit: 357943e9440683f2bff01dc2f1ef074e5104769a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-09-30 20:41:00 +00:00
Susana 725827b3e9 [FIX] Some fixes and improvements in l10n_cl module
[FIX] add account asignation to taxes
[FIX] Fixes after code review
[FIX] remove default value for taxpayer_type
[IMP] add an empty section in res_config_settings_view as a holder
for any Chilean Localization future configuration setting.

[FIX] change location of Chilean Localization section

closes odoo/odoo#37555

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-09-30 18:33:59 +00:00
Jeremy Kersten be8fc2296b [IMP] base, http_routing, website: allow custom routing rule
After this commit, you will be able (in technical mode) to update the url for
the python controllers.

Eg.
You can now rename /shop in /garden and /shop/product/ in /garden/vegetable/

Most of urls will be replaced at fly in the renderd qweb, with the function
url_for but all old urls will keep available. So if you access url /shop you
will be automatically redirected to /garden (308 Permanent Redirect).

As for cdn and other post-process of att, the automatically replacement in the
rendered qweb is only done when you will be not website editor. But the new
dispatch of URL will be applied in all cases.

For developper, since it is Permanent Redirect, don't forget to clear cache or
open chrome debug tool (with option 'Disable cache while DevTools is Open) to
see your lasts changes.

closes odoo/odoo#36555

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-09-30 13:58:14 +00:00
Damien Bouvy b6b42ef73f [IMP] sale_*: multi-editable list views
closes odoo/odoo#37547

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 13:34:36 +00:00
Damien Bouvy 652ebb96e5 [FIX] tests: correctly handle invisible fields in form proxy
The form proxy will raise an error if a required field is not filled,
even when the web client would let it pass through. Indeed, the web
client (correctly) assumes that a user cannot fill in an invisible
field and that something will probably be done on the server to handle
that (e.g. an override of the write/create or simply a command-handling
code by the ORM). Since invisible fields do not even get a widget
instaciated for them, no validation takes place whatsoever.

Since it is sometimes (for obscure reasons) necessary to include all
kinds of invisible fields in tree view (e.g. to get correct values for
related stored fields, somehow), it is possible that required fields
in a view are in fact not really required since they are ignored
by the web client and then correctly handled/modified server-side.

This commit adapts the test proxies to behave similarly to the web client
(since that is, after all, the goal of these proxies) and to ignore
invisible fields when validating views.

closes odoo/odoo#37432

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-30 16:20:51 +00:00
Victor Feyens b32132973c [IMP] payment : save related company_id on payment.token 2019-09-30 16:20:40 +00:00