Commit Graph
116771 Commits
Author SHA1 Message Date
Darshil Trivedi 69dd3dfa90 [FIX] stock: scrap: bypass confirmation wizard if not storable
If a user wants to scrap more quantity than he has in stock, we return
to him a confirmation wizard. This doesn't make sense when scrapping
consumables products, as there are no quants for these kind of products.

task 1864026
2018-08-16 15:14:54 +02:00
Graeme Gellatly 7d898ad72f [FIX] purchase: rounding in supplier info
- Set 'Product Price' accuracy to 5 places
- Create a PO for a product to a new supplier
- Enter price at 3.14561 / unit

Supplier info entry rounded to 3.15, while it should be 3.14561.

Closes #22253
Fixes #22252
2018-08-16 13:44:23 +02:00
Christophe Simonis 51225c9b9f [MERGE] forward port branch saas-15 up to 52e88036f2 2018-08-14 18:24:40 +02:00
Christophe Simonis 52e88036f2 [MERGE] forward port branch saas-14 up to d4ee30b4fa 2018-08-14 17:45:46 +02:00
Christophe Simonis d4ee30b4fa [MERGE] forward port branch 10.0 up to a487d7d397 2018-08-14 17:09:32 +02:00
Christophe Simonis a487d7d397 [MERGE] forward port branch 9.0 up to 72cb16865c 2018-08-14 16:57:21 +02:00
Christophe Simonis 71bba5e43d [FIX] anonymization: ignore unreachable code pylint warning 2018-08-14 16:55:36 +02:00
Christophe Simonis 72cb16865c [FIX] purchase: avoid non-sense domain on invoice's purchase order
PO that can be linked to an invoice are filtered via a domain
restricting the partner. However when no partner is selected yet, the
domain was `('partner_id', 'child_of', False)` which, beside being horribly slow, was also useless as it returns ALL partners.

Only generate a meaningfull domain.
2018-08-14 16:19:20 +02:00
Christophe Simonis a711c5acb8 [MERGE] forward port branch 9.0 up to 0b7c1d2978 2018-08-14 15:55:43 +02:00
Richard Mathot 0b7c1d2978 [REV] anonymization: partial revert of 2039c3c792
Shame on me.
2018-08-14 15:49:33 +02:00
Christophe Simonis 70128a2dfc [MERGE] forward port branch 9.0 up to d2605bccdb 2018-08-14 15:12:47 +02:00
Olivier Dony d2605bccdb [FIX] requirements: bump up pillow,jinja2 reqs
Recommended by GitHub's repository alerts.

We normally stick as close as possible to the version we depend
on in the official DEB packages. This in turn depends on the version of
Debian stable at the time of release - for 9.0 that would be Debian 8
(jessie) and thus Pillow 2.6.1.

However Pillow versions before 3.3.2 and Jinja2 before 2.8.1 suffer
from a few issues that could lead to crashes of Odoo workers.
The bugfixes have been backported in the DEB packages for Pillow,
so users of Debian/Ubuntu LTS versions won't be affected if they are
keeping their systems updated.

However it's worth an exception to our rule for pip users.
2018-08-14 14:54:57 +02:00
Richard Mathot 2039c3c792 [FIX] anonymization: end of support
task: 51094
2018-08-14 14:36:18 +02:00
Christophe Simonis c0f147173e [MERGE] forward port branch 9.0 up to 2917b38f28 2018-08-14 14:15:13 +02:00
Nicolas Martinelli 388bc549c1 [FIX] stock: remove unnecessary manual step
- Create a product A tracked by S/N
- Get some stock of A
- Create a SO and sell 1 unit of A, confirm
- Go to the picking, validate

An error message forces the user to manually encode the 'Done'
quantities.

This step is not necessary, since the user will still get a message
notifying him that the reserved quantities will be used as done
quantities.

opw-1873180
2018-08-14 13:43:43 +02:00
Nicolas Martinelli 90cdc91638 [FIX] account: fiscal year last day
Do not replace the day value without notifying the user.

In undetermined circumstances, a fiscal year last day and month can be
replaced by the default December 31st value. Since all settings are
re-written for any setting changed, this is likely to happen in the back
of the user.

Moreover, the `_verify_fiscalyear_last_day` is not correct since it
doesn't accept February 29th, while `compute_fiscalyear_dates` handles
it.

opw-1867978
opw-1873260
2018-08-14 13:32:41 +02:00
Christophe Simonis 2917b38f28 [FIX] crm: do not consider leads without emails as duplicated 2018-08-14 12:08:04 +02:00
len-odoo 549b7175ec [FIX] sale_crm: add marketing context when converting opportunity to quotation
When converting an opportunity to a quotation, marketing context (campaign,
medium and source) weren't copied to the newly created quotation.

opw 1863825
2018-08-13 15:22:26 +02:00
Nicolas Martinelli 34117549b9 [FIX] web: increase timeout
Enterprise build fails systematically because of timeout.
2018-08-13 14:00:18 +02:00
Nicolas Martinelli ea4502ceab [FIX] mass_mailing: bounced statistics
A mass mailing can be considered both as bounced and opened. This can
occur with some email providers, such as Gmail. Indeed, Gmail sends
out-of-office replies to the `Return-Path` address, which is also used
for bounced emails. Therefore, it is not possible to determine
accurately if a message sent to to the `Return-Path` is a genuine
bounced email, or an out-of-office reply.

However, if the recipient opens the email, it is possible to determine
that the bounce was counted incorrectly. In this case, we empty the
`bounced` field. Similarly, we only write on the `bounced` filed if the
`opened` field is empty. This could occur if the recipient opens the
email before the out-of-office reply is received.

As a bonus, we also make sure to avoid updating the status if no route
was found. No route means that the email was bounced, so no reason to
set it as opened.

opw-1869957
2018-08-13 13:57:13 +02:00
len-odoo b41baa3c92 [FIX] base: handle RedirectWarning exceptions during import
During an import, account_invoice.py's _onchange_partner_id can return a
RedirectWarning exception, which wasn't properly handled by the load method.
Since it is an Exception, it was expected to have a name field.
We add it as a property so that they can be treated uniformly.

opw 1866965
2018-08-13 13:53:12 +02:00
Arnold Moyaux e1ff6ce3d9 [FIX] purchase: cancel a PO undo the closest picking cancellation
Usecase to reproduce:
- Set a product buy and MTO
- Create a SO with it and cancel it
- All the pickings are cancel
- Cancel the PO
- The picking that generate the PO is set to confirm
The picking should remain in cancel state

It happens because the button_cancel method still
consider the canceled moves.

This commit only modify destination moves if they still
require an action from the user.
2018-08-13 13:51:54 +02:00
Nicolas Lempereur 9b609842e3 [FIX] l10n_in: invoice col length kept same
If there is less than 5 invoices lines, {5 - number of invoice line}
empty invoice line are added as padding.

But these line could have a different number of column than the content,
thus the style could differ slightly or more erroneously if there was
background color depending on column number such as on the boxed style
layout.

opw-1870625
closes #26317
2018-08-13 11:32:24 +02:00
Xavier ALT c5e1bffa3d [FIX] tools: formatLang should use cached lang 2018-08-13 11:18:00 +02:00
Odoo Translation Bot 75630e3d69 [I18N] Update translation terms from Transifex 2018-08-12 04:15:33 +02:00
Odoo Translation Bot 62a93c1ddb [I18N] Update translation terms from Transifex 2018-08-12 00:27:42 +02:00
Martin Trigaux b387a7e541 [FIX] base: rename languages to be more international
Chinese (China) is actually the Simplified version of Chinese
Chinese (Taiwan) is actually the traditionnal version
This will avoids confusions
2018-08-10 16:55:42 +02:00
Yannick Tivisse a06747c03d [FIX] base: Execute group config on modifications only
opw: 1872220

Purpose
=======

1/ Go on Settings -> Users, enable some groups for a specific user
2/ Go on any app -> Configuration -> Settings, modify a group

All the specific groups assigned to a user are erased.

Specification
=============

We should avoid to remove a user from a given group.

Create a new res_group with the default value, and only apply the
group modification if the group has actually been modified.
2018-08-10 16:22:00 +02:00
len-odoo 792520926a [FIX] sale: pass correct action when accessing quotation from email link
When accessing a quotation from an email link, no action is given.
As a result, after create/discard of a new record, the abandonRecord method does
not find a fallback page to go to, and it appears as if the discarded new record
had been created.

opw 1869350

11.0-opw1869350-action-len
2018-08-10 16:11:30 +02:00
Martin Trigaux cd3230c1d3 [FIX] delivery: translate delivery line
Fixes #26289
2018-08-10 15:27:16 +02:00
Gabriela Mogollon ebf29dfc2e [IMP] hr_payroll_account: Avoiding creating empty journal entries
Purpose
=======

Steps to reproduce
------------------

Install hr_payroll_account
Configure a salary rule
Create a payslip and confirm

Current behavior
----------------

A journal entry is created without items.

Expected behavior
-----------------

Create the journal entry with all items like it's created
When the payslip is computed (compute sheet button) and validated.

resolve https://github.com/odoo/odoo/issues/24796

Specification
=============

Now the super of ```action_payslip_done``` is called before the creation
of the journal entry. This means that the ```compute_sheet``` method is
called too before the filling of the account move.
2018-08-10 11:09:15 +02:00
Lucas Perais (lpe) da2140b726 [FIX] sale_timesheet: choose the project's company to determine cost
Companies:
B child of A

User:
Demo in B not in A
Admin in A

Create a product with Admin:
track service = timesheet on project
invoicing policy = delivered quantities

Create a SO with Demo and validate, a project is created
Now, make the demo user timzsheet on it

Before this commit, there was an access error on company,
that was because the the company that was choosen to determine the cost, was the one on the employee, which could be
in another company than the user and moreover than the project

After this commit, we take the company of the project

OPW 1871440
closes #26271
2018-08-10 09:45:06 +02:00
Lucas Perais (lpe) 21064c7de8 [FIX] hw_escpos: byte/string correction
OPW 1868196
2018-08-10 09:39:44 +02:00
Lucas Perais (lpe) abd2b2e2ca [FIX] account: reconcile through widget associate payment/invoice
Create an invoice, validate it

Create a payment from athe account.payment model (not the register payment wizard)

click on the smart button payment matching, and match the invoice with the payment
Reconcile

Before this commit, the invoice was not part of the invoice_ids field of the payment,
So, when printing the payment receipt or check, there was nothing on there

After this commit, we associate the invoice with the payment, and the receipt prints
what is expected

OPW 1871575

closes #26245
2018-08-10 09:35:26 +02:00
len-odoo 47c7d123da [FIX] web_editor: remove related videos at the end of youtube embeds
If a user embeds a youtube video on his website, he has no option to remove the
suggestion of related videos at the end of playback.
Since there is no good reason to have it, we disable the related videos in all
cases.

opw 1868380
2018-08-10 09:30:41 +02:00
Lucas Perais (lpe) 215754a7db [FIX] payment: display error on payment acquirer return
Before this commit, when authorize (for example) returned a business error
the error wasn't displayed to th ecustomer

After this commit, it is.

OPW 1866408

closes #26279
2018-08-10 09:27:09 +02:00
Goffin Simon bf282f2b7b [FIX] stock_landed_costs: List view in multi-company
In multi-company, it was not possible to distinguish the records
of the current company of the user.

opw:1870561
2018-08-09 16:01:31 +02:00
Nadal Francisco Garcia 4f4fdb2f35 [FIX] stock: fix unreserve
In the original commit 19116cc878, `action_assign` was called
on all `move_ids`. However, after API conversion, moves are filtered.

Closes #25886
opw-1868834
2018-08-09 15:19:15 +02:00
Nadal Francisco Garcia fac1d2dd2a [CLA] BT-nfrancisco added to Braintec 2018-08-09 15:19:15 +02:00
Goffin Simon a10ea93dbe [FIX] account: rounding problem with Payment Matching in multi-currency
Steps to reproduce:

- activate the multi-currency option in the Accounting App
- activate the EUR currency (USD being the base currency)
- create a EUR Bank Journal with an EUR account
- on 31/07 ==> rate = 1.1
- on 08/08 ==> rate = 1.2
- create a vendor bill for Asustek on 31/07 for 39794,40 EUR
- create a vendor bill for Asustek on 31/07 for 61668,00 EUR
- create a vendor bill for Asustek on 31/07 for 33487,70 EUR
- create a supplier payment for Asustek for 134950,1 EUR
- use the payment matching smart button
- match the 3 invoices you entered;

Bug:
Odoo says there is an open balance to write-off and prevents you from reconciling

Expected Behavior: the payment total amount in EUR matches the 3 vendor bills total
amount in EUR so I would expect Odoo to consider I have a perfect match between the
payment and the vendor bills and the difference in USD (base currency) should be
automatically reflected through an exchange difference entry.

if you follow the same operation with 3 invoices of 115EUR each and a payment of 345EUR,
it will work as expected.

opw:1872978
2018-08-09 13:43:38 +02:00
len-odoo 908ddbfeb7 [FIX] account_asset: do not show deactivated assets in the report view
When canceling invoices, Odoo deactivates related assets.
However these assets are not filtered in the pivot view, screwing the report.

opw 1864252
2018-08-09 13:17:16 +02:00
Nicolas Martinelli 1f42cf9f9c [FIX] sale, sale_timesheet: re-introduce default invoice policy
Related to f89d4201c7

Since the invoice policy is becoming more and more simple, it is
always nice to add as much logic as possible to make things even more
simple.

For the record, 5 fields are taken into account when it comes to
invoicing policy:
service_policy
service_type
service_tracking
invoice_policy
expense_policy

They are partially linked one with the other, and not all make sense for
a given product type...
2018-08-09 13:04:45 +02:00
Marco Calcagni ed19ad1568 [CLA] signature for As400it
Closes #26253
2018-08-09 11:38:24 +02:00
len-odoo f4ec8b95b7 [FIX] mail: only get one mail channel partner per user
When more than one mail.channel.partner have been linked to a given user, he may
be unable to open some discussion channel because of a traceback.
The issue is that we access a channel_partner field while the recordset is not a
singleton.
We limit the search to 1 to ensure that this recordset is a singleton.
2018-08-09 11:24:27 +02:00
Simon Lejeune 252bc396b4 [FIX] stock: button_validate: forced move lines
When a move line is not linked to a move, it'll be linked to the first
move of the same product at validation time. We slightly improve this
logic by linking it to the first non-completed move. To be completely
correct, we should split the move line if necessary and link it to all
needed moves, but at this time we don't  want to make the logic too
complex.

Use case: create a sale order with three sale order lines of the same
products, use the detailed operations view and add three move lines of
the same products, validate the picking. Before the patch, all move
lines were linked to the first move and thus only the first sale order
line had delivered quantities.

Fixes #25488
opw-1861765
2018-08-09 08:38:17 +02:00
Jigar A d92f17cebe [FIX] signup: allow non-admin to invite portal users 2018-08-08 23:44:40 +02:00
Christophe Simonis 325399ab44 [FIX] {sale_,}stock: revert 0ab71f1247
Esentially forward-porting a backport is not a good idea...
2018-08-08 19:38:19 +02:00
Christophe Simonis 4c2bdafe69 [MERGE] forward port branch saas-15 up to e7ccf38c48 2018-08-08 18:42:27 +02:00
Christophe Simonis e7ccf38c48 [MERGE] forward port branch saas-14 up to 42f87c73fd 2018-08-08 17:58:05 +02:00
Christophe Simonis 42f87c73fd [MERGE] forward port branch 10.0 up to 6ded4d9ce8 2018-08-08 17:26:04 +02:00