Commit Graph
109409 Commits
Author SHA1 Message Date
Christophe Simonis 5e6bb745e8 [MERGE] forward port branch 9.0 up to 4aea19d9e8 2018-03-06 11:56:50 +01:00
Christophe Simonis 4aea19d9e8 [FIX] sale_crm,crm: handle timezone in dashboard
Complete parent commit by correcting overwritten method.

Also use existing method to retrive date depending on tz in context.
2018-03-06 11:23:46 +01:00
Raphael Collet 36d6910269 [FIX] survey: constraint method on recordset 2018-03-06 11:23:29 +01:00
Nicolas Martinelli 037cfc9f67 [FIX] delivery: products not shared
- Define 2 companies A and B. Delivery methods are linked to products in
  company A
- Deactivate 'Share product to all companies'
- Create a user B in Company B only
- As user B, create a SO and open the drop-down list for delivery
  methods

An access error is raised.

Delivery methods should follow the same record rules than the products
they are linked to.

opw-1815490
2018-03-06 10:02:44 +01:00
Aaron Bohy b466b3bc60 [FIX] web: create favorite filters in dialogs
Consider the following scenario: open in edit mode a form view
containing a many2many field displayed with widget many2many_tags,
on the many2many field dropdown, click on 'Search More' (it opens
a dialog), and in the dialog, try to save the current search in
the searchview's favorite menu.

Before this rev., it tried to retrieve the context of the active
view in the closest instance of a ViewManager-like widget in the
SearchView's ancestors.

First, it is wrong as in the given scenario, the requested context
is actually the one of the list controller in the dialog, not the
one of the form controller in the background.

Second, it produces a crash in Studio, when trying to save filters
in the dialog opened by clicking on 'Search More' on the groups
many2many field in the sidebar.

This part of the code can't be tested in this version, but tests
will be added in master.

Fixes #23293
2018-03-06 09:06:45 +01:00
Lucas Perais (lpe) 31ad2aa31e [FIX] crm: avoid timezone date change to mess with dashboard stats
Have your OS be in Vancouver with time = 15:59:00
We are on day X
Have a next activity on a lead, scheduled for today
At 15:59:00 the next activity is not overdue

Before this commit:
Past 16:00:00 the next activity becomes overdue
This is because 16:00:00 is 00:00:00 in UTC (+8 hours)
And the next activity is scheduled for day X
But in UTC, we just passed at day X+1
Hence, the next activity being overdue

After this commit:
The next activity is not overdue, since we are actually on day X

OPW 1815323
2018-03-06 08:58:06 +01:00
Christophe Simonis 2534bd19fb [MERGE] forward port branch 9.0 up to 6deed451ee 2018-03-05 18:50:51 +01:00
qdp-odoo 6deed451ee [FIX] account: fix the runbot after commit 0e881fcd3a
The previous commit forbids to change the currency of a company having accounting entries, but there are some created by demo data and some tests were trying to set a different currency (to set up a fix environment). So in order to allow that in tests, we do it via a SQL query directly
2018-03-05 17:39:10 +01:00
Martin Trigaux 8b119e2ae9 [FIX] base: skip failed autovaccum
This patch prevents bugs fixed at 5d463d2 to block the database.
It was preventing the autovacuum to properly clean old records.
Failing to unlink (may have various different reasons) should not block the
autovacuum to try on other models

Closes #23455
2018-03-05 16:03:01 +01:00
Christophe Simonis 1bfe147f89 [MERGE] forward port branch 9.0 up to 0e881fcd3a 2018-03-05 15:00:56 +01:00
qdp-odoo 0e881fcd3a [FIX] account: forbid the change of currency_id if the accounting app has already been used 2018-03-05 14:50:22 +01:00
len-odoo e710e5df7a [FIX] web: show error when trying to export a report with more than 256 columns
If the user tried to generate a report with more than 256 columns,
he would get a traceback instead of an error message.
Furthermore, if only one measure was selected, then the check was not done
and the user would also get a traceback.

opw-1816931
2018-03-05 12:56:27 +01:00
Christophe Simonis 554afff3ac [MERGE] forward port branch 9.0 up to b8824913a7 2018-03-05 10:38:02 +01:00
Lucas Perais (lpe) 698dffcef0 [FIX] website_sale: avoid duplicated Thanks message
Configure a thanks message on a payment acquirer which has no automatic confirmation (none value)
(The wire Transfer will do)

Make a website sale with that acquirer

When arriving on the confirmation page on the website:

Before this commit:
The thanks message was duplicated: one at the top, just under "transaction is waiting a manual confirmation"
and one at the bottom, where the actual transaction status is displayed

After this commit:
The thanks message just appears at the bottom location

OPW 1787799
2018-03-05 09:06:56 +01:00
Odoo Translation Bot 3527bc004c [I18N] Update translation terms from Transifex 2018-03-04 00:58:51 +01:00
qsm-odoo 80f97fbd19 [FIX] website_slides: load viewer for app's iframes only
The website_slides JS was working on all iframe in all pages while it
should only affect its own ones, which contains a PDF document.
2018-03-02 18:13:22 +01:00
dduarte 99a3ba631e [CLA] PromptEquation / OdooGap signs CCLA
Closes #19223
2018-03-02 17:02:54 +01:00
Hilar Ak 9e36f966f1 [FIX] hr_recruitement: remove duplicated view mode
Closes #23129
2018-03-02 16:29:07 +01:00
Hilar Ak ff9801dc69 [CLA] hilarak signs the CLA
Done at #23129
2018-03-02 16:29:07 +01:00
qdp-odoo b8824913a7 [FIX] account: fix _amount_residual() dependencies.
The computation of residual amounts on account.move.line does not use account_id.currency_id... and should not. Never.
The previous implementation was thus stupidly recomputing the amount_residual fields on all journal entries of an account as soon as its currency field was touched, for nothing.
2018-03-02 14:45:15 +01:00
Josse Colpaert 3bd2bb7aa1 [FIX] stock: avoid block of schedulers
Avoid block of schedulers when there are confirmed moves of 0 quantity.

Co-authored-by: Nicolas Martinelli <nim@odoo.com>
opw-1817784
2018-03-02 13:07:21 +01:00
Jeremy Kersten 5ad278ac08 [FIX] web_editor: show 'open in new window' on link edit
Before this commit, when a user open an existing link in the editor
he cannot check/uncheck the option "Open in new Window" while he don't
update the url.

The field was hidden while keyup was not called.

After this commit, if the url contains a url, we show directly the checkbox.

This commit fixes opw-1819601
2018-03-02 11:56:07 +01:00
Christophe Simonis a6855b31c9 [MERGE] forward port branch 9.0 up to d4ec6b75ac 2018-03-01 13:25:10 +01:00
Swapnesh Shah 685f4eff50 [FIX] purchase: set date_approve on order confirmation
Restore behaviour before the workflow removal

Closes #23306
Fixes #23273
2018-03-01 11:55:42 +01:00
tbe-odoo d4ec6b75ac [FIX] yaml tests: Allow use of context inside context evaluation 2018-03-01 11:03:40 +01:00
Odoo Translation Bot fd032df4d1 [I18N] Update translation terms from Transifex 2018-03-01 02:39:27 +01:00
qsm-odoo b9d217c4f5 [FIX] website_form: button seemed buggy while it was actually disabled
Thank you to @Yajo
Closes https://github.com/odoo/odoo/pull/21628
2018-02-28 17:09:17 +01:00
Olivier Colson d1377650da [FIX] account: prevent the user from assigning to an account a tax belonging to another company than the one the account is linked to. 2018-02-28 15:27:48 +01:00
Christophe Simonis dae9b1a10e [FIX] account: correct move reversal
Oversight of previous forward-port
2018-02-28 13:56:11 +01:00
Christophe Simonis 0261d6d595 [MERGE] forward port branch 9.0 up to 239f4fec29 2018-02-28 13:41:04 +01:00
auyeung112002 b2c321fd1f [FIX] account: dummy_account_is should be readonly
Setting dummy_account_id to readonly avoid the journal entry items being wrongly set automatically.
2018-02-28 12:02:03 +01:00
Olivier Colson 239f4fec29 [FIX] account: When modifying the currency or company of a bank journal, also set it on the related res.partner.bank (if set)
See issue https://github.com/odoo/odoo/issues/22980
2018-02-28 11:39:05 +01:00
Goffin Simon 287516c1a9 [FIX] sale:Empty email sent to followers when confirming the quotation
Steps to reproduce the bug:

- Subscribe another person as follower to all kind of messages in your default sales team.
- Create a new quotation.
- Hit on Send by Email and send the email.

Bug:

A empty email was sent to the followers.

Fix:

Now only the email rendered in the wizard is sent to the followers.

opw:1816028
2018-02-28 10:57:48 +01:00
Lucas Perais (lpe) d396ed515c [FIX] website_sale_delivery: avoid double conversion to currency on delivery provider
Yourcompany is in currency USD
Go to the website and select the CAD pricelist
Have Fedex installed (then you'll have to set weight on the product you buy)
*Expected with DHL and generally any API driven delivery*

Make an online order to the USA but in CAD

Before this commit:
At the "Choose your delivery method" step
You'll see that the amount for Fedex that seems to be 'converted twice' into CAD
(And it is)

This is because there is a slight mismatch in how delivery compute their price
When the delivery is fixed, or based on a rule
Its price is always in terms of its company's currency
Whereas
in other delivery type, the price is computed in terms of ther order's currency

See the difference between the implementation of the  methods:
<get_price_available>
and
<provider_get_shipping_price_from_so>

OPW 1813466
2018-02-28 09:14:10 +01:00
Lucas Perais (lpe) b6d4cd5deb [FIX] account: reconcile on move reversal
Make an invoice for partner X
Make a payment from partner X (not using the register payment button)
On the invoice, you'll see your payment proposal

Now, reverse the move of the payment

Before this commit:
On the invoice you *still have* the payment proposal
This is because nothing reconciled the reversed entries with the original ones when they were created

After this commit:
The reversed moves are reconciled one on one with their original counterparts
And the original payment doesn't show up anymore on the invoice's proposal

OPW 1816462
OPW 1816641
2018-02-28 09:08:38 +01:00
Olivier Sarrat f620e78301 [FIX] doc: remove readonly as button possible attrs
According to #13264, setting a button as readonly is not working
Remove from the documentation

Closes #23114
2018-02-27 17:54:56 +01:00
Jairo Llopis 77db32edf2 [FIX] base: do not force creating localhost SMTP server
Do no recreate the record if it was removed for any reason

Closes #23285
2018-02-27 15:07:08 +01:00
apesquero 4b1ed44936 [CLA] signature for apesquero
Closes #23338
2018-02-27 14:54:35 +01:00
Nicolas Martinelli aff954bd63 [FIX] account: link bank to partner
Changes to a bank account should not be happening without approval and
not in an in-transparent way. In some cases, a third party can pay an
invoice for another account

opw-1817138
2018-02-27 11:31:09 +01:00
Alexis de Lattre 1f8835568b l10n_fr: chart of accounts: use bank account type only for accounts linked to bank journals (fixes bug #23040) 2018-02-26 17:22:41 +01:00
Patrick Tombez f435bc4fe9 [CLA] adds p-tombez to camptocamp's CLA
Closes #23329
2018-02-26 16:36:29 +01:00
Christophe Monniez 82e9cc7f97 [IMP] test_pylint: test the presence of python debuggers
From time to time, it happens that a developper forget to remove debuggers.
This commit adds a test to find such imports (pdb and pudb). The test
will fail if that kind of import is found. The Odoo runbot should run
this test and prevent developper from those small mistakes.
2018-02-26 16:12:54 +01:00
Adrian Torres 30db4cdd75 [FIX] stock: remove existing demo data on reinstall
Previous to this rev.:
    *Install stock w/ demo data
    *Uninstall stock
    *Reinstall stock

Result: Boom! Installation crashes.

Reason: The demo data installed with stock is not properly deleted after
the module is uninstalled, which causes issues/conflicts upon
reinstallation of the same demo data.

Solution: Remove any demo data of stock models upon installation if any
exist through a pre_init_hook, ideally this would be done by overriding
the unlink() of the affected models / setting some ondelete='cascade',
or even a uninstall_hook, however these solutions prove insufficient for
databases that are currently affected by the problem.

Fixes #22243
2018-02-26 15:12:25 +01:00
Odoo Translation Bot 3535904bce [I18N] Update translation terms from Transifex 2018-02-25 01:38:10 +01:00
qsm-odoo 216d73d727 [FIX] website_slides: fix slide loading (function call with wrong this)
Strangelly, this worked in 9.0 as the `this` element refers to the
`window` which also contains the `$` function. This may still be
wrong in some cases though, so it is fixed here (even if reported for
10.0).

opw-(1)817789
2018-02-23 13:37:00 +01:00
Akim Juillerat ab60d773eb [FIX] hr_timesheet_sheet: set default company on the company instead of department
Code is explicit enough ...

Closes #23120
2018-02-23 08:42:50 +01:00
Monica Diaz Pena 088d00f2a7 [FIX] mail: Don't duplicate uuid of mail channels.
If you duplicate a channel the UUID should not
be copied, otherwise it might introduce security
issues and the method 'channel_minimize' will
fail with an "expected singleton error".

Closes #23102
2018-02-23 08:42:43 +01:00
jem-odoo 7b29f410a5 [CLA] Add Monica to Merchise's CLA 2018-02-23 08:42:34 +01:00
Christophe Simonis f492c73080 [MERGE] forward port branch 9.0 up to cd21ea414e 2018-02-22 18:56:22 +01:00
Goffin Simon 5cdefcc39a [FIX] purchase: Adding PO on refund vendor bill
The function  _prepare_invoice_line_from_po_line has not been
designed to compute in a right the quantity for a  line in an
in_refund invoice. So it has no sens to display the field purchase_id
for a refund vendor bill.

Closes #23095

opw:816717
2018-02-22 11:21:13 +01:00