Commit Graph
137281 Commits
Author SHA1 Message Date
Laurent Smet 5bbd56aea4 [IMP] account: Remove test_control_journal_account dependency to AccountTestCommon
l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
- doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
- doesn't setup a testing user then all tests are done using the superuser.
- doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
- is run sometimes at-install.

--task: 2301180
2020-07-31 07:11:32 +00:00
DramixDwandqsm-odoo bdcc1ea9e7 [IMP] website_blog: add tag from frontend (editor left panel)
Previously, you could only add a tag on a blog post from the backend.
Here we're adding a way to add them from the left-panel so that it's
easier for the user to add them.

The long term goal will not be to reimplement complex view of the
backend. This is actually already past the limit: we will need a way
to instantiate views from the backend in the frontend in the future.

Part of https://github.com/odoo/odoo/pull/52759
task-2267693

closes odoo/odoo#52759

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-31 10:32:22 +00:00
DramixDwandqsm-odoo ea009585e1 [IMP] website_blog, *: add a way to search blog posts
*: website

As there was no way to search a blog post, it could be hard for someone
to find a particular post if there was a lot of blog post for example.

Part of https://github.com/odoo/odoo/pull/52759
task-2267693

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-31 07:40:31 +00:00
Victor FeyensandSteve Van Essche 8acfc6b965 [FIX] stock_picking_batch: wrong sanity check on picking creation.
1) Wrong use of self.batch_id in an api.model method.
2) Fix demo datas which didn't pass the sanity check (after the fix)

Avoid to put draft picking into non-draft batch picking and use batch's
actions instead of picking's actions for confirmation and reservation.

closes odoo/odoo#55254

X-original-commit: 9e9f50169ba4d4698ce64b0865db4cc6b4833b0e
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Steve Van Essche <svs@odoo.com>
2020-07-31 10:13:08 +00:00
Sébastien Theys 78bef3e08c [FIX] mail: improve performance of JS write, especially for x2m
- store `x2many` values as `Set`. This is conceptually more correct because
  duplicates were already not allowed, and using a `Set` allows for much faster
  operations such as checking the presence of a record in the relation, which is
  done at every write, for every linked record.

- `stringify` in `write` was slow and unnecessary because we can always assume
  that new non-primitive should be provided to `write`

- remove field values from store, in favor of just storing a counter, which is
  enough to trigger renders. This allows to get rid of one Proxy level around
  data, which was slower, but which also prevented from using `Set`.

- write in store exactly once per update cycle, to trigger one `useStore` call
  on each component. Records keep `__state` but as a local counter, to let
  `useStore` know which records have been updated (easier to compare a counter
  than comparing each and every field value).

Results
=======

The worse case test (using a lot of x2m) that was used to benchmark this PR
`form_renderer_tests.js` of `mail_enterprise` went from taking around 4s before
this commit, to around 2.5s after this commit.
And the worse `_setRelationLinkMany2Many` previously took around 250ms, and it
now takes around 50ms.

The whole `mail` QUnit suite took around 55s before, now around 42s.

Part of task-2308312

closes odoo/odoo#55248

X-original-commit: 4db0a10d85534ef896f6bcbf13bca4983a6e2003
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-31 09:43:01 +00:00
svs-odoo 89bf21ba79 [FIX] web: line break into tooltip
The commit e69c72f93b removed the line
breaks into tooltip help text.
This commit re-add them for the sake of readability.

closes odoo/odoo#55233

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-07-30 14:13:06 +00:00
Julien Castiaux f1215389e8 [FIX] mail: prevent international char in alias
Create a mail alias with non-ascii characters like 'foß', send an
email from your personal email account to that alias. The delivery fails
because Odoo SA servers don't support the SMTPUTF8 extension which is
required to parse the local-part ("display" <local-part@domain>) part of
a From header.

While external providers may create international, very weird, emails
and we should support receiving/sending emails from/to them. Our policy
is to only create very basic email addresses. That is all ASCII,
letters, digits and a limited set of punctuation characters.

Restricting what aliases can be created, we ensure no advanced extension
should be enabled on SMTP servers.

opw-2293336
Closes #53403

closes odoo/odoo#55166

X-original-commit: 4db3f21f52fa774ec651fc0b6eaa9a8652b2ae4c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
2020-07-29 23:44:47 +00:00
Mathieu Duckerts-AntoineandJulien Mougenot dc8973fd6e [FIX] web: default operators for search fields
During the refactoring of the control panel (https://github.com/odoo/odoo/pull/41268)
a regression concerning the operator used for the fields set as
search_default was introduced: the default operator was fixed to '='
while it would have been necessary to take into consideration the
optional 'operator' attribute or the field types. Moreover, the default
operator associated to many2one fields when using autocompletion was
also mistakenly set to 'ilike' instead of '='. The present commit
restores the previous behavior.

closes odoo/odoo#55099

X-original-commit: 1f8e93fc590a6c7ef6b93953058f2dcd643ac620
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
2020-07-31 08:04:57 +00:00
Fabien Pinckaers 9dd2c7fdc8 [FIX] calendar: don't crash if vobject is not installed
closes odoo/odoo#55236

Signed-off-by: Fabien Pinckaers <fpodoo@users.noreply.github.com>
2020-07-31 07:25:27 +00:00
Nicolas Martinelli 7eaf4f3e36 [FIX] point_of_sale: access error at closing
- Set the following access rights to a user A:
  Point of Sale: User
  Invoicing: Billing
  Inventory: User
- Create a product P, FIFO + Automated
- Add some stock for P
- As user A, open the POS
- Sell one unit of P
- Close the POS and validate entries

An access error is raised because the user doesn't have the right to
read the `stock.valuation.layer` object.

We can retreive the value as `sudo` in this case.

opw-2305446

closes odoo/odoo#55224

X-original-commit: d3147910e031253ddb172959e9016a0f326d7cdb
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 15:56:11 +00:00
Andrea Grazioso (agr-odoo) 6fd1855f37 [FIX] hr_recruitment: allow users to create applications
After 9ddfc18b41
an user with recruitment/officer (user) permission on hr_recruitment
could not create applications anymore because doing so imply a write to
hr.recruitment.stage

opw-2305646

closes odoo/odoo#55222

X-original-commit: b8359c55e6e57035ffa3b10bfa5294e22a74e837
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 15:43:33 +00:00
jvm-odoo 876b77af2c [FIX] board: fix graphs height
Issue

	- Install Projects, Dashboard
	- Project > All tasks > Graph view
	- Add to dashboard
	- Refresh & go to dashboard

	The graph is small and it's
	hard to read it

Cause

	We have no min-height & chartJS computes
	a height which is too small

	Already fixed in previous versions with
	9214d78152 but now the class `o_graph_svg_container`
	seems to be used nowhere

Solution

	Change the class name & adjust height a bit

OPW-2303224

closes odoo/odoo#55218

X-original-commit: 80a46b9249bd6dada4d462cd7a11a406eb1ceba5
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
2020-07-30 15:20:06 +00:00
Xavier Dubuc 0511a88f85 [FIX] im_livechat: fix visitors typing issues
In livechat, chat_post was called without notifying user has stopped
typing as done in new way of handling it in new mail module. This commit
handles the legacy by calling notify_typing rpc as needed.

task-2282271
task-2299331

closes odoo/odoo#55223

X-original-commit: 030ea9adf74f3f4c0d61b19870d6894de1f20c75
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-30 15:49:27 +00:00
Thibault Delavallée e3ab7d9b6b [REF] website_event_track: set color back on track
Partial revert of bd61b6cd38

closes odoo/odoo#55213

Related: odoo/upgrade#1535
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-07-30 14:53:04 +00:00
Florent de Labarre b6fc5ef468 [FIX] hr_expense: Team Approver have acces to all accounting
1. Apply same logic for sale and purchase user.
2. The group Expense Team Approuver can write/create/unlink,
it is opposite than https://github.com/odoo/odoo/blob/13.0/addons/hr_expense/security/ir.model.access.csv#L15
and https://github.com/odoo/odoo/blob/13.0/addons/hr_expense/security/ir.model.access.csv#L16

opw:2275116

closes odoo/odoo#53405

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-06-22 11:23:34 +00:00
Sébastien Theys af490aa25d [FIX] web: speed up tests by parsing OWL templates only once
closes odoo/odoo#55206

X-original-commit: 9b08be34ac6ffda091a36ebc72fd05374a9d661c
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-30 13:58:05 +00:00
Thanh Dodeur a258874132 [FIX] website: prevent flickering on image reorder in the image wall
Before this commit, reordering the images in the image wall was
causing a flicker of the snippet options.

It was caused by a forced deselection of the snippet (image) that is
not necessary since 17e7e754cd

task-2307083

closes odoo/odoo#55090

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-30 07:07:07 +00:00
Rémy Voet (ryv) e7fd2ba5c8 [FIX] mrp_subcontracting: fix flow with tracked component
After the odoo/odoo#52949 , the registering of tracked component,
in case of subcontracting, was broken. Fix and try to mimic
the same flow than before. The produce wizard has been replaced
by a clean MO form to register component and use backorder mechanisme
of MO to manage tracked finished product + tracked component.

task-2278147

closes odoo/odoo#54994

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-07-30 12:09:10 +00:00
Benjamin Vray 2458098f60 [IMP] website: ease google font selection
Before this commit users needs to link an embed code provided by
Google. But it became less obvious to find this code so we now ask for
the link of the font page. But we still keep the possibility to link
an embed code if ever a user is wrong.

task-2304075

closes odoo/odoo#54816

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-23 09:12:12 +00:00
stefanorigano (SRI) 167e70347b [IMP] website, website_form: add position options ui icons
Part of https://github.com/odoo/odoo/pull/54913
task-2157252

closes odoo/odoo#54913

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) 58927d6fc3 [IMP] website: add s_rating size option's icons
Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) 3906bd33e8 [IMP] website: review options UI for media list
Reword custom controls for image position and content vertical
alignment. Use different icons set according to the selected image
position.

Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) fd743b104a [IMP] website: use icons for vertical alignment option
Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) e847acc8ed [IMP] website: replace dropdown of shadow options with icons toolbar
Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) 3d2c591215 [IMP] website: replace icons for content-width option
Also reorder options from small to large.

Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) 5c09a1c77c [IMP] website: replace icons with text for height option
Part of https://github.com/odoo/odoo/pull/54913
task-2157252
2020-07-30 11:12:03 +00:00
stefanorigano (SRI)andqsm-odoo a1c9044ff7 [IMP] web_editor: render inline svg icons, apply css style
Render inline SVG inside buttons in order to allow CSS styling.

Define SVG icons design for normal/hover status applying the same colors
as default text buttons.

In order to support multi-colors SVGs, this commits will affect inner
shapes in different ways:
- '.o_graphic' shapes: will gets the UI btns colors (default/hover)
- '.o_subdle' shapes: will gets a slightly reduced default text color

Shapes without '.o_graphic/.o_subdle' classes will be rendered normally,
as defined in the svg code.

Part of https://github.com/odoo/odoo/pull/54913
task-2157252

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-30 11:12:03 +00:00
stefanorigano (SRI) 26e146644b [IMP] website, *: review snippet names
*: website_event, website_form, website_sale

Part of https://github.com/odoo/odoo/pull/55089
task-2157252

closes odoo/odoo#55089

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-30 10:19:06 +00:00
stefanorigano (SRI) b7fe2bdae2 [IMP] website, *: review snippets thumbs
*: website_blog, website_event, website_form, website_mail_channel,
   website_mass_mailing, website_sale, website_twitter

Part of https://github.com/odoo/odoo/pull/55089
task-2157252
2020-07-30 10:13:07 +00:00
stefanorigano (SRI)andqsm-odoo c0a11148e0 [IMP] web_editor: review snippets thumbs design
Part of https://github.com/odoo/odoo/pull/55089
task-2157252

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-30 10:12:58 +00:00
Victor Feyens cc665d51e8 [FIX] sale,purchase: do not enforce company at _prepare_* level.
By specifying the with_company at a higher level:
1) The risk of multi-company conflicts decreases
2) We allow customizations to use _prepare_* methods to potentially
create records in other companies when needed.

closes odoo/odoo#55192

X-original-commit: 33c767e1778d2b1fc83aaaea92c3c2aa008b9520
Related: odoo/enterprise#12105
Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-07-30 10:20:31 +00:00
Xavier Dubuc e244bfa1c8 [FIX] mail: do not fetch 'user_notification' messages in thread
task-2296856
See odoo/enterprise#12095

closes odoo/odoo#55189

X-original-commit: 5aaff1547d04bccf20ef333f515811570e8b8e22
Related: odoo/enterprise#12100
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-30 09:23:02 +00:00
Nicolas Martinelli dcf1f48ee6 [FIX] account: prevent unlink item linked to posted entry
- Create a vendor bill, post it
- Go to Accounting > Accounting > Journals > Purchases
- Select the items linked to the vendor bill, delete

Nothing prevents from deleting the items while a posted entry cannot be
modified.

opw-2305873

closes odoo/odoo#55187

X-original-commit: 14ef02f73e649b5f8c50f09213f0a0dbddf46217
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 08:49:10 +00:00
Nicolas (vin) 8b7861ddab [IMP] account: Clean various feedbacks reported by consultants
Clean various feedbacks reported by consultants WTA/CTH.

It concerns namely :
- CoA
- DEMO DATA
- SEQUENCE NUMBER ON JOURNALS
- PAYMENT STATUS
- BANK STATEMENTS

Task ID: #2300936

closes odoo/odoo#54874

Related: odoo/enterprise#11995
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-07-30 08:58:54 +00:00
Laurent Smet 2a751921c1 [REF] account: Refactor '_prepare_counterpart_move_line_vals'
closes odoo/odoo#55186

X-original-commit: 0ebe2034cbd55c4384dfc7f253d66958623847d7
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-07-30 08:48:38 +00:00
Laurent Smet 6c9b5d6f6f [FIX] account: Fix creation of statement with zero amount/amount_currency
During the migration, it could happen some statement lines are created with a zero amount in company currency or foreign currency.
It this specific case, we can't retrieve the correct amounts by multiplying the statement line conversion rate because X * 0 is always zero.
This commit ensures the amounts are well preserved in such case.

X-original-commit: a75bc7fdf014daf965cad72917ac475cbf83f6ac
2020-07-30 08:48:37 +00:00
Laurent Smet 17a8a6d933 [FIX] account: Fix missing 'currency_id' on statement lines with amount_currency=0.0
The `currency_id` must be set whatever the amount_currency is zero or not.

X-original-commit: 88065aef326dcbe0fb821da8d9aa6cc0316615c7
2020-07-30 08:48:37 +00:00
Laurent Smet 78aae94838 [FIX] account: Fix float division by zero when statement amount is zero
This should never happen for someone starting Odoo after saas-13.4 but is happening during migrations.

X-original-commit: b43849032766b95f07d3ac73fc67e4c03138c3b5
2020-07-30 08:48:37 +00:00
Laurent Smet 920a5f1df1 [FIX] account: Fix typo in field declaration: 'require' instead of 'required'
Note: Since this field must not be required, this attribute can be removed.
X-original-commit: f88e37e912b3c60349ad8cba92ec8bfd2a95e2bd
2020-07-30 08:48:35 +00:00
Nasreddin (bon) 54a429af58 [FIX] point_of_sale: Receipt footer breaklines escaped
Issue

	- Install "Point of Sale" module
	- Edit POS (e.g.: Shop) settings
	- Enable "Header & Footer" feature
	- Add a footer with multiple breaklines and save
	- Start a session with the current POS
	- Make an order

	Receipt footer not well formated

Solution

	Add 'white-space:pre-line' style to avoid escaping breaklines;
	inspired on text-field css class.

opw-2300889

closes odoo/odoo#55182

X-original-commit: 85de8418ae9b152fc0f4c300b71249440f381224
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 07:56:53 +00:00
Goffin Simon 2800c89014 [FIX] l10n_se: Fiscal position not loaded
Steps to reproduce the bug:

- Create a new company C with country = Sweden
- Install app l10n_se
- Go to Accounting/Configuration/Setting/Fiscal Localization Package, select Swedish Chart of Account and then save

Bug:

The sweddish fiscal positions were not loaded.

opw:2302926

closes odoo/odoo#55170

X-original-commit: bd0c2ee6501c87789278377f7725e3c611955edc
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-07-29 15:54:08 +00:00
Nicolas Martinelli 5eea4c014a [FIX] account, stock_account: clean anglo-saxon lines
- Configure a Product Category Automated + FIFO
- Create a product in this category
- Create a PO for 10 units, receive the units, bill the PO and pay
- Sell 1 unit of the product and deliver it
- Create an invoice for the order
- Without paying the invoice, create a credit note with the option
  'Full refund and draft invoice'
- Post new invoice

The anglo-saxon lines are counted twice.

This happens because the lines already exist in the newly created draft
invoice.

For the sake of simplicity of the fix, we clean-up the invoice after
creation.

opw-2300536

closes odoo/odoo#55158

X-original-commit: 02d857b8aa75962f535ab4cd69ff8e2a6ef3fb48
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-29 15:20:02 +00:00
Anh Thao Pham (pta) 7d010ee8a5 [FIX] repair: use Customer Payment Terms in repair invoice
- Install Contacts and Repairs
- Go to Contacts and configure Payment Terms of Contact X (i.e. 2 Months)
- Go to Repairs and create a Repair Order:
  * Select Contact X as Customer
  * Select "Before Repair" as Invoice Method
  * Add Parts or Operations
- Confirm Repair and Create invoice
The Payment Terms of the created invoice is the default one and not the Payment Terms of Customer.

opw-2304818

closes odoo/odoo#55152

X-original-commit: 351718d5f579fca4945538c78e63aa50118af2b4
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-29 14:30:21 +00:00
Swapnesh Shah 99c02a83a5 [IMP] stock: display validation properly
Before this commit, This validation message was not displayed properly. (See https://nimb.ws/zYBLvh )

Now we are displaying validation error Properly.

closes odoo/odoo#51209

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-05-13 18:23:51 +00:00
qsm-odooandThanh Dodeur a777da6cd3 [IMP] website: make GMap on contact us page a customize show option
Part of https://github.com/odoo/odoo/pull/49101
task-2091396

closes odoo/odoo#49101

Related: odoo/upgrade#1524
Related: odoo/design-themes#231
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Thanh Dodeur <39259739+ThanhDodeurOdoo@users.noreply.github.com>
2020-07-28 07:45:40 +00:00
Thanh Dodeur d98ee926d6 [IMP] website: allow to change GMap API key from left panel
Part of https://github.com/odoo/odoo/pull/49101
task-2091396
2020-07-28 07:45:40 +00:00
qsm-odoo 430b5b669f [IMP] website, *: move all google map options to left panel
*: web_editor

-> Introduce the we-gpspicker widget and improve the way the gmap lib
    is loaded (for Odoo / multiple snippets / ...).

Part of https://github.com/odoo/odoo/pull/49101
task-2091396
2020-07-28 07:45:40 +00:00
Thanh Dodeurandqsm-odoo 59d46b51b1 [MOV] website: move google map snippet from themes to community
Improve the base code and adapt to new website features as well.

Part of https://github.com/odoo/odoo/pull/49101
task-2091396

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-28 07:45:40 +00:00
Xavier Morel 37a7aed189 [IMP] core: allow both action & children on root node
Reported by VFE, odoo/odoo#54564 missed one of the use cases in menus:
normally a menu can have *either* sub-menus or an action (aka only
"leaf" menu items can have actions), however there's an exception for
root (application) menus: those can have an action, which is used as
the application's action, that is, what gets executed when opening the
application itself.

* root menus were already special cased (to allow a ``web_icon``),
  expand this to allow both action and submenus
* modify the alternatives -- submenu-items and menuitems with a parent
  -- so they keep the behavior of allowing *either* an action or
  children

closes odoo/odoo#55144

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-07-30 05:37:05 +00:00
Alexandre Kühn a647497b51 [FIX] im_livechat: missing env/owl dependencies in external lib
closes odoo/odoo#55173

X-original-commit: b24b0e29fe537baed6919f26a4b63e7f3ad37e66
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-29 16:42:27 +00:00