pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] account: Fix float division by zero when statement amount is zero

Browse Source 
This should never happen for someone starting Odoo after saas-13.4 but is happening during migrations.

X-original-commit: b43849032766b95f07d3ac73fc67e4c03138c3b5
This commit is contained in:
Laurent Smet
2020-07-30 08:48:37 +00:00
parent 920a5f1df1
commit 78aae94838
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/account/models/account_bank_statement.py
+4 -3
View File
@@ -627,7 +627,7 @@ class AccountBankStatementLine(models.Model):
journal = statement.journal_id
company_currency = journal.company_id.currency_id
journal_currency = journal.currency_id if journal.currency_id != company_currency else False
statement_line_rate = self.amount_currency / (self.amount or 1.0)
statement_line_rate = (self.amount_currency / self.amount) if self.amount else 0.0
balance_to_reconcile = counterpart_vals.pop('balance', None)
amount_residual = -counterpart_vals.pop('amount_residual', move_line.amount_residual if move_line else 0.0) \
@@ -657,7 +657,8 @@ class AccountBankStatementLine(models.Model):
# use the foreign currency set on the statement line.
amount_currency = amount_residual_currency
balance = journal_currency._convert(amount_currency / statement_line_rate, company_currency, journal.company_id, self.date)
balance_journal_currency = (amount_currency / statement_line_rate) if statement_line_rate else 0.0
balance = journal_currency._convert(balance_journal_currency, company_currency, journal.company_id, self.date)
elif currency_id == journal_currency.id and self.foreign_currency_id == company_currency:
@@ -699,7 +700,7 @@ class AccountBankStatementLine(models.Model):
if currency_id == self.foreign_currency_id.id:
amount_currency = amount_residual_currency
balance = amount_currency / statement_line_rate
balance = amount_currency / statement_line_rate if statement_line_rate else 0.0
else:
balance = amount_residual
amount_currency = balance * statement_line_rate