Before this commit, the corrected test crashed when the current
date was before the arbitrary dates of the test
because the wrong exchange rate was taken
After this commit, the test passes
closesodoo/odoo#42671
X-original-commit: 5867e9bf0cc745d7b1b3dcf76bc94567e859cff7
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Issue
- Install Employee
- Settings > Enable skills management
- Go on employee form view
- In languages, click on add
- Quick create a skill & save
- Save the form
ValidationError "The skill %s and skill type %s doesn't match"
Cause
You should not quick create a skill, you should edit the skill
type, add your skill and then select it.
Solution
Disabling skill quick create because it's misleading
OPW-2163059
closesodoo/odoo#42642
X-original-commit: 29a37ef574726cf7616ed6237e56626ba3c380a5
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Steps to reproduce:
-install accounting
-go to accounting > accounting > assets
-create a deprecable asset (account moves for deprecations
are set automatically)
-change your user's language to blank
-try to post one of the automatically created deprecations line
Previous behavior:
you get a traceback error
"TypeError: strftime() argument 1 must be str, not bool"
Current behavior:
you get the intended error message
opw-2162318
closesodoo/odoo#42641
X-original-commit: 6cd38a64893428db5c2b30e85b09a34b90aa8f4f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Steps to reproduce:
-install base_automation and contacts
-go to settings > technical > automated actions
-create an automated action on new contact creation
-set your action to "create next activity"
-leave the activity due type to blank
-trigger the automated action by creating a new contact
Previous behavior:
you get a traceback error
"TypeError: __init__() keywords must be strings"
Current behavior:
the field is required when activity_date_deadline_range is not 0
and does not allow a blank type
opw-2159755
closesodoo/odoo#42503
X-original-commit: 04dff5ad6c5935f899c7946cb1924afaea9e547c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Method was added at cf505c3 but not used, missing cleanup according to
xdo-odoo
closesodoo/odoo#42443
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The orderby specification is a string, not a list
Using a list as a orderby clause produces an error in the construction
of the group by query
closesodoo/odoo#42451
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
This commit fixes 9ac5f42cd0c381bdddfd196721983057bab7028b by correctly calling the probabilities
computation method. It was a backport of a master fix and methods names are
slightly different.
closesodoo/odoo#42643
X-original-commit: 2e41f129ee39786c8259af792635e3b0f3dbfa3d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Of the rename conversation dialog
closesodoo/odoo#42630
X-original-commit: f9479456c0924c12c098edaebc2013418c09590c
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
For performance reasons, the company_id of a lunch supplier is now
stored.
In a multi-company environment, the multi-company ir.rule was loading
*all* the suppliers in order to check their related company_id.
closesodoo/odoo#42631
Taskid: 2152319
X-original-commit: 0a73eeb0d3163c2c47fb2d25da024ed4a16824ff
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This method makes a write on res.company but many people do not have
access to the company
closesodoo/odoo#42644
X-original-commit: 130f08f13b49a529c1da0e1dc603c62337842f45
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
When subcontracting a product via a purchase order and not a simple
receipt. Then the cancelation of the receipt will not only cancel
the receipt of the finished product but not the delivery for the
components.
It happens because button_cancel on purchase order will call
_action_cancel the stock.move linked to purchase order line. It will
not call action_cancel on the stock.picking. However the part
responsible for the cancelation of components delivery is in the
stock.picking action_cancel method.
Move the stock.picking action_cancel logic in the stock.move
_action_cancel method since it's always call for both usecase.
Fixes#42551closesodoo/odoo#42653
X-original-commit: 841305f271411c3a67af271ac09da9ce0922f100
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
When the ecommerce module is installed, the partner field's context is overwritten, which causes some features to be lost, e.g. showing the customer address.
This commit fixes the above by merging the content of both contexts.
closesodoo/odoo#42650
X-original-commit: a7027a184f6e76d3580844c29f1b8639b847356d
Signed-off-by: Luis González [Vauxoo] <luisg123v@users.noreply.github.com>
Steps to reproduce:
1. Open 'Project' on mobile
2. You can scroll x while the content fit the screen.
This issue occured because of negative margins on
'o_kanban_manage_toggle_button' class.
In general, using negative margins should be avoided.
So in this commit we simply avoid to have negative margins by
removing unwanted borders. It keeps the same design.
Similar issue:
https://github.com/odoo/enterprise/commit/805ab4d4a329c0fdf7d1cade6c5d7e8428f3a634closesodoo/odoo#42518
X-original-commit: 38702215e6dff4e562a389ec03cdeb8683cd111c
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
When an invoice is duplicated, the `invoice_date` is not carried over.
If the field is not set, it will be set at posting at the current date.
closesodoo/odoo#42622
X-original-commit: 135d3db7b9b222be198e91235657bbef77d2f69b
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
missing bit from rev[0] and [1]
[0] 7ef11e3
[1] d6c8c34ef6539dad110f1e502eaee2c03d968797
closesodoo/odoo#42621
X-original-commit: 5096e724643ca77568ce2f09a40b138561f4c20f
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Before commit:
-when we search in product move with reference its not working because
the Reference filter is made based on picking_id in place of reference
field.
After commit:
-we made a reference filter based on reference field so when we search in
product move with reference its working.
closesodoo/odoo#42620
Task-id: 2165919
X-original-commit: 7f1141687d4cede2a600f49441ac2ecd0f123c89
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Before this commit, when the domain alias was set (e.g. my_domain.com),
the reply-to and the reply-path were filled with default values using
this domain (e.g. reply-to : catchall@my_domain.com and reply-path:
Return-Path: bounce+number@my_domain.com)
Now, both are filled with the sender email.
Fine-tuning of 66c5053
opw-2127407
opw-2161942
closesodoo/odoo#42619
X-original-commit: 417d69c6ec45310ae22d40adfa70080188a1b1f5
Signed-off-by: Josse Colpaert <jco@openerp.com>
In this commit we use the float_time widget on total_time field in order to
achieve an amazing wow onboarding back2basics effect.
closesodoo/odoo#42360
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
'Template Preview' action shouldn't be accessible through the action dropdown
as it is linked to a given template and accessible directly from the
template form view. Having it available in dropdown makes no sense.
closesodoo/odoo#42353
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Now we can translate name and description field in lunch.product object
and we want that translation in kanban view of 'lunch.product.report'.
So we set related field in 'lunch.product.report' and remove those fields
from init().
Due to related field it will affect on performace of lunch.product.report
kanban view loading.
Task-2068989
closesodoo/odoo#41206
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this commit, only the tracked page can start the chat request at visitor
side. Which is a bit sad as the operator can send the visitor a chat request
but if the visitor goes on a non tracked page but has the opportunity to start
a livechat, the chat request won't reach the visitor.
This commit refactor the way a chat request is sent to the client side.
Instead of looking for a opened chat request on every page request,
the chat request information (if any opened) is added to the channel info
that are given to the Livechat button widget.
If the widget receives chat request infos, the widget set himself, before
starting, the cookie of the livechat session using the chat request
informations. Then, the conversation (from chat request) is automatically
loaded as any other opened chat session.
Task ID: 2081550
PR #40274
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Previously there was no way to view when a survey (specifically a
certification survey) was being used by a course from the survey
app. We handle 2 cases for when a survey is currently assigned to
a course:
1. A survey is assigned to 1 course => survey form stat button visible to bring user
directly to corresponding course form.
2. A survey is assigned to more than 1 course (unlikely, but currently possible) =>
survey form stat button visible to show user a list of corresponding courses where
each list entry can be clicked on to view corresponding course form.
Note: we do not cover viewing courses a survey was previously assigned to as this would
be currently be unreasonable to track.
closesodoo/odoo#42336
Task: 2153743
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of the task is, in mobile view when you click on my profile button it
open profile in back ground and menu(burger menu) will stay open.
so close the burger menu in mobile when clicks on my Profile or Preferences.
Task: 2152160
Closes: #41899
Enterprise PR: https://github.com/odoo/enterprise/pull/7275
Related: odoo/enterprise#7275
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose of the task is to improve the mobile user experience of
the Expenses app by adding the upload button to the Expenses
kanban view.
Task ID: 2152155
closes odoo/odoo#41839
Closes: #41839
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently if slides officers or managers define documentation courses as
on payment there is no easy way for customers to buy it.
In this commit we add a button on the frontend to allow the end user to buy
a documentation course like a training course. This button is displayed
only for on payment documentation courses, leaving other documentation courses
displayed untouched.
Task ID : 2125086
PR : odoo/odoo#40679
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of this commit is to
* extract buy now button in its own template to ease its improvements
and re-use;
* rename some templates to improve "Customize" menu entries;
Task ID : 2125086
PR : odoo/odoo#40679
When creating a customer on a repair order form view, it isn't considered
as one. An adapted context key is needed to make sure the new res.partner
is correctly saved as "customer".
Fixes#42449closesodoo/odoo#42601
X-original-commit: 534ef6a87c3a9e8b0cf23a4cd8a487a0a66715c0
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
This reverts commit 404fa816403b60c0d6e36bef6f2c73f020ea5ff3.
The commit acts on some special case. But it seem to break some case
when there is a t-ignore or other directive at that same element.
Reverting because a good solution would need to take
into account t-attr-class and this might not be possible easily.
opw-2122947
closesodoo/odoo#42599
X-original-commit: da62f7e65bd1df67138fe9a82000f800dc0ff84c
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Fine-tunning of 42eec88e5da164e4930c48113109f2c8d4b73da3
Before this commit, the assets were not found when the user is connected
in mode debug assets in a multi-website and multi-company. This occurs
because the attachments (assets) were created only for the first website
accessed, and cannot be loaded when trying to access the second website.
Now, the attachments are created for each website accessed and can be
loaded withtout problems.
closesodoo/odoo#42593
X-original-commit: 95077a8cdd9f2cd99c2ef85bdf7ca5d58e006b71
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Commit d86c2c5883 removed the multi-company partner rule because it
interfered with the users rule. Indeed, interference between the user's
default company and its corresponding partner's company made it possible
to have users that were basically unselectable in relational fields if
you were not viewing more than one company at the same time.
However, this generates a lot of frustrations and tickets for Odoo
users, since having everything shared by default is annoying and a clear
departure from the expected behaviour.
This commit tries to mitigates this fix's side-effects by re-introducing
the multi-company rules but by not applying it to partners who are linked
to a non-share user (basically, any partner who has a user that is not
a portal user). That way, customers and vendors remain filtered by the
multi-company rules and only partners of internal users bypass the rule.
This is still a side-effect, and might raise a few eyebrows (why is this
partner visible even though it is in another company?), but the
trade-off seems to be worth it since it fixes the original issue with a
far smaller behaviour change.
Fixes#41720.
closesodoo/odoo#42592
X-original-commit: 2390ba60b8bd624daaea2e6d4e3fd85ef1b1faeb
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Steps to reproduce:
-install sales
-try to import a product file with volumes set to scientific notation
(9.2e-05 for example)
Previous behavior:
scientific notation is not recognized by the base_import module
and raises a small warning
Current behavior:
scientific notation is converted to decimal notation on the fly
when possible
opw-2162353
closesodoo/odoo#42591
X-original-commit: 9acd76c5d116abd07207af3b548658ad983ff82d
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Activate multicurrency. The default currency for the company should be
USD. Make an invoice in EUR, with taxes, save and create the invoice.
The tax section will display the correct tax amount but the displayed
amount on which the tax should be applied is wrong: it's displayed the
amount in the company currency rather than the invoice currency.
Adding a _convert step to restore the correct currency since that
information does not appear to be saved in the database
opw-2161039
closesodoo/odoo#42494
X-original-commit: f9a8015ef8231a23cf8e5552c08248cfc95e977c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, when "Send message" composer was open with some
suggested recipients, and then editing and saving data related to
the suggested recipients, the suggested recipients were not updated
on composer until some user interactions like page reload.
Steps to reproduce:
- Open an opportunity in CRM;
- Open "Send message" composer;
- Change "Email" field;
- Save changes;
> Suggested recipient above composer textarea is not updated with
newly saved email adress.
It becomes updated only after some user interactions, such as toggle
"Log note" then "Send message" or with a page reload.
This commit fixes the issue by updating the suggested recipients on
the composer in real-time when clicking on "Save".
Task-Id 2089816
closesodoo/odoo#40033
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
Co-authored-by: Alexandre Kühn <aku@odoo.com>
_get_unavailability_intervals didn't return the correct
dict (describe in the docstring). Then the override in
maintenance module was wrong.
task-2082261
closesodoo/odoo#42530
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Changing the background color was not working
because 'o_mail_snippet_general' having a background color white.
while bg-* colors are applied on a parent of 'o_mail_snippet_general'
closesodoo/odoo#42513
X-original-commit: 751dd4c16f8e6c9e373bd9be3a783cde2833947d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
- Create products A & B
- Create a BOM: 1 unit of A to produce 1 unit of B
- Create a Route which applies on products with the following Rule:
Action: Push To
Operation Type: YourCompany: Internal Transfers
Source Location: WH/Stock
Destination Location: WH/Stock/Shelf 1
Automatic Move: Automatic No Step Added
- Apply the route to A
- Create a MO for B, validate
- Create an Unbuild Order for the MO created, validate
The component (A) has a `stock.move` to WH/Stock/Shelf 1 but a
`stock.move.line` to WH/Stock.
This is because the `stock.move.line` is created when the quantity is
set in:
https://github.com/odoo/odoo/blob/98b1039705d5911946ed3b5180e4d114dc809ed4/addons/mrp/models/mrp_unbuild.py#L151
However, the `_run_push`, which only changes the `stock.move` location,
is called on `_action_confirm` during the call to `_action_done`:
https://github.com/odoo/odoo/blob/98b1039705d5911946ed3b5180e4d114dc809ed4/addons/mrp/models/mrp_unbuild.py#L152
The solution is to call `_action_confirm` before the creation of the
`stock.move.line`.
opw-2156132
closesodoo/odoo#42493
X-original-commit: ac0f43f704a988f11e4670e241380b76dc81f8fc
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
*: web_editor, website_forum, website_mass_mailing, website_slides
This class no longer does anything.
Part of odoo/odoo#41561
task-2155808
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The previous commit introduced a new imagepicker uservaluewidget, which
allows the user to select a picture or video in a generic way, this
commit adapts the background and CoverProperties snippet options to make
use of this uservaluewidget instead of duplicating most of the logic.
Part of odoo/odoo#41561
task-2155808
This commit introduces a new web_editor UserValueWidget on the
we-imagepicker tag, this widget allows the user to pick an image or a
video using the MediaDialog, and calls the containing snippet option's
method (specified via data-attribute) with the url of the chosen picture
or video as widgetValue. Videos are disabled by default and can be
accessed through the use of the data-allow-videos="selector" data
attribute, any $target that matches the selector will have videos
available in the media dialog.
Part of odoo/odoo#41561
task-2155808
In 2cc8316c66, the cover properties snippet option was refactored to
using a single data attribute per select instead of repeating it on
every button inside of it. After selecting an option, the corresponding
data attribute would be set on the cover container by finding the
currently active button and copying its select class attribute.
However, because of an oversight, instead of finding the currently active
button inside the select, the option would find any active item inside
of the select, and because the select is always open when a button
inside is clicked, the first active item inside of the select is its
toggler.
This commit fixes that by increasing the specificity of the selector
that finds the active button to only find buttons, and not the
select-menu toggler.
closesodoo/odoo#42567
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
missing bit from rev[0]
[0] 7ef11e3c96closesodoo/odoo#42517
X-original-commit: 8ff69abc9010bb2aa05dea5a5f2e1fa545e6179c
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
This commit fixes the following points:
- While dropping a form builder, the default action is now set to
'Send an email' instead of first available action.
- Titles of the forms which previously were readonly, are now editable.
- When sending an email, the 'reply-to' address is now set from the
email field provided in the form, instead of the catchall mail.
- Hitting 'Send' button for 'Send an email' option now immediately
sends the mail instead of putting it in the queue.
task-2082970
closesodoo/odoo#42515
X-original-commit: 7ada68cc91fde1b6eff151549808a20e85cb5bf7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Without this, it will crash since self.env does not exists in a controller.
Using request will still crash later since `check_followers` does not exists.
Introduced with 957c99abd5
Found while working on task-2152191
closesodoo/odoo#42509
X-original-commit: 70e4a716feda7acb7385a98ac51ab40dabc3f50e
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Hardcode some existing colors (but make them hidden in the colorpicker)
so they can be removed from snippets when selecting another color.
Normally, the chosable colors do not contain them, which prevents them
to be removed. For example, normally, the 'alpha' and 'beta' color
(which are the same as primary and secondary) are displayed instead of
their duplicates... but not for all themes.
This commit was mainly about the addition of 'success', 'info',
'warning' and 'danger' colors to the list (as we do not give the
possibility to select them through the editor but they might still be
used by snippets or in old databases). This also solves a bug for
upcoming features in master.
This commit also makes the excluded sections of the colorpicker hidden
instead of removed for the same reason.
In preparation of task-2152191 and others.
closesodoo/odoo#42505
X-original-commit: 222f72386a8a0a28ff450bf8dfa6a1ac8fa48d8e
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Lucas Perais (lpe)