The holidays count on the employee form is not consistent with the count on the dahboard.
The count on the employee form counts the holidays left based on the approved holiday.
The count on the time off dashboard counts all the holidays that are not cancelled or refused.
The time off counts should be consistent across the different screens.
Task-2670658
closesodoo/odoo#78953
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Reproduce :
(With timezone GMT+3)
- Create any record R1 with previous day's date and time after 21:00.
- Create any record R2 with today's date and time after 21:00.
- Create a filter to show all todays records (Date is between "<TODAY'S DATE> 00:00:00 and <TODAY'S DATE> 23:59:59".
Result :
Even though R1 is in yesterday's date, it will show in the list.
R2 will not show in this list.
Explanation :
This behaviour has been observed in several modules, for any timezone but UTC & only with custom filters default datetime values.
The search was applied on [datetime(UTC) + 2 * offset] because the timezone wasn't correctly set.
Solution :
Timezone is now correctly set on default datetime values.
closesodoo/odoo#79516
X-original-commit: 6fd105b89ea30695d6a324a5aa0b2004987c2e47
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Onockx Audric (auon) <auon@odoo.com>
On tablet, the call-to-action to install the app shouldn't show the QR
code... to be scanned by the tablet itself.
This commit fixes it by using the platform detection instead of the
screen size.
Steps to reproduce:
- Open "Expenses" on tablet
- ensure no records are listed (use filters if needed)
- click on the call-to-action to one of the app store
=> opens the QR code's modal instead of going directly to the store
task-2349194
closesodoo/odoo#79514
X-original-commit: e7cbced2ffff189f6aed9ce0b0ab8eb819dbd088
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Some variables were used in _t function instead of raw strings.
One string was not translated properly.
task-2686066
closesodoo/odoo#79505
X-original-commit: 7c5b475532dca1efea5599fb5a3f61ea646d8267
Signed-off-by: Antoine Guenet <age@odoo.com>
Current Behaviour :
Go to Time off -> Approvals -> Time Off -> create one time off of type 'Annual Time Off 2021' for multiple employees (i.e. Anita, Abigail and Audrey) -> validate -> refuse -> set to draft -> Traceback
Behaviour after the PR :
No traceback
opw-26842777
closesodoo/odoo#79503
X-original-commit: c4103536350ed6c0da93a18992e1f9b733bd845e
Signed-off-by: Kevin Baptiste <kba@odoo.com>
1. Configure MX company, make sure testing certificate and vat are loaded into the company
2. Sign an invoice with 16% included in price
No errors will be shown but opening the resulting CFDI xml will show a
discount "Descuento" equal to the tax amount, which is incorrect
opw-2665082
closesodoo/odoo#79501
X-original-commit: 3f58aefe607e562044617e2c9dbecb1afd2de586
Related: odoo/enterprise#22170
Signed-off-by: Laurent Smet <las@openerp.com>
**Description of the issue/feature this PR addresses:**
When the product configurator option is enabled and a product
that has no variants but has optional products is opened, there
are two modals one on top of the other because of an extra
trigger of a handler.
**Current behavior before PR:**
The modal shows up twice, and needs to be closed twice.
**Desired behavior after PR is merged:**
The modal only shows up once and behaves as expected.
opw-2678887
closesodoo/odoo#79500
X-original-commit: bbf5a96e05b7d39401e60981270beb41c54cfbb9
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Before to this commit all time off type would be displayed if ANY
allocation of that type existed for the time period selected, however
logically we only want to display them if the user selected/current user
has a valid allocation. This caused some issues with the extra hours
time off type.
TaskId-2658077
closesodoo/odoo#79498
X-original-commit: d5b36b5f73effc0344557a9d377468d4bb020695
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Since the Time Off B2B, the deduct extra hours didn't work anymore due
to an invalid domain.
This commit fixes the traceback but also the behaviour as the domain did
not make any sense anymore.
Also changes the default order for overtime records.
TaskId-2658077
X-original-commit: 13c57cdb3b797e56a164e5049b9f9d799ad127c9
Part-of: odoo/odoo#79498
Expected behaviour:
When you create a sale order with a project associated. When the sale order change state
from non upsell to upsell sales person should receive one email.
Current behaviour:
The sales person receive an email for every entry in the timesheet after the sale order goes
from non upsell to upsell.
Step to reproduce:
Create a sale order setup to create a project and task and the invoicing policy is ordered quantities.
Add a timesheet entry which takes it past the ordered quantity.
Create the invoice for the order.
The state of the line and order goes to upsell, and the upsell email is sent to the salesperson.
Add another line in the timesheet and the email is sent again to the salesperson
opw-2581428
closesodoo/odoo#79496
X-original-commit: d9c45eae10a2a6fd42f48112b9dc3ae4ab089ea9
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Adds new account to withhold vat tax, and new vat tax
Enables document type 46
Allow electronic docs in purchase journals
[FIX] l10n_latam_invoice_document Consider doc type 46 as a vendor document
More information -> https://www.sii.cl/preguntas_frecuentes/catastro/001_012_3665.htm
[RM] l10n_cl: remove _filter_taxes_included method
closesodoo/odoo#79479
X-original-commit: 0c34fe795cee7eb6f0c5678f9e505ccc9b6e57e8
Related: odoo/enterprise#22160
Signed-off-by: Josse Colpaert <jco@openerp.com>
We want to activate product variant by default for testing product configurator.
Otherwise Odoo want to de-install the whole module due to dependency chain.
Task-2677144
closesodoo/odoo#79466
X-original-commit: 63211eb48d3ac54e22dbee48f3131bd46aea5599
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, when inserting a new snippet or moving a snippet
that was already in the page would temporarily create hooks (`we-hook`)
in the page. The insertion of thoses hooks would trigger mutation
in the dirty observer (observer defined in edit.js) and mark all
oe_structure for which a hook was temporarily inserted.
Thus, creating unnecessary views in the backend.
Now, the code skip the mutations of the drag and drop hooks.
Task-2567752
closesodoo/odoo#79394
X-original-commit: 1b80fe9b56acea09a6784691561df65fe6349f50
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Antoine Guenet <age@odoo.com>
Issue:
When trying to print a Suisse QR bill, if multiple images are presents
in document and they have a url as src, some pictures will not be
displayed.
(Same issue may occur with simple QR code)
Cause:
It's a known issue with wkhtmltopdf: https://github.com/odoo/odoo/commit/2949138a7d84cd6c925ea1745d62f25ef077bb8b
Also, adding css class to body by js break wkhtmltopdf.
Solution:
Replace link by base64 image value (use a function to retrieve base64
image instead of image_url).
Remove class 'l10n_ch_qr' added by js (no need since CSS file didacted
to this report).
Move `_get_qr_code_base64` and `_get_qr_code_url` logic/flow
(since generic) to account module.
Move specific logic like `_get_qr_vals` and
`_get_qr_code_generation_params` to specific module (ex: l10n_ch).
extra: Alter some css for better rendering + update unitest.
opw-2620082
closesodoo/odoo#77643
X-original-commit: 699b6eeac993e3a8d97ae7949170f7e18ca05831
Signed-off-by: Olivier Colson <oco@odoo.com>
sale_order_id filter was wrongly labelled and added in #71232.
This commit hides this filter and adds the one that should have
been added.
task-2685356
closesodoo/odoo#79442
X-original-commit: 866143f4dd83b3b22a53262733b3a3d25ee8266c
Signed-off-by: Xavier <xbo@odoo.com>
When exporting, the delivery address is put inside the xml.
This field is added by the 'sale' module and is not supposed to be displayed for vendor bill.
However, even if this field isn't displayed, the factur-x module was setting the wrong delivery address on it.
closesodoo/odoo#79410
Issue: 2668902
X-original-commit: a127515d890df74e341c0f08406ef451a638f639
Signed-off-by: Laurent Smet <las@openerp.com>
Signed-off-by: Josse Colpaert <jco@openerp.com>
In a multi-company and multi-currency environment, the computation of
the purchase price may be based on the incorrect company (and thus lead
to incorrect results)
To reproduce the issue:
(Use demo data)
1. In Settings:
- Enable "Multi-Currencies"
2. Update "My Company (Chicago)":
- Currency: EUR
3. Edit currencies' rate for all companies(!):
- USD: 1.0
- EUR: 3.0
4. Create a product category PC:
- Costing Method: FIFO
5. Create a product P:
- Type: Storable
- Category: PC
6. Switch to "My Company (Chicago)"
- Note that in this company, the costing method of PC is "Standard
Price"
7. Edit P:
- Cost: 10
8. Create a sale order SO:
- Pricelist: EUR
- Lines (add Cost columns):
- 1 x P (Note that cost is 10€)
9. Confirm SO
Error: The sale order line is incorrect, the cost is now 30€. A rate
conversion has been applied on the amount
In `_compute_purchase_price`, several fields/methods depend on the SOL's
company: `property_cost_method`, `_compute_average_price`,
`cost_currency_id`. Therefore, we should include this specific company
in the environment of the product
OPW-2659265
closesodoo/odoo#79430
X-original-commit: 868142c3885f7bf65a7974066234feb0eb6241ae
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
Currently, the order of transfer lines makes no sense for a picker
(it's in the order of the creation of the line). We want to have the
lines of the detailed operation in the same order as the picker will be
picking the products, so we order by source location, destination
location, sequence, and then by id (i.e. creation time) respectively
instead.
Also the printing report of the batch transfer is on too many pages,
it's one page by location, but we always group on 'from location'.
So it would be better not to split by location and keep the report
on the least number of pages possible.
task-2496324
odoo/enterprise#21921closesodoo/odoo#79446
X-original-commit: 9b120caa2a5cd5e2487d663a180b486b5bdb201b
Related: odoo/enterprise#22144
Signed-off-by: Tiffany Chang <tic@odoo.com>
Before this commit, env.isMobile was defined lately and
you have to wait the next update of the template.
Steps to reproduce:
- Open "bar" POS session
=> 'pos-branding' is present in the header bar
X-original-commit: 931304b9e7085c77e5b9bed8054ae47fc2a6168f
Part-of: odoo/odoo#79448
Add possibility to zoom on floor screen on mobile devices.
It should be more easy to navigate when there is a lot of
tables.
Task ID: 2453679
X-original-commit: 43fbe45d4f9fc43477690e3d2fb1bc1299f4824b
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
Co-authored-by: Romeo Fragomeli <rfr@odoo.com>
On mobile, it wasn't clear if a value was set or not.
Now, we apply the same logic as for invoices:
customer or tip buttons will be highlighted if set.
This also fix the alignement by removing some css rules...
Task ID: 2453679
X-original-commit: ed41b793836e9f9c6ec6c754331f40f4fbdee1b0
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
"Discard" button shoud be on the left to respect the intuitive
mobile navigation.
We also take advantage of this commit to show icons and text on
desktop and only show the icons on mobile.
Task ID: 2453679
X-original-commit: f774f07a46197f7e1664aee32723b10bf6df37b4
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
Before this commit, when you clicked on "Review" the order lines weren't
visible due to the number of control-buttons.
To fix this, a "More..." button is displayed if there is more than 3 buttons.
When you click on this button, a new modal will display a menu with all controls.
Note that we had to find a way to close this popup after clicking on an action.
Task ID: 2453679
X-original-commit: 430d40f90c1e9a7e8e3663e8f2b129b0c24911e1
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
- Users were automatically redirected to the middle of the
receipt screen on mobile. It direcly showed the ticket but
users missed the buttons at the top of the page.
We changed the DOM to use the right "flex-direction" value.
- "(Both will be sent by email)" appears when you select a customer
and ask an invoice.
This text was positioned in absolute to be aligned to the bottom right
on the input. This can't work when you have a scroll bar like on mobile.
So we now simply use "text-align: right".
- Email input was too small on mobile.
To fix this, we decided to only keep the icon and remove "Send" text.
Task ID: 2453679
X-original-commit: ce2c8414333ca3ae6a28da0c59502e44eb16980e
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
- Icons (customer, invoice,...) are now displayed on mobile too.
- Pane buttons (Validate, Review,...) were too tall.
We now better see the content of the primary screen while being
able to click of these buttons.
Task ID: 2453679
X-original-commit: 61ede7cae6e074a9e4eb590ddd9bd126fb214d92
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
Before this commit, users had to use a popup window to change
the product category. It wasn't clear for users who are used
to using a large screen.
This commit adapts the breadcrumb navigation to be the same
as on desktop. This avoids the use of this popup.
We also improve the display of products by taking the entire width
of the screen. This allows us to add some space between the products.
Task ID: 2355025
X-original-commit: 9b7d1d6f9ef1342db5bb0d6a31eafa9d2586d171
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
Using a list view isn't the best way to display data on small screen.
We had to change this behavior to display a kanban view of orders.
We also merge design of "Ticket" screen and "Order Management" screen.
Task ID: 2453679
X-original-commit: d0e53721a97c14419a2f81ef8aa8be317cc5644a
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
When you clicked on "Review", there were not enough space to
properly check the order lines.
The "back" button took a lot of space in this screen.
Additionally, it shouldn't be the primary button in this view...
It's why this button has been moved in the action pad, next to the
payment button.
Task ID: 2453679
X-original-commit: 1418c9f10c80bea6393b47d5ffc1e0217ad1d4ba
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
The "back to floor" button is currently too big to be used on mobile
To fix this we have no choice but to display the table number only.
It would be good practice for this number to be unique; we will fix
the demo data in master branch.
This also fix a misalignment between arrow and text.
Task ID: 2453679
X-original-commit: 31dc371c824cee431072788faafb7f1dfd4a1335
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
The top of new order page is currently unusable because it's too large
for small screens.
To improve the UX, we remove the current search box and only keep the
icon and when the search icon is clicked, the search input is shown.
We also had to reduce the font size and paddings to keep filters next
to the search input. As it doesn't change much in desktop, these
changes are also applied for larger screens.
Task ID: 2453679
X-original-commit: 8f4202de307911e4ea54af6c018de87dd94086b6
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
The top of POS is too large and must be scrolled to be used.
To improve the UX, we remove the current search box and only keep the
icon and when the search icon is clicked, the search input is shown.
Task ID: 2453679
X-original-commit: e5d54ac1d30eef789ec1604e3a1212f415224ada
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
- Show user avatar logo on desktop and mobile.
We are now able to know which employee is currently connected on mobile.
The user name is still shown on desktop but didn't appear for small device.
- Add "sign-out" icon on desktop and mobile.
- Remove label strings like "Close", "Orders" and the username to
gain some space; the icons will do the job.
- Remove "close_button" unused class
Task ID: 2453679
X-original-commit: 551ef472ec42965af38f68343b9fe50ea7ec4c88
Part-of: odoo/odoo#79448
Co-authored-by: Adrien Dieudonné <adr@odoo.com>
Currently, the _fields_view_get_address() method replaces the field
'city' and all of its attributes.
That causes problems for attributes that are defined
in other previously installed modules.
This fix allows the 'required' attributes to be conserved.
closesodoo/odoo#79447
X-original-commit: 1ac8b5a40440e6c4fddc0e088064ea1a706d93ab
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: John Laterre <jol@odoo.com>
This PR are the follow-up of #73341 PR to fix the various points to finalize the feature for the v.15.
These points are done only in the Project Sharing feature:
- remove import button in favorite menu
- remove some filters in search view and update the search view
- add uom in session to use timesheet_uom widget for timesheets: this widget uses the uom stored in the session to display the unit_amount in hours or in day format.
- remove the using of avatar widget for employees.
- remove checkboxes in list view.
- change label for group by user_ids
- not set by default the height of the chatter
- remove the 'Set a cover' button in kanban view because the portal user has no access to `ir.attachment` model.
- add unit tests for project sharing feature.
- force staying in the project sharing form view when the user wants to see a subtask.
- display subtask planned hours
- allow the portal user to edit priority task when he is in project sharing feature.
- show "Assign to me" button
- see custom kanban state label
- get all options when the chatter is reloaded in project sharing.
In classic portal views:
- use task in sudo for classic portal form view
General point:
- prevent click on avatar user when `noOpenChat` is `true`
task-2633229
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#79429
Forward-port-of: odoo/odoo#77156
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
The "Auto-complete" bills field does not show all POs for the Vendor that are waiting for invoices.
To reproduce the issue:
- Create PO1 Vendor = "Supplier"
- Create PO2 Vendor = "Supplier, John Doe"
- Create Invoice for PO2
- In the PO2 Invoice, "Auto-Complete" field try to select PO1, but it is not shown.
The "Auto-complete" bills field should show all POs for the Vendor that are waiting for invoices.
The problem is that the field's domain filters is using the partner_id
field when it should be using teh commercial_partner_id.
opw-2684409
closesodoo/odoo#79438
X-original-commit: d3002116e665d799ba11b9f94e4b45bc4c39bde5
Signed-off-by: Arnold Moyaux <arm@odoo.com>
stock.orderpoint._post_process_scheduler confirms
productions after procurements have been run.
This was introduced to avoid conflict between
procurements, conflicts that can happen e.g. in
the purchase_mrp module.
However, currently action_confirm might
also be called on done or cancelled productions.
That can happen if there are already been lots
of procurements for the same product/orderpoint,
i.e. MO with the same values have been created multiple times.
To avoid this, add ('state', '=', 'draft' in the search_domain.
opw-2666960
closesodoo/odoo#79437
X-original-commit: 11c7b92f90804a4d73833e22c071e1665058fbdb
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Before this commit, it was impossible to to hide a column when the
timesheets or subtasks features are not enabled to the project shared.
This commit manages the column_invisible for the list view in project
sharing to compute the domain in this modifiers. We assume all tasks
displayed in project sharing are linked to a project shared.
task-2633229
closes#77156
X-original-commit: ab2b5d1fd1f09d804ab410bc326cfebf26d5a7c6
Before this commit, we import all xml in project module. The problem is
the ones for project sharing should not be included in `web.assets_qweb`.
This commit excludes the project sharing assets from `web.assets_qweb`.
task-2633229
closes#77156
X-original-commit: 21e21d7956d6de1775f4230060cdff7c39015bbc
Before this commit, the portal user could see the checkbox in search
view to share his favorite item with all users. This action is not
authorize in project sharing feature and should be removed.
This commit removes this checkbox to avoid the portal user to share his
favorite item with others users.
task-2633229
closes#77156
X-original-commit: 19b38074dd8bfe4d8347db31f946beeb2850d453
Before this commit, when the user chooses to encode in 'Days', the
timesheets, when a collaborator accesses to the project sharing feature
for a shared project. This collaborator has an access error because he
does not have any access to `uom.uom` of the current company. Indeed, we
use this uom to change the label of `unit_amount` field for
timesheets linked to this project shared.
This commit fetches the name of the encoding for the current company in
sudo to change the label of `unit_amount` field of timesheets during
the load_views of project sharing feature.
task-2633229
closes#77156
X-original-commit: 575315744a31a975208c82f72403ecebf3585f37
Before this commit, those columns are not invisible if the project has
not allow_timesheets enabled (or not allow_subtasks for "Total Hours"
field) in list view of project sharing feature.
This commit changes the attrs of those field to hide the column if the
domain is satisfied.
task-2633229
closes#77156
X-original-commit: 3856024d037a86a07703cc492f7cc41be93169de
Before this commit, when the collaborator clicks on the favorite menu,
he has a traceback because the 'spreadsheet' service is not available.
Since we don't want to use this service and we just want the menu item
to save the current as favorite. This commit override the favorite menu
to remove the registry items to add the menu item and we just add the
one we want.
task-2633229
closes#77156
X-original-commit: d970c13494db2c3e085155b7855b656fbbe26467
Before this commit, when the task has a user assigned to a task and the
current user wants to assign himself to this task. He cannot see the
'Assign To Me' button because this button is only visible if the
`user_ids` field is empty.
This commit changes the visibility of this button to show this button
only if the current user is not yet assigned to the task.
task-2633229
closes#77156
X-original-commit: cfba241bada2b3690b4303b7e01747301925d162
Kevin Baptiste