Commit Graph
103938 Commits
Author SHA1 Message Date
Raphael Collet 3ec5a23007 [FIX] base: recompute view.model_data_id (#13885)
The field was a stored computed field without dependencies, and therefore it
was never (re)computed. Add a simple dependency on the model `ir.model.data`
to make the recomputation everytime a view is modified. Moreover, when views
are created from modules, delay the recomputation of view fields until their
`ir.model.data` record is created.
2016-10-19 15:20:14 +02:00
Nicolas Martinelli d3e2aa5551 [FIX] purchase_requisition: incorrect method call
Missing arguments in method call, which causes crash.
2016-10-19 11:13:35 +02:00
Nicolas Martinelli d8c88079d3 [FIX] purchase_requisition: unit price when quantity change
On a PO linked to a purchase tender, changing the quantity on a PO line
will trigger a recompute of the unit price. However, this recomputation
will take into account the unit price of the supplier pricelist, not the
unit price on the purchase tender.

opw-690483
2016-10-19 11:08:15 +02:00
Nicolas Martinelli fad9378d17 [FIX] purchase_requisition: price unit in blanket order
When the purchase tender of a PO refers to a blanket order, the price
unit used to create/update the order lines doesn't take into account the
potential difference of UoM.
2016-10-19 11:08:07 +02:00
Géry Debongnie a75961364b [FIX] web: properly apply styles attribute to form fields
The form widgets did not apply the 'style' attribute to the result of
the rendering.  Because of that, many small adjustment were no longer
possible. This commit makes sure that it is indeed done.
2016-10-17 16:33:09 +02:00
Christophe Simonis ba6ca788fd [FIX] fields: correct detection of new records on relational fields 2016-10-17 14:51:37 +02:00
Christophe Simonis ceb1ba6dbd [MERGE] forward port branch 9.0 up to b14c8b3 2016-10-17 13:46:24 +02:00
Christophe Simonis b14c8b361c [MERGE] forward port branch saas-6 up to fa50349 2016-10-17 13:14:22 +02:00
Christophe Simonis fa50349d7e [MERGE] forward port branch 8.0 up to 001610e 2016-10-17 13:01:20 +02:00
qdp-odoo 4cfc0f7232 [FIX] hr_expense: create the account.payment objects when an expense is paid by the company.
This is required in order to have those bank journal items appearing afterwards in the bank statement reconciliation widget (blue line) for reconciliation.
2016-10-17 10:11:59 +02:00
qdp-odoo 001610ece9 [FIX] anglo_saxon_dropshipping: fix accounting entries creating on anglo_saxon + real_time + dropship.
This revert the fix made on 7bdd4de and replace it with a proper one that do create an account entry from stock_input to stock_output on a dropship move. That way, we avoid the manual change of account on supplier invoice. See the whole discussion on odoo#12687
2016-10-17 09:39:53 +02:00
Odoo Translation Bot d1c81f136c [I18N] Update translation terms from Transifex 2016-10-16 02:57:56 +02:00
Odoo Translation Bot 2ce7679032 [I18N] Update translation terms from Transifex 2016-10-16 00:34:35 +02:00
Martin Geubelle 0d5bdaa5a0 [FIX] anonymization: remove unstored field
In 8.0, the field `base` was a stored Float (see https://github.com/odoo/odoo/blob/8.0/addons/account/account_invoice.py#L1516 )
In 9.0, the field `base` is a Monetary computed non-stored (see https://github.com/odoo/odoo/blob/9.0/addons/account/models/account_invoice.py#L1307 )

As it is not stored, there is no point of anonymise it, so it can be removed from the CSV file.
2016-10-14 18:18:31 +02:00
Martin Geubelle cbd3e8fcbd [FIX] anonymization: add monetary field 2016-10-14 18:14:24 +02:00
Jeremy Kersten 33978d7a7a [FIX] stock: adjustement inventory, check options activated in res config
Before this commit, the inventory by lot/pack/serial/... was only visible
if you switch quickly between res_config and adjustment inventory... once
the vaccumn clean the osv memory, the options was ignored.

Same issue with the _get_string_qty_information function.
2016-10-14 18:07:21 +02:00
Jairo Llopis 448521df64 [FIX] fields: setting a one2many field deletes all its lines (#13082)
Setting the value of a one2many field (`rec.line_ids = ...`) converts the new
recordset to a list of commands, and passes it to `write`.

Currently the list of commands is like: `[(5,), (0, 0, vals), (1, id, vals), (4, id), ...]`.
Notice that the command `(5,)` is inappropriate here: it deletes all the
existing lines of the record. Reintroducing the same lines with `(4, id)`
commands crashes, because the corresponding `id` is no longer in database.

The fix serializes the recordset as a list of commands like
`[(6, 0, ids), (0, 0, vals), (1, id, vals), ...]`.
Only the lines that are not kept will be deleted in this case.
2016-10-14 14:54:02 +02:00
Nicolas Martinelli 5e9a93e051 [FIX] account_asset: deferred revenue generation
- Create a deferred revenue type > 3 depreciations, one every month
- Create a deferred revenue with this revenue type
- Odoo generates a depreciation board with 3 entries > one should be
  done in October, one November, one in december
- Generate your deferred revenues entries UNTIL 31st of december

Odoo create the 3 depreciations but they all have the 31ST of december
as accounting date > the dates of these accounting entries should be the
date defined on the depreciation board.

opw-690970
2016-10-14 14:44:47 +02:00
Pierre Masereel 852e2c557e [FIX] barcodes: set_quantity traceback on mobile
When we are trying to set the quantity on a mobile device, we get
a traceback saying that we cannot call the 'find' function on the
elements returned by '_get_records'.

This '_get_records' function returns a 'Collection' when called on a tree
view and an 'Array' when called on a kanban view. When we are working
on a mobile device, most of the one2many are displayed as kanban.
The thing is when we work with the object returned by '_get_records' we
call a 'find' method on it, which is implemented by Odoo's Collection class.

So when we call 'find' on an 'Array' we actually call 'Array.prototype.find' which
is implemented on most desktop browser and on some mobile browser [1]. This is what
caused the traceback on Chrome in Android.

To fix this issue, we enforce '_get_records' to always return an 'Array' and we ensure
that, when working on this 'Array', we use '_.find'.

[1] https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find
2016-10-14 12:22:22 +02:00
Denis Ledoux 4a0a279472 [FIX] website_quote: correct company for the quote validation
In the frontend customer quote validation,
the company used in the sentence
```
I agree that by signing this proposal,
I accept it on the behalf of
```

was the quotation company, which is the company
which is selling, not the company/customer which is buying,
and this does not make any sense.

Instead, it should use the company of the customer
accepting the sales order, or simply the customer
if he does not have a company set.

The only case which make it a little weird is when
it's the customer himself, without parent company,
who is accepting the quote
"on the behalf of himself", but:
 - This isn't possible to correct this without
   breaking the translations, because the
   sentence "I accept it on the behalf on"
   is within the same sentence than
   "I agree that by signing this proposal"
 - This makes sense if another person than the
   customer himself is validating the order
   (the customer sent the quote link with the token
    to another person).

opw-690837
2016-10-14 11:38:36 +02:00
Thomas Binsfeld d0bfcfd41d [FIX] Inheritance of purchase_order_change by preparing data dictionary
Data dictionary filled inside the function purchase_order_change had no possibility
of inheritance.

opw:690733
2016-10-13 22:30:40 +02:00
Jairo Llopis a2f0dda366 [FIX] website_portal: redirect to login for '/my' controller
Current issue without this patch:
On a bare database, install `website_portal` and go to `/my/home` logged out.
You get to an empty page where you can see Public User's details.

Expected behavior with this patch:
User should be redirected to the login page.

Additional notes:
- Other submodules (`website_portal_sale` and `website_project_issue`) were
  actually implementing this, so that is removed BTW and relies in base
  module's now sensible behavior.

This commit closes #12775
2016-10-13 16:30:03 +02:00
Simon Lejeune 4450495e9e [REF] web_kanban: allow a custom limit defined in the arch
With this commit, it's now possible to set an arbitrary limit on any
kanban view by adding a limit attribut to the root kanban tag in a
kanban definition.

Do not forward-port.

Backport of rev 8a87c382ba
2016-10-13 16:20:30 +02:00
Nicolas Martinelli 1f0a778742 [FIX] stock: reverse picking in several steps
- Activate the receipt in two steps on the warehouse
- Create a PO for a stockable product
- Receive the product in Input zone
- Receive the product in Stock
- Reverse the move to Stock > products are back in Input
- Reverse the move to Input

You can't reserve quantities for this last move (from Input to Vendor).

This is because a picking has been automatically created from the Input
to Stock.

Original move which is reversed: Input -> Stock
When we reverse it, we don't want to send it back to Stock, so we need
to check the destination location of the original move, not its
location.

opw-689206
2016-10-13 16:12:05 +02:00
Devendra Kavthekar c63c225274 [FIX] web: is_false() for reference field widget. (#9335)
In the widget, the value of reference field is a pair `[val1, val2]`.
When the field is blank, its value is `[false,false]`, thus checking `[false,false] === false`
never succeeds, and this breaks the check for required fields.
2016-10-13 16:01:21 +02:00
Simon Lejeune 5abe76c2d2 [FIX] web: clear_uncommitted_changes on browser's back button
This is done by guarding the `on_hashchange` evant handler with the
`clear_uncommitted_changes` function.

Note that the url has already changed when we are in this handler, so we
make sure to restore the old url when the user chose to continue its
edition.
2016-10-13 15:51:09 +02:00
Simon Lejeune a7b976c704 [FIX] web: browser's back button while in the same action
When you browse through the views of an action and then hit the back button,
the view does not change. For example, go to the customers kanban, click
on a customer, hit back, you're still in the customer form view.

related rev: 46857d267b

`do_load_state` is called when you hit f5 or press the back button on
your browser. The related rev took care of fixing the ugly part that
make the webclient goes trough the multi record view then the mono
record view when you hit f5 on a mono record view.

In this context, it removed the code in view manager's `do_load_state` that
switched the mode of the action if it isn't the same the one the web client
is trying to restore from the state (because now the correct mode is loaded).

However, if you hit the back button while the previous view is in the same
action, it obviously doesn't switch the mode anymore and you're facing
the same view.

The issue is fixed by restoring the switch_mode in the view manager's
`do_load_state` (without its oudated comment).
2016-10-13 14:38:33 +02:00
Yenthe V.G cfe0dc6d34 [FIX] website_sale: remove duplicated method
Added twice during a forward port

Closes #13796
Fixes ##13795
2016-10-13 14:31:18 +02:00
Nicolas Martinelli 89700eb771 [FIX] account: multi-currency reconciliation
Reconcile the following entries :
D                          C
Amount currency
3.655,52€                                                   +3.872,45$
                            3.436,80€                       -3.872,45$

What Odoo does when I reconcile the 2 entries above using the
"Reconcile" button:
D                          C
Amount currency
3.655,52€                                                   +3.872,45$
                            3.436,80€                       -3.872,45$
0€                           218,72€                          -236,61$
0€                                    0€
+236,61$

What Odoo should do :
D                          C
Amount currency
3.655,52€                                                   +3.872,45$
                            3.436,80€                       -3.872,45$
0€                           218,72€                       0$

opw-687481
2016-10-13 13:08:44 +02:00
Adrien Peiffer (ACSONE) d81258ab8e [FIX] Consider currency rate to compute total amount in expense analysis
Like in Invoices Analysis, the expenses must be expressed in the currency
of the company. In this way, it makes sens to sum them to compute the total.

opw:689760
2016-10-13 11:24:06 +02:00
Richard Möhn cb581bc14f [FIX] api: in todo list, group records to recompute by environment (#11267)
The effect of this change is to trigger the recomputation of fields on larger
recordsets.  This takes advantage of batch computations within compute methods.
2016-10-13 10:13:33 +02:00
Nicolas Martinelli f4d7d04c1d [FIX] l10n_in: taxes tags
There are inconsistencies between the tax tags as defined in the module
and what the reporting expects.

opw-689188
2016-10-13 10:10:13 +02:00
Goffin Simon 6799abb37a [FIX] account_asset: Depreciation Expense Account appears twice
For the field account_depreciation_id in the account.asset.category.form
view, the string "Depreciation Expense Account" was already used for
the field account_depreciation_expense_id.

opw:690297
2016-10-13 09:42:01 +02:00
Goffin Simon 7bcc197531 [FIX] sale: Making a downpayment with a fiscal position
When creating a SO line and an invoice line for a downpayment,
the fiscal position set on the SO must be taken into account
to map the right taxes.

opw:688611
2016-10-13 09:15:48 +02:00
Jeremy Kersten d3609f7f19 [FIX] web,crm: list view, don't fallback on group_operator declared in python
Partial revert of odoo/odoo@633780a
2016-10-12 18:03:51 +02:00
Jeremy Kersten 7fb1b6f30b [FIX] utm: dont try to set cookies if Response is Exception
Also prefetch tracking_fields before the call to super to avoid to use a closed cursor.
See odoo/odoo@6780597

this commit closes #13646
2016-10-12 17:57:24 +02:00
Christophe Simonis a73cd57485 [MERGE] forward port branch 9.0 up to 6faf232 2016-10-12 16:56:44 +02:00
Christophe Simonis 6faf232b71 [MERGE] forward port branch saas-6 up to ef4efea 2016-10-12 15:33:01 +02:00
Christophe Simonis ef4efeac7c [MERGE] forward port branch 8.0 up to 16430be 2016-10-12 15:27:07 +02:00
Goffin Simon a8e1595a12 [FIX] sale: visible cost price in sale order line
The Cost of the product(purchase_price) must be shown in the wizard opened
when changing a SO line.

opw:690180
2016-10-12 14:13:33 +02:00
vnsoft 16430be566 [FIX] models: in method read_group(), allow orderby='id desc'
When orderby argument is 'id desc', an error occurs: "read_group order by 'id'
ignored, cannot sort on empty..."
2016-10-12 13:19:37 +02:00
Alexandre Fayolle 65c685ad24 [FIX] context mutations (#10368)
when extending these methods with the new api, the context is a frozendict
so we need to copy before mutating.

this patch was made by searching for key addition to context and calls to the
update() method on the 8.0 addons, and checking if a copy was made before in
the method.
2016-10-12 12:30:42 +02:00
Raphael Collet 8f6b5fcf9e [FIX] ir_model: in _module_data_uninstall(), unlink the right recordset
The bug was introduced by eb04aa1e (migration to new API).
2016-10-12 11:24:24 +02:00
Cedric Snauwaert 77c64e3f05 [FIX] account: add a constraint to prevent the change of the reconciliation flag on account when there are already account_move_line existing 2016-10-12 10:35:29 +02:00
Richard deMeester 32b0e9520d [FIX[ account: correct 'read' call
Using the read method should generally pass a single id as a list
due to the new API inheritance of the read method.  If an attempt
is made to use the new API, the result is inconsistent.
Following 4f0ca6d9

Closes #13678
2016-10-12 10:28:16 +02:00
Sebastián Ramírez d30f512128 [FIX] doc: use the correct dir structure
To respect the folders created by scaffold and the coding guidelines
Closes #13676
2016-10-12 10:23:45 +02:00
Sebastián Ramírez 9adcf51600 [CLA] signature for tiangolo
From #13676
2016-10-12 10:23:24 +02:00
开阖软件 Jeff Wang 007607030a [FIX] tools: keep keyword arguments in wrapper
The patched add_sheet method lacks from the keyword argument cell_overwrite_ok
that is present in original code.

Closes #13755
2016-10-12 09:57:35 +02:00
Martin Trigaux 69dfa67ac7 [FIX] pos: do not mix create and validation date
The validation_date was using the creation_date value in the follwing scenario:
1. create a new order with a few lines (creation_date=t1)
2. reload the page, `init_from_JSON` uses validation_date=t1
3. validate the order at t2, ignored due to already stored value

creation_date must be kept for tracablity reasons (e.g. pos_blackbox_be)

Fixes https://www.odoo.com/groups/59/20542134
2016-10-12 09:44:56 +02:00
Nicolas Lempereur 3cd80916f1 [FIX] purchase_requisition: typo in groups name
The field in stock configuration group_stock_adv_location is toggling
the group "stock.group_adv_location". There was a typo which was using
on the form view of purchase.requisition the group
"stock.group_stock_adv_location" instead.

opw-690804
2016-10-12 08:38:00 +02:00