This commit fixes issues that could happen when a groupBy is present
in the load params from the ActivityModel. Before the rewrite of the
view to Owl, this code was present but was forgotten. This causes
crashes whenever web_search_read is then called, leading to undefined
record in the template, and crashing the view.
Now, the groupBy param (if present) is replaced by an empty array.
A test has been added to verify that during the load, even if the
ActivityModel has received a groupBy in its load parameters.
closesodoo/odoo#124215
X-original-commit: b6fa8ec174f5467baaed32b0c12acd0224757281
Signed-off-by: Dardenne Florent (dafl) <dafl@odoo.com>
This commit adds the signature for mohamedlaminelalmi.md, indicating
that the Contributor License Agreement (CLA) has been signed.
closesodoo/odoo#124211
X-original-commit: bd2082c07f6605a4b991e577aae5249010ff0ccc
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Fix an issue where products with internal references containing point
or slash were not recognized as direct matches in the website searchbar.
Instead, fuzzy search was used to find similar words.
This commit addresses the problem by fixing the regular expression
used for matching words in Odoo's search functionality.
X-original-commit: dee84ff3b0ec56149780e6eefb8724f954918fd1
Part-of: odoo/odoo#124211
Bug
===
If we create a selection properties with some options, change the type
to char, and then again to selection, the options are restored.
But, if we just change the type to char, the options of the old
property are stored in the database, and we don't want that.
Task-3346103
closesodoo/odoo#124129
X-original-commit: 35c99a9110cec3317f36d4ddffae5196b58939e5
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
pre_init_hook
When reinstalling a module, an error occurred if using env from
api.Environment in pre_init_hook.
Example:
- Module A depends on module B, and model M that created from module A
- When reinstalling module B, an error occurred if using env['M'] in
pre_init_hook
closesodoo/odoo#124086
X-original-commit: 70fcfa0d9cdf51964fce1a3be31bbd26258e2275
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
When user uninstalls a module it doesn't unlinks custom crons
which are created by user and it will keep running in the background
and will generate traceback.
So, to fix this we unlink all the custom crons which are related to the
module being uninstalled.
sentry-3929309220
closesodoo/odoo#124175
X-original-commit: b0202488220bd48dd177e9e0601f2f3ba8d7a0f1
Signed-off-by: Fabien Pinckaers <fp@odoo.com>
Signed-off-by: Rahul Prajapati (rapr) <rapr@odoo.com>
Before this commit, the error message thrown by the XML assets loader
was designed only for Chrome and logged only part of the error message
(without the actual reason of the parsing error).
This commit ensures that the entire error is logged to comply with all
browsers implementations and have all informations regarding the error.
closesodoo/odoo#124212
X-original-commit: 9d3dbd5f62e0cf8fbd1c64dfd87d2b22610cbf17
Signed-off-by: Géry Debongnie <ged@odoo.com>
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
By default all the draft moves that are not the first one in a period
get the name `/`, indicating it is in draft. In the UI the name field
is then just an uneditable `Draft` placeholder.
When quick edit mode is activated, we always show the text field for
move names to allow users to edit the sequence number beforehand.
However for all abovementioned draft moves, it would show `/` in the
text field, requiring the user to first delete that symbol before
entering the right sequence.
This commit makes sure the names of draft moves without a sequence
number are empty (no `/`), so that in the UI the text field can be
filled out immediately and a placeholder `Draft` is shown.
task-3326827
closesodoo/odoo#124186
X-original-commit: 83a7daa07fedcaeddb983a94a86e4c7a187915d9
Signed-off-by: William André (wan) <wan@odoo.com>
How to reproduce
================
* Install the account_accountant module
* Go to `Journal Items`
* Select the pivot view
* Select the measure `Amount in Currency`
=> A traceback will occur
Cause
=====
Field amount_currency has group_operator set to none to avoid grouping
several amount in different current together.
Proposed fix
============
If the `group_operator==None`, The field will not be shown as
aggregator.
opw-3061776
closesodoo/odoo#124179
X-original-commit: beccce4d5ec26e885c06c5af4cb1d6147cb0e91f
Related: odoo/enterprise#42127
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Co-authored-by: Nicolas Lempereur <nle@odoo.com>
Impossible to duplicate the Dutch tax report due to a unique code constraint. I also made sure that this issue does not occur in any other localization.
How to reproduce:
- Activate debug mode
- Configuration>Accounting Reports
- Open the form view of the Dutch VAT Report
- action>duplicate
==> Validation Error:
The operation cannot be completed: A report line with the same code already exists.
closesodoo/odoo#124176
Task: 3199129
X-original-commit: affd307665f3e745e9d2a84b3c9ec213370956c3
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: hupo-odoo <hupo@odoo.com>
The test added in #120818 was relying on a model that does not depend on
module `spreadsheet, rather the opposite. This information was probably
lost during the forwardport process.
Since the fix concerns `spreadsheet.mixin` and not just
`spreadsheet.dashboard`, it makes sense to test it globally, in a
dedicated test module.
Fixes runbot build errors 20966 and 20968
closesodoo/odoo#123947
X-original-commit: 7205e3b26eb3de3f53d6984cd07ec3e4b3fbcfdd
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
If End Date is already defined and user remove that date in
the form view of productivity losses, an error is generated.
Steps to reproduce error:
- Install the mrp module.
- Manufacturing > Configuration > enable work order option.
- In Configuration > Work Centers, open any of the work centers
- In form view of work center click on 'Hours Lost' stat button.
- Now in form view of productivity losses remove the date in the
End Date field and save it.
- Traceback will be generated.
Applying these changes will resolve this issue.
sentry :- 4177445007
closesodoo/odoo#123801
X-original-commit: 4f3e4fe4ba31d9d25b70f3307fcadf0e3a556af2
Signed-off-by: Tiffany Chang <tic@odoo.com>
The danish administration create a standardized COA.
In this PR, we have rework completely the chart of account of the localisation
to match the document given by the government.
closesodoo/odoo#121186
Task-id: 3251723
Related: odoo/enterprise#40956
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Entering a value greater than that allowed by a 32-bit integer raises an
error
Steps to reproduce:
1. Install eCommerce
2. Open the website and go to the 'Shop' page
3. Open the editor and click on any product in the grid
4. Set the value of the 'Number Of Products' to an integer greater than
2147483647
5. An error is raised
Solution:
Limit the number of product per page to 10000. This will have the effect
of avoiding the `NumericValueOutOfRange` error but will also prevent the
user to load too much products at once to avoid a timeout.
opw-3226154
closesodoo/odoo#124158
X-original-commit: f620e95b5e459551f881a9aec2bc75b45b9d354e
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
When inserting a dynamic placeholder in the editable document
we need to ensure the said document currently hold the focus and
have an active selection range.
This was previously handle by the `onDynamicPlaceholderClose()` method
which used to be called before `onDynamicPlaceholderValidate()`.
This seems to have changed from 16.1 to 16.2.
In order to fix the problem and ensure the focus in any situation,
we add a `wysiwyg.focus()` call at the beginning of the validate method.
task-3222474
closesodoo/odoo#124149
X-original-commit: 51b992dec0bcdf09fde5e0811699235b590723ee
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Remove overlapping bottom border of the input since the field is boxed.
Add 4px of left padding to the input not to have the cursor overlapping
the box and feel crowded.
Remove the "action" button left border radius.
closesodoo/odoo#124150
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
When we send a report to the iot_w we use Ghostscript to print it. But if it is a ZPL report it crash.
So we need valid if the report sended is a PDF before print it
However if it is a different format, like ZPL, we use print_raw to send directly to the printer
closesodoo/odoo#124146
X-original-commit: a4c315ab657109f2ed69745207cd99ea978889b8
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Before this change, when a package was unpacked the SQL query into the method was looking up all the records into the stock_quant table to find duplicate entries. This could lead to severe performance issue on large database. With this change, if the method is called on a recordset, the SQL query will only try to find duplicate records for records with the same product's ids and location's ids than those in the recordset.
closesodoo/odoo#124143
X-original-commit: c261eb3820e7cbfc98de9c1bd0a79375e6f5d4f4
Signed-off-by: Tiffany Chang <tic@odoo.com>
Since [1] the origin livechat button has no border on the bottom.
This conflicts with the skin of the website livechat button
which is displayed as a circle. This commit solves this issue.
[1]: https://github.com/odoo/odoo/pull/123684closesodoo/odoo#124126
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
From 7s to 2ms for this query with 2.6M records
explain (analyze, verbose, buffers)
SELECT "hr_work_entry"."id" FROM "hr_work_entry" WHERE
(
("hr_work_entry"."active" = true) AND
(
(
("hr_work_entry"."state" in ('validated', 'draft')) AND
("hr_work_entry"."contract_id" in (548259))
)
AND
(
(
(
(("hr_work_entry"."date_start" >= '2023-05-01 00:00:00') AND (
"hr_work_entry"."date_start" < '2023-05-31 23:59:59.999999')
) AND
("hr_work_entry"."date_stop" > '2023-05-31 23:59:59.999999')
)
OR
((("hr_work_entry"."date_start" < '2023-05-01 00:00:00') AND
("hr_work_entry"."date_stop" <= '2023-05-31 23:59:59.999999')) AND
("hr_work_entry"."date_stop" > '2023-05-01 00:00:00'))
) OR
(("hr_work_entry"."date_start" < '2023-05-01 00:00:00') AND
("hr_work_entry"."date_stop" > '2023-05-01 23:59:59.999999'))
)
)
)
ORDER BY COALESCE("hr_work_entry"."conflict", false) DESC,
"hr_work_entry"."state" ,"hr_work_entry"."date_start"
;
closesodoo/odoo#124108
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this patch it was impossible to add a reified field to a
res.users list view via Studio.
The internal methods used by search_read are overwritten in res.users
to ignore reified fields.
closesodoo/odoo#123994
X-original-commit: 11e791d68256a5411d727b031930471eceaafb3f
Signed-off-by: Rémy Voet <ryv@odoo.com>
Signed-off-by: Jinane Maksoud (maji) <maji@odoo.com>
Co-authored-by: Alvaro Fuentes <afu@odoo.com>
We don't want users to edit their websites on a too small screen. To do
this, we hide the edit button when the screen width is less than 768 px
(the MD breakpoint of Bootstrap). Unfortunately, when a user creates a
new website, they go through the website configurator and are then
redirected to their new website with the edit mode enabled. We don't
want that when the screen is small. This commit only opens edit mode
after a website is created if the screen is large enough. Note that this
commit will also prevent users from forcing edit mode with the url
(enable_editor=1) when their screen is too small.
task-3316267
closesodoo/odoo#123992
X-original-commit: 00ea187ce641013feea00650cb2cadab73ebe636
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
Since [1] the pyhton discuss tests have been splitted into a
subfolder. They are wrongly immported and cannot be run at the
moment. This commit solves this issue.
[1]: https://github.com/odoo/odoo/pull/120062closesodoo/odoo#124114
X-original-commit: b796704408d0511af2c310fde5964003dc25190e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
**Before this commit**
Since [1] poppers margins computed from the style are
not taken into account.
**Additional note**
The commit [1] has been backported to 16.0 branch
right in front of this commit.
**After this commit**
This commit fixes that by taking those margins into account.
[1] b9551a50closesodoo/odoo#124113
X-original-commit: 453f38527d0d232c886daa9dc71717f678918064
Signed-off-by: Damien Abeloos (abd) <abd@odoo.com>
Signed-off-by: Bruno Boi (boi) <boi@odoo.com>
Steps to reproduce:
-------------------
- go to a task in a project;
- in the chatter, schedule an activity of type "Meeting";
- click on open calendar;
- click anywhere on the calendar view.
Issue:
------
The event title is not pre-filled.
The name of the task must be noted each time.
Solution:
---------
When it is possible to create a "Meeting" type activity,
it is sometimes useful to have the name of
the record pre-filled on the quick create dialog.
opw-3324920
closesodoo/odoo#123964
X-original-commit: 5c738ba5525833d3bd4e32f3e4e9cf00ea129427
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>
This commit improves the behavior of MCQs with one answer. Previously, when
there were multiple correct answers and any one of them was selected,
a "partial" graph was displayed instead of a "correct" graph. With this commit,
the behavior has been modified as follows:
- If the selected option is correct and has any score, the "correct" graph will
be shown.
- If the selected option is incorrect but scores are above zero, the "partial"
graph will be shown.
- If the score is zero or less and the option is not correct, the "incorrect"
graph will be shown.
Task- 3252605.
closesodoo/odoo#120629
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
In this commit we have removed quick create option from many2one_avatar_employee and many2many_avatar_employee
widget. because of There are too many faulty employees records coming from a
quick Enter press on a list.
Example:
According to my attention when we do quick create then partner is not created.
task-3343117
closesodoo/odoo#124071
X-original-commit: 001b9c8b075d012568f7ea0890ab23b6d46cbed2
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Since may 2020, M$ stopped to ship their 32 bits OS.
So, there is no need to distribute a 32 bit version anymore.
This will reduce the package size by 2.
The new package will use Python 3.10 by default, that's why the
local requirements were changed (a wheel package was missing for windows
in the previous version of PyKCS11).
closesodoo/odoo#124057
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
When a sub-menu needs to be opened in the navbar, it sometimes gets
nested within the navbar itself, making a vertical scrollbar appear
instead of floating outside the navbar, above the top of the page.
This happens if the navbar was opened in small screen sizes using the
hamburger icon, then, after a rotation, the navbar is turned into its
fully expanded version.
This commit hides the hamburger menu if the collapse toggler becomes
`display: none`.
Steps to reproduce:
- Add a sub-menu nested under the "Home" menu.
- Open the developer tools, enable mobile view.
- Select "Surface Pro 7" (Vertical 912x1368 - use "Rotate" if needed).
- Open the menu with the hamburger icon.
- Click on the "Rotate" button.
- Open the sub-menu by clicking on "Home".
=> The menu was displayed within the navbar causing a vertical scrollbar
to appear.
task-3247552
closesodoo/odoo#124046
X-original-commit: 02603d6e9f98488369ff61d31aa7f47e1bd21e6e
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
when the user removes the company_id and add a line in the purchase order
then the issue is generated.
Steps to reproduce:
- Create a new purchase order.
- Remove the company_id in the Purchase order.
- Now add a line in PO. Select a product with the consumable product type.
- Traceback will be generated.
Applying these changes will resolve this issue.
Sentry-4215579151
closesodoo/odoo#124035
X-original-commit: 75edec6f73b70c4b9b86ad67bc838f468c2574b7
Signed-off-by: Tiffany Chang <tic@odoo.com>
Steps to reproduce:
* Create an analytic account
* Create MO with Analytic Account
* Create WO on MO
* Create Time Tracking on WO
* Delete the WO
Bug:
The analytic line related to the work duration remains on the Account
Fix:
Remove the lines when the WorkOrder is deleted
opw-3174736
closesodoo/odoo#124014
X-original-commit: 59ebf21d126d9d5c93e97e6b404b23270050aa6f
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
=== ISSUE ===
If you open the lunch module with the Kanban view activated, there is
a border at the bottom of the view, which was previously used to create
a separation between two elements of different colors.
Since Milk brings a fresh new design, this border was removed on other
kanbans but not this one which makes it not consistent.
=== AFTER ===
We remove that `border-bottom` class to make the view consistent with
other kanbans.
task-3328235
part of task-3326263
closesodoo/odoo#123946
X-original-commit: 4e4846ac9c78ce6775baebf1a073bdc67164b6bb
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this commit, the `hr_holidays_tour` tour failed randomly because
a many2one was set just before a daterange, without any kind of safety
check to ensure that all values are input sequentially.
When an update occurs on a record in a form view, a daterange will force
its inputs to be set to the record values. This is done to keep track of
onchanges and to ensure that the field is displaying the proper values.
The issue arises when the tour inputs the daterange values JUST BEFORE
the many2one value is actually committed and updates the daterange
field, in which case the tour values are lost before the daterange could
send an update to the record.
This fix adds proper safety checks in that tour to properly await for
the many2one value to be set before setting the daterange values.
closesodoo/odoo#123852
X-original-commit: 4abb28fb29a9bda6727fb3d04d5b0a017b99e123
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Prior to this commit, when a tour uses `getClientActionUrl` or
`registerWebsitePreviewTour` (which uses `getClientActionUrl`) but would
not define a `path` or a `URL` parameter, the function would add an
"undefined" string as the value of the path parameter of the generated
URL.
It is obviously wrong as this would lead to a `/undefined` page in the
iframe which is, in most cases, a 404.
There is at least one instance of this causing the tour to go on a 404
page which was introduced by [1], however, fixing the util makes more
sense as website preview has a default path.
This commit fixes that by checking if a path is defined in the
`getClientActionUrl` function.
[1]: https://github.com/odoo/odoo/commit/9fd5d25f59578abc9c608578a7d2e2953880b582closesodoo/odoo#124063
X-original-commit: d69fac674d128f8ef47c096d63db653012f2d1fa
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
During upgrading the chart template will try to create
xmlid to existing records to avoid duplicate journal codes.
but there are some existing code journal which was inactive
and it was not unlinked so need to search for archived journal
too.
```
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "account_journal_code_company_uniq"
DETAIL: Key (company_id, code)=(1, EXCH) already exists.
```
closesodoo/odoo#124022
X-original-commit: 7264e664f5a665cea3cd4e9d4f40214c51442080
Signed-off-by: William André (wan) <wan@odoo.com>
After https://github.com/odoo/odoo/pull/120070, pos is no longer loading the
assets of `barcodes_gs1_nomenclature`. We should, however, load them because pos
is dependent on the said addon thru `stock`.
And since pos no longer loads the legacy `web.core` module, we also need to
adapt the barcode_parser.js override to use a more modern module in importing
`_lt`.
closesodoo/odoo#123977
X-original-commit: 00c5a3171bceed6f84e76ca4819d20d0ef61bcc1
Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
This commit adds a test to make sure allday recurring events have correct dates.
task-3327004
closesodoo/odoo#123442
X-original-commit: ad0c6052d87e35128aabc3a2716dbbae4bc4ce36
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Before this commit, all instantiated events were reset to the initial start date
when quick-creating an allday recurring event. Now, each instantiated event
keeps the correct start date.
The problem occurred because start_date and stop_date values are included in the
context when quick-creating an event.
task-3327004
X-original-commit: 393251bf2b20b3fd150e60726d455749a1b0af36
Part-of: odoo/odoo#123442
Sharing content by email as portal is not working and raises an AccessRecord
because we are trying to access the "email_formatted" field of the company.
This is solved by adding 'compute_sudo' to the computed field.
Indeed, we want portal users to be able to read the email address of the
company while they cannot access res.partner records.
A tour has been adapted to ensure this behavior.
Task-3349132
closesodoo/odoo#124036
X-original-commit: a37cea5af70728106445eac8dc0ccf7a95054501
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
During `to_inline` process, the document will be transformed to be email friendly.
This can add some `<!-- mso -->` comment into the document.
These comments nodes will create issues during future edition,
if we keep them in the editable.
So we add a sanitize step to remove all comments nodes.
task-3222474
closesodoo/odoo#124020
X-original-commit: b85a29d9ba36aaaa90e514ba45d1054b693a26e2
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Geelen Sébastien (sge) <sge@odoo.com>
Reorganize the urgent save steps to call `_toInline` before the urgent `updateValue`.
This will give a chance to the _toInline to finish before the `updateValue`
if no asynchronous process is triggered during the inlining process.
In case we have some async stuff that delay the `_toInline` completion,
we keep the second `updateValue` which will wait for the asynchronous completion, as before.
task-3222474
X-original-commit: 85540a58a58b5f60b587697490fe837b3e4a69ec
Part-of: odoo/odoo#124020
Column (from bootstrap css) are broken during toInline conversion,
so we remove them from the commands in inlineStyle context.
During inlining of the document,
the css of bootstrap columns ( width, margin, padding, ...) is embeded
and hadcoded in the `style=""` property of the column div element.
After such a process, the edition system cannot work with these column anymore :
It cannot, for example, affect the number of column or remove a column via the powerBox.
If we leave those commands available,
after inlining, the column commands will always work as if there is no column present
at the current location in the document.
For example : Instead of changing the number of column, the user will
create a new set of columns inside a previously inlined column.
task-3222474
X-original-commit: caf4bbe153557249679e0eab2cdb90f9e04708f3
Part-of: odoo/odoo#124020
Avoid inlining the content of html_field during blur
to ensure we don't break edition.
Blur occurred when opening dynamic placeholder popup or media modal.
If, during those process, we inline the document content,
the Editor will lose the reference to the current caret position inside the document.
Because Elements where overridden or changed by the `toInline` function.
If the editor cannot put the caret back in the previous correct position,
it will put it back at the end of the document.
And thus inserting the dynamicPlaceholder or new media element
at the wrong place inside the document.
task-3222474
X-original-commit: 28efe94a08d2747936ac4aa78f1d9e53545ee8b2
Part-of: odoo/odoo#124020
luvi