Commit Graph
155245 Commits
Author SHA1 Message Date
Victor FeyensandValentin Vallaeys 1deb7ee2ce [FIX] sale_product_configurator: quantity input style
Task-3008022

X-original-commit: 855238bde2e261cc76ce52fd7c4545c0ae97e557
Part-of: odoo/odoo#102731
Co-authored-by: Valentin Vallaeys <vava@odoo.com>
2022-10-09 22:03:50 +02:00
Victor Feyens 4eeadbc6c2 [FIX] sale: keep product external button on order lines
X-original-commit: f09af5332487a9e579cc7243ecabd87461c2d97f
Part-of: odoo/odoo#102731
2022-10-09 22:03:50 +02:00
Denis Ledoux 94e05f9eed [IMP] base, web: do not set on_change="1" on most views
Only kanban, tree and form implements onchanges.
Therefore, on calendar, graph, pivot, ..., putting `on_change="1"`
is useless and is a waste of resources and KB.

e.g. CRM lead pivot view

Before:
```xml
<pivot string="Pipeline Analysis" sample="1">
    <field name="create_date" interval="month" type="row"/>
    <field name="stage_id" type="col" on_change="1"/>
    <field name="expected_revenue" type="measure"/>
    <field name="color" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="automated_probability" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="message_bounce" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="probability" on_change="1" modifiers="{&quot;invisible&quot;: true}"/>
</pivot>
```

After:
```xml
<pivot string="Pipeline Analysis" sample="1">
    <field name="create_date" interval="month" type="row"/>
    <field name="stage_id" type="col"/>
    <field name="expected_revenue" type="measure"/>
    <field name="color" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="automated_probability" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="message_bounce" modifiers="{&quot;invisible&quot;: true}"/>
    <field name="probability" modifiers="{&quot;invisible&quot;: true}"/>
</pivot>
```

I would have like something smarter, like using the `editable` concept
for instance, but it's not that easy.
e.g. kanban is not considered as editable, while it does support
onchanges when grouping record by a field and drag and dropping
record from one column to another.
However, if we change the kanban view to make it editable,
the view validation will start validating the fields domain:
https://github.com/odoo/odoo/blob/45d4ac14f65c53dcde56592715d50169bde116ad/odoo/addons/base/models/ir_ui_view.py#L1439-L1442
causing issues:
- If a field used in the domain is not in the view, it will need to be
  added in the view,
- while it will not be used, as you cannot do a search in related fields
  in kanban views anyway.
e.g.
```
odoo.tools.convert.ParseError: while parsing /data/build/odoo/addons/analytic/views/analytic_line_views.xml:120
Error while validating view near:
<kanban class="o_kanban_mobile" __validate__="1">
                <field name="date"/>
                <field name="name"/>
Field 'company_id' used in domain of field 'account_id' ([('company_id', 'in', [company_id, False])]) must be present in view but is missing.
```

In addition, the kanban doesn't need the readonly and required
attributes on the field nodes, as other editable views (tree and forms)
do.

In addition, the tree list is currently considered as "editable" only
when it has `editable="bottom" or `editable="top"`, while
a tree without this editable attribute can still trigger onchange,
for instance when using `widget="handle"` or `widget="boolean_toggle"`.
We should therefore making the tree list editable whatever the case,
leading to the same issues than listed for the kanban above,
or make an exception for field in non-editable tree views using a
widget..

So, as the smarter way seems difficult and risky, for a limited gain
I choose the easy way by separating the concept "editable" and
"onchange-able" and to not set `on_change="1"` on views not considered
as "onchange-able".

closes odoo/odoo#102788

X-original-commit: aeb65ee536b1611c1cb829c91906f327f8e331c7
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
2022-10-09 21:07:47 +02:00
Nicolas (vin) 1561747629 [FIX] account: avoid receivable accounts on bank journals
You cannot set a receivable or payable account as a bank account of
a bank journal directly, but it is very possible to just set an
account of another type, then change the type of this account to
receivable.
This new constrains will make sure that you cannot change the type of
an account.account set as bank account on a bank journal to any of those
two types.

closes odoo/odoo#102790

X-original-commit: f9500ca4c898cd86681cc2e48ec2c66cf5670917
Related: odoo/enterprise#32579
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Nicolas Viseur <vin@odoo.com>
2022-10-09 19:49:53 +02:00
Nicolas (vin) d765b0301e [FIX] account: fix resequence form view
The resequence form view css has been broken, this aims to restore
it as it was in previous versions

X-original-commit: aa1fc47cc52b7ae51fb66ba077eb8b2691d0dbff
Part-of: odoo/odoo#102790
2022-10-09 19:49:53 +02:00
Romain Derie c996f785f1 [FIX] website_sale: restore community ecommerce dashboard
Since [1] the community ecommerce dashboard was not rendered anymore.
This is because a `t-name` was combined with a `t-extend`.
This is unsure why but since `t-extend` is deprecated anyway, we replace
it by `t-inherit`.

Note that for some reason, it was then causing an issue in
website_sale_dashboard which inherit from this website_sale template.
The template would not be found anymore.

Indeed, if the inherit mode is extension, a template has to inherit the
base one of the inherit hierarchy and not the one he wants to inherit..

```xml
<!-- module A -->
<template t-name="A.template"/>
<!-- module B -->
<template t-name="B.template" t-inherit="A.template" t-inherit-mode="extension"/>
<!-- module C -->
<template t-name="C.template" t-inherit="A.template" t-inherit-mode="extension"/>
```

This part is adapted in the enterprise related PR.

[1]: https://github.com/odoo/odoo/commit/dcf79f01b33a4f3ddb7e77480f0a7a8be1cd3794

task-2993773

closes odoo/odoo#102782

X-original-commit: 85905934c2ad2507cfc6f74428db61ac97a3bc41
Related: odoo/enterprise#32578
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2022-10-09 19:49:47 +02:00
Benoit Socias cb81b5ef93 [FIX] website, website_sale: repair Plausible dashboard layout
This commit includes several changes in the Plausible dashboard:
- Remove the "Analytics" title.
- Add margins (container-fluid => container).
  This also fixes the country map overflow and the flickering.
- Remove the duplicated scrollbars.
- Use the background colors from within the iframe.
- Hide the date range buttons by default, but show them if website_sale
  is installed.

It also reorders the Reporting menu as follows:
- Analytics
- eCommerce
- Online Sales
- Visitors
- Page Views

task-2993773

X-original-commit: b8c1976e933628182496929d348dda11b5051a0c
Part-of: odoo/odoo#102782
2022-10-09 19:49:47 +02:00
qsm-odoo 2ae4e64341 [FIX] web_editor: restore overlay position computation
While working in the current state of the website configuration, the
overlay computation was not working anymore in case the scrollbar is
moved out of the wrapwrap. Indeed, in that case, the position was wrong
by the amount of the page scrolling.

While we could include that scrolling value in the equation, this commit
chooses to restore the way it worked before the "website-in-backend"
merge at [1]: making the overlay be naturally positioned according to
the page scrolling wherever the scrollbar is. To do that, the overlay
had to be moved inside the content (the website iframe) which has the
disadvantage of risking the overlay design being broken by a theme. This
solution was chosen as it simplifies the code, and potentially allows
for performance improvements in the future: not forcing a position
recompute after each scroll (the animation should already be smoother /
more performant this way). This will actually be needed for another fix
/ improvement: the background image overlay has to be in the iframe too.

Note: a further commit will move back the scrollbar behavior out of the
`#wrapwrap`, this is thus especially needed.

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

closes odoo/odoo#102785

X-original-commit: 872bb20b3ac08cf82613e15e6634a2e7593ccf7a
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-09 18:52:49 +02:00
qsm-odoo d134987f21 [FIX] web: make smooth scrolling during drag&drop work with BS5
Since BS5, the <html> receive the 'smooth' CSS value for the
'scroll-behavior' property. As the name indicates, it makes scrolling
smooth (on click on anchor link for example) instead of an instant
jump (although the exact behavior is left to the browser).

The problem is that this auto-smooth from the browser conflicts with
the "smooth drag and drop" code (at least if the scrolling target is
actually the `<html>` element which is never the case currently). Indeed
this code expects to make small instant jump depending on the position
of the user cursor. This commit solves the problem by disabling the
browser auto smooth for the duration of the drag and drop.

Note: a further commit will move back the scrollbar behavior out of the
`#wrapwrap`, this is thus especially needed.

Note: this bug fix could be back-ported, should the need arise (custo
might want to use the 'smooth' 'scroll-behavior' in stable without BS5).
Although the only side effect is slower smooth drag and drop.

X-original-commit: 81ed9bee81bacca7b55598e9af7cac51cd7805cf
Part-of: odoo/odoo#102785
2022-10-09 18:52:49 +02:00
qsm-odoo 0783f7ca71 [FIX] web: properly handle smooth drag and drop for iframe normal scroll
The smooth drag and drop in edit mode (over the website iframe)
currently works correctly. This would not be the case if the scroll was
not on the `#wrapwrap` but left to the `<html>` element. Indeed, special
code handles that case, but that code is actually not needed in case
what is being dragged is outside an iframe and that the smooth
scrolling is performed inside that iframe.

Note: a further commit will move back the scrollbar behavior out of the
`#wrapwrap`, this is thus especially needed.

X-original-commit: 4947ef118c646171fd3358135dcab8f63efa04d2
Part-of: odoo/odoo#102785
2022-10-09 18:52:49 +02:00
qsm-odoo 5d7097d149 [FIX] website: remove duplicated table edition UI on the website side
An option to edit tables via a specialized overlay was made with [1] for
the backend edition of HTML fields. It was indirectly added for the
website builder where an UI to do that already exists (in the editor
panel). It is actually a problem because of the way it was implemented:

- Rely on the fact this is not the `<html>` which scrolls (which cannot
  be considered necessarily true and won't be true by default in a
  future update).

- Use 'visibility' property instead of 'display' to hide the UI making
  the UI participate in the rendering of the page at all times (and when
  the `<html>` scrolls actually shows a white bar at the bottom of the
  website page).

It was decided we do not want this UI on the website side. This commit
takes the easy road: just force the fact it is hidden. Indeed, not
instantiating it comes with a bunch of problems as the related code is
spread throughout the editor code. A better implementation will follow.

Note: a further commit will move back the scrollbar behavior out of the
`#wrapwrap`, this is thus especially needed.

[1]: https://github.com/odoo/odoo/commit/7a64a04421171469c58bb94bbe8c55b1e2fdf3f2

X-original-commit: 8c1a719674315eadb6d8f6c925cc4303227fad67
Part-of: odoo/odoo#102785
2022-10-09 18:52:48 +02:00
qsm-odoo 0803163c3c [IMP] website: simplify useless multi-document/window in widgets
With [1] (and some others before), much code was adapted so that it
works in the new system where the website is displayed in an iframe and
the editor around it (see [2]). Some public widgets code was adapted for
no reason though and although correct it's confusing and can be
simplified to not be confused with snippet options code.

[1]: https://github.com/odoo/odoo/commit/03c552690b15cbf2e7d6b7812386ac64042219af
[2]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

X-original-commit: 49e60152995e2739219909536061e376ad00747e
Part-of: odoo/odoo#102785
2022-10-09 18:52:48 +02:00
qsm-odoo 09ef0e4663 [FIX] web: make scroll utils properly work with website iframe action
The `scrollTo` method and related utils (jQuery animate, ...) were not
properly adapted to work in the context of multiple documents. E.g. the
website editor code (outside the website iframe) is calling the
`scrollTo` util to scroll to added snippet elements (inside the website
iframe). In that case, the util was performing some searches in the DOM
outside of the website iframe while it was meant to be done inside. The
result was that the scroll was not considering the website fixed navbar
and scrolled "too far".

Another bug is visible only when the scrollbar is left to be the natural
browser one (not on the `#wrapwrap`). In that case, the `scrollTo` util
simply had no effect anymore as the `animate` override of jQuery was not
adapted.

Note: a further commit will move back the scrollbar behavior out of the
`#wrapwrap`, this is thus especially needed.

X-original-commit: ab417de98068afaaa12995726c7c6445f075ca4f
Part-of: odoo/odoo#102785
2022-10-09 18:52:48 +02:00
qsm-odoo e54ade4ca5 [IMP] web: allow dom util of getScrollingElement to use document param
X-original-commit: a77e9984e59e1624ee198647005da3039eea42e1
Part-of: odoo/odoo#102785
2022-10-09 18:52:47 +02:00
Damien Bouvy b903a355f7 [FIX] base: update reifed view for users with new grid form
Replace some layout magic with some layout determinism; in particular,
the view attempted to have a 4 column layout which is not well supported
in grid form views.

This commit instead create a "normal" structure (outer group > inner
group) for "boolean" group access (e.g. 'Extra Rights' or 'Technical'
sections of the user form access groups, whilst in debug mode).

closes odoo/odoo#102789

X-original-commit: fd854e87d8a138052302afbd3da486f41102c695
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2022-10-09 16:34:51 +02:00
Nicolas (vin) 94beb218ea [FIX] account: do not allow to create a country in the settings
The fiscal country field could be used to create a new res country or
open the form view and allow to change things such as the country code.
This is obviously an issue and shouldn't be allowed.

closes odoo/odoo#102708

X-original-commit: 0881199fba43e01d6d7613eff00549eac5827480
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Nicolas Viseur <vin@odoo.com>
2022-10-09 16:34:42 +02:00
Romain Derie f7ab908abf [FIX] website_sale: land on website in backend when previewing INV or SO
The invoices and sale orders got a button "Preview" to reach their
frontend/website page. One of the goal is to then be able to enter edit
mode and customize it.
But since we merged frontend > backend with [1] (and multiple iterations
since then), landing on the frontend is not a good idea to do that as
you would then need to click on the "Editor" button to go back to the
backend and be able to enter edit mode. Now we reach the iframe preview
directly.

Note: this will be improved in a further update to not require a reload
of the backend when clicking on the button.

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

closes odoo/odoo#102787

X-original-commit: 007ae49e9c94061adf34aa9f911c7a9a0e873e0e
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2022-10-09 15:40:49 +02:00
Romain Derie e216399b91 [FIX] sale_quotation_builder: land on website in backend when editing
The quotation templates got a button to design them, which lands on
their website/frontend preview.
The goal is to then be able to enter edit mode and customize it.
But since we merged frontend > backend with [1] (and multiple iterations
since then), landing on the frontend is not a good idea to do that as
you would then need to click on the "Editor" button to go back to the
backend and be able to enter edit mode. Now we reach the iframe preview
directly.

Note: this will be improved in a further update to not require a reload
of the backend when clicking on the button.

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

X-original-commit: a98ea96b52f6ccfd43e364720001ed4c4bcbcb4e
Part-of: odoo/odoo#102787
2022-10-09 15:40:49 +02:00
Pierre Rousseau 590957106b [FIX] spreadsheet: rename conflicting getter
closes odoo/odoo#102706

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
2022-10-09 11:49:58 +02:00
Pierre Rousseau c9022c7494 [IMP] spreadsheet: update o_spreadsheet to latest version
### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/35585379 [IMP] readme: re-introduce o-spreadsheet nick name
https://github.com/odoo/o-spreadsheet/commit/f81baa40 [IMP] spreadsheet: Add data filters
https://github.com/odoo/o-spreadsheet/commit/7851fffc [FIX] tests: fix non-deterministic helper
https://github.com/odoo/o-spreadsheet/commit/d3106bca [FIX] scorecard: resize text while figure is resized
https://github.com/odoo/o-spreadsheet/commit/1e7ee52d [FIX] model: don't translate technical error message
https://github.com/odoo/o-spreadsheet/commit/7088a9a1 [FIX] Chart Panel: Chart title is updated when typing
https://github.com/odoo/o-spreadsheet/commit/900c1b60 [FIX] automatic_sum: evaluated date blocks automatic sum
https://github.com/odoo/o-spreadsheet/commit/4dbac05c [ADD] Copyright, license
https://github.com/odoo/o-spreadsheet/commit/3de57000 [IMP] documentation and readme
https://github.com/odoo/o-spreadsheet/commit/6efe8064 [DOC] Rebuild documentation

Part-of: odoo/odoo#102706
2022-10-09 11:49:58 +02:00
Joseph Caburnay 998914d29f [FIX] web: lighter hover highlight
closes odoo/odoo#102751

X-original-commit: 1d4145dfda1f8a95c3f386ae01fb0e29ddd4be48
Signed-off-by: Géry Debongnie <ged@odoo.com>
2022-10-09 10:08:56 +02:00
Antoine Vandevenne (anv) 4aebe16d56 [CLN] payment: update docstrings for Sphinx's autodoc
task-2804999

closes odoo/odoo#102716

X-original-commit: 5800c773184dce836a0fc3b67189ec6a14124178
Related: odoo/documentation#2797
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2022-10-09 09:11:43 +02:00
Julien Van Roy f1120ca254 [FIX] account_edi_ubl_cii: fix import facturx
Factur-x import is broken since: 4ea13aea05b1d9650a2c9605d24ac7d69583cefa
Indeed, for non FR/DE companies, the `_get_xml_builder` is now returning
None, thus the import `_create_invoice_from_xml_tree` and
`_update_invoice_from_xml_tree` do not work.

closes odoo/odoo#102777

X-original-commit: 6eb6662b53a521adda0588d05f316652b66e758b
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
2022-10-08 19:55:59 +02:00
Damien Bouvy 906bc28737 [IMP] web: make inline numeric fields a reasonable size
Inline fields for numeric and date values shouldn't be as wide,
since they tend to be 'close by' another field (e.g. currency,
periodicity, etc.) in the same 'row' or included in a text zone - in
which case we want the value to be closer to its context, and not
completely isolated in a huge area.

closes odoo/odoo#102775

X-original-commit: 5f5729f8ba79c7919774021310208d41cb8ddb56
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2022-10-08 19:55:57 +02:00
Lucas Perais c93eb01ec4 [FIX] web: form: no "oh snap" dialog on error in dialog
Have a form view in a dialog (action in target=new)
The create/write of that model throws an error.

Before this commit, the "Oh snap!" dialog was displayed, but makes little sense
in a dialog.

After this commit, the old UserError dialog is displayed.

closes odoo/odoo#102764

X-original-commit: d36f1708219f63fae5a86b6c1e81b328ca96b347
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2022-10-08 18:57:13 +02:00
FrancoisGe 943e672d35 [FIX] web: discard invalid row in list view
Before this commit, in a list view, if you clicked the discard button
for an invalid row, it would not be discarded and the discard button
would disappear.

Why did this happen?
Invalid fields in the record were not deleted.

How to reproduce?
- Go to a list view with a required char field
- Edit the char field of a record with an empty string
- Click outside the record (it becomes invalid)
- Click on the discard button

Before this commit:
The record is not discarded (its values do not change and it remains
in edit mode) and the discard button disappears

After this commit:
The record is correctly discarded and the discard button disappears

closes odoo/odoo#102763

X-original-commit: 73ba2217ec56819ff979020a43d0c13f8ff0b697
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2022-10-08 18:57:10 +02:00
Younn Olivier 35789f9ab4 [FIX] payment: open redirection in top window
When [1] was merged, it did not adapt correctly external providers
redirections. As now the /shop pages can be viewed inside an iframe, the
external redirections must be opened in the top window.

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

task-2687506

closes odoo/odoo#102723

X-original-commit: 3a32b9e1efa6277b345dc9239334680651690df7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-08 18:57:08 +02:00
Arnold Moyaux 5dd70ed8b6 [IMP] stock: quantity done on stock.move is always editable
Quantity done will be always editable. Different use case:
1. If there is not location/package/tracing/owner -> same behavior than
  before
2. If the details are needed:
- Immediate transfer. In case of increase the quants are reserved and the
`qty_done` on `stock.move.line` is increased depending the reservation.
If the quantity couldn't be fully reserve then default `stock.move.line`
are create (depending the putaway rules or multiple ones if the products
are tracked). In case of decrease, the quantity reserved are unreserve
but the `stock.move.line` are not unlink until the validation.
- Planned transfer. The quantity done will fill the reservation. If the
picking is not assign, it will reserve the quantity needed. In case of
decrease, it will only unreserve the extra quantity (compare to the
initial demand). To unreserve the quantity bellow the intial demand, the
`stock.move.line` could be unlink or use the `unreserve` button.

force_qty in `_action_assign` is needed because we don't reserve only
base on the initial demand (`product_uom_qty`) but sometimes on the
quantity_done.

In order to never block the user. The action_show_details is always
available. If the id is not available, it will save and open the record
(we take the record based on the new existing line with same product
and highest id).

closes odoo/odoo#102738

Task-id: 2960983
X-original-commit: cacc677a08066bc23e1c89df36027599d05f2a08
Related: odoo/enterprise#32555
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2022-10-08 18:00:19 +02:00
Julien Van Roy 3034f1d0db [FIX] l10n_fr: clean Tax Groups, CoA, Taxes, Fiscal Positions, Tax report
This commit cleans the tax groups:
- it removes the negative tax groups
- it makes sure that there is only one tax group per tax rate
- all the taxes with the same rates are attached to a single tax group

This commit splits the taxes to make the distinction between the goods and services.
In addition, the fiscal positions are also updated accordingly (make sure to map to another
one having the same scope: goods/services and type: sale/purchase).

These changes are based on the reliable feedback of LPDE (Didier Six). No tax were removed
from the old version. Only some were split, the others were kept (but modified).

In addition, the tax report is updated to the 2022 version and the new tax report lines
are linked to the taxes.

task-2674047

closes odoo/odoo#102749

X-original-commit: a4c5171e1a79242bba201affba9d94bb9e137e94
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
2022-10-08 17:02:51 +02:00
Brice bib Bartoletti ed1a35b3f8 [FIX] l10n_eu_oss: fix l10n_es test skipping
The aim of this commit is to improve the test skipping code of the oss modules
by avoiding to hardcode the chart_template_ref (xml_id) directly in the error
message.

Before this commit:
The TestOSSSpain test class was failing when the l10n_es module wasn't
installed instead of being skipped.

After this commit:
The TestOSSSpain test class is correctly skipped instead of failing.

closes odoo/odoo#102770

X-original-commit: c8018174c483183f95cda2bd805eb003e2ab90f5
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Brice Bartoletti <bib@odoo.com>
2022-10-08 15:20:55 +02:00
Jensi Chovatiya ca913fe69a [FIX] project: fix the avatar on task quick create
Before this commit,  project task kanban quick create does not
display the avatar on user_ids due to m2m tags widget.

so in this commit, replace the many2many_tags widget with many2many_avatar_user.

task-2871552

closes odoo/odoo#102771

X-original-commit: 02226e70f0367033e279e937dc439422ef8956f5
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
2022-10-08 14:22:43 +02:00
Barad Mahendra 6b82a26803 [IMP] project: add form view to Send SMS Text Message action
task-3000758

closes odoo/odoo#102768

X-original-commit: 89f920b112e0b9e87ceed329becb6838788f4c11
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
2022-10-08 13:30:24 +02:00
Pratik Awasthi 8918e5a2c4 [FIX] project: remove duplicate recurring_task field from task form view
task-3000758

X-original-commit: 80487dc6d505fcc3fc4e141648ce2a91f133f8c7
Part-of: odoo/odoo#102768
2022-10-08 13:30:23 +02:00
Pratik Awasthi 142b1d45f2 [FIX] project: fix list view of task analysis
Before this Commit, project > reporting > tasks analysis > drill down the
graph/pivot view > list view was editable and allowed creation of new records

After this Commit,  project > reporting > tasks analysis > drill down the
graph/pivot view > list view is not editable and does not allow creating
new records.

task-3000758

X-original-commit: ff2bed424064ef5cf049ae8ad0d47f65d33bf5b9
Part-of: odoo/odoo#102768
2022-10-08 13:30:23 +02:00
Pratik Awasthi cdd38f770a [FIX] hr_expense: fix subtotal for journal items
Steps:
Create a expense with product having no cost and having the
total amount directly added from expense sheet.
then create an innvoice.

Issue:
While adding journal lines in hr expense the amount per unit
was calculated as the total amount of product such as quantity into the
price per unit inside the invoice.

Cause:
expense's total_amount was passed as price_unit instead of expense's unit_amount
and due to that total amount was multiply by qty so wrong value was passed.

Fix:
If unit_amount of product is non-zero then pass the unit amoun for invoice or
pass the total_amount if unit_amount does not exist.

task-3000758

X-original-commit: d47ca52a2cb8eb7146094e7d172f41f6aa3621a2
Part-of: odoo/odoo#102768
2022-10-08 13:30:23 +02:00
Simon Genin (ges)andJulien Mougenot 8d535edd9f [IMP] web: add edge scrolling behavior to useMakeDraggableHook
In house implementation of automatic scoll when dragging an element to
the edges of its container.

closes odoo/odoo#102756

X-original-commit: 290a6213a6e36fc2e5d11216b59a6aaf79554196
Related: odoo/enterprise#32568
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
Co-authored-by: Julien Mougenot (jum) <jum@odoo.com>
Co-authored-by: Simon Genin (ges) <ges@odoo.com>
2022-10-08 13:30:07 +02:00
Simon Genin (ges) 2e8d9cdf18 [FIX] web,*: fix kanban useSortable screen width limit
Reproduce:
Go on a kanban view, with enough columns so it goes off the screens.
Scroll on the right, try to drag anything beyond the original (before
scrolling) limit of the screen. The cards are stuck floating at that
limit. Note it didn't prevent the drop to work properly where the mouse
was.

Issue:
The useSortable hook gets an owl ref, which is used as a limit to where
things can be dragged and dropped. Originaly and logically, it was the
current component ref, the renderer. But for some unknown reason, this
space was not getting wider than the initial screen size. It may be a
problem with the flexbox layout.

Tried solutions:
- A first solution was to add the overflow-x-scroll css property to the
renderer. It works, but now the horizontal scroll bar is no longer
always visible. You have to scroll all the way down to see it. UX wise
this is not acceptable.

- We could remove the clamp mecanism inside useSortable to let the drag
and drop motion go anywhere. This works, but decrease the quality of the
interaction. It looks cheap and not polished.

Final Solution
Finally, we decided to pass a ref to the o_content div from the layout
component down to the kanban renderer. If the useSortable is given this
ref, it works as intended. While it may seem too much, it is not
unreasonable to propose a reference to the most parent element of the
view contents to the renderer.

X-original-commit: a569305acaa1c812ede739c267e2e9530945f65f
Part-of: odoo/odoo#102756
2022-10-08 13:30:07 +02:00
Pierre Paridans 81defa2804 [FIX] web: ListView footer columns with optional field
This commit fixes the number of cells created in the ListView's footer
when the optional field's button is present.

Steps to reproduce:
- Open Accounting > Customer Invoices
- Switch to ListView
=> the footer (containing totals) has one less cell

closes odoo/odoo#102222

Forward-port-of: odoo/odoo#101954
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
2022-10-08 13:30:04 +02:00
Pierre Paridans 1233ff1b18 [FIX] web: ListView group's pager position
This commit fixes the pager's position in a grouped ListView when the
optional field's button is present.

Steps to reproduce:
- Open Account > Intrastat Code list
- Unfold "Commodity" group
=> The group's pager is misplaced

Forward-port-of: odoo/odoo#101954
Part-of: odoo/odoo#102222
2022-10-08 13:30:03 +02:00
Romain Estievenart dd4f5eb44c [FIX] mail: restores the chatter's ability to grow in FormView
The commit odoo/odoo@babf7634e0 broke a
previous fix in odoo/odoo@6228500a3f
allowing the chatter to grow beyond its original size.

This commit restores the `flex-grow: 1` on the chatter's container but
also limit its maximum width (like in saas-15.3) to avoid it becoming
unreadable.

closes odoo/odoo#102767

X-original-commit: 3db27dc6c2e22b2b86650d1828f8e52929c43df6
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Signed-off-by: Romain Estievenart (res) <res@odoo.com>
2022-10-08 12:31:57 +02:00
Romain Estievenart 97533b6d8d [FIX] web: text overflow ellipsis appear on trash
Add missing exclusion `o_list_record_remove` class used to allow text
overflow mixin.

Steps to reproduce:

- Open the Employee app
- Plan creation
- The trash as an overflow ellipsis => bug

closes odoo/odoo#102758

X-original-commit: a2ee880237724463b90fc43df69b689b82756fe4
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Romain Estievenart (res) <res@odoo.com>
2022-10-08 12:31:55 +02:00
Romain Estievenart 151d53c40b [FIX] web: kanban state column text overlap when resize on list view
Allow `o_state_selection_cell` to have the overflow mixin to allow the
resize of the kanban state column on list view without text overlapping.

This commit follows https://github.com/odoo/odoo/commit/e22abffdc230c2ae494a85fdf7fd8d6b488be3ea

Steps to reproduce:
- Open the helpdesk app
- Click on VIP Support tickets
- Go to the list view
- Check the kanban state column and try to reduce it's size
  => The text is overlap

X-original-commit: a9f83d6d2e9f53a6a562044303c5bcb5ab5f1a9c
Part-of: odoo/odoo#102758
2022-10-08 12:31:55 +02:00
Romeo Fragomeli 13f3ed2919 [FIX] account: force One2Many List to take all space
The component `section_and_note_one2many` doesn't take all `width`
available and so in some case when there is too content or the form view
is too small the `table` overflow outside the form.
This commit forces this component to take `100%` of the `width`
available.

Steps to reproduce:
* Open Sales
* Select a Quotation
* Reduce the size (width) on the Browser => BUG

closes odoo/odoo#102743

X-original-commit: 32b0d75385889f037f574cbc515aa2895583f99e
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2022-10-08 12:31:50 +02:00
Noe Antoine b947bab7f3 [FIX] website_event_{*}: harmonize spaces over online screens
*: exhibitor, meet, track

Before, there was a weird bar above left column of the track screen,
of a different color than the one over the content column. The side
column titles were not centered and aligned with content (for small
screens) and background color was used strangely as well as the
borders.

Harmonize the small space above meeting / exhibition / tracks
online screens. Add a small space above both columns, in small screens
as well (creating space between the blocks, having different purposes)
above online screens of meetings, ehibitors and tracks. Remove css that
can be removed and replace it with bootstrap standard classes.

The spaces uses the website background color. The side column title are
centered vertically and match the titles in the main column when the
screen is small.

Task-3006773

closes odoo/odoo#102721

X-original-commit: 65e8e1b8c501cccecc675437429c9ba3f415a09e
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2022-10-08 12:31:47 +02:00
Benjamin Vray be375bb2a8 [IMP] web_editor: fix images and icons animations on mobile
Due to the 'transform: none' applied on images and icons on mobile, some
animations do not work in mobile. This commit makes an exception to this
rule for animated images/icons.

task-2984828

closes odoo/odoo#102713

X-original-commit: 78098b3db96e796ae6a09bd0f4bec1eb0c384d28
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-08 12:31:45 +02:00
Lucas Perais a672c354c4 [FIX] data_recycle: adapt form views to grid
Before this commit, the frequency fields were not aligned. This is due to the
new CSS grid system in the form views for inner groups.

This commit reorganize the arch itself to have the the relevant fields and their business
modifiers in the same cell of the inner group. It not only makes sense technically, it does so
in business terms as well.

closes odoo/odoo#102578

X-original-commit: d4118297dd6116fbd2ccefe27b09e9e4b7d5b412
Related: odoo/enterprise#32475
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2022-10-08 12:31:40 +02:00
Lucas Perais 1a61853d7d [FIX] web: InnerGroup: a row can have visible and invisible cells
Have an InnerGroup which has a first div visible all the time
and a second div conditionally invisible.

Before this commit, when the second div was invisible, the first was not
displayed.

After this commit, the two divs are displayed correctly.

X-original-commit: c69836e3c53e1efb61f66612c266a31aa9b54816
Part-of: odoo/odoo#102578
2022-10-08 12:31:40 +02:00
Lucas Perais f6e1485001 [FIX] hr_holidays: always show if no rules are set in accrual form
Go on Timeoff > Configuration > Accrual Plans

Before this commit, when no rules were set, there was no visual feedback.
This was because that feedback only appeared when the form view was in readonly,
which is virtually never the case now because of the always edit feature.

After this commit, there is the relevant visual message if no rule is set.

X-original-commit: 599554adc3883fa2742764d8f948258dee2ef89e
Part-of: odoo/odoo#102578
2022-10-08 12:31:39 +02:00
lejeune quentin a9774ca9cb [FIX] pos_adyen: Fix Adyen abort function
Currently the "abort" function in the pos_adyen module did not include
all the information necessary to cancel the current payment.
With this commit this information is added and the status is correctly
returned to the JS in order to have the correct status on the payline

https://docs.adyen.com/point-of-sale/cancel-a-transaction#cancel-from-register

closes odoo/odoo#102747

X-original-commit: 897e9ed1ae5b828017b0cff02281685e757d5e14
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Signed-off-by: Masereel Pierre <pim@odoo.com>
2022-10-08 11:35:16 +02:00
Samuel Degueldre 94f81ed41d [FIX] base: fix sourcemap header offset
in b1d57adf6ff3 the size of the header added to source files while
concatenating them was reduced, but the corresponding offset use when
generating source maps was not adapted, causing source maps to drift
further and further from the actual source location the further in the
compiled asset the line is.

This commit fixes that by decrementing the header offset as needed.

closes odoo/odoo#102651

X-original-commit: 4d4585ee6c905c2a3adc4692098c1a3544417629
Signed-off-by: Géry Debongnie <ged@odoo.com>
Signed-off-by: Samuel Degueldre <sad@odoo.com>
2022-10-08 11:35:14 +02:00