Commit Graph
127334 Commits
Author SHA1 Message Date
Nicolas Seinlet 0855f94181 [FIX] website_crm_partner_assign: force date format as format is forced in XML
https://github.com/odoo/odoo/blame/saas-12.3/addons/website_crm_partner_assign/views/website_crm_partner_assign_templates.xml#L674

closes odoo/odoo#35697

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-13 14:02:48 +00:00
Kevin Baptiste 0b25547fc6 [IMP] hr_holidays: add domain on active time off
Add a domain to only count active holiday allocations on the employee's
profile.

TaskID: 2048672

closes odoo/odoo#35547

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-08 06:43:24 +00:00
Laurent Smet 68a13c99fd [FIX] account: Fix taxes computation for intracomm
Suppose an amount of 1000 with tax 21% having +100%, -100% as repartition:
In that case, the condition preventing a rounding issue must be ignored because
the sum of factors is 0%, not 100%

closes odoo/odoo#35681

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-08-13 09:37:00 +00:00
RomainLibert 499d3efa7c [FIX] l10n_ae: remove tag_ids
closes odoo/odoo#35652

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-08-12 12:41:16 +00:00
Robin Heinz 95c8e55232 [FIX] point_of_sale: wrong pricelist price on receipt
Before this fix, we had the wrong origin price when we were using
pricelist not showing discount and additionnal discount. The price was
the main one of the product instead of the price with pricelist applied.

Task-Id: 2025886

closes odoo/odoo#35644

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-12 11:00:10 +00:00
Laurent Smet e0d18f222e [FIX] account: Fix compute_all of taxes when dealing with refunds
closes odoo/odoo#35608

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-08-12 06:46:20 +00:00
mcm-odoo 319f07743e [FIX] website_slides_forum: add link to "home" forum
This commit adds a link to go to the "home" forum to "Forum" tab in question
page.

Task 2026846

closes odoo/odoo#35637

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-12 09:58:14 +00:00
mcm-odoo 85e8de1dc8 [FIX] website_{portal, rating, slides): fix navigation tabs color
Text colors were white on a white background which can be difficult to read
in some extreme cases. Sort of.

Task 2026846
2019-08-12 09:57:12 +00:00
Jinal PatelandMohammed Shekha f0fdfbf44e [FIX] web: add support for TRUE_LEAF and FALSE_LEAF in ModelFieldSelector
before this commit, domain selector widget does not support
TRUE_LEAF and FALSE_LEAF i.e. [(1, '=', 1)] and [(0, '=', 1)] respectively,
the reason is the chain part of the domain i.e. field name has value 1/0 and
we don't have field name like 1 and 0 in domain and hence ModelFieldSelector
don't accept it

after this commit, domain selector can handle this special two domains which is
[(1, '=', 1)] and [(0, '=', 1)], add support for chain with 1/0 in ModelFieldSelector

task- 1998145

closes odoo/odoo#35603

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>


Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-08-09 12:32:27 +00:00
Alexandre Kühn a72b23f6b5 [FIX] mail: register thread window after append in DOM
Before this commit, we may have the following error:

`TypeError: Cannot read property 'html' of undefined`

This happened in the following scenario:

Terminology:
- in multi-tab environment, there is a master tab and slave tabs
- master tab fetches notifications from the server and forwards them
to slave tabs

State:
- 2 logged-in users: Michell & Marc
- Mitchell has open 2 browser tabs
- Mitchell has a pinned private conversation with Marc

Steps:
- Mitchell has focus on a slave tab
- Marc posts several messages to Mitchell in very quick succession

=> Mitchell gets crash error above.

This issue is caused by chat window being registered in mail manager
while it has not been mounted to DOM. On receiving 2nd new message,
it has to re-render chat window header in order to update displayed
unread counter. However, this fails due to chat window having no DOM
node yet.

This commit solves the issue by mounting chat window to DOM before
being registered in mail manager. That way, on receiving 2nd new
message, it does not trigger a re-render on chat window that
is about to be mounted to DOM, since it has not been registered yet.
Note that the displayed unread counter will be correct, because it
uses the up-to-date unread counter on mount.

Task-ID 2050108

closes odoo/odoo#35601

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-08-12 08:31:15 +00:00
Odoo Translation Bot 452a4497c1 [I18N] Update translation terms from Transifex 2019-08-11 06:07:52 +02:00
Ankita Raval 6e5186c8f9 [FIX] point_of_sale: chatter is broken in pos session
The chatter was not displayed correctly on the pos session because of
missing fields in the view. We've added those missing fields.

TASK-ID: 2030754

closes odoo/odoo#34651

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-09 15:15:07 +00:00
wan d1fab53f07 [FIX] account: group payment
The commit https://github.com/odoo/odoo/pull/32198/commits/c9ec53b4e2373c08d944aac3a6bff2519cb5b13e removed the ability to make one payment for multiple invoices and forced to make one payment per invoice. We should have the ability to choose
Also, reinforce the security for multi company by ensuring the user can
only select a journal from the company the invoices are in, and by
ensuring one can only register payments for invoices issued by one
company.

closes odoo/odoo#35569

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-08-09 14:59:32 +00:00
Shreya Thakrar e0b8e5e0e7 [FIX] website_rating: fix review display in mobile
In mobile view, review display layout is not clean. Stars string is too short
and progressbar is also too short. This is because we have visibility hidden
for 'Remove Selection', visibility property takes space.

In this commit we give more space for stars / text, and in mobile we add an
icon instead of 'Remove Selection' string.

Task 2047409

closes odoo/odoo#35598

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-09 11:47:07 +00:00
asa-odoo 3bd03e27bb [FIX] website_slides: fix quiz completion blocking users in fullscreen
Once a quiz is completed in elearning fullscreen view a pop-up is displayed.
Due to z-index it makes a black overlay on full-screen, so that we can not
click anywhere on the screen.

In this commit we update z-index value fix the issue and make screen clickable.
Website menu is also still clickable.

Task: 2044221
2019-08-09 11:43:44 +00:00
Nicolas Seinlet 3af0b3387f [IMP] hr_recruitment: use search_count to count
closes odoo/odoo#35584

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-09 08:22:54 +00:00
Mathieu Duckerts-Antoine ba4ce71bf5 [FIX] web: favorites have unique descriptions
In the favorites menu, it was possible to create two
favorites with the same name (contrarily to the
specifications). The root cause of the problem was that
the submenus of the favorites menu were not updated at
all. This commit fixes that situation.

closes odoo/odoo#35495

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-07 15:24:06 +00:00
Mathieu Duckerts-Antoine 691a8a690c [FIX] web: toggle favorite correctly updates other filters status
When toggling a favorite filter, the options used by
the active date filters/groupbys and the field created
via autocompletion were not correctly cleared, leading
to strange situations. This is fixed by this commit.
2019-08-07 15:10:57 +00:00
jem-odoo 5d64a5114e [FIX] project_timesheet_holidays: multi company issues
Partial backport of ef1afb7b69

Task-1999686
Closes #35520

closes odoo/odoo#35526

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-07 09:18:47 +00:00
Shreya Modi 752b2553c6 [FIX] mass_mailing: remove unsupported color picker on mailing lists
-There is unsupported color picker which is not required to differ
mailing lists thus removing it.

task-2042384

closes odoo/odoo#35494

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-07 12:45:33 +00:00
Goaman b384a00fe2 [FIX] web_editor: Do not remove block
Do not remove block in _removeNextEmptyUnbreakable.

Before this commit, when you tried to remove insert a character in
a td, with an empty td after the first one. The function
_removeNextEmptyUnbreakable removed the empty td. It was for
example breaking snippet in the website and mass_mailing.

closes odoo/odoo#32096

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-08-07 15:00:25 +00:00
David Monjoie d0e8059330 [FIX] web_editor: disable custom handling for Safari MacOS 2019-08-07 10:09:28 +00:00
David Monjoie 5578b98ad7 [FIX] web_editor: fix selecting snippet template text 2019-08-07 08:49:47 +00:00
David Monjoie 97e6b7f126 [FIX] web_editor: fix snippets preview on drop not displaying 2019-08-07 08:49:46 +00:00
David Monjoie cfbe4bbe42 [FIX] web_editor: fix snippets reloading traceback 2019-08-07 08:49:46 +00:00
Gorash 8e4b8be4e6 [FIX] web_editor: remove virtual corrector/completion keyboard glitch
For the ours need, we can not let the contentEditable behavior. Indeed,
this one does not have the same behavior according to the browser. The
DOM node could be erase, merge, cut, in them according to the keyboard
interactions. The problem is that if we have to manage these behaviors,
we have to manage everything. It was already the case in the previous
version, however before we created an editor by zone and by a hack we
mix the history.
In the case of the virtual keyboard of some OS / Phone, the events are
different and the autocompletion does not update (bug that prevents
modification interactions with javascript). In order to solve these
problems, we use another event for the insertion of the characters.
However, we must also force the update of the corrector by forcing a blur
and a focus.
The current version is a temporary version. We are currently working on a
version that uses a virtual dom and does not need to do excessive prevent
default.
2019-08-06 10:45:04 +00:00
Christophe Simonis 4e21d6180b [FIX] web_editor: do to try to inline css for readonly html fields
closes odoo/odoo#35539

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-07 13:31:01 +00:00
Laurent Smet 053b77fc9e [FIX] account_voucher: Set tax_repartition_line_id on move.lines created from vouchers
closes odoo/odoo#35530

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-08-06 14:29:24 +00:00
Christophe Simonis c687bd9aed Revert "[FIX] web: hide dashboard tooltip on page change"
Mow that the Journal Dashboard use Chart.js, this patch is unneeded.

This reverts commit 6d9dabd5d9.

Oversight of previous forward-port.
2019-08-07 16:29:42 +02:00
Christophe Simonis 7d04dc1c7c [MERGE] forward port branch saas-12.2 up to 9e74730a26 2019-08-06 18:48:24 +02:00
Christophe Simonis 9e74730a26 [FIX] mail: use defined variable
Oversight of previous forward-port.
2019-08-06 16:13:06 +02:00
Christophe Simonis 0fadd586fa [MERGE] forward port branch 12.0 up to ff9ddfdacc 2019-08-06 15:57:57 +02:00
Christophe Simonis ff9ddfdacc [MERGE] forward port branch saas-11.3 up to 97d81f1220 2019-08-06 12:13:19 +02:00
qsm-odoo dc0630833b [FIX] website: prevent multi checked options in the same group
In the customize theme modal, if one option enabled views which were
a subset of the views which are enabled by another option, both options
would be checked on modal opening if all the related views were active.

This is the case for the "choose an image" and the "choose a pattern"
options: the first one enables a view which adds an image on the body
and the second one enables the same view but also another which enables
the fact that the image must be repeated.

This commit solves the issue by always selecting the option enabling
the most views among the checked options in a same set.

opw-1958395

closes odoo/odoo#35465

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-05 15:57:25 +00:00
Christophe Simonis 97d81f1220 [MERGE] forward port branch 11.0 up to b8be821058 2019-08-05 17:12:30 +02:00
Christophe Simonis b8be821058 [MERGE] forward port branch saas-15 up to 6668f69822 2019-08-05 16:15:38 +02:00
Christophe Simonis 6668f69822 [MERGE] forward port branch saas-14 up to 14547f847c 2019-08-05 14:58:14 +02:00
Christophe Simonis 14547f847c [MERGE] forward port branch 10.0 up to af3f6e596d 2019-08-05 14:50:37 +02:00
qsm-odoo 2c029a0cf6 [FIX] website_forum: restore the possibility to change accepted answer
The design for accepted answers changed a lot and with it, the
possibility to remove or change accepted answers was gone. This commit
tries to reintroduce the possibility without breaking the design and
by making an unique attribute addition to the XML (stable change).

task-2034497

closes odoo/odoo#35445

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-05 11:38:49 +00:00
Jorge Pinna Puissant bacb353799 [FIX] point_of_sale: show lot number on order form
Allow to see the lot/serial number on the order form, only for the users
with group group_production_lot.

opw-2037285

closes odoo/odoo#35443

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-08-05 11:31:05 +00:00
qsm-odoo 7e1d98cbb9 [FIX] website_forum: restore star icon color for favorited questions
task-2034497
2019-08-05 10:19:03 +00:00
Nicolas Martinelli 91399aed95 [FIX] web: RTL on list view
- Set the user language to a RTL language, e.g. Arabic
- Open a list view containing float or monetary fields, e.g. the invoice
list view

The numbers are left aligned while the corresponding columns headers are
right aligned, making the list view confusing.

The header alignment is hardcoded at rendering rather than in the SCSS.
Therefore, `rtlcss` doesn't affect it.

Instead of hardcoding the alignment, we use a proper CSS class so it is
adapted by `rtlcss`.

opw-2044019

closes odoo/odoo#35414

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-08-05 08:18:34 +00:00
Goffin Simon 6236ed1a5b [FIX] stock_dropshipping: Updating dropship product
Steps to reproduce the bug:
- Install stock_dropshipping module and enable Routes on SO lines
- Create a storable product P with a supplier S
- Create a SO with P and set this line with the route dropship
- Confirm the SO ( a PO has been created to S with P)
- Change P on the SO with an other product

Bug:

The product P stayed on the PO.
So a product linked to a PO line cannot be changed on a SO.

opw:2040249

closes odoo/odoo#35383

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-08-05 09:22:09 +00:00
Christophe Simonis 94aa43722e [FIX] test_mail: bump expected query count
324268a976 has the side effect of
generating an extra query.
2019-08-02 14:38:06 +02:00
Julien Castiaux e26a5e46ff [FIX] web: spam new event creates multiple modals
On the Time Off, spam click to create a new event, each click opens a
new event form modal.

When the modal form fields have not been cached yet, the frontend
fetches them and delay the modal form opening after those fields have
been fetched. As the interface is still available. It is possible to
re-click multiple time during the fetch, each click schedules a new
modal form. When the first finally shows, they all stack on screen.

opw-203577

closes odoo/odoo#35098

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-08-02 11:42:27 +00:00
Christophe Simonis 4ac13f85f4 [MERGE] forward port branch 11.0 up to 593f631e5e 2019-08-02 12:41:55 +02:00
Alex Tuyls 3682232d1e [FIX] portal: zipcode field labelled as mandatory
Field zipcode is optional, while it is labelled
as mandatory.

closes odoo/odoo#35401

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-08-02 09:37:30 +00:00
Lucas Perais (lpe) 4e454a9537 [FIX] account: reconciliation double click on proposition
Open the reconciliation widget, with a statement line that has
some move lines to reconcile with

Put your browser in Fast 3G to slow down stuff
then click multiple times on a move line to add it to
the reconciliation chain of the statement line

Before this commit, as many lines appeared in the reconciliation
chain as many clicks were made

After this commit, one can only click once on the lines

linked to #35194

OPW 2042751

closes odoo/odoo#35417

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-08-02 14:52:06 +00:00
Odoo Translation Bot e5754cd936 [I18N] Update translation terms from Transifex 2019-08-04 03:08:10 +02:00
Jérôme Thériault 8a49074fcb [FIX] base: add missing attributes in RNG
Attributes are documented for the gantt view but were not available in
the RNG
https://www.odoo.com/documentation/10.0/reference/views.html#gantt
https://github.com/odoo/enterprise/blob/fe0213e70de952/web_gantt/static/src/js/gantt_renderer.js#L32

closes odoo/odoo#31001

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-02 12:57:23 +00:00