Commit Graph
126256 Commits
Author SHA1 Message Date
JPR 6da3dafe94 [FIX] base_import: 'Create if does not exist' option 2018-09-03 15:20:39 +02:00
Martin Trigaux 98665aca1c [FIX] transifex: actually escape strings containing a '
The report's template is wrong
should becomes

text:'The report\'s template is wrong'

but previous code had no effect
2018-09-03 15:03:09 +02:00
Olivier Dony 74d72b9153 [FIX] portal: raise front-end asset priority
This is necessary to make it among the first of the "assets frontend"
inherited views, and specifically make it appear *before* the one from
website. Without this, SCSS styles may be randomly broken if the
original installation order of `portal` and `website` was reversed
(e.g. for older databases).
2018-09-03 14:42:35 +02:00
Martin Geubelle e273407157 [FIX] mail: consider activity as a valid view type
The recently introduced `activity` view (see rev. odoo/odoo@1de9496 has not
received all the consideration it deserves as a real view type (no RNG, not in
the valid view `type`, no doc, etc.). It was currently only working based on a
`_get_default_activity_view` method.

Even if the RNG is currently really basic, its grammar could evolve in the future.

This was causing an issue when opening Studio with this view as a default view
with an invalid type was created.
2018-09-03 13:40:22 +02:00
Goffin Simon bc913d9d2b [FIX] point_of_sale: Print receipt on Safari
As explained on stackoverflow with
https://stackoverflow.com/questions/23626998/safari-print-issue-with-javascript-window-print
There is an issue with javascript window.print() on Safari

Steps to reproduce the bug:
When clicking on button "Print receipt" in the point of sale, nothing happened.

opw:1858205
2018-09-03 13:23:21 +02:00
Toufik Benjaa b789092ead [FIX] mail: Access right issues while accessing mail.message
- The SQL request to retrieve mail.message information to compute access
  rights was incorrect. Which triggered false access right issues.
2018-09-03 13:16:11 +02:00
len-odoo b95b4035e4 [FIX] web: tab selects first many2one entry without triggering spurious create
Suppose you select a customer for a sale order.
You type the beginning of his name "think", and a name_search is triggered
which finds matching results, with first result "Think Big Systems".
There are three ways to select it: click, enter or tab.
Now there can be a warning set on this customer
("Bad client, only accept cash", or "good client, offer discount").
In that case, clicking on tab would trigger the onchange displaying the warning,
but it would also set floating to true, which means a dialog to create client
"think" would appear.
This happens if the onchange is delayed, and thus the call to reset the floating
state is triggered only after the focusout completed, instead of before.

Coauthored with @aab-odoo

opw 1866619
opw 1874475
2018-09-03 12:09:56 +02:00
Nicolas Martinelli 122f06b86e [FIX] l10n_th: withholding taxes
Withholding taxes should have a negative value.

opw-1865270
2018-09-03 12:05:30 +02:00
Nicolas Martinelli 5b89ca142d [FIX] purchase: vendor reference
In case no PO has a vendor reference, keep the value.
2018-09-03 11:57:49 +02:00
Goffin Simon d448849ba3 [FIX] delivery: Error message for unavailable delivery methods
With a fixed price delivery method, the error message was not displayed when
the address doesn't match.

Inspired from function base_on_rule_rate_shipment

The error message was not clear enough.

opw:1879204
2018-09-03 11:13:34 +02:00
XavierDo 0c07ff7f41 [FIX] calendar: allow search on message_ids
When fixing calendar search for recurring events we assumed that
no autojoin field will be used in this search.

The filter unread messages is based on message_ids from mail thread.
The solution here is to redefine this field in calendar to remove the autojoin.
2018-09-03 11:11:39 +02:00
XavierDo 641fe7f34f [FIX] calendar: only make leaf evaluation when necessary
A little optimisation to avoid one more query when we have no
recuring event, and only evaluate leaf of recuring event.
2018-09-03 11:11:39 +02:00
Martin Trigaux d6a0e9db81 [FIX] mail_bot: do not crash on user with no email
When creating a new user, the linked partner may not yet have an email address
(not mandatory field).
When logging in for the first time, after some time an error comes up
   "Unable to post message, please configure the sender's email address."

While the user should set up an email, this popup coming from no specific action
is confusing.

With this patch, the message will be posted as the system (which has an email)
The user will be warned of having no email when trying to reply.

Closes #26601
2018-09-03 11:06:59 +02:00
Martin Trigaux 5700f960d4 [ADD] test_translation_import: new duplication test
To make sure what was corrected is tested
2018-09-03 11:02:56 +02:00
Martin Trigaux e656a350a6 [FIX] test_translation_import: correct test
Now that it is tested, actually correct it
2018-09-03 11:02:56 +02:00
Martin Trigaux a9cd97f58e [MOV] tests: move test to be executed
The test was in a folder not checked by the runbot
The test, as it, is actually failing and it will be corrected in the next commit
2018-09-03 11:02:55 +02:00
Martin Trigaux 1566c0ab3b [FIX] tools: avoid loading duplicated code translation
This commit fixes two bugs:

- a8469c45 was fixing the case where the first line was not 'code' but broke
  the usecase where a po started with code line

- Correct the usecase where a pot and po file do not have the same line of code
  by matching on res_id=0

This avoids to have a pot expecting a code message at line 42 and a translation
at line 43

Closes #26722
2018-09-03 11:02:43 +02:00
jem-odoo 933487eb65 [FIX] rating: error on template rendering
Task #1878247
2018-09-03 10:17:30 +02:00
Toufik Benjaa 82195c587c [FIX] mail: fetch notifications for active partners only
- When trying to fetch notifications for failed mail delivery, the code
  doesn't check if the partner is active or not.

  If the partner is archived, then it tries to access its information on
  a dict that doesn't contains them and crashes.
2018-09-03 10:08:58 +02:00
Nicolas Martinelli e6390a76a6 [FIX] purchase: overwrite vendor reference
Overwrite vendor reference only if there is a PO linked to the bill.
Otherwise, any addition of product will erase what the user just typed.

Closes #26734
2018-09-03 09:54:34 +02:00
Romain Derie 1f9b416878 [FIX] website_*: fix bs4
[FIX] website_form_editor: adapt layout to bs4

1. With BS4, dialog width is 500px and not 600px anymore.
   As a result, on large screen using col-x-3 is not enough anymore.

2. With BS4, a row should be set when using col-x-x or they will be one above
   the other.

3. As the template is not only used in the modal but in the page itself, we
   should had a container to prevent the input fields to take all the page
   width.

task-1878150

[FIX] website_helpdesk_form: missing `container` class

When submitting a ticket to an helpdesk team, the form would be displayed to
the left, against the screen border since there were no `container` class.

task-1878150

+ layout margin & size improvement
2018-09-02 15:27:18 +02:00
Romain Derie d228005ec4 [IMP] sale_coupon: adapt to multi-websites
This commit adds the `website.multi.mixin` to coupon program to make it
multi-websites.

It also adds the website_id field in the views and adapt SQL constraint on code
which now became multi-websites friendly.
2018-09-02 15:27:05 +02:00
Romain Derie fe72773b20 [IMP] sale_coupon: adapt to multi-websites
This commit adds the `website.multi.mixin` to coupon program to make it
multi-websites.

It also adds the website_id field in the views and adapt SQL constraint on code
which now became multi-websites friendly.
2018-09-02 15:27:05 +02:00
Odoo Translation Bot a67c48b0b3 [I18N] Update translation terms from Transifex 2018-09-02 07:07:27 +02:00
Odoo Translation Bot d40145a42e [I18N] Update translation terms from Transifex 2018-09-02 04:09:57 +02:00
Odoo Translation Bot e8606ce00b [I18N] Update translation terms from Transifex 2018-09-02 02:24:05 +02:00
Odoo Translation Bot 8846a0c21b [I18N] Update translation terms from Transifex 2018-09-02 00:29:56 +02:00
Odoo Translation Bot b5471da2e0 [I18N] Update translation terms from Transifex 2018-09-01 02:38:40 +02:00
qsm-odoo 4bc79da943 [FIX] website, *: avoid top menu flickering
* portal, web
2018-08-31 18:57:12 +02:00
qsm-odoo 7253b55f41 [FIX] website, *: BS4, restore website menu dropdowns
* website_event, website_event_track
2018-08-31 18:57:12 +02:00
Jeremy Kersten 7566a8c205 [FIX] website: page manager visual fix
sort by url by default
don't show multi level if not in multi website mode
2018-08-31 18:04:23 +02:00
Romain Derie 6bfb0810b0 [FIX] web_editor, website(_*): fix bs4
[FIX] web_editor: adapt col size to avoid too small select

We should avoid col-md-3 in col-md-9 as the menu dialog is instanciated at 2
places:
  - When creating a link in the editor
  - When editing website navbar menu

In the second case, there is a hack in `content.js` to remove `modal-lg`
lowering the width of the modal and making the select too small.

[FIX] website: lower navbar font size

With BS4, font-size of navbar element went from 13px to ~17px (rem unit
computation).

14px seems better than previous 13px as the frontend content size is
higher than the backend one. Thus, 13px looks too small in contrast with the
frontend page content.

[FIX] website_crm_partner_assign, website_customer, website_membership: fix layout

This commit fixes multiple layout issues, mainly by aligning code of the 3
modules:
  - Add margin right to avoid text to be against image
  - Using image_medium everywhere
  - Fixing search input width

publish toggle red + odoo primary is weird -> gray
navbar now has a background & float-right not working since flex
-> remove navbar class, use d-flex and ml-auto so the right element will be floating since using all available width

task-1878150
2018-08-31 16:37:45 +02:00
Romain Derie 47b00c5d53 [FIX] base,website,web_editor: handle key field on ir.ui.view for multi website
With multi-websites, we expect qweb views to have a key set as it is the key
that is used to find duplicates (two views with same keys are duplicate, the
one with a website_id set is more specific than the one without a website_id)

Thus, 5ff87e8039 sort on key in order to find the most suitable one.

It would crash if a qweb view is created without a key (False) as it can't sort
`bool` and `str`.

This commit:
  - Adds a generated key to scss views
  - Adds an SQL constraint to avoid QWeb views without a `key`
  - Generates a random key when creating a QWeb view without a `key`
  - Handle False key in `filter_duplicate()` by extracting views with False key
    before sorting, and then adding these views to the recordset

Note: We also want the key to be editable as it is now an important field with
      multiwebsite. Thus, we removed the readonly on this field.

+ fix python tests as we now force key on qweb views with sql constraint
+ pep8
2018-08-31 16:37:45 +02:00
Jeremy Kersten 9b1d1d5728 [FIX] website: allow to switch from company from the front end
In some case, you can be on website 2 (where company_id = 2) with your user into the company 1.
In this case, you will not see the product on ecommerce from company 2 while you stay in company 1.
2018-08-31 16:37:45 +02:00
Jeremy Kersten ba2116838e [FIX] website, mass_mailing: fix social network
- Remove useless onchange company id from website, now that we configure it
in the res config.
- Add the onchange company into the res_config_settings
- Remove left duplicate data from mass_mailing
- Add ALL social links into the res config
2018-08-31 16:37:45 +02:00
Yenthe666 288bcccc8e [FIX] website, social_media, mass_mailing: add default value for missing media
+ add instagram

This commit closes #26644 and closes #26649
2018-08-31 16:37:45 +02:00
Jeremy Kersten 52300d7fb0 [IMP] website: res_config_settings remove payment acquirer link
New idea according FGI request is:
A settings with nothing to configure (just a link), is useless in the
res_config_settings view.
2018-08-31 16:37:45 +02:00
qsm-odoo 7ce1e60be4 [FIX] website: properly show theme colors in customize dialog 2018-08-31 16:00:10 +02:00
qsm-odoo 0b480f6b2c [FIX] website_theme_install, *: multi-website customization dialog
* theme_bootswatch, theme_default

Before this commit, the customization dialog for themes was not
multi-website. That means if a theme was installed on a website, the
customization dialog was enabled for all the websites.

Note: this commit uses the '_post_copy' system of theme installations
for the first time and it had to be adapted a little bit.
2018-08-31 16:00:10 +02:00
Jeremy Kersten f39b31930a [FIX] website_theme_install: reload registry when installing new theme 2018-08-31 16:00:10 +02:00
len-odoo a822d3ee41 [FIX] hr_timesheet: add float_time widget on float time field in pivot view
Since pivot views can use fancy widget attributes, we use one to display some
float time value (getting 8:30 instead of 8,5).

opw 1876445
2018-08-31 15:49:32 +02:00
len-odoo 8c1204954e [FIX] web: display values according to widgets in pivot view
The pivot view didn't take into account the widget set on the fields.
In particular this was a problem for float fields that store time values.
They are now displayed with float_time if declared as such in the view.

opw 1876445
2018-08-31 15:23:31 +02:00
Christophe Monniez 580a0b2ef7 [FIX] tests: redirect chrome headless stdout and stderr to dev null
When executing a very long HttpCase browser_js test, it happens that one
of the chrome process PIPE is full (ie. clickEverywhere test).
In that case, the communication with Chrome is blocked.

With this commit the stdout and stderr of the Chrome process are
redirected to /dev/null.
2018-08-31 15:03:11 +02:00
Christophe Monniez 4e7fcf3e07 [FIX] web: wait web client to be ready before clickEverywhere test
When starting the clickEverywhere test with enterprise modules
installed, it happens that Odoo web client is not yet fully loaded.
In this situation, the test does not find any app to test.

With this commit, an attribute is added to odoo to check if the web
client is fully loaded.
2018-08-31 14:45:25 +02:00
Alexandre Kühn de1631c717 [FIX] web: call on_close handler from history_back
Revision on https://github.com/odoo/odoo/commit/3210f108272be89f1a7b01f4e1816b7f04ae0a3b

Before this commit, when doing an action that opens a dialog
(with `target: 'new'`), then triggering 'history_back', the
`on_close` handler of the action was never called.

This was not the correct behaviour, because the dialog closes
without the `silent` option set. Indeed, when this option is
not set, it should always call the `on_close` handler.

The bug comes from closing the dialog without any options, and
this case was not handled correctly in the commit above. This
commit fixes the problem by ensuring that the `on_close` handler
is called even when closing the dialog without any option.
2018-08-31 14:31:01 +02:00
Thibault Delavallée 0f3281e3b1 [REF] hr_holidays: clean leave and allocation access rights
Purpose

 - clean access rights;
 - solve some access and security issues;

Access specifications

 - an user
  - can see all leaves;
  - cannot see name field of leaves belonging to other user as it may contain
    private information that we don't want to share to other people than
    HR people;
  - can modify only its own not validated leaves (except writing on state to
    avoid bypassing validation);
  - can discuss on its leave requests;
 - an Officer
  - can see all leaves;
  - can validate "HR" single validation leaves from people if
   - he is the employee manager;
   - he is the department manager;
   - he is member of the same department;
   - target employee has no manager and no department manager;
  - can validate "Manager" single validation leaves from people if
   - he is the employee manager;
   - he is the department manager;
   - target employee has no manager and no department manager;
  - can first validate "Both" double validation leaves from people like "HR"
    single validation, moving the leaves to validate1 state;
  - cannot validate its own leaves;
 - a Manager
  - can do everything he wants

In top of that, multi company rule are correctly added.

In reporting model using in "summary" name field should also be stripped
if you are not an HR officer and if it is not your own request.

Concerning allocation requests: implement same rules except constraint on
name field as it is less private and therefore can be seen.

This commit is linked to task ID 1876795 and PR #26656.
2018-08-31 14:19:23 +02:00
Thibault Delavallée 0113d989a8 [REV] hr_holidays: revert "[FIX] hr_holidays: officers can CRUD leaves for their companies"
This commit was not correct and was a quick fix to avoid blocking daily use
of odoo saas-11.3. Next commit will fix access rights and enforce their
definition through more detailed tests.

This reverts commit ae34db3221.

This commit is linked to task ID 1876795 and PR #26656 .
2018-08-31 14:19:23 +02:00
qsm-odoo 4bb0ea03e5 [FIX] website_theme_install: create theme attachments... with their key 2018-08-31 13:44:31 +02:00
Nicolas Martinelli 078c3ec492 [FIX] payment_authorize: remove incorrect fields
`firstName` and `lastName` should be filled in for Australia, but the
implementation is not correct since:
- it assumes that the name is first name + last name, which is not the
  case in all countries (e.g. France)
- it doesn't take into account that the name could be a company name

This reverts commit 26974d4e5f.
2018-08-31 13:37:25 +02:00
Nicolas Martinelli ce6400e098 [FIX] mass_mailing_event: event domain
- Create an event, add an attendee
- Click on the stat button 'Mail Attendees'

The domain is shown as 'Event', '?', [id].

This is because the domain selector widget doesn't support the `in`
operator. Supporting it is not trivial, since ultimately `field_utils`
cannot parse a list of ids for a Many2one. It's less intrusive to change
the domain, since a standard use of the method will simply contain a
single id.

opw-1878322
2018-08-31 13:15:40 +02:00