Victor Piryns (pivi)
eb73917c0f
Current behaviour: Down payments are taking into account in the project profitability in the section "Other Cost". When invoicing fully an SO, the total sum in profitability is the sum of the invoiced amount on the SO + the down payment. Expected behaviour: Down payments should not be present in the project profitability, to avoid incorrect sums. Steps to reproduce: - Install Sales, Accounting, Timesheets - Activate Analytics in the Settings - Set a Service Product that is invoiced based on fixed price - Make sure that it generates a Project + Task - Create a Quotation, confirm the SO with that product - Create a down payment for 50% of the SO - Confirm that invoice - Create another invoice for the SO for the rest of the SO and confirm it - Go to the project's profitability tab for the SO, you can see that we have the value of the SO + the amount of the down payment, leading to an incorrect sum, in the section Invoiced. Reason for the problem: When taking the invoices for the profitability of the project, since a down payment is another `sale.order.line`, we handle it in the method `_get_revenues_items_from_invoices`, and there we are taking into account the down payments. Fix: Elaborate the domain used to fetch the invoices in `_get_revenues_items_from_invoices_domain` to not take those that are down payments. Affected versions: - 16.0 - saas-16.1 - master opw-3195016 closes odoo/odoo#115050 X-original-commit: ae151ec16a0054420f5c2827a1924c87e5b672ba Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com> Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials