Samuel Degueldre acbf806030 [FIX] point_of_sale: fix indeterministic order of payment methods
Previously, pos payment methods were ordered by sequence only, this can
cause issues because the default cash payment method is considered to be
the "first", ie the one with the lowest sequence, but because they are
created with a sequence of 0 by default, if there is more than one cash
payment method, their order is indeterminate.

This can cause issues if the order of payment methods given to the pos
application during load_pos_data doesn't match the order of the payment
methods obtained in get_closing_data, as tests will use the first cash
payment method when paying, and then compute the cash difference with
the default cash payment method which is supposed to be the first
received in load_pos_data. If the order is different then the cash
difference will not match what's expected and the test will randomly
fail.

This commit adds the id to the _order of the pos payment method model,
causing the ordering to be deterministic. It also removes the order from
the search params used for this model in load_pos_data, as it was
already the default ordering but was now masking the correct order newly
defined on the model.

closes odoo/odoo#121797

X-original-commit: b78c93a697baed3a01cac9319ccdc479d3bfd840
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Samuel Degueldre <sad@odoo.com>
2023-05-19 14:34:51 +02:00
2023-05-11 12:01:49 +02:00
2023-05-19 13:33:11 +02:00
…
…
…
…

Build Status Tech Doc Help Nightly Builds

Odoo

Odoo is a suite of web based open source business apps.

The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...

Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.

Getting started with Odoo

For a standard installation please follow the Setup instructions from the documentation.

To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials

S
Description
No description provided
Readme LGPL-3.0
3.4 GiB
Languages
Python 49.6%
JavaScript 47.8%
SCSS 2%
CSS 0.3%
HTML 0.2%