Denis Ledoux
70a8758760
Before revision5bf1207c8ca new environment was created for each call at `xml_import` or `convert_file`, with `odoo.api.Environment(cr, SUPERUSER_ID, {})` meaning the context was empty, meaning the lang was never set Now that we pass from end to end the environment, the caller of `xml_import` or `convert_file` passes his own environment, therefore propagating his `context` variables, therefore potentially passing a lang in the context. Therefore, since this change, the lang of the user is taken into account when calling `xml_import`/`convert_file`, and it updates the translation term rather than the source term for translated fields. This could be an actual/intended valid behavior, this needs to be discussed, but currently the places where `xml_import`/`convert_file` is called expects to update the source term, not the translated term. See for reference https://github.com/odoo/odoo/pull/116780#issuecomment-1486506663 Therefore, as this is an unexpected/unintended change of behavior of the refactor5bf1207c8c, and as code blocks calling `xml_import`/`convert_file` have not been adapted, we prefer to play it safe and revert the behavior to what is was. This is very possible other context keys will need to be dropped, but one of the desired change of the refactor was to be able to pass keys in the context, currently we prefer to not wipe the environment context and just blacklist the one we do not want to propagate, such as the lang. If other related issues arise, we will then re-consider. closes odoo/odoo#117621 X-original-commit: 44fa57e52fbc853b7756a96c73c94baa469c99ca Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials