Antoine Guenet
282face688
When inlining e-mails, we convert font icons to images by calling the font_to_img route with the icon's dimensions. To get the icon's dimensions, a call is made to `convert_inline`'s `_getWidth` and `_getHeight` functions. These functions assume that calling `getComputedStyle` on the icon to get its width/height will return a value in pixels. However, this is not always the case. For example, if the icon is in a hidden element, `getComputedStyle` can return "auto" or whatever value is set in the icon's `style` attribute (e.g., "fit-content"). This commit ensures the return values of `_getWidth` and `_getHeight` are always numbers as expected. Doing this also reveals a false negative in the tests where the grid to convert is not added to the DOM before calling `bootstrapToTable`. Since `_getWidth` returned `NaN` in this case, `style.setProperty` failed silently and no max-width was set on the cells. The tests didn't account for the missing max-width, which now suddenly appeared with this fix (NaN failed but 0 doesn't). This commit fixes the tests by adding the grid to the DOM before calling `bootstrapToTable`, and adding the expected max-width to the expected result. X-original-commit: 73b404df9be1ba28a784711174cc19e7c599099e Part-of: odoo/odoo#113784
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials