Damien Bouvy
18910e926f
This try except block was added in another era, where the piece of code in the block was far less ambitious (and not for good reason since adding a try except block because of a malformed mail template seems overkill). Even worse, this block actually prevented errors from bubbling, which could have adverse effects. Example: a long transaction confirmation (several seconds since it implies S2S communication, invoice creating/validation, etc.) is rollbacked because a mail message is recorded on the quote during the processing time. The quote confirmation then crashes because of a concurrent update error in postgres. This try except block does not re-raise the error, which means that instead of retrying the operation like the ORM would normally do, we have an incomplete traceback in the system (since the error message crashes itself) and the transaction is not validated (as far fetched as it may seem, this is in fact how this bug was discovered). This try-except block offers no gain in error logging (on the contrary, since we have lost the initial error-causing statement) and prevent the orm from correctly managing errors. This commit removes it and let the orm handle the errors like a grown up man; either crash for real (because it should crash to know if there's a problem) or retry the transaction if it's a serialization issue. opw-744629
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, Purchase Management, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
If you are a developer you may type the following command at your terminal:
wget -O- https://raw.githubusercontent.com/odoo/odoo/10.0/setup/setup_dev.py | python
Then follow the developer tutorials
For Odoo employees
To add the odoo-dev remote use this command:
$ ./setup/setup_dev.py setup_git_dev
To fetch odoo merge pull requests refs use this command:
$ ./setup/setup_dev.py setup_git_review