Adrien Widart (awt)
037e2a3e79
If a user decrease the SOL qty of a kit once the return is done, an unexpcted picking will be created To reproduce the issue: 1. Create a kit K: - With one component - There is one component in the stock 2. Create and confirm a SO with 1 x K 3. Process the delivery 4. Return the delivery 5. Set the SOL qty to 0 Error: a useless and unexpected picking is created to return the kit When setting a new SOL qty, we check if we should create and run a new procurement to adapt the qty on delivery-side. To do so, we get the qty being delivered, and we compute the difference with the new SOL qty. Here is the issue, when getting the qty being delivered, it returns the old SOL qty (1.0): https://github.com/odoo/odoo/blob/797f67bcb222142b79a9eee3e4a882ff679af9db/addons/sale_mrp/models/sale.py#L164-L167 This is not true. Since the kit has been returned, the qty being delivered is zero. As a result, a procurement is created to compensate that incorrect qty. The incorrect return value (1.0) comes from [1]. However, that fix is not correct. Here was the initial issue: To get the qty being delivered, we use the moves of the components, include the BoM lines qties and try to compote the kit quantity. To do so, we call `_compute_kit_quantities` with the components' moves and the kit qty. However, there is an error: the moves are based on the old kit quantity, and we give the new kit quantity to the method. This is why the result was incorrect in the use case of [1]. [1] bafad58353c562a9b79735640c23d3cca004e0b0 OPW-3077209 closes odoo/odoo#113438 X-original-commit: 0b8af1d63d496489ac1608141c9b2dbccc8b7966 Signed-off-by: Adrien Widart <awt@odoo.com> Signed-off-by: Tiffany Chang <tic@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials