Commit Graph
106951 Commits
Author SHA1 Message Date
Josse Colpaert ffe13756f5 [FIX] mrp: manufacturing vignette in inventory dashboard
When clicking on the "manufacturing" vignette in the inventory
dashboard, the records were not filtered correctly (example: add a new
warehouse, a new "manufacturing" vignette appears for this warehouse in
the inventory dashboard, clicking on it would display the MO of all the
warehouses).

With this fix, as with the pickings, it will only show the count of MO
filtered to that specific picking type in the vignette, and clicking on
it will displayed the filtered ones.

We implementent the method of the compute field the same way the similar
method for the picking is implemented.

fixes #15008
2017-01-17 14:43:06 +01:00
Thibault Francois d588efba6c [FIX] project: remove unused field
Remove unused fields (including inherited view) in kanban project view,
For example, `user_id` triggers a read for each project on res partner,
40 projects display = 40 read on `res.partner`.

Closes #15096
Related to opw-696979
2017-01-17 13:22:24 +01:00
Nicolas Martinelli 805f7ed8e7 [FIX] event_sale: traceback
- Go in Events > Events
- Create or modify an event
- Add a ticket to your event, and try to change the product -> traceback

The field `event_type_id` does not exist on model `product.product`. It
has been removed in commit 7f97a64091.

opw-704838
2017-01-16 15:54:00 +01:00
Nicolas Martinelli aa6c0ef907 [FIX] mail: missing translation 2017-01-16 15:49:05 +01:00
Nicolas Martinelli 1161951d96 [FIX] mail: notification authorization
When user user denies Odoo to display desktop notifications, the message
'Permission granted' is displayed.

opw-697985
2017-01-16 15:49:05 +01:00
Martin Geubelle c0e02f089b [FIX] report: edit report without website
Before this commit, website needed to be installed to edit
a HTML report because the context `inherit_branding` was not
correctly passed.

Credits to @sle-odoo
2017-01-16 15:02:33 +01:00
Martin Trigaux d126529d1b [FIX] base: avoid traceback when rendering traceback
If node is not installed (missing dependency), the user is not aware of the
source of the issue as it can not be displayed in the css_errors or logger.
The error is
/usr/bin/env: ‘node’: No such file or directory
which contains unicode quotes.

Does not fix #15057 but at least say the source of the problem.
2017-01-16 14:50:20 +01:00
jaredkipe 4b500aa298 [FIX] auth_oauth: remove redirect if there is only 1 provider
Forcing the redirection for 1 provider but not for 2 makes no sense.
Was done at 311f041f for the reset password, applied to signup too.

Closes #15032
2017-01-16 13:49:59 +01:00
norlinhenrik 47c60db4a0 [FIX] product: set the correct company in property
`set_multi` uses the company of the current user.
As the property is created in sudo, the company of the admin may be different
than the one of the current user.

Before this commit, setting a different pricelist on a partner when logged in a
different company than the admin, the change had no apparent effect (was
creating a property for the admin's company).

Set `force_company` in the context to always set the one on the current user.
set_multi ignores if the same as the global rule to avoid bloating the table.

Closes #14984
2017-01-16 11:55:07 +01:00
norlinhenrik b74e02b847 [CLA] signature for norlinhenrik
Done at #14984
2017-01-16 11:55:07 +01:00
Odoo Translation Bot 6fc0d955d0 [I18N] Update translation terms from Transifex
To reflect changes 62bd57e285
opw-704728
2017-01-16 09:41:24 +01:00
Martin Trigaux 62bd57e285 [FIX] product: correct pricelist translation
The pricelist is renamed into USD in demo data of website_sale.
For most people, it should be Public priclist
2017-01-16 09:12:07 +01:00
Odoo Translation Bot 4d4e0484d1 [I18N] Update translation terms from Transifex 2017-01-15 04:31:44 +01:00
Laurent Mignon 273a15ea7d [FIX] website: port of rev a98d60c
The forward-port of the above revision missed
the conversion to the new api

Closes #15064
2017-01-13 14:03:52 +01:00
Nicolas Martinelli 266ae2a26b [FIX] mail: trim '()' characters
In commit 07425d407f a trim of some special characters was introduced
to prevent a crash. This was necessary in v9, but it is not in v10.

opw-703465
2017-01-13 13:28:22 +01:00
Nicolas Martinelli 8fd6f85169 [FIX] product_extended: Compute from BoM
The price suggested thanks to the "Compute from BoM" button only takes
into account the price of the products listed in the BoM lines.

In v9, there was a "Recursive" option that provided the possibility to
compute the prices of all products implied in the BoM, recursively. This
option has been removed since it was leading to a "black box" behavior
that was unclear to the users.

However, limiting the price computation to the BoM lines only is too
restrictive since it doesn't even take into account the phantom BoMs.
By using the `explode` method, we have access to:
- all products not manufactured
- all products manufactured which are not kits (phantom BoM)

It means that the cost of manufactured products (not kits) should still
be computed before the product itself.

opw-697866
2017-01-13 13:25:00 +01:00
Nicolas Martinelli 11e99a0b53 [FIX] product_extended: compute from BoM
When a product template UoM is different from its BoM UoM, the price
suggested thanks to the "Compute from BoM" is incorrect, since it doesn't
apply the conversion rate between the product template UoM and the BoM UoM.

This is because we try to fetch the product UoM through the BoM. However,
if the BoM is not specific to a product.product, the field bom.product_id
is empty.
2017-01-13 13:25:00 +01:00
David Arnold 3609782481 [REF] account: improve inheritability of account.reconcile.model in chart template generation.
This commit adds a _prepare_reconcile_model_vals() method that localization can overwrite should they need it. Courtesy of David Arnold. Was PR #14981
2017-01-13 12:12:14 +01:00
Denis Ledoux 2ddd5590b2 [FIX] base: correct typo in _fields_find, res_ids -> res_id
The issue is introduced by revision
d465346f1e

Raphaël actually meant
`res_ids = data.mapped('res_id')`

Indeed, there is no `res_ids` field on `ir.model.data`,
but there is a `res_id`.

In addition, the same code is written correctly in the method
just above this one, `_object_find`

opw-704592
2017-01-13 11:54:22 +01:00
Nicolas Lempereur 9aaed65352 [FIX] setup: server UTC timezone on windows
In 07bf7bf4f3 a fix was introduced for windows server UTC timezone.

It is possible it would be helpful in some situation to also have it in
setup/odoo (for example if odoo was installed on windows in some other
way than the Installation bundle).

opw-693764
2017-01-13 10:37:24 +01:00
Nicolas Martinelli a93632df91 [FIX] hr_holidays: allocation name
When creating an allocation request by employee tag, the name contains
'False on...'.

opw-703893
2017-01-12 15:16:30 +01:00
Damien Bouvy 1382c0884d [FIX] website_mail, crm, project: replace support email by form url
and correct documentation url with correct version.
2017-01-12 14:21:40 +01:00
Yenthe V.G 2e18f35c4e [FIX] product: Rename invalid context variable
The context uses an invalid name, which means it'll never work correctly.

fixes #15028

Bug coming from the module migration
2017-01-12 10:38:33 +01:00
Nicolas Martinelli f60936fafe [FIX] account_asset: cancel invoice
Extension of commit 9d14230d74. Deactivate the assets when the invoice
is cancelled, which is more logical.

opw-703108
2017-01-11 16:56:23 +01:00
Martin Trigaux cdf62af265 [I18N] account,website_portal: reflect changes in source terms
Thanks Obam.. hmm @JKE-be sorry
2017-01-11 14:50:11 +01:00
Goffin Simon 2db449a2ae [FIX] hr_attendance: check in with blank pin
When writing a blank pin, the user logged can check in his own related
employee.

opw:703744
2017-01-11 14:02:05 +01:00
Damien Bouvy 5bd8f97fa2 [FIX] website_portal_sale: use correct company for invoice creation
Invoices created automatically by the payment acquirer must use the
correct accounts/journals, which may not always be the case if not
explicitly set in the context.
2017-01-11 13:32:11 +01:00
Jeremy Kersten 4b24c2b2a2 [FIX] webite_crm_partner_assign: fix layout for opportunities list 2017-01-11 11:12:47 +01:00
Jeremy Kersten b1f837e0e2 [FIX] website_portal: usability terms
Courtesy of apr
Task-27929
2017-01-11 11:12:47 +01:00
Jeremy Kersten c61fbe36b8 [FIX] website,website_sale: add o_text_overflow in front end
And use it in right column from ecommerce (task-28865)
2017-01-11 11:12:47 +01:00
Jeremy Kersten 9ac974548e [FIX] mail: don't check read access if user not connected.
In the worst case, user is not logged in and he will really have no access and
will have a perm read error after login. We cannot check if an unknow user has
access or not.

In most cases, user will be logged in and will see the document directly if
he has access or will be redirected to messaging if no access.

In the best case, he will be redirected to login page before to see the message.

task-22505
2017-01-11 11:12:47 +01:00
Jeremy Kersten 498852c27f [FIX] website_sale: multi image uses hover option by default 2017-01-11 11:12:47 +01:00
Jeremy Kersten 1f5041f3dc [FIX] account: typo in warning 2017-01-11 11:12:47 +01:00
Jeremy Kersten 4b102523b5 [FIX] crm: search_count don't support limit
Bug migration new api
2017-01-11 11:12:47 +01:00
Denis Ledoux b228f548ca [FIX] website: port of rev a98d60cb11
The forward-port of the above revision missed
the conversion to the new api and that
`context` had to be replaced by `self.env.context`

Fixes #14922
Closes #14923
2017-01-11 11:03:49 +01:00
Nicolas Martinelli 5a1ec14519 [FIX] marketing_campaign: method not implemented
In the Lead Automation module, the module is working as expected when
the activity type is 'Email'. In other cases, the corresponding methods
are not implemented and raise an error.

opw-697829
2017-01-10 19:19:58 +01:00
Josse Colpaert ff098a7ad4 [FIX] mrp: procurement creation for raw materials
According to the routes set on the products of the raw materials, a
procurement may have to be created for the consumed lines of the MO.

A route may also be set on a product category. Before this patch, we
only look for procurement rules for the routes defined on the products
and on its category, ignoring the inherited route of the parent category.

Fortunetaly, we have a computed field on the product model returning
all the routes from the current category, so we use this one in the
search for procurement rules.

A test has been added to show the failure.
2017-01-10 18:42:37 +01:00
Josse Colpaert 2f66e7abde [FIX] mrp: handle the case of empty routings
Before, when the routing of a production order was empty (no operations),
it got into an inconsistent state (you click on "plan" and nothing happens).

Empty routings were used before to do subcontracting or 2-steps inventeory
(we did not set any operations on the routing but we set a location).

Here, we change the related routing field on the production order into a
calculated field which becomes empty when the routing has no operations.
This way, the "produce" button is displayed (as for production orders
without routing) and working/

This is a temporary patch to workaround the issuein a stable release.
In master, we might remove the location on routing and place it on the
workcenters and put a constraint that does not allow an empty routing.
2017-01-10 18:37:53 +01:00
Christophe Simonis 909ce5175f [MERGE] forward port branch saas-11 up to 9fa79a2d66 2017-01-10 16:57:21 +01:00
Christophe Simonis 9fa79a2d66 [MERGE] forward port branch 9.0 up to fc813847d8 2017-01-10 16:53:27 +01:00
Denis Ledoux fc813847d8 [FIX] account: wrong counterpart in invoice / out refund register payment
Revision 20935462a0
introduces the below regression:

When registering a payment on a customer invoice refund
or a vendor bill, with a payment difference

e.g. payment of 101 for an invoice of 100

and marking the invoice as fully paid,
the counter part in the payment account move
were wrongly computed:

In those cases,
its the payment total minus the invoice residual total
that must be performed, and not the other way around.

This revision solves this, inspired on how
the payment difference is computed for display
in the wizard on how it was before the above revision,
in the method `_compute_payment_difference`

Fixes #15000
2017-01-10 16:49:21 +01:00
Josse Colpaert c2040da0ba [REF] mrp: inventory post when last work order is finished
Before this patch, the inventory was automatically posted when you click
on "done" on the last planned work order. This behavior was preventing
the user from correcting, for example, the consumed quantity on the raw
materials move on the manufacturing order if it was different from the
theoretical quantity. Note that finishing anyone but the last work order
still let you edit the consumed quantity. Same with changing the lot.

Now you have to click on "mark as done" on the manufacturing order to
post the inventory. Note that this is the same behavior when working
without work order (produce > mark as done will post).

We adapt the tests to reflect this change.
2017-01-10 15:32:14 +01:00
Goffin Simon 78646696b8 [FIX] hr_attendance: attendance_manual
In Kiosk mode, the user logged cannot check in and check out his related
employee with any wrong pin.

opw:703744
2017-01-10 15:26:11 +01:00
Denis Ledoux 23deeb187d [FIX] account_check_printing: remove useless sudo
This sudo is useless, and prevent the use of the record
rules on the creation of payments.

opw-703143
2017-01-10 15:09:24 +01:00
Christophe Simonis 482fd04167 [MERGE] forward port branch saas-11 up to f1583504ce 2017-01-10 13:46:17 +01:00
Christophe Simonis f1583504ce [MERGE] forward port branch 9.0 up to 3f7b1f6083 2017-01-10 12:07:44 +01:00
Ravi Gohil 23d07478e3 [FIX] mrp: fix migration issue using recordset instead of record in loop 2017-01-10 09:44:35 +01:00
Nicolas Lempereur 3f7b1f6083 [FIX] web_editor: ignore read only + debug + write
In some case (for example the one solved with b51d21c5) we can have
write done on a field text in read only mode.

With 98ed53ce if :

- such a case happened (in b51d21c5 the fix only worked after the given
  field was written one time) or a similar instance,
- and the user was in debug mode,
- and the widget used was TextFieldHtmlSimple

this could lead to an issue with the code trying to toggle the code view
mode whilst the editor is closed.
2017-01-10 08:31:38 +01:00
Nicolas Lempereur 41c64a89a5 [FIX] stock: use avg for cost in group by report
When doing pivot table data visualization, the Unit Cost of several
lines are summed up but there has more meaning if they were averaged.

This will probably still not be perfect (such as averaging two line
with different quantities the quantities would not be taken into
accounts) but it is already slightly better.

opw-694068
2017-01-09 16:53:40 +01:00
Simon Lejeune 17adc2e09e [FIX] barcodes: form view barcode handler: concurrency
Suppose the following usecase: you scan the first product of the
picking. A server onchange is then triggered. You scan the same product
a second time, before the first onchange has returned. You expect that
the first onchange is completely executed before running the second one.
This was not the case. Moreover, some onchanges were not be able to
work with the invalid  state of the formview at some times, and crashed.

The previous implementation was wrong because id didn't run the main
barcode processing mechanism inside a Mutex. It was also wrong because
it didn't correctly wait for the onchange to execute (a previous  barcode
onchanges or some classic ones) before setting the barcode field.
2017-01-09 16:36:00 +01:00