Remove duplicate fields in tree views / kanban (outside of templates).
A field should not be present twice in a kanban view. If one of the nodes
has custom attributes behavior of other nodes is somehow unpredicatable.
Having field present only once gives a more coherent behavior. Xpaths
could also lead to weird results if fields are present several times.
Notably adding a field in the view preface instead of inside the view
template itself (see b63043e for example of fix).
An heuristic to detect duplicate fields will land soon in master. As this
commit targets a stable version only view fixes are provided.
Task ID-2329114
PR odoo/odoo#56946
X-original-commit: 90f8e9255fa46c408763346ed135d9e561ae7fd5
Remove duplicate fields in tree views / kanban (outside of templates).
A field should not be present twice in a tree view. If one of the nodes has
custom attributes then behavior of other nodes is somehow unpredictable.
Having field present only once gives a more coherent behavior. Xpaths
could also lead to weird results if fields are present several times as
developers generally do not expect fields to be present several times in a
view.
An heuristic to detect duplicate fields will land soon in master. As this
commit targets a stable version only view fixes are provided.
Task ID-2329114
PR odoo/odoo#56946
X-original-commit: 977c2b9d12419fba3bada1ebefcca15f051ca565
Before this commit, the end users were unable to click on the
kanban image to see document's preview.
To fix this we removed lines from a previous fix which is no
longer useful in 13.0 because we now use kanban views for
many2X fields instead of list views.
See original commit:
https://github.com/odoo/odoo/commit/26c62cbb4401bffb72ce77fee481ca84b77a8143
So for mobile phones it's working fine.
For iPads, this rule is no longuer necessary since iPadOS.
See "Accelerated Scrolling on iOS and iPadOS":
https://webkit.org/blog/9674/new-webkit-features-in-safari-13/
For previous versions it still works because the DOM has changed.
Steps to reproduce:
- Go to Document
- Click on "o_kanban_image"
=> Your're stuck on a grayed page.
opw-2260101
closesodoo/odoo#56977
X-original-commit: 0d41d0daa7220a791bc4df85cca4100e3634e432
Related: odoo/enterprise#12907
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
This commit fixes the reminder button classes to enable/disable the right ones
as it's being clicked.
(We also fix a css rule for event colors).
Task ID 2325327
X-Original-commit 58917df45d93cd9787036582e6f745901996166c
closesodoo/odoo#56988
X-original-commit: 0c78735ba82553da2633feb48901ed8d0043c049
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>
- Go to Contacts > Configuration > Country Group
- Open Europe
United Kingdom is still in the group, but should not.
opw-2328125
closesodoo/odoo#56987
X-original-commit: e43c35d3c95c58d6d6af424d4eebf8244c83f332
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
Currently, 200+ country flags are stored in ALL db's as ir_attachment's (thus in the filestore), and also duplicated at each backup, ...
To reduce the footprint of Odoo databases (and their backups), the country flags are now considered as static images and accessed as such, without storing their references in database.
##### New widget for static image URL's
A new `image_url` widget is added (frontend & backend), to allow specification of a static URL in Char fields, enabling the access and display of `res.country` flags through their static urls : `/base/static/img/country_flags/<country_code>.png`.
##### Restriction of countries creation & deletion
To ensure no inconsistency can be introduced because the flags are now static, we now restrict the creation and deletion of countries.
Countries are nearly static data, they shouldn't ever be deleted... This prevents common database inconsistencies, bugs and feature disabling.
Manually created countries can easily be wrongly configured, won't behave as expected and/or will crash with Odoo integration (delivery carriers, taxes, VAT validation/formatting).
Therefore, creation/deletion of countries is limited to admins, supposed to know what they are doing...
Will probably be backported in V14
LINKS
Task ID-2325371
COM PR odoo/odoo#52774
UPG PR odoo/upgrade#1338
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The modification of countries data should be restricted to knowledgeable users.
Indeed, by modifying, deleting and/or creating res.country records, the resulting
behavior generally won't be what you expect, breaking existing flows (delivery, taxes, VAT validation, ...)
in an open OR hidden way...
By restricting those modifications, we reduce the risks of users breaking their database through
'minor' changes unexpectingly triggering 'heavy' problems.
1) Avoid the storage of all country flags as ir_attachment (230+
ir_attachment in a new db) to reduce the filestore of databases.
The country flags are nearly static and not expected to be modified on
Odoo instances.
This change is based on the new "image_url" widget logic (see previous commits).
2) Extend the flag coverage for countries
Add the missing country flags & specify a mapping to provide flags
for overseas administrated countries/territories.
The new "image_url" widget logic provides the ability to provide static image
links in Char fields instead of duplicating the image file in database (+ filestore)
through an Image field (& ir_attachment).
This commits implements the frontend qweb logic for this widget, following the logic
of the existing "image" qweb widget.
This new widget allows definition of Images through static urls stored in a Char field.
It was implemented to provide a way to reduce databases footprint by using
static files instead of duplicating them in the databases (& their backups).
Storing attachment in database (when not specified as an url attachment) copies
the given file in the filestore. When not necessary, this should be avoided to reduce
the databases footprint (and their backups).
On a given instance, the gain is minor, but on servers with hundreds of databases and/or
backups, the impact is noticeable, leading to an economy of scale.
Install "account_check_printing" module
Open "Accounting" icon from the main menu
It opens the journal dashboard by default
It runs the following search domain in account.payment model:
domain = [
...
('payment_method_id.code', '=', 'check_printing'),
...
]
It runs the following query:
SELECT "account_payment".id
FROM "account_payment"
WHERE ...
AND ("account_payment"."payment_method_id" in ($2)))
...
The average duration of this query is 37ms
It query is ran for each journal created
If you have created 600 journals (real case) so it will run 600 times
It will spend more than 22 seconds opening this dashboard
After that, you are available to create accounting actions since that
the menu is not available before of this dashboard
So, it is important to open it faster
Creating the following index:
- account_payment(payment_method_id)
The average duration of the last query is reduced to 0.935ms instead.
It means, it will spend 0.5s opening this important dashboard with 600 journals
44x faster
closesodoo/odoo#56831
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Tours with `step_delay` potentially hide errors because of missing tour steps.
This is mainly caused by unfinished renders within the `step_delay` between
two steps. It is possible that the render after the 1st trigger is not yet
finished but the 2nd step trigger already existed in the screen. Because the
render result of 1st step is late and the 2nd step is already triggered, the
3rd step will fail. Note that the 3rd step will occassionally fail because
render of the 1st step is most of the time faster than step_delay but
there is no guarantee that the render is always faster because of occassional
cpu slow downs.
Runbot will eventually catch these tour errors which it did with the ticket
screen tour.
In this commit, we removed the `step_delay` in the pos tours. We also
supplemented the missing step in the ticket screen tour which was the cause
of random runbot error when there was `step_delay`.
We also figured that value property of input element is not observed by the
tour service's mutation observer, which result to an indeterministic error
in a step in tip screen. To fix this, we introduce an attribute to the input
element which is used in the step trigger.
closesodoo/odoo#56961
X-original-commit: 2ef73bb64cd0730d1e078a47f2ea9e1290b0df6c
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Joseph Caburnay (jcb) <caburj@users.noreply.github.com>
Have a payment method [PAYMENT] on POS with split transactions enabled.
Make a POS sale to a specific customer, pay with [PAYMENT].
Close and validate the session.
While the accounting entry for the POS sale will have the partner set,
this is not the case for the entries related to the payment.
opw-2307973
closesodoo/odoo#56142
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Steps to reproduce the bug:
- Let's consider a rental product RP with variants
- Configure product configurator
- Create a rental order
- Select RP and set a quantity in the product configurator
- Click on Add
Bug:
When the rental.wizard was opened, the quantity was not taken into account and was reset
to 1.
opw:2321357
closesodoo/odoo#56913
X-original-commit: afe0f0d5566df9bccc28535e85dec98d3c7587b4
Related: odoo/enterprise#12871
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
HTTPS had been disabled on SaaS to allow the use of the IoT Box that
had no valid SSL certificate. As of V13.0, IoT Boxes connected to
Enterprise DBs have a valid certificate. POS can then use HTTPS.
Nginx is configured to redirect all requests to `/pos/web` to HTTP,
so we change the POS URL to `/pos/ui`, except when using a Six
payment terminal as it only works in HTTP.
closesodoo/odoo#56933
Taskid: 2191878
X-original-commit: 8aee4992778fee5e2f146c4cff8b35e83c7f56b3
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>
Its most glaring issues have been fixed.
task-2291904
closesodoo/odoo#56921
X-original-commit: b1efd7965a3b185b95bd30beca3d1b7f08165c8a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
PURPOSE
When typing the /help command in discuss, a helper message that is mentioning
the shortcut for canned responses is displayed. The issue is that canned
responses are available to the users after 'im_livechat' module installation.
SPECIFICATION
Display the "Type :shortcut to insert canned responses in your message." part in
the helper when livechat is installed.
LINKS
Task-2264981
PR https://github.com/odoo/odoo/pull/52600closesodoo/odoo#52600
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The tax_base_amount field on account.move.line is expressed using the company currency but the current code is storing an amount expressed using the move currency.
closesodoo/odoo#56905
X-original-commit: 09c59012bf80d2ccbafe21c39e604d6cfda72924
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
- Before this commit, deleting slide category from frontend was not possible
- After this commit, there is a 'trash' icon on the category while hovering
on it (just like slides), clicking which will delete that category and
reload the page to re-arragne the content. If there are slides under the
category being deleted, they will be uncategorized and move to the top.
Task: 2093671
Closes#49646
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, when the city_id field was set and then removed,
both city and city_id were shown, you would see 2 city fields in a weird
way.
opw-2312641
closesodoo/odoo#56896
X-original-commit: b381fb0b644cf3c94e798319ceecf5d6b97df9ad
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Before this commit, the evaluation context was forced with sudo(False)
as the call to _render_qweb_html was made with sudo(True). The sudo
was removed to prevent rendering a report on any object.
This was problematic for reports such as sale.order portal page where
the public user does not have access to the record but uses a custom
verification mechanism using an access_token field and then calling
_render with sudo.
This commit moves the sudo call to keep the _get_evaluation_context
with the same environment and allow to call _render with sudo
Add tests with sale portal building the report as low-priviledge user
closesodoo/odoo#56890
X-original-commit: 57665a02f7b4cd113f8f40ec47c58a518fe8669c
Related: odoo/enterprise#12845
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Before this commit the class btn-outline-alpha was still used in a
button on the job description template. This class is no longer
available in Odoo so we replace it with btn-outline-primary.
task-2312878
closesodoo/odoo#56880
X-original-commit: 5be022b5231cecf82ed30651917c52282df42ebc
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Have an action which help field has the value:
```
<p></p>
```
Display an empty list or kanban
Before this commit, the nocontent helper was displayed even though there was
nothing to display.
After this commit, an empty html tag is the same as an empty string,
so the helper is not displayed.
task-2320318
closesodoo/odoo#56883
X-original-commit: 3d6bdc5b01a4a94de9baa9bae230e6b34f38dbc9
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Currently, when we open kiosk mode in attendance then the barcode
image is broken in community due to wrong img path.
So in this commit, Fix the barcode image as path to display
barcode image properly.
closesodoo/odoo#56868
Taskid: 2327526
X-original-commit: 4bfe8136f7cec853c1339c6d27754b8f1bc1c72d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, the access to private addresses group show in the other
category in user form view and due to that it is visible in non-debug
mode too.
So in this commit, Move the private addresses group to tehcnical
category so it should visible in debug mode only.
closesodoo/odoo#56811
Task-id: 2318509
X-original-commit: 5f0ef2e36c33343a6beada36ef121de4b8767089
Related: odoo/enterprise#12803
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
`_send_reward_coupon_mail` is defined as `ensure_one` but is called on
`self` in `action_confirm` which supports multiple records in self, thus
raising a ValueError when confirming multiple sales orders together.
This commit adapts the method to handle multiple records.
FW-Port of odoo/enterprise#12161closesodoo/odoo#56861
X-original-commit: 99c230c1c167d7369f8003c0219386799f92097d
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Alex Comba <alex.comba@agilebg.com>
When using FacturX, the user shouldn't see any XML. Indeed, the XMLs are embedded inside the PDF.
Then, this is confusing to see all this XML attachments directly in the chatter.
To avoid that, FacturX is now creating the attachments without any link to the account.move.
Also, when reseting to draft/post multi-times, the old attachments are unlinked because if we want to retrieve it, we could look directly inside the old PDFs.
closesodoo/odoo#56844
X-original-commit: ea1a690d9859eca7df478a6b4de3ed704f13e0f8
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
When calling 'button_cancel', the EDI documents that don't need any web-services must be cancelled directly.
X-original-commit: cd668909f578a7bbe87ab5e6f73df82855809c3b
This adds support for pyusb dependency after v1.0.0b2 and
brings a chance to rely upon the system pyusb package instead
of a custom pip installation.
By v1.0.0b2 the public API of the library has changed, and the
'interface' parameter from 'usb.Device.write' method has disappeared.
This patch sets or avoids this parameter depending on the pyusb version
used.
X-original-commit: 312a161cacc7a04c2934a34ffb19cbf607462e69
Allowing to filter the type of EDI attachments data we want to filter allows finer testing when multiple EDI modules are installed. Wihtout that, we risk to also consider data from other formats than the one we are testing (it actually happened for l10n_mx_edi).
closesodoo/odoo#56824
X-original-commit: 719ffecb58a7e81089427c9e22b5e5f99246980b
Related: odoo/enterprise#12811
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
By counting the number of customers/suppliers before doing the query and
updating all at once, we can reduce the number of queries done quite a
lot for big batches of invoices.
closesodoo/odoo#56848
X-original-commit: b0e0035b585f976e912e97e7f95f66b525bc8e43
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>
The peformances were bad when posting a lot of moves at the same time.
This is because a SQL query was executed for each document to retrieve
the last sequence used to build the new one.
By batching the documents to sequence, we can reduce drasticaly the
number of SQL queries done.
X-original-commit: ff26e093c98a5b933620642e242530a8931c1471
PURPOSE
This merge commit fixes a few wording and view issues on the "event online"
layouts, as well as minor templates adjustments.
SPECS
- Avoid breaking the talk description page when description is very long
- Modify all occurrences of "starts at" to "starts on" (better wording)
- Move the "hide sponsor" concept from _exhibitor to _track_online
To be able to hide the sponsors on the "registration confirmed" template
- Hide the sponsor block in "mobile" view (breakpoint md)
- Have a common css definition for background color based on color field
- Reorganize track list display
- Make some minor layout adjustments (agenda colors / ...)
See underlying commits for details.
LINKS
Task ID 2325327
closesodoo/odoo#56812
Forward-port-of: odoo/odoo#56530
Forward-port-of: odoo/odoo#56430
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
According to late specifications we are about to loose at least 20K€ in our
marketing actions if we do not
* add a header 'Book your talks' on track page, as maybe it is unclear
that a talks list having favorite buttons is there to help you booking
your talks;
* put 'Add to favorite' button as standard instead of small;
* reorganize track card in list display, notably
* hide tags in mobile as this adds a lot of noise, especially when having
lot of tracks;
* use background color as in agenda to highlight important tracks;
* move favorite button on top of card in mobile;
* hide duration in mobile, keeping only exact datetime at which is begins;
* globally align items in desktop / mobile to have a nice display;
Task ID-2325327
PR odoo/odoo#56430
X-original-commit: 366b70f3d4758bbab0a3c16dc0ec48f300f1de8c
Some new specifications
* if a track has no color -> use a light bg instead of color_0 which is a
hard gray. This is not really nice when having lots of tracks without
color / some tracks with color;
* align header badges;
Task ID-2325327
PR odoo/odoo#56430
X-original-commit: c804e8eceef03841aa7001a0b2cb14c58a5146f6
SPECIFICATIONS
Have a common css definition for background color based on color field. This
will be used notably for track agenda and list display.
LINKS
Task ID-2325327
PR odoo/odoo#56430
X-original-commit: 92579eddda3f15eef9d759a910000374a73f4410
This commit fixes a few wording and view issues, notably:
- Avoid breaking the talk description page when description is very long
- Modify all occurrences of "starts at" to "starts on" (better wording)
- Move the "hide sponsor" concept from _exhibitor to _track_online
To be able to hide the sponsors on the "registration confirmed" template
- Hide the sponsor block in "mobile" view (breakpoint md)
- Make some minor layout adjustments
Task ID-2325327
PR odoo/odoo#56430
X-original-commit: 342799035911123b609876268a86c1da251f7645
PURPOSE
Clean code. Be more performance oriented.
SPECIFICATIONS
Improvements applied in this commit
* not all() --> any(not) for earlier returns;
* all([generator]) --> all(generator) to avoid unnecessary list casting.
This code construct is better managed by all;
This commit will probably not have a big performance effect on standard
production databases. However each performance and cleaning improvement
is welcomed.
LINKS
Task ID-2328619
closesodoo/odoo#56810
X-original-commit: 1cc6bb1231401ea7f501d2f5b5e9641ec8734850
Related: odoo/enterprise#12802
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The three following fields have been added to fleet.vehicle:
- frame_type (Selection)
- frame_size (Float)
- electric_assistance (Boolean)
These fields are specific to bikes and are only displayed in form view when vehicle_type = bike
Number of doors is now set to 0 instead of 5 when the vehicle is a bike.
"plan_to_change_bike" boolean field has been added to the res.partner model and has also been added as related field in fleet.vehicle model.
Task ID: 2238055
closesodoo/odoo#50064
Related: odoo/upgrade#1718
Related: odoo/enterprise#10152
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Victor Feyens