[FIX] various: remove duplicate fields in tree views

Remove duplicate fields in tree views / kanban (outside of templates).

A field should not be present twice in a tree view. If one of the nodes has
custom attributes then behavior of other nodes is somehow unpredictable.

Having field present only once gives a more coherent behavior. Xpaths
could also lead to weird results if fields are present several times as
developers generally do not expect fields to be present several times in a
view.

An heuristic to detect duplicate fields will land soon in master. As this
commit targets a stable version only view fixes are provided.

Task ID-2329114
PR odoo/odoo#56946

X-original-commit: 977c2b9d12419fba3bada1ebefcca15f051ca565
This commit is contained in:
Victor Feyens
2020-09-03 08:45:21 +00:00
committed by Thibault Delavallée
parent f9e7b5130b
commit e261cddd73
5 changed files with 2 additions and 6 deletions
+2 -2
View File
@@ -286,7 +286,8 @@
<field name="mode">primary</field>
<field name="inherit_id" ref="account.view_move_line_tree"/>
<field name="arch" type="xml">
<field name="matching_number" position="after">
<field name="move_id" position="replace"/>
<field name="matching_number" position="replace">
<field name="tax_line_id" string="Tax"/>
<field name="tax_base_amount" sum="Total Base Amount"/>
<field name="tax_audit"/>
@@ -294,7 +295,6 @@
</field>
<field name="date_maturity" position="replace"/>
<field name="analytic_account_id" position="replace"/>
<field name="matching_number" position="replace"/>
<field name="debit" position="replace"/>
<field name="credit" position="replace"/>
</field>
@@ -460,7 +460,6 @@
<field name="payslip_status" widget="toggle_button" options='{"active": "Reported in last payslips", "inactive": "To Report in Payslip"}' groups="hr_holidays.group_hr_holidays_user" nolabel="1"/>
<field name="state" widget="badge" decoration-info="state == 'draft'" decoration-warning="state in ('confirm','validate1')" decoration-success="state == 'validate'"/>
<field name="category_id" invisible="1"/>
<field name="department_id" invisible="1"/>
<field name="user_id" invisible="1"/>
<field name="message_needaction" invisible="1"/>
<button string="Approve" name="action_approve" type="object"
@@ -31,7 +31,6 @@
<field name="priority">10</field>
<field name="arch" type="xml">
<tree string="Mailings" sample="1">
<field name="state" invisible="1"/>
<field name="subject" attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}"/>
<field name="mailing_type" invisible="1"/>
<field name="mailing_model_id" string="Recipients"/>
-1
View File
@@ -201,7 +201,6 @@
<field name="company_id" invisible="1" force_save="1"/>
<field name="picking_id" invisible="1" force_save="1"/>
<field name="move_id" invisible="1" force_save="1" />
<field name="picking_code" invisible="1"/>
<field name="product_uom_category_id" invisible="1"/>
<field name="product_id" invisible="1"/>
<field name="package_level_id" invisible="1"/>
@@ -42,7 +42,6 @@
<field name="active" invisible="1"/>
<field name="allowed_route_ids" invisible="1"/>
<field name="product_category_id" invisible="1"/>
<field name="warehouse_id" invisible="1"/>
<field name="product_tmpl_id" invisible="1"/>
<field name="product_id" attrs="{'readonly': [('product_id', '!=', False)]}" invisible="context.get('default_product_id')" force_save="1"/>
<field name="location_id" options="{'no_create': True}" groups="stock.group_stock_multi_locations"/>