Commit Graph
118414 Commits
Author SHA1 Message Date
Toufik Benjaa f12287c356 [FIX] website_crm_partner_assign: display partner ordered by sequence
- Fix for e2310eec60
2018-08-24 11:13:47 +02:00
sed-odoo 4015c84633 [FIX] web: Disable keyboard shortcuts on BlockUI
Related to the bug: 1874270

Purpose
=======

Keyboard shortcuts working on BlockUI and can cause some issues when used.

Specification
=============

It should not work and should not be display while some process is being executed.

- add function to remove the "accesskey" attributes to avoid the use of the
  access keys while the blockUI is enable.

- add function to reset the "accesskey" attributes when the blockUI is disable.

- add condition to avoid the "Alt" key to reattribute access keys.
2018-08-24 10:49:30 +02:00
Toufik Benjaa 61d790d6e2 [FIX] base: avoid crash when acessing image without access_token
- When accessing an image from an "ir.attachment" which doesn't have an
  access_token, the code crashes if you provide the argument access_token
  on the URL.

  This is due to a comparison between a boolean and a string using the
  consteq function.
2018-08-23 15:20:24 +02:00
Christophe Monniez d4f36c0e8b [FIX] hr_holidays: remove unread meassages filter
Before the models split in a0f4f65 the Leaves Summary report inherited
the message_needaction from mail.thread.  Now the hr.leave.report model
does not have this field and leads to a traceback.

With this commit, the filter is removed from the search view of the
report.
2018-08-23 14:57:14 +02:00
Toufik Benjaa e2310eec60 [FIX] website_crm_partner_assign: display partner ordered by sequence 2018-08-23 14:54:08 +02:00
Toufik Benjaa 26084f1cc7 [FIX] web: allow to bypass postprocess on image widget
- If a CDN is used, this might cause issues for images that need access
  rights to be display.

  This is due to the fact that users are not connected on their account
  under the CDN domain, which makes the CDN requests reject since it is
  not authorized to access to those resources.
2018-08-22 15:30:52 +02:00
Toufik Benjaa 7f775f0677 [FIX] hr_expense/holidays: approval issue if manager in different company
- When trying to retrieve the manager of an employee who is in a
different company, an access right error appears.
  This commit fixes this issue.
2018-08-22 12:17:44 +02:00
tanghulu0608 e1d4b48d8e [FIX] web: correctly apply pdf_viewer style
The pdf_viewer widget has been moved from mrp to web in rev. odoo/odoo@a7b521f
but the corresponding style was still in the mrp module. It's now put in the
right place.

Closes #26449
2018-08-22 11:40:40 +02:00
Christophe Simonis 6cc7d3f945 [FIX] web: correct test view option name 2018-08-21 17:36:34 +02:00
Christophe Simonis 70d0148d0d [MERGE] forward port branch 11.0 up to fbfb91799e 2018-08-21 16:58:17 +02:00
Christophe Simonis fbfb91799e [MERGE] forward port branch saas-15 up to 9cf0dbe226 2018-08-21 16:00:40 +02:00
Christophe Simonis 9cf0dbe226 [FIX] base_sparse_field: improve fields' view
Set default values when creating serialized field from contained field.
2018-08-21 15:12:16 +02:00
Nicolas Martinelli 65c2a9b70c [FIX] sales_team: default team is active
Check the default team is active. Moreover, make the return object type
consistent.

opw-1876966
2018-08-21 14:46:11 +02:00
Christophe Simonis c619b19f66 Revert "[FIX] manual creation of serialized field from the interface"
Non applicable since b0646f9d2c.

This reverts commit 03395ea103.
2018-08-21 14:13:15 +02:00
Nicolas Martinelli f46761caa8 [FIX] membership: change partner on invoice
- Go to a contact C1 > Membership tab > Buy membership
- Create an invoice with the membership
  => It creates a membership line on C1
- Change the partner on the invoice to C2

The membership line and the membership status is not transfered to C2.

We first need to recompute on C1, and we also need to explicitly write
the new partner C2 on the membership lines.

opw-1875673
2018-08-21 13:39:16 +02:00
Nicolas Martinelli b8161ec806 [FIX] membership: cancel invoice
- Go to a contact > Membership tab > Buy membership
- Create an invoice with the membership
  => The status of the member goes to 'Waiting membership'
- Validate the invoice
  => The status of the member goes to 'Invoiced membership'
- Create a credit note to cancel the membership
  => The status of the member goes to 'Paid members'.

It shouldn't be the case because the client has canceled his membership.

We look on `payment_move_line_ids` instead of `payment_ids`. Indeed, the
latter doesn't list credit notes, while the first one lists all move
lines used for payment.

opw-1875673
2018-08-21 13:39:16 +02:00
Christophe Monniez c8762eaa03 [FIX] hr: properly set label in kanban-box
In recruitment, clicking on configuration > job positions > kanban view
leads to an odoo client error.

The qweb template cannot evaluate the condition on the client side.
With this commit, the ternary condition is properly evaluated.

Also, an unnecessary t-attf is removed.

Closes #26486
2018-08-21 12:08:31 +02:00
Christophe Simonis e80f853ab3 [MERGE] forward port branch saas-14 up to aafa6e38c4 2018-08-21 12:06:23 +02:00
Toufik Benjaa a05ae78abd [FIX] mail & project: Display access button on mail notifications
This commit fixes two issues:

	- If a partner has multiple users and if any of these users is a
          share user, then the access button on mail notifications is not displayed.

	- If a project.task is either assigned or has its stage folded
	  the access button may not be displayed for certain users.
	  The users affected by this bug are the one who have their user's
	  partner is linked to multiple users with at least one flagged as a share user.
2018-08-21 11:58:50 +02:00
Christophe Simonis aafa6e38c4 [MERGE] forward port branch 10.0 up to 342d037373 2018-08-21 11:33:53 +02:00
Christophe Simonis 342d037373 [MERGE] forward port branch 9.0 up to f750393030 2018-08-21 10:50:32 +02:00
Pedro M. Baeza 87a6b879a2 [FIX] account: Fix tax summary on invoice report
We want to show the base amount for the tax when there are multiple taxes or the
amount is not the invoice total, not the contrary.
2018-08-21 10:36:53 +02:00
Lucas Perais (lpe) cc72b0c2fa [FIX] crm: fix API
Because of 2917b38f28 which appeared in v9.0 but has not been adapted to the new API
afterwards, the early return was out of sync with what a search returns in new API

in v9.0: search returns a list, so must our early return

in v10.0: search returns a recordset, hence the fix

OPW 1878192
closes #26474
2018-08-21 09:37:54 +02:00
Nicolas Martinelli 07b5f205ab [FIX] models: unlink ir.property
On a new DB with demo data, as Demo User:
- Create a partner
- Unlink the partner

An `AccessError` is raised.

The error is raised on `ir.property`, for the field
`property_product_pricelist`. An entry was indeed automatically created
at partner creation. However, a regular user is not allowed to delete an
`ir.property`.

The property can be safely deleted as SUPERUSER as long as the proper
unlink access rights have been tested beforehand.

opw-1870737
2018-08-21 09:32:01 +02:00
Olivier Dony f750393030 [FIX] website_forum: properly catch errors for email activation 2018-08-21 03:28:59 +02:00
Denis Roussel f5a8eef02b [FIX] l10n_be_inovice_bba: Missing field in supplier invoices
reference_type was already present in the customer invoice but not in the
supplier invoice

Closes #25732
2018-08-20 16:33:06 +02:00
Adrien Dieudonne 634de21b76 [FIX] web: graph_renderer: check graph data before rendering
Before this commit, we had two different errors when data was
unavailable:
The first one is generated by Odoo: "No data to display, try to[...]"
The second one is generated by nvd3: "No Data Available".

We always want the same message.
So now, we always make some checks before rendering
the graph by calling _render.
2018-08-20 16:10:25 +02:00
mreficent 42c2274eac [FIX] test_exceptions: Import correctly safe_eval
Trying to generate an exception using a safe_eval was failing
Introduced at 12634e1
Can be ignored for v10 (fixed at bd00fcd)

Closes #26450
2018-08-20 15:58:10 +02:00
Pieter Paulussen 00eb2e3e6d [CLA] update Dynapps N.V. CLA agreement
Closes #25336
2018-08-20 15:48:28 +02:00
Rohan Patel 7b50bda171 [FIX] l10n_fr_hr_payroll: correct typo
correct attribute in xml, style instead of stype

opw-1878290

Closes #26471
2018-08-20 15:43:25 +02:00
Habib Ayob 13252a7daf [CLA] Paradigm Digital signs Odoo's CCLA
Closes #26468
2018-08-20 15:40:26 +02:00
Alexandre Moens 429f785426 [REV] Revert "[FIX] Stock : deliveryslip report - prioritize partner_id (#25709)" (#26458)
This reverts commit 6e8f1fcc63.

Reverted commit broke more than it fixed.

What it fixed : Show partner info when partner is changed after the
movelines are created (very specific used case, could be considered to
be the wrong way to do things)

What it broke : dropshipping
2018-08-20 15:29:29 +02:00
oleksandrpaziuk aab2fc0e33 [FIX] l10n_ch: Improvements of VAT report and implementation TVA return charge
Was PR #25190
2018-08-20 14:57:30 +02:00
Benoit 03395ea103 [FIX] manual creation of serialized field from the interface 2018-08-20 13:56:29 +02:00
Toufik Benjaa 21430a4d02 [FIX] hr_holidays: Leaves approval fails on multicompany
- When trying to approve a leave with a manager in a different company
an access rights error is triggered.
2018-08-20 12:52:58 +02:00
Lucas Perais (lpe) b2be451c7c [FIX] point_of_sale: fix rounding logic
Use case specifically for round globally, but the justifications hold anyway
Have a session with one tax, multiple partners, and returns of freight (negative amounts)

When validating a pos.session, the computation of amls was a bit out of logic,
Namely, we grouped tax lines by :
1. their tax id (correct)
2. their partner_id (not wrong but limited)
3. their balance > 0 (wrong)

The justification for point 2 and 3 is two fold:
- Ultimately, the order is level of granularity that really makes sense
It's the order that is paid and therefore that has both legal and business meaning
and on which the amounts are retrieved anyway
- On the order, we litterally make the sum of tax amounts of each line, aggregating
credit and debit under the same variable
It is only logic to do the same for grouping the taxes at validation time

This commit only corrects the behavior for the rounding method 'globally'

OPW 1865700
closes #26203
2018-08-20 10:23:27 +02:00
Jeremy Kersten c89c1c23c9 [FIX] website_forum: fix typo introduced by #bae90d8
This commit closes opw-1877970
2018-08-20 10:10:04 +02:00
Grzegorz Krukar 48b492b086 [FIX] gamification: correctly set computed values
Field incorrected named
Introduced at 0c64964

Closes #25307
2018-08-20 09:10:20 +02:00
Tommy Tran 89bea8ef43 [FIX] hr_maintenance: fix singleton error in _compute_owner
avoid singleton error when accessing on multiple records

Iontroduced at 9a20c6556f

Closes #25379
2018-08-20 09:04:00 +02:00
Nicolas Martinelli a456161680 [FIX] sales_team: AccessError on default team
- Create 2 companies C1 and C2
- Assign User U1 in C1
- Assign the default Sales Team (`sales_team.team_sales_department`) to
  C2
- Create an invoice with U1

An `AccessError` is raised because the user is not allowed to access the
default Sales Team.

We fall back on `sales_team.team_sales_department` only if the user has
read access.

opw-1876966
2018-08-20 08:41:10 +02:00
Odoo Translation Bot a7dd10a838 [I18N] Update translation terms from Transifex 2018-08-19 04:12:48 +02:00
Odoo Translation Bot afffcc971f [I18N] Update translation terms from Transifex 2018-08-19 00:28:25 +02:00
Nicolas Lempereur d409ab6f32 [FIX] web: open group in list => keep line selection
You:

- open a grouping in a list view
- check a line of this grouping
- open another grouping

=> all checkbox are unchecked

With this commit, 0982ceaa is improved so the selection is only reset
when the list has been reloaded.

opw-1865736
closes #26213
2018-08-17 15:33:40 +02:00
Nicolas Lempereur ac1e187eea [FIX] document: no query attachment out of form view
Since cce70fd4 the attachment menu is only displayed for form view.

But if in another view there is active_ids (eg. selecting record in a
list view), we will still make a query to ir.attachment without using
the result.

Without the code change, the added test would fail when doing a
search_read RPC call to ir.attachment model.

related to #26213
2018-08-17 15:33:40 +02:00
Kirti Choudhary 80118dd8a2 [IMP] document: added QUnit testcase
note: backport 562d467 from saas-11.2 to 11.0 to add a similar test

related to #26213
2018-08-17 15:33:40 +02:00
len-odoo 9f1534ee8c [FIX] stock: add origin to the chatter when creating a picking from a sale order
Before v11, the picking origin was added to the chatter, which is a useful
feature.
We add it back.

opw 1874379
2018-08-17 15:19:36 +02:00
Nicolas Martinelli b4cbf0bb61 [FIX] calendar: date start
When creating and editing a new calendar.event record from the calendar
view, the start_datetime field does not prefill from the day that was
selected on the calendar.

Introduced in e08f999468

opw-1875276
2018-08-17 13:38:32 +02:00
Nicolas MartinelliandArnold Moyaux f0028bc837 [FIX] mrp: raw materials and multi-location
- Create a BOM for Product P with the following component:
  Product C, 5.0 units
- Make some stock for C:
  2 units in location 1
  3 units in location 2
- Create a MO for P, reserve.

When trying to produce an error arise:

> Cannot set the done quantity from this stock move, work directly with
> the move lines.

If the user tries to unlock the MO in order to set the done quantity on
the move lines, the same error will arise when trying to produce.

In the specific scope of the production, we set the quantity done on the
move line instead of directly on the move, to avoid this limitation.

opw-1871241

Co-authored-by: Arnold Moyaux <arm@odoo.com>
2018-08-17 13:21:28 +02:00
Lucas Perais (lpe) 412c471e78 [FIX] tools: sanitize allow white-space style
OPW 1870847
2018-08-17 12:58:21 +02:00
Joren Van Onder 750e70e0a1 [FIX] l10n_co: remove duplicate account template
Introduced by 986a7550a5.
2018-08-16 14:56:51 -07:00