Commit Graph
126133 Commits
Author SHA1 Message Date
Goffin Simon b27c5e0c36 [FIX] base: Wrong view displayed
Steps to reproduce the bug:

- Go to Contact app
- click on Configuration > Bank accounts
- Create a new one

Bug:

It was impossible because the field partner_id was hidden.
The form view view_company_partner_bank_form was displayed instead
of view_partner_bank_form.

opw:1908114

closes odoo/odoo#28916
2018-11-26 12:25:11 +00:00
Goffin Simon a9c9a3d8e4 [FIX] maintenance: Access rights with admin
When only installing in a new instance the app maintenance,
the admin was not in the group 'group_equipment_manager'.
So when going to Maintenance > Equipment, the button create
was not available

opw:1912453

closes odoo/odoo#29026
2018-11-26 12:06:10 +00:00
Nicolas Lempereur 6d7a085040 [FIX] sale: de translation can ecommerce wired
There was an issue in translation that broke the mail template "Sales
Order: Send by email" in german. This prevented to do a wired sale on
the ecommerce in german.

This has been fixed in https://transifex.com/odoo/ but is done in this
PR to fix it more speedily than next week.

opw-1911419
opw-1911696
closes #29033
2018-11-26 17:21:02 +00:00
Jeremy Kersten 18e3746969 [FIX] website_sale: uniform multi-website public users handling
When determining the last order for a given user, public users from
other websites need to be properly ignored. The previous behavior was
broken by 9d72263717
2018-11-23 12:14:13 +00:00
Alexandre Kühn b4f132ca21 [FIX] bus: elect master tab when master tab is unloaded
Before this commit, chat windows could not be sync'ed
between browser tabs for about 10 to 20 seconds.

This issue is caused by the implementation of the
crosstab longpolling, which uses a master-slave
architecture with a single tab being the master tab.
The master tab is responsible for performing the
longpolling RPC, so that it keeps a single HTTP request
for all Odoo tabs. Other tabs are synchronized through
the local storage.

When the master tab was closed, a new master tab election
must occur. However, this process was taking up to 20 seconds,
due to the tab waiting for their next tick on the local
storage to initiate a new election. The tick for a slave
tab is 10 seconds, and it may jumps a tick in case the master
tab is closed exactly before the tick, hence extending the
duration to 20 seconds.

This commit fixes the problem by ensuring that the tab
election for the longpolling is done right after the master
tab is closed. As a result, a new master tab should follow
right away.

Steps to reproduce:

1. open two tabs.
2. open a chat window in one tab: it opens in both tabs.
3. fold/unfold chat window in one tab: both tab should sync.
4. refresh both tabs.
5. fold/unfold chat window in one tab: both tab should not sync.
6. after 10 or 20 seconds, both tabs should again sync.

Task-ID 1911437

closes odoo/odoo#28925
2018-11-21 16:43:27 +00:00
Toufik Ben Jaa dbd5cb48e2 [FIX] mail: check access rights on models when fetching messages
- When fetching messages (e.g. opening discuss), we do not check if the
  model associated to a message is accessible for the current user.
  This could result to access rights error messages when trying to read the
  main attachment of the associated record.

  To avoid to triggers this errors, we first check if the current user
  has read access to the specific model, if so we try to read the
  record's main attachment.

closes odoo/odoo#29025
2018-11-26 10:42:37 +00:00
Nicolas Martinelli fab4451c0e [FIX] account: account documentation
The example given when creating an account only applies to United
States. It is then confusing to users in other countries.

opw-1908241

closes odoo/odoo#29019
2018-11-26 08:23:42 +00:00
Robot Odoo 96506d1add [MERGE][FIX] mail: several discuss and messaging menu fixes
This merge fixes the following issues

1.  No prefix '#' on DM chats
2. Undated previews appear last in the messaging menu

It also adds a missing test for "[FIX] mail: add mention no set focus on subject" https://github.com/odoo/odoo/commit/6d5df714a7970f69a27296c157b08772ceac5b7d.

Task-ID 1911738
Task-ID 1912001

closes odoo/odoo#28926
2018-11-26 10:51:39 +01:00
Alexandre Kühn c45c5bb411 [FIX] mail: messaging menu show undated DM previews last
This commit fixes two related issues:

1. Previews without any message should not be dated.

Before this commit, when a channel or dm preview had no date,
it was displaying the current date. This commit fixes the issue
by not showing the date for those previews.

2. Dates previews should appear before undated previews.

Before this commit, undated previews were considered similarly
as dated previews in the ordering of previews in the messaging
menu. Since DMs are shown before Channels, any pinned DM without
any message were displayed on top of messages with some message.
This commit fixes the issue by putting undated previews after
dated ones. This rule is applied before considering type of the
thread (i.e. DMs before channels).

Task-ID 1912001
2018-11-26 08:51:34 +00:00
Alexandre Kühn c22539fd8c [ADD] mail:tests: add test for https://github.com/odoo/odoo/commit/6d5df714a7970f69a27296c157b08772ceac5b7d 2018-11-26 08:51:34 +00:00
Alexandre Kühn 341fb5f240 [FIX] mail: no '#' prefix in DM name
Before this commit, DMs had the prefix '#' in their
displayed name (e.g. '#Demo User').

This commit fixes the issue by putting this prefix
only on non-chat DMs. In particular, mailboxes, DMs
and Livechats no longer show this prefix. This change
is also visible in the breadcrumb of the discuss app.

Task-ID 1911738
2018-11-26 08:47:36 +00:00
Odoo Translation Bot 07f6b8ef57 [I18N] Update translation terms from Transifex 2018-11-25 01:26:32 +01:00
Christophe Simonis 2569bcc11d [FIX] crm: allow to filter leads by activities
This was possible do to it on opportunities, but not on leads (other
search view).
This is needed to allow effective search from activity dropdown.

closes odoo/odoo#29003
2018-11-23 17:42:22 +00:00
sri-odoo b6246b3a46 [FIX] * : add missing app icons
- Add missing SVGs files
- Add icons for new apps

closes odoo/odoo#28992
2018-11-23 15:28:32 +00:00
Jeremy Kersten 04a3d61954 [FIX] website: settings - related field are now RO by default
Following of 3f4f77f and 52a8ed3c0c

closes odoo/odoo#28997
2018-11-23 15:05:46 +00:00
Aaron Bohy 06b91b7658 [FIX] web: benchmarks: add missing test_utils
Without those, the benchmarks suite can't run.

closes odoo/odoo#28996
2018-11-23 15:00:17 +00:00
Aaron Bohy fad35964bf [IMP] web: backport of new asserts
This rev. is a complement to the partial backport 49e78f46 of
abf32b8. In addition to the helpers, we also backport the asserts
(like isVisible, containsOnce...).

closes odoo/odoo#28994
2018-11-23 14:51:49 +00:00
Robot Odoo df1fea4de1 [FIX] web_unsplash: new guidelines negociated with Unsplash
Unsplash CEO asked us to stop exposing our key client side (even if it was
only in the browser network and previously allowed by their API team leader).

Also, all our Odoo instances (on premise or not) should share the same
production key, which is not possible in our case obviously.

After multiple exchange, it has been negociated that:
1. Our non saas user won't be able to apply for a production key and should
   prefix they Unsplash application name by 'Odoo:'. Their key will remain in
   test mode.
   Indeed, Unsplash won't be able to review every Odoo application and ensure
   it respects the API terms and it is a real application.
2. Our saas user will query Unsplash server side so the key remain hidden.
3. The documentation should explain it all

task-1911345

closes odoo/odoo#28804
2018-11-23 17:04:50 +01:00
Robot Odoo cd2637cfdf [MERGE] Avoid some unnecessary ormcache invalidations
Avoid invalidating ormcache when possible.
There are currently too many invalidations, which makes the ormcache less effective in practice.

closes odoo/odoo#28993
2018-11-23 16:04:32 +01:00
Romain Derie 55073e3baa [FIX] web_unsplash: add unsplash searched terms in attachement name/url
Before this commit:
An unsplash image would be saved as an attachement with:
  - A name like 'x54ze78z.JPEG'
  - An url like '/unsplash/x54ze78z.JPEG'
  - A filename like 'x54ze78z.JPGED'
We would not store the searched terms in the name/url.
Then, we would not be able to search on local attachement in the media dialog
to retrieve the images based on what we searched.

Now:
We store the searched terms in the name/url so it can be used later in the
media dialog search:
  - Name like 'big_lion.jpg' (duplicates may be possible)
  - Url like '/unsplash/x54ze78z/big_lion.jpg'
  - Filename like 'unsplash_x54ze78z_big_lion.jpg'

Task-1911345
2018-11-23 14:58:48 +00:00
Romain Derie 8b1a05d9e0 [FIX] web_unsplash: don't expose client_id in network
Unsplash CEO asked us to stop exposing our key client side (even if it was
only in the browser network and previously allowed by their API team leader).

After multiple exchange, it has been negociated that:
1. Our non saas user won't be able to apply for a production key and should
   prefix they Unsplash application name by 'Odoo:'. Their key will remain in
   test mode.
   Indeed, Unsplash won't be able to review every Odoo application and ensure
   it respects the API terms and it is a real application.
2. Our saas user will query Unsplash with a dedicated enterprise key
3. The documentation should explain it all

Task-1911345
2018-11-23 14:51:07 +00:00
Raphael Collet c96d4cdbad [FIX] base: ormcache invalidation in ir.config.parameter
Writing on a parameter invalidates the ormcache and propagates the invalidation
to other workers.  Setting a parameter to its current value should not trigger
ormcache invalidations.
2018-11-23 14:02:17 +00:00
qsm-odoo 9049892152 [FIX] website: add some more BS3 compatibility
Completes https://github.com/odoo/odoo/pull/27981

- Correct `col-*-offset-*` support.

- Compatibility for BS3-deprecated `visible-*` classes (only not taking
  care of table/table-row/table-cell cases as difficult with sass and
  those classes were already BS3 deprecated anyway).

- Correct order for BS3 `visible-*-*` and `hidden-*` classes (otherwise
  their combination are not correctly working). Also, the 'inline'
  version was forgotten by previous PR.

- Compatibility for BS3 `btn-xs` class.

closes odoo/odoo#28842
2018-11-22 14:09:22 +00:00
RomainLibert 1111de6eb2 [FIX] hr_holidays: use display_name instead of name
In order to see the remaining days in the tree view we need to use
display_name instead of name, as display name will use the name_get
which is overriden to add this information.

closes odoo/odoo#28981
2018-11-23 10:52:42 +00:00
Yenthe V.G 5fd5c4095b [IMP] hr_recruitment: improve English in demo data
closes odoo/odoo#28970
2018-11-22 16:59:58 +00:00
Raphael Collet e181f592f3 [FIX] odoo: ormcache invalidation on loading registry
Do not propagate cache invalidations to other workers when simply loading the
registry.  Only do it when installing/upgrading/uninstalling modules.
2018-11-22 11:05:30 +00:00
Raphael Collet ad065093eb [FIX] models: ormcache invalidation on import
Do not propagate cache invalidations to other workers when changes must be
discarded, because of an import error or a dry run, which are both handled as
successful transactions.
2018-11-22 11:03:51 +00:00
len-odoo fff6c93830 [FIX] board: fix the domain of consecutive 'add to dashboard' operations
Add a search containing a domain to dashboard. Remove that domain.
Do a new search with a different domain.
Add that search to dashboard;
the domain sent would be the concatenation of the two domains.

We make it so that only the last domain is sent, with a test.

opw 1907650

closes odoo/odoo#28843
2018-11-20 13:44:56 +00:00
Christophe Simonis 0ef5cedebb [MERGE] forward port branch saas-14 up to 637e4c68fc 2018-10-08 17:29:03 +02:00
Christophe Simonis 637e4c68fc [MERGE] forward port branch 10.0 up to e88c5c1ece 2018-10-08 17:28:08 +02:00
Martin Trigaux 3e178daa30 [I18N] l10n_multilang: export source terms
closes odoo/odoo#27544
2018-10-08 14:34:21 +00:00
len-odoo e88c5c1ece [FIX] mail: sudo on user name
Suppose user A creates a sale order S in company X. He then changes to company Y
Sales manager B, in company X, creates the invoice for sale order S.
Bug: the compilation of the report fails because of the user.name in the
template. Then the tracking update fails, making it impossible to validate the
invoice.

opw 1884915
2018-10-08 15:59:30 +02:00
Nicolas Martinelli 94a4b695e9 [FIX] account: remove useless file
The file is not imported by the manifest following the removal of the
reports.

opw-1891341

closes odoo/odoo#27542
2018-10-08 13:55:31 +00:00
Nicolas Martinelli a4e46846d7 [FIX] point_of_sale: float comparison
- Create the following pricelist for product A:
  4 Units: 2.88
  3 Units: 3.45
  2 Units: 4.85
  1 Units: 7.50
- In the POS, click several time on A to add in the cart

The 2 first units are merged in a single line, but from the third one a
new line is created.

This is because of the float reproesentation of 4.85, which becomes
4.8500000000000005.

opw-1887586

closes odoo/odoo#27539
2018-10-08 13:16:51 +00:00
Christophe Simonis 1b5f14713b [MERGE] forward port branch saas-15 up to 0ef5cedebb 2018-10-08 18:59:03 +02:00
Christophe Simonis 0efe62d63d [MERGE] forward port branch 10.0 up to 085d504561 2018-10-08 14:51:52 +02:00
Nicolas Martinelli c36dedb095 [FIX] account: prevent incorrect fiscal year end date
We prevent setting a fiscal year end date which doesn't exist.

opw-1890518

closes odoo/odoo#27534
2018-10-08 12:32:05 +00:00
William Henrotin 53bc3d90d8 [FIX] mrp: remove multiness in non multi method
The method button_start begins by an ensure_one() but loop on self too. 
This commit removes to loop for cleaner code.

Task : 1850640

closes odoo/odoo#27532
2018-10-08 12:01:49 +00:00
Duc Dao 085d504561 [FIX] base: use correct field for Vietnamese
There is no name field but a state_name one
Closes #27512
2018-10-08 12:13:32 +02:00
Yannick Tivisse c972b62b3c [IMP] fleet: Load fleet vehicles as data instead of demo data
Purpose
=======

In the fleet module, Models & Brand are in demo data. It should be loaded as regular data.

closes odoo/odoo#27524
2018-10-08 09:55:20 +00:00
Laurent Smet 847ad7a44d [IMP] account: rename write-off to counterpart in reconciliation model
'Write-off' is a wrongly used term in the reconciliation model.

A write-off occurs when a client owes money to you but is unable to pay.

closes odoo/odoo#27518
2018-10-08 09:20:56 +00:00
Julien (juc) Castiaux fbd4eba87d [FIX] mail: groupby was using a wrong create_id field
Grouping mail activities by "Created by" was grouping on the
"create_uid" field which is always the admin user. New groupby
groups using the "create_user_id" field which is the real id
of the creator.

opw-1886369

closes odoo/odoo#27718
2018-10-12 10:58:54 +00:00
Aurélien Warnon f25ead03c6 [FIX] (website_)sale: fix product_attribute_custom_value access right
Targets commit d3530eb07e

Purpose
=======
Users within the "sales_team.group_sale_salesman" group should be able to
access/add/edit/delete custom attribute values.

closes odoo/odoo#27654

closes odoo/odoo#27679
2018-10-11 11:19:51 +00:00
Rémi Rahir cf9d962dc9 [IMP] iap: split charge to ease developer's work
Imp/refactoring of the charge function to make tools available for asynchronous services.

closes odoo/odoo#27686
2018-10-11 14:43:15 +00:00
Christophe Monniez 4f28121065 [FIX] web: increase clickEveryWhere test timeout again
Two minutes increase was obviously not enough.

closes odoo/odoo#27709
2018-10-12 08:34:37 +00:00
Romain Derie 47406d6e5d [FIX] website_hr(_recruitment): make website specific
As commit 066cfc9598 did for other website_module, this commit make theses
2 modules multi-website compatible.

Mostly by:
  - Adding website_id in form/list views
  - Preventing routes from being accessed by wrong website (only needed for
    admin as portal users will get a 403)
  - Adapt search([]) with multi website domain
  - Add domain in model converter in routes for URL autocomplete (eg menu URL)
    Note that it is not needed for sitemap.xml

closes odoo/odoo#27528
2018-10-11 17:08:20 +00:00
Aaron Bohy 76cc621c1d [FIX] web: grouped list view: group header layout
This rev. ensures that the group name is vertically centered inside
the group header row. Padding rules have been moved from enterprise
to community.

Task 1878254

closes odoo/odoo#27603
2018-10-11 19:03:57 +00:00
Jeremy Kersten c4e0e5461c [FIX] web: guess resize placeholder
Before this commit, if you ask for a small image, you was waiting a picture of
64x64 but in case this image was not found, a placeholder with an other size
was returned.

Now, we try to guess the asked size, and return a resized placeholder.

This bug appear since we change the default placeholder picture with a big one

This will fix several issue and avoid to hard code size everywhere in the code

Eg: commit 92f837c and commit https://github.com/odoo/odoo/commit/154fc7d9dd550d35b7266af024e54c20e18938fc#diff-9af1af2039d16d6b544d481b4ee1ed7cR144

closes odoo/odoo#27695
2018-10-11 17:21:53 +00:00
qsm-odoo c7f72248a9 [FIX] web: clear all BS4 alerts
Commit https://github.com/odoo/odoo/commit/8caf84f70ada259f041b424d37686845604d182a
was not handling the case where there was an invisible DOM element
between the button box and the alert component. Let us clear all alerts.

This commit also introduces a way to properly fix/extend bootstrap in
future fixes/updates (some of our rules may already be moved in that
file once it is forward-ported to master).

closes odoo/odoo#27662
2018-10-11 16:31:24 +00:00
Manuel Vázquez Acosta c77f7fc5cd [FIX] models: Allow rich comparison with third party objects.
Instead of returning False directly when comparing a non-model, return
NotImplemented that will trigger the __eq__ test from the other side.

This allows third party objects (for instance a serialization/deserialization
scheme) that cannot be a Model to be considered equal is some scenarios.

closes odoo/odoo#19977
2018-10-11 16:59:49 +00:00