Commit Graph
126133 Commits
Author SHA1 Message Date
Christophe Simonis f6ea6ce951 [MERGE] forward port branch 11.0 up to c576800813 2018-10-09 13:55:53 +02:00
TWA 983c7e8152 [IMP] mail,crm,...: Replace occurences of name_get()[0][1] by display_name
Purpose
=======

display_name is equal to doing name_get()[0][1]

Replacing name_get()[0][1] by display_name could be good for 2 things:
- Uniformization of the code
- Probable optimization if name_get is used inside a for loop on a recordset (as the values will be prefetched and put in the cache).

TaskID: 1849250

closes odoo/odoo#26341
2018-10-09 11:28:00 +00:00
Christophe Simonis a799b13292 [REL] bump alpha version 2018-10-09 11:40:02 +02:00
Christophe Simonis 835b77ba94 [MERGE] forward port branch 12.0 up to ebe43bad9e 2018-10-09 11:37:30 +02:00
Alexandre Kühn 5c12a664d5 [FIX] web: click on href inside kanban record
Before this commit, when clicking on a link in a kanban
record having `href` that is set, it was opening the record
and accessing the `href`.

The intended behaviour is to not open a record if any children
component of the record contains either a click event or is
a link with `href`. The former was correctly handled, but not
the latter.

This commit fixes the issue by preventing opening the record
when clicking on a inner link with href from a kanban record.

Closes #24664

closes odoo/odoo#27529
2018-10-09 08:39:50 +00:00
Lucas Perais (lpe) 62cbc5f240 [FIX] board: translate custom views according to current user
Have a user in English, put a sale report as "favorite" (pinned to dashboard app)
Change the user's language

Before this commit, the pinned view was in English (because it was recorded that way)

After this commit, the pinned view is in the user's language.

OPW 1890664

closes odoo/odoo#27574
2018-10-12 08:36:19 +00:00
Odoo Translation Bot 44069cc4bd [I18N] Update translation terms from Transifex 2018-10-14 03:21:07 +02:00
Sébastien Theys 57ae9428b4 [FIX] web: prevent URL click from opening a record
If we click on a link, we only want to open the URL,
and not the record when the button is on a list.

PR: #27230
2018-10-12 12:45:38 +00:00
Robot Odoo 04eda06cb2 [FIX] web: do not create partner from calendar's sidebar
Fixes #27666

closes odoo/odoo#27720
2018-10-12 15:13:02 +02:00
Benoît Fontaine 347a3bd948 [FIX] web: use correct context attribue
Disable the possibility to create partner from calendar's sidebar
The option "can_create: false" was present but badly referred

Fixes odoo/odoo#27666
2018-10-12 11:58:19 +00:00
Benoît Fontaine a9c5da180f [CLA] signature for Linekio 2018-10-12 11:58:12 +00:00
len-odoo ad79cc09c6 [FIX] web: don't allow reference widget to be set on char fields
The reference widget is expecting a models list as selection attribute
in the field declaration.
It does not exist in the case of the char field.
Support for char fields was added to allow for external identifiers,
but it only works in readonly.
As a consequence, it tracebacks in Edit mode when used in studio.

We thusly remove char field from the list of supported fields.

opw 1892602

closes odoo/odoo#27708
2018-10-12 10:13:50 +00:00
Nicolas Martinelli fc1ba68c6a [FIX] sale_timesheet: zero timesheet
1. Create a SO with a product that creates a task on a new project
2. Create a timesheet on the task, with time = 0:00
3. Open the project overview from the projects dashboard or from the SO

A crash occurs because of a division by zero.

opw-1893397

closes odoo/odoo#27712
2018-10-12 09:54:04 +00:00
len-odoo 52d779007d [FIX] web: use read to update record values after resequence
Commit:
https://github.com/odoo/odoo/commit/818c18e55d0718286ff5bf332186a10f4d7a58ef
Updated the resequence logic in a way that was almost falser than before.
The added test however did work by coincidence, as index values were equal to
the sequence field values.
To be sure that we synchronize with what happens on the server, we do a read
after the resequence.
Additionnally, we take into account the result of the server resequence return;
if it is false, it means no resequencing happened, so we should not do a read.

opw 1867049

closes odoo/odoo#27184
2018-10-12 07:51:12 +00:00
Lucas Perais (lpe) 1ab53c27ff [FIX] website_[sale,delivery]: update freeshipping on delivery change
Since those two modules do not have a bridge, there was no support for changing the freeshipping line
when changing the delivery carrier

Now it has, at the price of ugly code

OPW 1871526

closes odoo/odoo#26935
2018-10-10 14:26:23 +00:00
Lucas Perais (lpe) 721260d2a7 [FIX] account: retrieve bank statement for process_reconciliation
Multicurrency is ON
Your company in USD

Make a bank journal in EUR
Create a statement and push reconcile

In the widget, create a line with a tax and hit reconcile

Before this commit, the amount_currency field of the tax move line was not filled

After this commit it is

OPW 1885014

closes odoo/odoo#27592
2018-10-10 14:56:56 +00:00
Nicolas Martinelli c576800813 [FIX] hr_expense: AccessError on product
- Install hr_expense and stock.
- Add enough products which can be expensed so that a 'Search More...'
  option is proposed.
- Restrict the rights of a user U to 'Employee' only.
- As U, create an expense, and click on the 'Search More...' option when
choosing the product

An AccessError is raised on `stock.move`.

The error is due to fields `qty_available` and `virtual_quantity`.

These fields are not necessary in that context, so we define a specific
tree view for this use case.

opw-1891399

closes odoo/odoo#27561
2018-10-09 08:22:12 +00:00
Odoo Translation Bot 75388edd9c [I18N] Update translation terms from Transifex 2018-10-09 10:13:22 +02:00
8445baa08d [FIX]web: do not crash when dismissing a modal with escape
stopPropagation of navigation_move event for where direction=cancel,
currently if navigation_move event throws error when user press escape
in dialog where dialog is opened from editable list record

Scenario: Install website_sale -> Open Product form(variant enable) ->
open variant tab -> open Attribute m2o form popup and press Escape on dialog
Result: Error
Expected: It should close dialog and keep editable list view record open,
btw m2o field should also be focused when dialog is closed but that's
another issue, will be fixed in another ongoing task

Related to Issue: #1873919

Co-authored-by: Vincent Schippefilt <vsc@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
2018-10-09 09:46:39 +02:00
Nicolas Martinelli ebe43bad9e [FIX] l10n_lu: remove deprecated reports
The `account.financial.report` model has been removed, so these reports
are now deprecated. They will be added back in Enterprise.

opw-1891341

closes odoo/odoo#27559
2018-10-09 07:01:29 +00:00
Nikunj Ladava 293dbe267a [FIX] payment: fix invalid param on rpc fail
This commit is related to Task ID 1891721

closes odoo/odoo#27555
2018-10-09 05:42:29 +00:00
Nimesh Jethva fb460f8800 [IMP] stock: hide PO/SO on lot view during create&edit
It's not needed to see the many2many of PO and SO during the create and
edit since the lot could not be already sell or buy during its creation.

Task 1909002

closes odoo/odoo#28817
2018-11-29 06:03:39 +00:00
Robot Odoo 00e7de8079 [MERGE][FIX] im_livechat: correct configuration path and improved sentence
In the form view of a livechat, the instructions to configure with Odoo
website CMS was still referring to "Website Admin", instead of
"Website".

In addition to fixing this error, the sentence has been slightly improved,
as we have to regenerate the term anyway.

closes odoo/odoo#29115
2018-11-28 20:35:34 +01:00
Yenthe V.G 548268c82c [FIX] im_livechat: update translation term for improved sentence 2018-11-28 18:26:15 +00:00
Yenthe V.G 7a3c05cea7 [FIX] im_livechat: show correct path for configuration and improve sentence 2018-11-28 18:25:04 +00:00
Romain Derie a3210dc314 [FIX] base: fix asset generation when there is .less files
Since commit f7130556bb the compiled assets would be returned in a loop
before executing the rest of the `preprocess_css` method.
But every loop would override the previous one as it is `=` and not `+=`.

Fixes #27922

closes odoo/odoo#29109
2018-11-28 16:17:43 +00:00
Robot Odoo 0fb85032a7 [FIX] website_forum: show correct title on hover over accept answer
Description of the issue/feature this PR addresses: Fix wrong title on hover

Current behavior before PR: When hovering over the icon to accept an answer on the forum it will show the text "Send answer":
![image](https://user-images.githubusercontent.com/6352350/49157862-1a914b00-f321-11e8-8cd0-d98175ab9741.png)

Desired behavior after PR is merged:
The text says "Accept answer" as you're accepting an answer, not sending one.
![image](https://user-images.githubusercontent.com/6352350/49157238-97bbc080-f31f-11e8-81f7-c36950f7138e.png)

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#29101
2018-11-28 18:53:36 +01:00
Yenthe V.G 135d3d61e0 [FIX] website_forum: update .pot file with correct translation 2018-11-28 14:07:51 +00:00
Yenthe V.G ba75ffde80 [FIX] website_forum: show correct title on hover over accept answer 2018-11-28 14:07:00 +00:00
Nicolas Lempereur dbe0337555 [FIX] mail: mention escape let original intact
When selecting a mention we will add a mention in a list of selection
from the list of mention.

In 10f0766b3 that mention in list of selection was escaped so this would
match the text that would be escaped when the mention was searched in
it.

But the object are the same so the change modified the original list.

Modified test failed with:

```
  10. first partner mention should still display the correct partner
      name (Expected: "ЅpëciãlUser<&>\"`' ツ" Result:
      "ЅpëciãlUser<&>\"`' &lt;&amp;&gt;&quot;&#x60;&#x27; ツ")
```

opw-1909300
closes #29098
2018-11-28 12:33:17 +00:00
Pierre Paridans 3b0a6a6c35 [FIX] crm: form field alignment
In the Lead form view, properly align "Planned Revenue" and "Probability" fields
side-by-side and adjust their styling in mobile.

Related to task 1891955

closes odoo/odoo#28763
2018-11-22 10:34:22 +00:00
Nicolas Lempereur e942c3520b [FIX] hr_org_chart: 3 level num subordinate right
On the third level of a organization chart, the number of subordinates
on the right but over the container boundary.

For the second level there was already a special case:

  padding-left: $tmp-gap-base;

So for the third a fix could have been:

  padding-left: $tmp-gap-base*2;

But this changeset replaces margin by padding so invisible content does
not create a horizontal scrollbar (since we had 100% width with
margin-left that busted it out of its container).

opw-1912437
closes #29043
2018-11-28 12:39:14 +00:00
XavierDo 136fee6fcf [FIX] mail_bot: only display odoobot once in mention suggestions
Before this commit odoobot was appearing twice in mention
suggestions when talking to odoobot.

The initial need to be able to ping odoobot from everywhere led to the
override of channel_fetch_listeners. This is not usefull anymore.

This fix simply removes this override to avoid this problem since we
don't have a real use case where we need to ping odoobot in another
channel.

Task 1907142

closes odoo/odoo#28791
2018-11-28 11:35:12 +00:00
Olivier Colson db21ef7578 [FIX] l10n_de, l10n_mx, l10n_nl: isolate account.tag creation by country
Before that, the specific account tags created in l10n modules were not only assigned when the company was in the right country.

closes odoo/odoo#29030
2018-11-26 13:17:10 +00:00
Martin Trigaux cb097e05ea [FIX] mail: invite: use proper translation terms
Fix translation placeholders in invite wizard, to make them easier to
understand for translators. Also rework the message generation code
to ensure proper XML structure.
2018-11-03 18:11:59 +01:00
XavierDo 863f3275d2 [FIX] mail: verify attachment access early to avoid errors later 2018-11-02 11:35:10 +01:00
len-odoo 7d2fd1d1b4 [FIX] board: do not display the no_content_create div
That div has been given an absolute position, which does not work inside another
div on the dashboard.
If there are other dashboard elements below, there are unusable since they are
covered by the no_content_create div.
Moreover, there is no create button on the dashboard, so we shouldn't even see
it.
It also spares us from seeing that hideous clippy-inspired smiling paper sheet.

opw 1907650

closes odoo/odoo#29076
2018-11-27 15:08:34 +00:00
Romain Derie a67553c9d2 [FIX] website_event: website menu on event not working
Commit 7077f18e3 tried to fix the website event menu issue.
But the fix was wrong and fixed only the event having a website_id set.
After the 7077f18e3 fix, event with a website_id set are working as expected
but the ones without a website_id are not working.
Indeed, it will create a website.menu without a website_id which will result in
the menu being duplicated for each website (multi-website rule).
The required on website_id when activating website menu on event was trying to
hide that new issue but it was problematic since:
1. We were removing a feature for no reason as it would not be possible anymore
   to create a generic event (no website) with website menu activated.
2. The required would only work in form view, demo data or custo data loaded
   through xml without a website_id but having website menu activated would
   still bug and would not have a menu. Worst, the menu would be duplicated for
   every website and added to the website navbar.

Now, regardless of the event having a website_id set or not, activating or
deactivating event menu will work.

closes odoo/odoo#29036
2018-11-26 15:04:57 +00:00
Alexandre Kühn 6f37e2cc5d [FIX] mail: increment messaging menu counter once per unread preview
Before this commit, the total amount of unread messages of a
channel was considered in the computation of the messaging
menu counter.

As a result, if the channel contains 100 unread messages,
the messaging menu was displaying a counter of more than 100.

The intended behaviour is to increment the messaging menu
counter once per unread channel, thus the example above should
incremented the counter only once. The channel preview itself
should still display that there are 100 unread messages.

Task-ID 1913080

closes odoo/odoo#29080
2018-11-27 15:06:23 +00:00
Goffin Simon 77a8d92196 [FIX] mrp: BOM recursion with different variants
Fine tuning of 00bf6709a8.

Let's consider two variants V1 and V2

The function check_cycle was too restrictive, it didn't allow
to create a BOM for V1 with a dependence to V2.

But a common use case could be for example:

A black T-shirt made  from a white T-shirt and black color.

opw:1911622

closes odoo/odoo#29075
2018-11-27 14:13:03 +00:00
Yenthe V.G b5e32b8318 [FIX] fleet: make fleet vehicle state translatable
closes odoo/odoo#28999
2018-11-27 13:48:23 +00:00
Laurent Smet eaf76bff5a [FIX] account: Fix regex matching rule in reconciliation model
Before:

Suppose 'invoices 2018/0002 and 2018/0003' that becomes '2018000220180003' after
REGEXP_REPLACE(st_line.name, '[^0-9]', '', 'g').

'2018000220180003' ~ '20180002' match: OK
'2018000220180003' ~ '2018' match: NOT OK
'2018000220180003' ~ '' match: NOT OK

After this commit:

move.name/move.ref giving an empty string are filtered out.

'invoices 2018/0002 and 2018/0003'
becomes ' 20180002 20180003' after REGEXP_REPLACE(st_line.name, '[^(0-9|\s)]', '', 'g')
and becomes {"",2018001,2018002} after the regexp_split_to_array.
Then, the matching is now done by a comparison instead of a pattern matching between the move
and this array of potential candidates.

'20180002' = ANY({"",2018001,2018002}) match: OK
'2018' = ANY({"",2018001,2018002}) not match: OK
'' is filtered out: OK

closes odoo/odoo#28962
2018-11-22 13:37:13 +00:00
Rémi Rahir 879a719478 [IMP] base: update phone codes on res.countries
closes odoo/odoo#28580
2018-11-27 13:03:58 +00:00
Rémi Rahir 191665f45a [FIX] crm_reveal: increase timeout of external server request
every request on the IAP-service server sends a batch of 25 views to
process. Each of them takes around 1.5 second to be processed, thus a
full batch will exceed the default timeout of 15 seconds.

In addition, we removed the config parameter that allowed to choose the
batch size as an high value could provoke another timeout error that
would evade the user's attention.

closes odoo/odoo#28967
2018-11-22 15:19:44 +00:00
Xavier Morel 14ff69a46c [IMP] web: keep ?query on becoming superuser
Being in debug mode is necessary to become superuser (whether on the
login page or within the client), however because the becoming
endpoint would straight redirect to the _login_redirect result the
debug mode would be lost, which is commonly inconvenient.

Replace the redirect_with_hash call by local_redirect, which goes
through great pains to conserve the ?debug by default.

Task 1908202

closes odoo/odoo#29058
2018-11-27 09:32:57 +00:00
Alexandre Kühn 9df8e88046 [FIX] mail, test_mail: make mail_tour work
This tour was broken since the following refactoring:
https://github.com/odoo/odoo/commit/cd34f6de727d5b3858420cff3c9d3c5995c4e75c

With this commit, mail_tour should work correctly, and
is automatically run on runbot.

Note that the tour is automatically run in the module `test_mail`,
so that the tips are not displayed by installing Discuss.

Task-ID 1912730

closes odoo/odoo#29040
2018-11-26 16:26:34 +00:00
Goffin Simon 00bf6709a8 [FIX] mrp: BOM recursion with different variants
Let's consider two variants V1 and V2

The function check_cycle was too restrictive, it didn't allow
to create a BOM for V1 with a dependence to V2.

But a common use case could be for example:

A black T-shirt made  from a white T-shirt and black color.

opw:1911622

closes odoo/odoo#29038
2018-11-26 14:22:17 +00:00
Lucas Perais (lpe) 034a27f630 [FIX] web: customizing filter doesn't close dropdown
Have a many2one, click on search more

Open the filter menu of the search view

Add custom filter

Click to select a field

Before this commit, the whole dropdown closed

After this commit, it doesn't

OPW 1911337

closes odoo/odoo#28969
2018-11-26 14:47:44 +00:00
Alexandre Kühn 6f7a04be0b [FIX] mail: reply message from inbox
Revision on https://github.com/odoo/odoo/commit/cd34f6de727d5b3858420cff3c9d3c5995c4e75c

Before the commit above, it was possible to reply to a message
from Inbox. Those messages were linked to a document, and replying
to any of them put a response in the related document.

This feature has been broken since the commit above: the reply
icon was only shown on messages linked to a channel, instead of
message linked to a document. Also, it was erroneously prompting
that the message was sent to the channel, even though it was not
the case.

This commit fixes the issue by toggling the visibility of the
reply icon, so that it is shown only for messages that come from
a document. Also, since posting a message requires a thread, this
commit added the possibility to post a message from a mailbox,
which instead posts the message to the related document thread.

Task-ID 1912647

closes odoo/odoo#29028
2018-11-26 14:12:50 +00:00
Lucas Perais (lpe) 889bdd3569 [FIX] web: fielddate[time] should select their value when entering them
Before this commit, when focusing on a date[time] field, the value was not selected
In v11.0, it was

This is due mostly because of the migration to BootStrap 4

After this commit, the value inside the input is selected

OPW 1911333

closes odoo/odoo#28989
2018-11-26 14:51:09 +00:00