Before this commit, a search to find the timesheets is slow because the
model containing the timesheets contained also the basic AAL and so many
records could be stored into that model.
This commit adds an index on project_id field in that model to search
quicker than before the timesheets since a AAL is a timesheet when the
`project_id` field is set.
Closes#85513
X-original-commit: 8cc4006
Part-of: odoo/odoo#85968
Co-authored-by: Yannick Tivisse <yti@odoo.com>
Co-authored-by: Laurent Stukkens (LTU) <ltu@odoo.com>
Every tax should have a tax repartition line even 0% tax
closesodoo/odoo#85990
X-original-commit: 17e3bd58e519bd40fdc0c7fd431cd1a8f90cf33e
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Brice Bartoletti <bib@odoo.com>
Steps to reproduce:
===================
- Create a Sales tax
- Archive it
- Go to Sales and create a SO
The archived tax is available for SO line
Cause:
======
Context {'active_test: False'} is defined on tax_id field of SO line
to still display archived taxes on existing SO.
This context is passed to the field in the form view by default, allowing
archived taxes to be selected in SO creation/edition.
opw-2769057
closesodoo/odoo#85987
X-original-commit: 3f4497aac646f27514a03531ba57b100add7da92
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Oversight of https://github.com/odoo/odoo/pull/85651
Commit above made changes to some icons from `oi-` to `fa-`.
Doing so, there was unfortunately a typo, and the template was not valid.
As a result, RTC did not work.
This commit fixes the typo, and make RTC work again.
closesodoo/odoo#85980
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Delivery slip created from a POS order contains the product name 3 times
Steps to reproduce:
1. Install Point of Sale app
2. On the Point of Sale dashboard, open 'Shop' settings (with the three
dots on the top right corner)
3. Check Ship Later in Inventory
4. Open a POS session, add a product to an order and go to the payment
5. Select a payment method and a customer, check the option "Ship Later"
and then validate the order
6. Quit the POS session and go to Point of Sale > Orders > Orders
7. Open the created order and access its picking with the smart button
8. Print the delivery slip
9. The name of the product is printed 3 times
Solution:
Override `_get_stock_move_values` in point_of_sale in order to overwrite
the value of `description_picking` when the order comes from a POS
Problem:
`product_description_variants` doesn't hold the same value whether it's
in sales or in point_of_sale. In Sales it describes the variants of the
product but in point_of_sale, it is the full product name i.e. the
product name and the variants used.
opw-2736443
closesodoo/odoo#85963
X-original-commit: 1c6710f59e2c9cf679c80a246ebb355a1b21776c
Signed-off-by: Masereel Pierre <pim@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
The purpose of this commit, is to make generic improvements in
project.
In this commit, following changes are made:
- add allocated hours field in project form and list view
- remaining hour widget in project kanban view displays allocated
hours (-) timesheeted hours on task
- hide progress bar in project list view if planned hours is zero
- hide task stages if user is set
- move company field below tags field
- project list view: rename 'Activities' to 'Next Activity'
task-2692856
closesodoo/odoo#82019
Related: odoo/upgrade#3149
Related: odoo/enterprise#23148
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Co-authored-by: Krina Oza <kro@odoo.com>
After choosing a template, the mass_mailing tour is supposed to tell us
to click in a paragraph to edit it. It was targeting a snippet that
doesn't exist anymore so the class name had to be adapted for it to
work again.
task-2778418
closesodoo/odoo#85934
X-original-commit: 2e2004b7cda8ea4dadb8de06991b7a2c91992661
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Antoine Guenet <age@odoo.com>
The mass_mailing tour had a droplet to the right of the mailing's title,
which was not so obvious to the eye so this moves it to the bottom.
task-2778417
X-original-commit: f6d69879ca6c55e6dd29387820383e069eccad07
Part-of: odoo/odoo#85934
Previewing templates in the "SELECT A TEMPLATE" tab of mass_mailing made
one lose all their changes. This makes sure they are preserved and
restored when needed.
task-2778411
closesodoo/odoo#85932
X-original-commit: e96e11d6ab8e5f7a6d5da498409cc0d5fb26cad1
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Antoine Guenet <age@odoo.com>
Pick a template for your new mailing, then change your mind and select
another one in the "SELECT A TEMPLATE" tab. Then make a change in the
mailing: your template change is rolled back. This is the bug that is
fixed with this commit.
task-2778411
X-original-commit: f84f15922af3a1e13409d3fd65805e64f7c6de4c
Part-of: odoo/odoo#85932
Wrong arch caused the following error when user language is not English
ValueError: Không tìm thấy phần tử '<tree string="Liên hệ">' trong giao
diện cha
View name: res.partner.tree.form.inherit
Error context:
view: ir.ui.view(2867,)
xmlid: membership.view_partner_tree
view.model: res.partner
view.parent: ir.ui.view(115,)
closesodoo/odoo#85936
X-original-commit: 7bfea3cee51400239430aa89aa28a62cae7ba0c5
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Whenever the browser is lagging between multiple enter,
the command hints were not being updated until the browser
main thread process the event queue.
Task-2728794
closesodoo/odoo#85935
X-original-commit: 8525f6ea677e89a932c783545c1d9dcf9b4d175a
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
* order by logic/dependencies
* reduce stacktrace depth during create precomputation
by computing the computed fields dependencies before the field itself
not during the field computation (if the field was defined after)
* guidelines applications
* single quotes for tech strings
* double quotes for strings shown to user
* respect max line length
* try to follow consistent order for field attributes
* ordering of methods (computes, onchanges, crud, ...)
Part-of: odoo/odoo#81510
Still having sometimes a test failing due to extra queries...
closesodoo/odoo#85929
X-original-commit: 34eebe66f12bf43dbf7c16800e177907fe39f2ba
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose is to update counters according to current runbot's state. This eases
checking impact of future performance improvements done.
Task-2631088 (Appointment: profile and add performance tests)
closesodoo/odoo#85838
X-original-commit: b0c7a6397526ad2698fac0701e4323c019ea8bf6
Related: odoo/enterprise#25002
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit:
A call to `sync_data` was made each time an event happen in the calendar
( changing the day, switching to day/week/month/year ).
This can easily saturate the server and spam the Microsoft API.
After this commit:
One call is made at a time per tab.
This PR is an adaptation of the same fix which was done only for
Google calendar at:
https://github.com/odoo/odoo/pull/69619/files#diff-8457ad89f2f7a1847af533828b40994bfc6d80e1e9d45ee7707b534bda2b0f06
and partially solve another PR that I was planning (but a bit too "overkilled"):
https://github.com/odoo/odoo/pull/85465
OPW-2749791 & OPW-2741728
closesodoo/odoo#85754
X-original-commit: d25b3d783fd08cd1c84095da554f52b463422bc2
Signed-off-by: Arnaud Joset <arj@odoo.com>
Step to reproduce:
- Create an event in calendar with reminder
- (Move the event to trigger the reminder)
- Click on 'Details'
Current Behaviour:
- Open a new event
Behaviour after PR:
- Open the event linked to the notification
opw-2761492
closesodoo/odoo#85089
X-original-commit: e1787f5a107f452f5c50e4e931cdd7afcea04e48
Signed-off-by: Arnaud Joset <arj@odoo.com>
Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>
With this commit we can now call a hook when we want to modify the code for this route.
Before this commit the only way to modify/extend this would be by taking over a big part of the code.
closesodoo/odoo#84907
Signed-off-by: Laurent Smet <las@odoo.com>
When we want to settle the amount due by a customer, we can choose a
payment method through a Popup. When the payement method choosed in the
popup is linked to a terminal the payment line is added, but don't have
a correct status, so we cannot send the request to the terminal.
To correctly add the payment and related status, we are moving some
logic that was set in the payment screen into the method that create the
payment line on the order.
closesodoo/odoo#85873
X-original-commit: 325772042c3d55034842e5710ab398237531e494
Signed-off-by: Masereel Pierre <pim@odoo.com>
Problem :
* updating an invoice line on mobile would result in an incorrect untaxed amount, tax amount and total amount on the invoice and an incorrect entries in the journal items
* subtotal of invoice line was not showing in mobile view
Solution :
* the problem was that debit and credit fields were missing from the view so onchange were not trigger
closesodoo/odoo#85877
Task: task-2766245
X-original-commit: c1b9c96dddaa02209bae042481781dd175a678dc
Signed-off-by: Ruben Gomes <rugo@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Followup of odoo/odoo@c178a7829f where a failure type renaming was badly
propagated. This commit fixes failure type naming allowing to correctly
distinguish a missing email from an invalid email.
Task-2684479 (Mail: Better send error storage and display)
X-original-commit: 1a08b3f4b3aa849549783348c51c393a1f84a409
Part-of: odoo/odoo#85864
Those indexes probably come from previous implementation of composer model
when it was inheriting from mail.message. It was also inheriting from the
custom search / read manual ACLs implementation doing some SQL directly to
check access. Those indexes should not be necessary anymore as anyway this
is a transient model.
Prepares Task-2088884 (MailComposer: Onchange to editable computed stored)
closesodoo/odoo#85841
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Coming from odoo/odoo@a4597fe34f . This code is not necessary anymore since we better
handle From, SMTP-From, as well as allowing mail server filtering. We can
now use standard aliases and servers instead of relying on hardcoded value
"postmaster-odoo".
Task-2784996
closesodoo/odoo#85837
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This PR simplifies the SCSS of the Pager component.
After the revamp of the pager, the Legacy Pager was broken because it
used the same SCSS file. This commit adds some BS classes on the Legacy
Pager to keep consistency between both versions while waiting for the
removal of the legacy one.
task-2733437
closesodoo/odoo#82866
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
After the revamp of the pager, the Legacy Pager was broken because it
used the same SCSS file. This commit adds some BS classes on the Legacy
Pager to keep consistency between both versions while waiting for the
removal of the legacy one.
task-2733437
Part-of: odoo/odoo#82866
Define "Bootstrap v5 ready" utility-class to handle gaps.
This class definition can be safely removed after migrating to v5.
task-2733437
Part-of: odoo/odoo#82866
task-2767820
This move is done to prepare the use of server side model definitions during tests.
Indeed, a model having all type of tracked fields will be needed to ease tracking
value testing. This model will be added to the test_mail module so the tracking
value tests need to be there as well.
closesodoo/odoo#85819
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Small changes in the layout of the hr_leave form view,
mainly for the manager's view point
Task : #2734842 [Time Off] ux changes
closesodoo/odoo#82976
Related: odoo/enterprise#23896
Signed-off-by: Kevin Baptiste <kba@odoo.com>
One key has two different types. Fix one and
let the other one as is to use it in the report
clean commit a038607bfdbe764fd436a94ce8149720fdca87ff
closesodoo/odoo#85813
X-original-commit: 4ca4dbc6707f26d69a4116b1ad90c1d9082119a1
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Steps :
Install Sale / E-commerce.
Create product P (price = 100).
Create price list L.
Create price rule R (product = P, price = 50).
Go to product P > Price Rules > archive R.
Create a quotation. / Website > click 'Go to website' > Shop.
Select price list L.
Create a SOL with product P. / Search for product P.
Issue :
Price is 50.
Cause :
Archived price rules are included in the 'search' of
_compute_price_rule_get_items().
Fix :
Exclude them.
opw-2752184
closesodoo/odoo#85811
X-original-commit: d5e8308492ac8955ad76fd8d9f3781266dee76f6
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
* Studio generate computed field "count" when the user add a button
in the button box. Since those lines are written by studio with drag and drop
it should not be counted for the maintenance subscription.
We can detect them because field created by the user in studio start with x_studio
and fields created outside studio does not have studio_customization
xml_id
* Add test to make no standard module introduce customization in the
database during the install the will be counted by cloc
see https://github.com/odoo/enterprise/pull/22664closesodoo/odoo#85763
X-original-commit: 47ae24081fe5c0c86ce8507229dfb550ec585633
Signed-off-by: Christophe Simonis <chs@odoo.com>
Signed-off-by: Thibault Francois <tfr@odoo.com>
