Commit Graph
121666 Commits
Author SHA1 Message Date
Lucas Perais (lpe) eaedfe4074 [FIX] web: display of timezone mismatch select widget
On the user's preference, change the timezone to one that is different
from the browser.
Save the form.

Go back to the user's preferences.

Before this commit, every timezone was displayed inside the span that contain
the warning icon, and leaked everywhere on the form view.

This was because of the joint action effects of commits:
86897ca167
4dfabb8f7a

Which provoked the field to be re-rendered in edit mode,
but with an $el on which a span was added. `<option/>` elements
were then added to both `<select>` and `<span>`
This did not happen before v12.0

After this commit, there is no display glitch

OPW 1895088

closes odoo/odoo#28108
2018-10-29 08:36:33 +00:00
Gabriela Mogollón e6bb3eb3e0 [IMP] l10n_mx: Add advance accounts on the chart template definition
closes odoo/odoo#28165
2018-10-25 17:29:12 +00:00
Odoo Translation Bot 29dc21ae4b [I18N] Update translation terms from Transifex 2018-10-28 01:25:21 +02:00
Robot Odoo 88a9ebdb00 [FIX] account: fix onboarding issues
* fix in the accounting config bar ('add a bank' and 'fiscal year' steps)
* better display names and icons for vendor bills uploaded manually (moved some code that was previsouly only done in document_account for vendor bills created through the DMS)

closes odoo/odoo#27882
2018-10-27 00:12:37 +02:00
eco-odoo 4eeaf6c0e2 [IMP] account: set default vendor_display_name for uploads
Previously a default name was set only for vendor bills created from
emails.

Task: 1893079
2018-10-26 13:36:26 +00:00
eco-odoo 4312c1786d [FIX] account: mark configuration bar bank step done
When a new bank account was created manually, the step was not marked as done.
2018-10-26 13:36:26 +00:00
eco-odoo b2a14dda03 [FIX] account: onboarding fiscal year step various issues
Design: remove empty space in the dialog form.
Opening date:
-fix move line not created introduced by c4b9c51abf. This prevented saving the opening date;
-set default date to start of current year.
Add a validation on fiscal year last day:
-the automatic calculation was removed in 90cdc91638 but no validation was set;
-the help message became irrelevant;
-the fiscal year end date was set as readonly in 52a8ed3c0c and not fixed in 3f4f77fd9d.
2018-10-26 13:36:26 +00:00
Romain Derie 40c6bc3ad2 [IMP] web_unsplash: Implement Beacon Alternative and credit Unsplash
Unsplash API requirements does not directly allow to store their images on
our server (We should use hotlinking unless the image is edited (cropped etc)).
Still, they have the `Image Beacon Alternative` to allow to store their images
on our server if we really need it with our use case.

With the Beacon Alternative, we should ping Unsplash server to notify an image
view.
To do so, we need to be able to recognize Unsplash imagesin the DOM, this is
why we are now using /unsplash/ in the URL.
The Unsplash image name should be the image ID as it will be the identifier
needed to ping their server.

This commit also adds credit to Unsplash in the media dialog next to the
unsplash input search.
It also add the `w-100` on the media dialog card as we lost that UI behavior
from BS3 to BS4.

opw-35060

closes odoo/odoo#27377
2018-10-26 10:13:07 +00:00
Xavier Morel 8c9174ff80 [FIX] base: handling of *_view_ref in SSF
The feature was not tested, and as it turns out completely broken:

* the non-raw string means the "backrefs" were really interpreted as
  octal literals
* the second backref was entirely wrong

Also add all loaded views to the field descriptor in case we might
have a use for it (and because inline sub-views are always stored on
the descriptor).

closes odoo/odoo#28194
2018-10-26 11:39:53 +00:00
Thibault Delavallée bf65793b31 [REF] mail: rename blableblu
Some people do not understand the old forgotten langage coming from R'yleh
sub-city of Helk'Yizrk. Let us use standard naming then.

closes odoo/odoo#28196
2018-10-26 12:39:18 +00:00
Christophe Monniez e0219c7f39 [FIX] tests: avoid remaining requests
From times to times, warning are seen on the runbot during HttpCase
tests with the chrome headless browser.

Those warning are about Odoo trying to join remaining requests threads.
In the dumpstack, the thread seems blocked in the werkzeug
handle_one_request method, when trying to read the HTTP request line.

One explanation could be that Chrome opens a pre-connect socket for
a future use. When the HttpTest cleans the browser, the page stops
loading but (probably) keeps the socket open for a while.

That could explain the problem.

With this commit, a timeout is set on the request handler,
in the hope that it closes the pre-connect socket too.

Cheery-pick of f9ee8cf to avoid runbot_merge failures.

closes odoo/odoo#28193
2018-10-26 11:42:03 +00:00
len-odoo 46f48c35a0 [FIX] survey: replace the native datetimepicker by an Odoo-styled BS one
Commit: a034a17d37
with a starking lack of foresight, erroneously put a native input date.
It wrongly assumed that the text input was a text input instead of a BS
datetimepicker, which was broken when upgrading BS3 to BS4.
Which means that it wasn't styled as the rest as Odoo, as well as not being
configurable, not working on some browsers, and subject to locale errors.

We fix the DOM so that the BS datetimepicker is correctly applied.

Related to 9a6cd4e41dda56c4f454ed898ed17adad0d8556f

closes odoo/odoo#28135
2018-10-25 08:19:22 +00:00
Géry Debongnie f0a7d69dcf [FIX] web_tour: only allow one active tip at once
Before this commit, the code for the tour system was kind of naive and
simply activated tips for each tour.  This was not really an issue,
since most user install one app at a time, so they had the time to
follow a tour, and when they install the next app, it is no longer
active.

However, since we activated the multi-app feature in our website, it now
happens that multiple apps are installed at once.  Because of this, this
commit is now necessary.

closes odoo/odoo#28178
2018-10-26 08:30:48 +00:00
Nicolas Seinlet 0e948f6f35 [FIX] mail_bot: call super and append result
Instead of using an or which is a nightmare for PostgreSQL
in this use case, call super and simply append odoobot to
the result.

closes odoo/odoo#28017
2018-10-22 10:15:28 +00:00
len-odoo 25e82a5c68 [FIX] website: fix the date picker widget on the publish page dialog
When updating to BS4, the datetimepicker library was updated to
tempusdominus.js.
It expects the DOM to be slightly different to apply correctly.

opw 1896103

closes odoo/odoo#28073
2018-10-25 09:03:16 +00:00
Martin Trigaux a93884fb47 [FIX] account: do not translate technical content
Using t-value instead of the content of a tag allow the content to be skipped
by the translation extractor

closes odoo/odoo#28160
2018-10-25 13:28:31 +00:00
Jeremy Kersten ab017d767a [FIX] website_sale: optimize last_website_so_id
Don't compute it for public user that can have thousand of SO
Improve request to find the last one.

'Sent' state should be included, but in case of wire transfer, state is sent,
while we should not be able to update this order.
-> to imp in master

Courtesy of @nseinlet that spotted this issue and propose similar fix

This commit closes #27779 #28158

closes odoo/odoo#28164
2018-10-25 14:28:08 +00:00
Robot Odoo 921fde1d37 [FIX] different IAP related problems
widget of crm_reveal did not call the correct service name, becoming useless

Allow saas clients to access their iap accounts portal

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#28163
2018-10-25 17:35:57 +02:00
Nicolas LempereurandLaurent Smet b987ec2e97 [FIX] l10n_ch: isr report with report refactoring
Report refactoring and f29df7fb2e expect when printing document that the
current one is in variable `o`, so this commit enables it.

opw-1894243
closes #28143

Co-authored-by: Laurent Smet <smetl@users.noreply.github.com>
2018-10-25 13:01:35 +00:00
Rémi Rahir 600f7176a2 [FIX] partner_autocomplete: wrong service name on widget 2018-10-25 13:00:41 +00:00
Rémi Rahir 134411710a [FIX] iap: make link visible in SAAS
When we switched to bs4, we changed the style of the dashboard and put
the iap recap link inside a specific div which elements are hidden for
saas users.
2018-10-25 12:40:11 +00:00
Lucas Perais (lpe) 6389b358c8 [FIX] base: partner_merge: adapt to new administrator ID
closes odoo/odoo#28146
2018-10-25 10:05:13 +00:00
Nicolas Martinelli 384b56cb55 [FIX] website_sale_digital: no link to download
In the portal, there is no link to the downloadable content.

This is because the content of the `super` call has been changed in
4c31a758cf. The key is now `sale_order`.

opw-1895878

closes odoo/odoo#28132
2018-10-25 07:40:33 +00:00
Gert Pellin ccf9f560c6 [FIX] point_of_sale: alignment note textarea
before fix:
in firefox the textarea of note modal has a overflow
textarea can be expanded outside borders modal in all browsers

closes odoo/odoo#27887
2018-10-18 10:26:08 +00:00
Nicolas Martinelli 919a279c55 [FIX] sale: useless part in template
`invoices2` is never set and is a leftover of development.

closes odoo/odoo#28134
2018-10-25 07:56:38 +00:00
Nicolas Lempereur 378ce8c447 [FIX] web: copy traceback in firefox
Same issue as in 902e484f1. In some browser (eg. firefox) the container
parameter of ClipboardJS is needed if the focus is inside the modal so
the copy work.

See information on:
https://github.com/zenorocha/clipboard.js/pull/368

opw-1902040
closes #28117
2018-10-24 15:56:23 +00:00
Martin Trigaux 76d7b0303b [FIX] website_twitter: set correct alt text
Was not an alternative text, just technical information

closes odoo/odoo#28109
2018-10-24 13:57:55 +00:00
Martin Trigaux d0213a6fec [FIX] stock: correctly translate route name
Translating a variable does not work, the call must be translated

Reexport the source terms to reflect the changes

closes odoo/odoo#28099
2018-10-24 09:38:45 +00:00
Yenthe V.G 585846d20a [FIX] purchase_requisition: correctly handle multiple unlinks at once
self may be several records

Fixes odoo/odoo#28032
Closes odoo/odoo#28045
2018-10-24 14:08:51 +00:00
Raphael Collet 828b76d578 [FIX] models: make onchange return a smaller diff
Large diffs (specifically in x2many fields) cause performance issues.  They
overload the web client, which considers all returned fields as dirty.

closes odoo/odoo#27941
2018-10-23 14:25:38 +00:00
Stefan Rijnhart 4d8b0b723b [FIX] base: don't hardcode the new admin user id
There is no longer a priviledged user and the user named "Administrator" may
not have the id 2.

Instead of hardcoding an id, uses a group-based check

Remove the global variable ADMINUSER_ID to ensure nobody is using it (as it can
be a source of bugs when base.user_admin is not ID 2)

closes odoo/odoo#27432
2018-10-23 14:40:02 +00:00
Nicolas Martinelli 0530b36a2d [FIX] purchase: matching domain
The domain used for the `purchase_count` variable should be in line with
the domain used to retrieve the PO list at
https://github.com/odoo/odoo/blob/68dafa0620fb8e36c9a1a58da0668bede2c3699b/addons/purchase/controllers/portal.py#L50

opw-1894625

closes odoo/odoo#28096
2018-10-24 09:11:50 +00:00
Goffin Simon 274f956f8d [FIX] stock: Lot/Serial Number not displayed
The field lot_name is not initialised in many cases.

Steps to reproduce the bug:

- Set your user in the group called "Display Serial & Lot Number in Delivery Slips"
- Create a new stockable product P with setting tracking "by unique serial number"
- Create 10 serial numbers for P
- Purchase 10 units of P and select the 10 serial numbers created
- Create a SO where I selected 1 unit of P with its serial number and confirm it
- Go to the delivery slip and print the delivery slip

Bug:

The serial number was not printed in the delivery slip.

opw:1900735

closes odoo/odoo#28076
2018-10-24 08:11:32 +00:00
Lucas Perais (lpe) 796b45afd6 [FIX] point_of_sale: right negation syntax in xml JS
f4bfc90755 reverted a bunch of commits,
including a legit bugfix in a XML for JS templates

This commit re-does that bugfix

OPW 1895212

closes odoo/odoo#28062
2018-10-23 12:24:54 +00:00
qdp-odoo 68dafa0620 [FIX] l10n_ch: fix swiss QR Code crap
The specifications of this feature have not been frozen yet and the feature is not expected before mid-2020. Merging it in stable was premature.
There's now an ir.config.parameter to hide the feature until really needed: a field in the accounting settings will be added in a next version to show it, in the meanwhile people can manually add the parameter to use/test the QR code.

Also fixed all 3 typos/grammar errors in the single sentence message displayed when some pieces of information were missing while printing the QR code

Also fixed the place where the Swiss options for the ISR are displayed in the accounting settings (under 'invoices' instead of 'fiscal periods')

Also fixed a 'not-a-multiple-of-4' indentation.

closes odoo/odoo#28035
2018-10-23 07:21:02 +00:00
Nicolas Lempereur dd94d06727 [FIX] web,base: report body rtl/ltr of language
Currently, the RTL/LTR direction of a report is the language direction
of the current user printing the report.

So for example a customer invoice in french can be RTL and a customer
invoice in arabic can be LTR.

With this changeset we keep a reference to the body language and use it
to choose direction later on.

opw-1890833
closes #27878
2018-10-23 15:51:16 +00:00
Romain Derie a5a86c4d11 [FIX] website_sale_wishlist: prevent product to be added more than once
The add to wishlist button will only be disabled once the RPC gets back to the
client.
Thus, the button being grayed out will occur depending of the connection speed.
If the RPC does not get back almost instantaneous, the user will be able to
click multiple times on the button and add the product more than once.

This commit fixes that behavior by disabling the button when the user click on
it.

Closes #27489, closes #27735
2018-10-17 09:49:22 +00:00
Pierre Masereel 498dbc548b Revert "[FIX] product_form: remove hs code and duplicate internal note"
The field hs_code has been removed but will be used in future tasks and
customers have already filled this field.

So we set it back in a sperate module to respect our stable policy.

This reverts commit 2d738f8563

closes odoo/odoo#28071
2018-10-23 12:25:09 +00:00
Pierre Paridans 60d3fc736c [FIX] partner_autocomplete: autocomplete not defined in mobile
Bugfix to prevent traceback in mobile apps due to override
of Many2one widget with native implementation.
Happens in every form view containing a partner field.

Implemented as defensive programming.
The goal of the included test is to prevent a silent error for the
webclient. It doesn't test the actual behavior in mobile (where there is
no DOM for Many2one).

Task #1896641

closes odoo/odoo#27967
2018-10-23 16:58:58 +00:00
Nicolas Lempereur a4f34c6480 [FIX] web_tour: tooltip message over document viewer
Currently:

- normal modals have a z-index of 1050 ($zindex-modal)
- chat window have a z-index of 1051
  ($zindex-model + 1 == $o-mail-thread-window-zindex)
- document viewer modal have a z-index of 1052
  ($o-mail-thread-window-zindex + 1)
- tour tooltip ball and messages have a z-index of 1051 ($zindex-modal)

A tooltip ball is in the DOM next to the element that is pointed out, so
if the element is inside a document viewer modal we see the ball.

But a tooltip message is positioned inside the body, so if we hover a
ball inside the document viewer modal, the tooltip message is behind the
modal.

In this commit, we set tooltip to bootstrap $zindex-tooltip value (1070
a of now).

opw-1893035
closes #27928
2018-10-23 08:49:52 +00:00
Romain Derie 4900f1824f [FIX] website_sale_stock: hide website field from picking form view
With multi-website enabled, the website field in the picking form view would
appear alone in the top right. (As company_id does if multi-company but as
website is a related (grayed out) most of the time empty it looks weird)

task-1894793

Note that in master the website field will be back in a refactored form view

closes odoo/odoo#27950
2018-10-23 09:19:03 +00:00
Nicolas Lempereur a03b967aa9 [FIX] web: restore CSS kanban AttachmentImage field
Modification in 60aa9ffd0 of web module kanban_view.scss contained
unused CSS style and style that affected usage of AttachmendImage field
in a normal kanban view.

The correct code was added in commit 6e12372 in composer.scss of mail
module.

opw-1892053
closes #27923
2018-10-23 11:33:53 +00:00
Adrien Dieudonne ee622b9b66 [FIX] mail: schedule an activity button not visible in mobile
Before this commit, text color was in grey because of a css
inherited rule applied by Bootstrap when there is no href attribute.
In mobile, text color was in white as the background and it was not
possible to see the text.

Now, we transform this link into button to restore the previous
behavior and keep it visible in mobile.

closes odoo/odoo#28061
2018-10-23 11:43:05 +00:00
Martin Geubelle 717111479b [FIX] web: do not block tour with blockUI
A previous rev. odoo/odoo@2672143 has prevented a tip to be consumed
in automated tours when blockUI was displayed.

This condition is not exactly correct. A blockUI element can be displayed
on any node, not only the webclient (which is the case when calling
`framework.blockUI`. This is the use case we want to deal, not the others.

So the tip cannot be consumed only with `o_ui_blocked` now.

closes odoo/odoo#28060
2018-10-23 10:23:06 +00:00
Robot Odoo f1abe19067 [FIX] auth_ldap: missing model description
Missing model description produces a warning when the module is installed

closes odoo/odoo#28047
2018-10-23 13:22:31 +02:00
Alexey Pelykh e658cb8c32 [FIX] auth_ldap: missing _description on res.company.ldap
Produces a warning when installed
2018-10-23 10:32:29 +00:00
Alexey Pelykh a5d22c2aec [CLA] Brainbean Apps OU signs Odoo CCLA 2018-10-23 10:30:12 +00:00
Kishan Gajjar 3a28e507da [FIX] website_sale: BS4, restore UI for customize dropdown
closes odoo/odoo#28009
2018-10-22 05:48:17 +00:00
Robot Odoo e63d319656 [MERGE][FIX] test(_mass)_mail: simulate email sending in performance tests
Commit 356a421 introduced a hook to avoid sending emails while
installing application data. However we have to carefully re-activate email
sending in tests that depend on them especially performance tests.

Performance counters are updated to match current runbot state for both
community and enterprise.

Mass mailing performance class is made a direc child of TransactionCase
to ease manipulation and be able to use patch.

This merge is related to task ID 1902307 and is mainly a fix and better use
of https://github.com/odoo-dev/odoo/commit/356a42166082f9448b7e82393caeb00839be8c8f.

closes odoo/odoo#28027
2018-10-23 11:24:25 +02:00
Thibault Delavallée 82329eab64 [REF] test_mass_mailing: make performance test class child of TransactionCase
It eases manipulation and lessen overhead. Performance tests should be self
contained as much as possible.

Commit linked to task ID 1902307.
2018-10-23 08:44:08 +00:00