Commit Graph
126793 Commits
Author SHA1 Message Date
MaxLarue e0b33e280e [IMP] sale_timesheet: overview usability and styling
In order to make the overview more understandable, we provide some modifications:

- remove some value when they are zero ("No task found", ...)
- the whole middle column (percentages) is merged inside the hours one
- provide some tooltips
- renaming titles
- ...

To do so and to avoid leaving empty lines or doing complicated template branching, the
above table is split in two different tables, so that we can remove lines independently.

We also added a new category in the overview, concerning timesheets that are related to a cancelled so. This meant tweaking the project_overview plan_prepare_value method, in order to have the new numbers calculated and keep the others consitent.

Task-1968121

closes odoo/odoo#33015

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-05-29 07:29:21 +00:00
Juhil Somaiya 1f3a00fb3e [FIX] calendar: traceback on recurrent meetings when repetition number is 0
If the user tries to save the recurrent event with 0 as the number of
repitations or interval there will be a traceback so instead of traceback
display the warning so user will not be able to save that event.

Task-1930809

closes odoo/odoo#31388

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-05-29 08:39:13 +00:00
Martin Trigaux 9aac7c9286 [IMP] web: unify the use of GROUPABLE_TYPES
cf discussion on #31789

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-05-28 15:47:49 +00:00
Martin Trigaux b9f8e234ae [IMP] web: allow to group by integer
No technical reason to forbid it

Fixes odoo/odoo#31684
Closes odoo/odoo#31789
2019-05-28 15:47:36 +00:00
Rafis Bikbov f203a89859 [IMP] base: remove unused variable 'last_update'
closes odoo/odoo#28725

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-05-28 16:15:01 +00:00
Rafis Bikbov 5c9e5aadf3 [CLA] Add Rafis Bikbov from IT-Projects LLC 2019-05-28 16:14:55 +00:00
Antoine Huvelle 7e4f46c0fe [FIX] stock: tooltip of product_min_qty field
The field description didn't match the behavior
Reported by a learning partner

closes odoo/odoo#32260

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-04-08 11:45:41 +00:00
Yannick Tivisse 1245905279 [IMP] base: Improve label for company_id on res.users form
closes odoo/odoo#33723

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-05-28 14:31:34 +00:00
Yannick Tivisse ac6cbbaf5d [IMP] web: Improve switch company bar layout
fp request: add 0.1rem padding-top and -bottom to the items of the multicompany dropdown menu
2019-05-28 14:31:34 +00:00
Yannick Tivisse ec670beb4b [IMP] web: Keep multi company config when switching company
when moving from company A to company B, company A should not be 'uncheck' (it should stay in the set of visible companies)
use case: https://drive.google.com/file/d/1o9lN_8jHSxDOkeqTpo7F_NgmvO4NwF2l/view
I start in A with only A visible
I check B to make both A and B visible
I move to B and A is not visible anymore
when moving to a company that is not checked, it should be checked, but the reverse is not true (moving out of a company should not uncheck it)

fp request
2019-05-28 14:31:34 +00:00
Robot Odoo 73474f56fa [MERGE] website_sale, *: review shop layouts and options
* website, website_sale_comparison, website_sale_coupon,
website_sale_delivery, website_sale_wishlist

- Use cards to match event and forum recent design refactoring
- Make the shop use responsive and perfect-squared product grid items
- Make the shop product list view option a CSS-only option, which
visitors can toggle to/out
- Use better XML and JS for existing options and add new options
- Allow to set ppg/ppr
- Better mobile responsiveness
- Make more robust xpath
- ...

Note: the design will be reviewed in an upcoming task, this ensures
more robust XML to work on and new options to start with.

See sub-commits for details.

task-1925327

closes odoo/odoo#31147

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-05-28 19:45:27 +02:00
qsm-odoo f685d5ad9d [IMP] website_sale: implement better edition usability
- Allow to switch from grid to list view in edition
- Do not show grid options when in list view

Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 2e7300c043 [IMP] website_sale: review sorting labels
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 1f1edd2432 [FIX] website_sale: adapt design to make it work on all browsers
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 900b765b43 [REF] website_sale: allow to customize default aspect ratio of grid shop
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo d0573de2b6 [IMP] website_sale, *: save the layout mode in the user session
* website

Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo c65233aa9b [IMP] website_sale: review alignment and mobile behaviors
- On mobile, both list view and grid view are the same, the toggle
  button is thus hidden to simplify the UI
- Review table alignements and button behaviors on mobile
- ...

Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo dd5ecfcbd5 [IMP] website_sale: use collapse for /shop filters in mobile
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 699fd6e303 [REF] website_sale: make better xpath to split /shop layout
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo da634afed5 [REF] website_sale: make robust xpath for collapse categories
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo d1240ee5d9 [IMP] website_sale: allow custom PPR and PPG
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 5521bcd81c [IMP] website_sale, *: review layouts and options
* website_sale_comparison, website_sale_wishlist

- Use cards to match event and forum recent design refactoring
- Make the shop use responsive and perfect-squared product grid items
- Make the shop product list view option a CSS-only option, which
  visitors can toggle to/out.
- Use better XML and JS for existing options.
- Better mobile responsiveness

Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 3b9bfced29 [REF] website_sale, *: remove useless classes
- 'border_primary' -> BS4 equivalent: 'border border-primary'
- 'noborder' -> BS4 equivalent: 'border-0'
- 'font-weight-normal' -> BS4 has the same class for the same behavior
- 'break-word' -> Unused, and probably a bad idea to use anyway

Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
qsm-odoo 291ea878d2 [REF] website_sale: move editor-related scss in a dedicated file
Part of https://github.com/odoo/odoo/pull/31147
task-1925327
2019-05-28 15:05:42 +00:00
Prakash PrajapatiandMohammed Shekha 77cd665645 [IMP] web: Hide the handle widget in grouped list view
when user in the group by list view it is not allow to change
the sequence of items by drag & drop with the handle widget,
so it does not make sense to display handle widget.

After this commit handle widget will hide in grouped list view.

Task-1964661

closes odoo/odoo#32855

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>


Co-authored-by: Mohammed Shekha <msh@openerp.com>
2019-04-22 09:17:57 +00:00
Prakash Prajapati b3aab58a59 [IMP] web: Hovering out of a systray menu item closes its submenus dropdown
While hovering in the systray a menu dropdown can only be open if user currently on his parent menu.

It should close when user hover on another systray menu.

Task: #1959678

closes odoo/odoo#32322

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-05-28 14:03:29 +00:00
Romain Derie 04b4818d84 [FIX] website: onchange new record adaptation
Before this commit, when you go on website config settings, you can't save.
This is because the website default lang field is not set anymore (supposed to
be set in onchange), and since it is hidden in the view if only one language,
there is no clue about the error field.

Following d0bb596f1d, x2many fields of new records are new records, meaning
that:
`self.many2one in self.x2many`
is not true anymore since self.x2many is a new record.

Also:
`self.many2one = self.x2many[0]`
is not working as before, the new record is not saved in the many2one

closes odoo/odoo#33716

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-05-28 10:13:36 +00:00
Priyanka KakadiyaandMohammed Shekha d9c33c4c78 [IMP] web: add accesskey 'b' for previous breadcrumb
Also, exclude 'b' for being automatically assigned to buttons

Issue : 1878248

closes odoo/odoo#33689

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>


Co-authored-by: Mohammed Shekha <msh@openerp.com>
2019-05-27 13:59:34 +00:00
Varun Raval a61f8c591f [IMP] mail: modify out of office field label on user
Replace name 'out of office' group string from 'Out of Office' to 'Chat Status'.

Replace 'out_of_office_message' field string from 'Out Of Office Message' to 'Message'.

Task 1999697

closes odoo/odoo#33552

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-05-28 09:07:45 +00:00
Robot Odoo 6069ea3fa8 [MERGE] web_editor, *: clean media dialog code
* web_unsplash, website, website_blog

Merge commit for PR: #33509

No big functional change, clean up media dialog code in preparation
of task-1930726.

See individual commits for more information.

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-05-28 14:17:46 +02:00
Sébastien Theys 5275f16f24 [IMP] web_editor: remove the unused onUpload option
This was introduced in b26ad79a8c
and only used in `addons/web_editor/static/src/js/editor/rte.summernote.js`
at that time.

Then that file has been removed in f296992317

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys 3924abb71b [IMP] web_editor: make media widget save always return a Promise
Before this commit, the return value would be mixed. For consistency, make it
always return a Promise.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys d4b09c1146 [IMP] web_editor, web_unsplash: remove options duplicate attributes
Since a reference to the options is already kept, there is no need to keep a
reference to each option individually.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys b0acd056e9 [IMP] web_editor: clean up media file widget selectors
Avoid selectors based on DOM structure, use classes whenever possible.
Register all the selectors in start to avoid searching the DOM multiple times.
No functional change.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys 277c30e7e6 [IMP] web_editor, website: clean up media dialog
Restructure the code in a more logical manner. No functional change.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys 8ab696dc82 [IMP] web_editor, web_unsplash: split media widget (image & document)
The common code is kept in a generic File widget, while the split allows for
easier customization.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys d25d3324e2 [IMP] web_editor: split search out of MediaWidget
The search is not used on VideoWidget for example, so it makes more sense to
split it out of the basic MediaWidget.

PR: #33509
2019-05-27 16:32:52 +00:00
Sébastien Theys e378aebc24 [IMP] web_editor, website_blog: clean up save/saved events
The web_editor had two different events `save` and `saved` doing more or less
the same thing but with a different signature.

In this commit we keep only the `save` event and adapt the code accordingly.

PR: #33509
2019-05-27 16:32:52 +00:00
Varun Raval dece93d5be [IMP] mail: hide integrations tab if no integrations are available
When we're on a channel, we can see the "Integration" tab even if integrations
are not available. So now whenever any integrations are available then only the
"Integrations" tab will be shown otherwise it will be hidden.

task-1973976
closes #33184

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-05-16 05:28:36 +00:00
Priyanka Kakadiya e71f954da3 [REF] purchase,mrp,repairs,stock: enforce uom domain
Enforce the domain of the UOM not by an onchange but by a domain.

Exemple of issue if the domain is enforce by an onchange:
- create a picking
- add a move
- select the product
- select an uom
> the uom presented are the one from the product category.
-Save
- edit
- select an uom
> all UOM are presented even the ones of other categories

This commit enforce this new logic at most places.

task: 1886272

closes odoo/odoo#33083

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-05-28 08:36:58 +00:00
Deiber Rincón 818ff8c406 [IMP] point_of_sale: use more unique identifier
When custom modules load a different partner field set for a completely
unrelated purpose AND this loading takes place prior to the stock odoo
one, then the load_new_partners method will infer the wrong field set
as the first in row hit is returned by _.find.

It is not optimal code quality to use `res.partner` as if it was a
unique identifier, while not inhibiting multiple loads of on a single
model.

Adding a (more) unique label and refer it in the find solves this
problem and makes the code more robust.

closes odoo/odoo#32351

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-05-28 09:54:56 +00:00
Jigar Patel 9bd647ac88 [FIX] web: avoid flickering when click on action defined using href tag
Before this commit,
Defining action using <a type="action"> outside of normal views(like qweb view)
css style does not apply to it because missing the href tag. by defining href
tag on a link will first open home screen then perform do_action thus it will do
flickering.

After this commit,
Prevent event default behaviour so it will stop flickering and restore css style
for action by defining href tag on it.

closes odoo/odoo#33703

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-05-28 06:40:33 +00:00
Xavier Morel 16cd987a53 [IMP] validation error messages through optional use of jing
A long-standing issue with data files is that lxml (libxml2) has
trouble reporting useful errors, often going no further than "the file
is not valid" (libxml2 apparently has issues reporting useful errors
within non-trivial <choice>, which Odoo's data file schema makes
extensive use of) e.g. if a data file has some stray text in an
unexpected place (in this case, after a `</field>` tag in a
`<record>`), libxml2 will report:

ERROR:RELAXNGV:RELAXNG_ERR_EXTRACONTENT: Element odoo has extra content: data

Jing (the reference implementation) provides significantly better
error reporting:

error: text not allowed here; expected the element end-tag or element "field"

It's in java which is inconvenient and expensive for baseline
validation (and as a hard dependency), but there's now a "jingtrang"
package which bundles the relevant jars & invocation on
pypi (https://pypi.org/project/jingtrang/), making for a convenient
optional dependency for better development experience.

closes odoo/odoo#33666

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-05-27 06:58:48 +00:00
Kaushalya Mandaliya 9b823c9c6a [FIX] stock: traceability report printed version and backend view
Before this commit:
Print button was hidden in traceability report from commit: 9378552a89

After this commit:
Print button is visible.
Removed a css rule which caused horizontal scroll in pdf report.
Also removed unnecessary and redundant styles.

Task-1974338
Closes #33289

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-05-21 09:35:59 +00:00
Kaushalya Mandaliya f2bd331e08 [IMP] stock: making traceability report full-width in backend view
Task-1974338
2019-05-21 09:35:59 +00:00
Kaushalya Mandaliya 7b65e6c6bb [FIX] stock: no formatting while printing traceability report for the first time
While generating the traceability report for the first time,
if the assets are not in cache, the report will be having simple markup with
no styles applied. To workaround this issue, we manually commit the writes
in the `ir.attachment` table. It is done thanks to a key in the context.

Task-1974338
2019-05-21 09:35:59 +00:00
Xavier Morel ff02bf1137 [REM] multi from ir.actions.act_window
Task 1843603

* src_model is redundant with binding_model_id
* multi -> binding_view_types (if empty => all views) (maybe should be
empty by default yo?)
* in convert, type => rec.get(type) but no @type possible on <act_window>...
* removed deprecated auto_refresh & auto_search (not used anywhere (?))

closes odoo/odoo#24738

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-05-27 12:00:39 +00:00
William Henrotin 6bc26ff5e9 [IMP] mrp: alternative workcenters
Purpose: link workcenters that can do the same job together.
Planning a workorder will be done by choosing, among the similar
workcenters, the one that will finish the production the soonest.

This commit adds a new many2many field on the mrp.workcenter
model. Planning the workorders will:
1. Loop on the operation's workcenter and all the alternative ones.
2. Compute the first available work slot for each of those workcenters.
3. Choose the soonest finished slot

Furthermore, planning workorder is done thanks to the resource module.
Each workorder is saved on its own workcenter calendar by a resource.calendar.leaves
The two date fields are thus computed from the leave date.

Task : 1892819

closes odoo/odoo#33018

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-05-28 06:50:58 +00:00
William Henrotin 2c299e7b21 [REF] resource: relax ir rule on leaves
The field user_id on resource.resource is optional but the access rules
on resource.calendar.leaves request that field set. Which means a user
can only see his own leaves but not the ones of a machine's calendar for.
instance

This commit relax those rules to give access to the user's leaves and the
one not assigned to a specific user

Task : 1892819
2019-05-28 06:50:00 +00:00
Jigar Patel 9ab3270c5a [FIX] web: avoid flickering when click on action defined using href tag
Before this commit,
Defining action using <a type="action"> outside of normal views(like qweb view)
css style does not apply to it because missing the href tag. by defining href
tag on a link will first open home screen then perform do_action thus it will do
flickering.

After this commit,
Prevent event default behaviour so it will stop flickering and restore css style
for action by defining href tag on it.

closes odoo/odoo#33703

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-05-28 06:40:33 +00:00