Commit Graph
140847 Commits
Author SHA1 Message Date
stefanorigano (SRI) 26e146644b [IMP] website, *: review snippet names
*: website_event, website_form, website_sale

Part of https://github.com/odoo/odoo/pull/55089
task-2157252

closes odoo/odoo#55089

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-30 10:19:06 +00:00
stefanorigano (SRI) b7fe2bdae2 [IMP] website, *: review snippets thumbs
*: website_blog, website_event, website_form, website_mail_channel,
   website_mass_mailing, website_sale, website_twitter

Part of https://github.com/odoo/odoo/pull/55089
task-2157252
2020-07-30 10:13:07 +00:00
stefanorigano (SRI)andqsm-odoo c0a11148e0 [IMP] web_editor: review snippets thumbs design
Part of https://github.com/odoo/odoo/pull/55089
task-2157252

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-30 10:12:58 +00:00
Victor Feyens cc665d51e8 [FIX] sale,purchase: do not enforce company at _prepare_* level.
By specifying the with_company at a higher level:
1) The risk of multi-company conflicts decreases
2) We allow customizations to use _prepare_* methods to potentially
create records in other companies when needed.

closes odoo/odoo#55192

X-original-commit: 33c767e1778d2b1fc83aaaea92c3c2aa008b9520
Related: odoo/enterprise#12105
Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-07-30 10:20:31 +00:00
Xavier Dubuc e244bfa1c8 [FIX] mail: do not fetch 'user_notification' messages in thread
task-2296856
See odoo/enterprise#12095

closes odoo/odoo#55189

X-original-commit: 5aaff1547d04bccf20ef333f515811570e8b8e22
Related: odoo/enterprise#12100
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-30 09:23:02 +00:00
Nicolas Martinelli dcf1f48ee6 [FIX] account: prevent unlink item linked to posted entry
- Create a vendor bill, post it
- Go to Accounting > Accounting > Journals > Purchases
- Select the items linked to the vendor bill, delete

Nothing prevents from deleting the items while a posted entry cannot be
modified.

opw-2305873

closes odoo/odoo#55187

X-original-commit: 14ef02f73e649b5f8c50f09213f0a0dbddf46217
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 08:49:10 +00:00
Nicolas (vin) 8b7861ddab [IMP] account: Clean various feedbacks reported by consultants
Clean various feedbacks reported by consultants WTA/CTH.

It concerns namely :
- CoA
- DEMO DATA
- SEQUENCE NUMBER ON JOURNALS
- PAYMENT STATUS
- BANK STATEMENTS

Task ID: #2300936

closes odoo/odoo#54874

Related: odoo/enterprise#11995
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-07-30 08:58:54 +00:00
Laurent Smet 2a751921c1 [REF] account: Refactor '_prepare_counterpart_move_line_vals'
closes odoo/odoo#55186

X-original-commit: 0ebe2034cbd55c4384dfc7f253d66958623847d7
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-07-30 08:48:38 +00:00
Laurent Smet 6c9b5d6f6f [FIX] account: Fix creation of statement with zero amount/amount_currency
During the migration, it could happen some statement lines are created with a zero amount in company currency or foreign currency.
It this specific case, we can't retrieve the correct amounts by multiplying the statement line conversion rate because X * 0 is always zero.
This commit ensures the amounts are well preserved in such case.

X-original-commit: a75bc7fdf014daf965cad72917ac475cbf83f6ac
2020-07-30 08:48:37 +00:00
Laurent Smet 17a8a6d933 [FIX] account: Fix missing 'currency_id' on statement lines with amount_currency=0.0
The `currency_id` must be set whatever the amount_currency is zero or not.

X-original-commit: 88065aef326dcbe0fb821da8d9aa6cc0316615c7
2020-07-30 08:48:37 +00:00
Laurent Smet 78aae94838 [FIX] account: Fix float division by zero when statement amount is zero
This should never happen for someone starting Odoo after saas-13.4 but is happening during migrations.

X-original-commit: b43849032766b95f07d3ac73fc67e4c03138c3b5
2020-07-30 08:48:37 +00:00
Laurent Smet 920a5f1df1 [FIX] account: Fix typo in field declaration: 'require' instead of 'required'
Note: Since this field must not be required, this attribute can be removed.
X-original-commit: f88e37e912b3c60349ad8cba92ec8bfd2a95e2bd
2020-07-30 08:48:35 +00:00
Nasreddin (bon) 54a429af58 [FIX] point_of_sale: Receipt footer breaklines escaped
Issue

	- Install "Point of Sale" module
	- Edit POS (e.g.: Shop) settings
	- Enable "Header & Footer" feature
	- Add a footer with multiple breaklines and save
	- Start a session with the current POS
	- Make an order

	Receipt footer not well formated

Solution

	Add 'white-space:pre-line' style to avoid escaping breaklines;
	inspired on text-field css class.

opw-2300889

closes odoo/odoo#55182

X-original-commit: 85de8418ae9b152fc0f4c300b71249440f381224
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-30 07:56:53 +00:00
Goffin Simon 2800c89014 [FIX] l10n_se: Fiscal position not loaded
Steps to reproduce the bug:

- Create a new company C with country = Sweden
- Install app l10n_se
- Go to Accounting/Configuration/Setting/Fiscal Localization Package, select Swedish Chart of Account and then save

Bug:

The sweddish fiscal positions were not loaded.

opw:2302926

closes odoo/odoo#55170

X-original-commit: bd0c2ee6501c87789278377f7725e3c611955edc
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-07-29 15:54:08 +00:00
Nicolas Martinelli 5eea4c014a [FIX] account, stock_account: clean anglo-saxon lines
- Configure a Product Category Automated + FIFO
- Create a product in this category
- Create a PO for 10 units, receive the units, bill the PO and pay
- Sell 1 unit of the product and deliver it
- Create an invoice for the order
- Without paying the invoice, create a credit note with the option
  'Full refund and draft invoice'
- Post new invoice

The anglo-saxon lines are counted twice.

This happens because the lines already exist in the newly created draft
invoice.

For the sake of simplicity of the fix, we clean-up the invoice after
creation.

opw-2300536

closes odoo/odoo#55158

X-original-commit: 02d857b8aa75962f535ab4cd69ff8e2a6ef3fb48
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-29 15:20:02 +00:00
Anh Thao Pham (pta) 7d010ee8a5 [FIX] repair: use Customer Payment Terms in repair invoice
- Install Contacts and Repairs
- Go to Contacts and configure Payment Terms of Contact X (i.e. 2 Months)
- Go to Repairs and create a Repair Order:
  * Select Contact X as Customer
  * Select "Before Repair" as Invoice Method
  * Add Parts or Operations
- Confirm Repair and Create invoice
The Payment Terms of the created invoice is the default one and not the Payment Terms of Customer.

opw-2304818

closes odoo/odoo#55152

X-original-commit: 351718d5f579fca4945538c78e63aa50118af2b4
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-29 14:30:21 +00:00
Jinal Patel 8d721f6728 [IMP] base: change unique model name sql constraint message
-Purpose of this task is to make the unique model name constraint
 clearer by specifing name of the model needs to be unique.

-In this commit, change the constraint message from
 'Each model must be unique!' to
 'Each model must have a unique name.' to let the user know name
 of the model causes the issue.

task-2254964
Closes-#51513

closes odoo/odoo#51513

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2020-05-19 09:08:36 +00:00
Thibault Francois 585a28b89a [FIX] im_livechat: performance issue with _compute_nbr_channel
filtered(lambda c: c.channel_message_ids)
take more than 2 minutes to get executed with a regular user
due to access_right check for every single message.

Solution:
use the previous read_group with the domain channel_message_ids != False
which is equivalent

closes odoo/odoo#54318

X-original-commit: b4dcfc3e273c40c53cbf778152cf38fabb39a096
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-07-10 10:34:00 +00:00
Xavier Dubuc c767df5e97 [FIX] mail: set full composer subject and recipients
task-2291887
task-2291893
task-2291898

closes odoo/odoo#54531

X-original-commit: 26170ad9ab09d75de2e0af98fb7daedc2ed57e50
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-15 16:18:53 +00:00
Toufik Ben Jaa 04a757d596 [FIX] project: allow non manger to duplicate tasks
- The field `allowed_user_ids` is only accessible to Project Manager.
  When trying to duplicate a task, an access right issue is raised
  if you are not project manager.
  This is due to the fact that when trying to duplicate this field is
  read.

  To avoid this issue, we specify that this field should be copied thus
  not be read.

closes odoo/odoo#54509

X-original-commit: 95dedd23cc7a7d66d7a7dc17b9f9ac4f5473e226
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
2020-07-15 12:42:59 +00:00
Jeremy Kersten b3681bc85f [FIX] website_event: restore the online magic country
Removed with commit aebe199d80, but independant of is_online

Restore partially the feature, order by physical event is no more easy to restore
since is_online field doesn't exists anymore to sort.

Can be done as a custo if really required.

closes odoo/odoo#54516

X-original-commit: a6be8cfa40525c5d835cdb40e2e8936aeb36864c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-07-15 13:16:39 +00:00
Aymane (ayt) 59a156f80c [IMP] crm: Add colors to activity buttons
Issue: All action buttons were the same color.

Solution: Make the snooze button more visible by giving-it
 a warning color

Closes Task#2295872

closes odoo/odoo#54508

X-original-commit: d4b7f8b44c8d0d5b07a85cd52ee1648f9068f7b2
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-07-15 12:31:30 +00:00
Nicolas Martinelli 5718764ed9 [FIX] base: currency of Slovakia
The currency of Slovakia is EUR (since 2009).

opw-2293328

closes odoo/odoo#54507

X-original-commit: 7a414dd666ae57285762f059e1c3e3cdb4801a1f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-15 12:28:01 +00:00
Paul Morelle 2cd9f763a5 [FIX] event: fix invalid domain in view_registration_search
Commit 30af656e1a removed a third operand
in the domain but forgot to remove its operator, making the domain
filtering on the Participant invalid.
This commit fixes it by removing the ~~first~~ second pipe.

closes odoo/odoo#54504

X-original-commit: 44feadabab601b0df34d504b585abb9339a4a478
Signed-off-by: Christophe Simonis <chs@odoo.com>
2020-07-15 12:11:04 +00:00
Joseph Caburnay d51b56e20d [FIX] pos_restaurant: idle timer not resetting properly
1. Idle timer is now reset also for touch events.
2. Using onWillUnmount and onMounted hooks to add event listener to
window for detecting activities is not possible in this situation
because setting the listener depends on a pos.config field
(iface_floorplan) which is only available after 'start' is finished.
(Remember that hooks are required to be set in the constructor.)
So instead of using those hooks, we replicate them by using a global
variable IDLE_TIMER_SETTER. This variable holds the bound method
_setIdleTimer and set it as callback to each event listener.
Then, before closing pos, we remove the listeners.
3. Close present temporary screen when going back to floor screen
after idle timer.

closes odoo/odoo#54498

X-original-commit: de1430d71890da24547fe24ba04dd28f59f77ee0
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2020-07-15 11:39:43 +00:00
Joseph Caburnay 4ed4ac5474 [FIX] point_of_sale: actionpad layout in safari
Tested in safari, chrome and firefox, removing display: flex property
in the .pads element solves the issue. There is actually no need to
declare .pads to flex-flow in column direction as div are block
elements, and they laid out in column by default.

X-original-commit: 6389f00598fa6acd991b21f9875d27005b689ec6
2020-07-15 11:39:42 +00:00
DramixDw da32bdb88a [IMP] website, *: make cover options always available
*: website_blog, website_event

It would make sense to be able to change the height of a cover or to
change the text alignment even if there's no backgroung-image.
Therefore, we're removing the background-image restriction for the
options of the cover snippet.

Part of https://github.com/odoo/odoo/pull/47933
task-2210733

closes odoo/odoo#47933

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-15 11:36:56 +00:00
DramixDwandqsm-odoo 188c338ab2 [IMP] website, *: make editor closer to WYSIWYG
*: event, website_blog, website_event, website_forum, website_sale,
   website_sale_comparison

We're changing most of the "DRAG BUILDING BLOCK HERE" placeholders so
that they only appear on drag. Making the preview as close as possible
to the page once saved. However, we're still keeping them on empty pages
because it make sense there to let know that the area is editable.

Part of https://github.com/odoo/odoo/pull/47933
task-2210733

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-15 11:36:56 +00:00
Xavier Dubuc 67a515ded9 [FIX] mail: introduce "assets_tests" assets bundle
Needed to merge introducing new assets in 13.4

odoo/odoo#54235
task-2291898
task-2291893
task-2291887

closes odoo/odoo#54485

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-15 09:27:20 +00:00
Antoine Prieels 09e24786ff [IMP] point_of_sale: Improve load demo data text
Improve the text in the load demo data wizard that shows when a
pos_session with no product is started.

closes odoo/odoo#54482

Taskid: 2296281
Related: odoo/enterprise#11848
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2020-07-15 08:52:21 +00:00
Simon Genin (ges) e88fc62222 [IMP] fleet: Improve ux of list views
Small UX improvements on list view and edit text of an empty kanban
screen.

Task ID 2291554

closes odoo/odoo#54234

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-07-15 08:37:56 +00:00
qsm-odoo 1384354356 [IMP] website, *: review options' order/label + add "⌙" markers
*: web_editor

Some of those "⌙" markers will become foldable options in the future.

Part of https://github.com/odoo/odoo/pull/53930
task-2157252

closes odoo/odoo#53930

Related: odoo/upgrade#1478
Related: odoo/design-themes#332
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-14 14:43:16 +00:00
qsm-odoo 20249d316e [IMP] website: remove animate scrolling option for table of content
Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo b4ce6fbc01 [IMP] website, *: add prettier preview of border styles
*: web_editor

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo 43c158295b [FIX] website: remove duplicated filter option for blockquote
The blockquote in its "cover" layout allows to add a background with
a dedicated colored filter on top of it. That option was a bit buggy
since the filter option only appeared if the page was saved first. As
we now have a generic option to apply a colored filter on image
themselves, that option became useless anyway.

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo bb0cd4d5c8 [IMP] web_editor, *: review background color/image options UI
*: website, mass_mailing, website_blog, doc

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo d23a9c1954 [IMP] web_editor, *: introduce new "button group" editor widget
*: website, website_form

Basically work just as a we-select but with a different design.

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odooandBenjamin Vray b96c0eaf38 [IMP] web_editor: allow to use images in the left panel
Part of https://github.com/odoo/odoo/pull/53930
task-2157252

Co-authored-by: Benjamin Vray <bvr@odoo.com>
2020-07-14 14:43:16 +00:00
qsm-odoo f16113a06e [IMP] web_editor, *: review the editor design CSS
*: web, mass_mailing, website, website_form, website_sale

New CSS design of the editor (step 1/x).

This work is unfortunately far from perfect but is a first step towards
what we want. In particular, much CSS linked to elements that are meant
to be removed/moved in the upcoming weeks was done in a huge rush but
will thus hopefully be removed/reviewed before the 14.0 release.

As the design is now far more complex including gradients and other
"complex" elements, it was also very difficult to keep a design based on
css-variable so this system was removed, which means that the editor now
appears the same everywhere (backend, frontend, ...). The original goal
of this system was to have an adapted style for backend, frontend and
website visitors. Unfortunately, the current result was a very good
frontend editor design, a not-so-good backend editor design (for mass
mailing at least) and a totally unadapted design for the website
visitors. Making this perfect will be achievable by loading different
assets for those 3 areas and hopefully those assets will only differ by
the values of editor scss variables.

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo 6c31104fa9 [IMP] web_editor, *: remove snippet panel block icons
*: website, mass_mailing

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:16 +00:00
qsm-odoo 2616c8950f [FIX] web_editor: make sure user events bubble before updating UI
Example where this was a problem: when clicking on a field type for
website form, the whole option is rerendered and we never go through the
"close" method of the clicked we-select element (which will be important
in the future).

Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:15 +00:00
qsm-odoo 8d57f21d7d [IMP] web_editor: hide we-row with no visible widgets
Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:15 +00:00
qsm-odoo 4b826abcfb [IMP] web_editor, portal: review img/fa display rules mixup
Part of https://github.com/odoo/odoo/pull/53930
task-2157252
2020-07-14 14:43:15 +00:00
Joseph Caburnay 473cab3a91 [FIX] point_of_sale: invoicing error at first invoiced order
To reproduce, open a pos session. Finalize an order with invoicing.
Error message is shown.

Invoicing in pos calls doAction of the action manager. The first time
doAction is called, it triggers a chain of events and a side effect
of that chain is to instantiate two mail owl components which isn't
possible because not all mail assets are loaded. A very quick fix is
to bypass that mentioned chain of events by setting isStarted flag to be
true. Aside from bypassing the instantiation of mail components, there
are procedures that were skipped as well which includes:

1. setting the bus to listen to scroll events
2. setting odoo.isReady to true
3. adding a class to the action manager element

All of the above is not important in pos and can be skipped so this
quick fix is valid. However, this fix doesn't actually solve the real
problem which is the fact the pos is loading unnecessary assets.

This commit implements the quick fix. Cleaning up pos assets will be
done in the future.

closes odoo/odoo#54478

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2020-07-15 08:34:45 +00:00
Xavier Morel 470fb905a9 [FIX] base, mail: properly annotate Partner.find_or_create
In 6e25a510b3 `find_or_create` was
modified to return a recordset rather than just an id. This made it
incompatible with the RPC protocol and it was not annotated to
downgrade the return value back to an id.

Fixes odoo/odoo#54466

closes odoo/odoo#54476

X-original-commit: a7e3894e20207b714cebefa908be090967866791
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-07-15 07:36:23 +00:00
Andrea Grazioso (agr-odoo) 5a9cf0f357 [FIX] l10n_in: fix reports using invoice currency total
In the GSTR1 report, Under 6A Export Invoices, the invoice value which
is shown in the report is expressed in invoice currency without any
currency symbol.

This is misleading for users because the GST form report website
asks amounts in company currency (Indian currency)

opw-2292449

closes odoo/odoo#54462

X-original-commit: bb617b70eab3e033c828c2899c139e66ddc8fc28
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-14 16:35:12 +00:00
Raphael Collet 6c9da4a206 [FIX] core: search on boolean field with operator in
closes odoo/odoo#54457

X-original-commit: 363533b7d50448c06cef2baa68d6f4f634346252
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2020-07-14 15:15:11 +00:00
Xavier Morel 36b72077a5 [FIX] account: override not renamed when base method was renamed
odoo/odoo#34023 added this override to `postprocess_pdf_report`, which
was apparently missed when odoo/odoo#33770 made a few
methods (including this one) RPC-private.

Fix the override so it's properly called again (probably).

Task 2285894

closes odoo/odoo#54448

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-07-14 13:55:11 +00:00
Jeremy Kersten 76b2de42f4 [FIX] *: handle null value for boolean in sql queries
It has always been a best effort until the v13 to have false as default value
for boolean field.
Until v13: https://github.com/odoo/odoo/blob/12.0/odoo/models.py#L3645

During ORM refactoring in v13 it has been replaced by a default value in sql
From v13: https://github.com/odoo/odoo/blob/13.0/odoo/tools/sql.py#L79

But with a typo since columntype for boolean is bool and not boolean.
What's mean that in v13 we have a lot of null value for boolean (~=False)

In all cases, we try to be aware and check Falsy boolean with 'null or False'
(https://github.com/odoo/odoo/blob/13.0/odoo/osv/expression.py#L1230)

So we should do the same when we write pure sql in method bypassing the ORM.

closes odoo/odoo#53391

closes odoo/odoo#54458

Related: odoo/enterprise#11319
Related: odoo/enterprise#11838
X-original-commit: 118c9f6aafd423f415b2bbfcf8a9cfcd676d9b92
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-07-14 15:52:59 +00:00
qdp-odoo 92a7f8c13f [IMP] base, tests: use freezegun lib to mock dates and datetimes
closes odoo/odoo#54227

Related: odoo/enterprise#11742
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2020-07-10 08:20:13 +00:00