When registering payment, we display now the date + time instead just the date.
closesodoo/odoo#58667
X-original-commit: eb534d078dcdf58aedf09131dd57c8f6da69a910
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
The method get_fiscal_position was missing the @api.model decorator
closesodoo/odoo#58665
X-original-commit: 7cad8db251b62972b3a0ea8ca970014cd0f1b5c1
Signed-off-by: Josse Colpaert <jco@openerp.com>
Calling a compute method on 1M records inevitably brings a worst case in
cache prefetching: the code that determines which records to fetch has
time complexity O(N²). We avoid this situation by calling the compute
method on maximum 1K records. Each computed batch has a "prefetch set"
of maximum 1K records too, which avoids the worst-case scenario above.
closesodoo/odoo#58664
X-original-commit: 0b1aa660b1d94fe46dea09670b875f2d81ca36a3
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
This commit improves the performance of the 'sale_price_subtotal' field of
event.event by refactoring the way it's computed.
The previous naive implementation looped on sale.order.lines linked to the
event and performed a currency conversion for every single line. This leads
up to thousands of requests to fetch the conversion rate and sum up everything
on a real production database like Odoo.com .
This new implementation groups the amounts by currency and performs a single
conversion per currency (factored by the number of events in 'self'). It has
the drawback of using 'today' to fetch conversion rates instead of the actual
SO date like previous implementation.
We (aka: all main POs as this decision was discussed) consider that as an
acceptable trade-off to increase performances.
Task ID-2335287
closesodoo/odoo#58650
X-original-commit: a4c4b03a09ffc08842f44b5759e3c7298cfbd915
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, the colors of the navbar in the table of content
menu were not adapted to the color combinations system. With navbar in
top position, the background and the colors of the links were using the
same color.
After this commit, the colors of the list-group-item links are also
adapted with color combinations.
task-2312878
closesodoo/odoo#58645
X-original-commit: a0dc17676c570887773854243bcb8cd8823359d5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
When creating an event through the quickcreate, the user creating the
event was not set as attendee.
closesodoo/odoo#58631
Taskid: 2334943
X-original-commit: 07d799a5f676ed68fd2ffd9cd9bac3269f947ad1
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>
After this commit, if an url with trailing slash is not found we fallback
to the url without the slash with a redirect to respect seo.
With this change we have the same behavior that controllers.
We continue to support trailing slash if page explicitely created with /
via backend e.g. and for retrocompatibility.
task-2346185
closesodoo/odoo#58603
X-original-commit: 3d65424708d1623654756d58d78cec5f8d71276f
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
When a company is created, a note is added with all the additional
info retrieved from the IAP. Just like when autocomplete is enabled.
closesodoo/odoo#58598
X-original-commit: 0cc87a9349ab3d4e0d51a837deb6630d692ac98f
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This commit fixes several issues
* there are still some jinja references although the template is now done
in QWeb;
* put preferences content inside the same paragraph to avoid unnecessary
blank spaces;
* fix hardcoded company name (olé);
Followup of fd8709515c
Task ID-2338930
closesodoo/odoo#58577
X-original-commit: fd838a3d87f5bd326921dd15c2a41c3d1d3dd131
Related: odoo/enterprise#13591
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Since yet another change in view / server synchronization order line was
not correctly propagated to registration editor values. Registrations
were created several times when confirming an order as backend did not
receive order line information.
Task ID-2344167
X-original-commit: 406795fbee7be60c3346fa00a20755bfc1c8eff3
In this commit we remove the warning logger when not being able to format
a phone number. Indeed this does not indicate there was a real issue.
It simply indicates that either the phone number is not parsable or not
matching given country format.
It happens in a lot of situation that phone numbers are not valid: bad
encoding, country mismatch due to {lead, task, ticket} / partner not always
being the same, ... This should not raise a server warning.
When using frontend SMS composer for phone number, a warning is displayed
to the user telling the number is probably incorrect. This is considered
as sufficient from UX point of view as it warns users. We do not think
we should warn admins that some data is incoherent in database.
This commit also
* Revert "[FIX] crm: avoid linking demo leads with an unrelated partner"
This reverts commit 2c94c4c81ffa171158586cd64828d27c537cd1d6
-> having "invalid" data should be a valid use case of real life
* Revert "[FIX] crm: get correct country for phone validation"
This reverts commit a58f9fc154c038d72031b281e2bec2c0fc2915ba
-> country of a lead comes from its partner if set but can be different.
Same for phone numbers. Values on a lead after a compute are considered
as complete. Sales persons could effectively have incoherent data on their
form view but that is the result of what has been encoded.
Task ID-2325228
X-original-commit: cecc4ca6f02e599e193c3fa688bfcbd02ac0580b
Currently rating globally allows 3 values for customers through email
requests: 5, 3 and 1. Through other means (frontend use of rating widget)
values from 5 to 1 are possible.
Only 5 is considered as a valid value for parent container satisfaction.
This leads to strange situation where a document with 4, 4, 4 and 5 has
only 25% of satisfaction.
This is considered as a bit harsh. In this commit we move the "satisfied"
limit of parent container as being above the "ok" value (aka, 4 and 5).
X-original-commit: c884a29b6b0f2cbc8b0aebbaed93d6f211621d1d
Steps to reproduce the bug:
- Let's consider a service product P with Service Tracking = 'Create a task in an existing project'
and Project = PT
- Create a lead L and set a tag T on it
- Mark L as won and create a new quotation Q from L
- Add P on Q and confirm it
Bug:
An error was raised because the tag T didn't exsit on model project.task
PS: Confirming an order can trigger the creation of many records in different models and the generic field
tag_ids is defined on many models. So keeping it in the context when confirming an order can lead to many issues.
opw:2338764
closesodoo/odoo#58455
X-original-commit: 61a55aabaa46b002b7a4afb6335ab879026c740b
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Add hooks to be able to tweak the Bank customer ID number for ISR-B
Those hooks will allow to not use of the field l10n_ch_postal for
multiple purposes.
Fixes conditions on which the reference is generated.
It shouldn't be always generated if l10n_ch_postal is set.
Only if a l10n_ch_subscription_xxx is set.
closesodoo/odoo#58398
X-original-commit: 4790b8e57aa357cda32818392d795b8c0dc48f43
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Some of the TOTP-related forms contained an attempt at making a centered
modal pop-up, using a bootstrap `card` that would also serve to
emphasize that the interaction was sensitive and security-related.
Some of the "footer buttons" were moved inside the form to make it
more obvious that they were part of the interaction flow.
However some of this caused breakages of responsiveness and did not yield
a really satisfactory result anyway.
This commit switches back to using regular non-centered forms. It looks
quite ugly because the content is better suited for a narrow modal, but
it means less surprises in terms of layout and less responsiveness
issues.
closesodoo/odoo#58541closesodoo/odoo#58544
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Fix the scroll when the snippet is the dynamic one because it did not
work as we tried to get the offset of an element with the d-none class.
Remove the scrollValue variable because we don't need it anymore.
It was used before the code was reviewed in a previous commit.
task-2312878
closesodoo/odoo#58486closesodoo/odoo#58530
X-original-commit: e6d32bc4bfa7f0c3c2f82c2eb99a562c1cb93d83
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Three cases were not covered:
- If the partner with duplicated VAT is inactive (false negative).
- If there are specific contact record rules that hides some of the results for
that user (false negative).
- If the user have several companies viewed at the same time, but the contacts
don't overlap the company scope (false positive).
We cover all of them with this modification.
Was PR #53701closesodoo/odoo#57859
X-original-commit: 35cd931735e2092e08b2cf59434fb3bd579b12ea
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Make sure that model dependencies are flushed before searching with a
given domain. This fixes inconsistencies in `search` and `read_group`.
closesodoo/odoo#57037
X-original-commit: 6b80632e98a932d2b552d6dec0fc7208ca8e04c1
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Before this commit the layout of the off-canvas menu was broken with an
affixed header.
task-2312878
closesodoo/odoo#57442closesodoo/odoo#58528
X-original-commit: 6e1c2ad5db69fe7eaa8f53c8da8375435b59f486
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* Prior to this commit, the auto scroll is triggered when dragging
items over the right panel (if the dragged item is close to bottom
or top).
* After this commit the auto scroll is is no more triggered as long
as the dragged item is over the right panel area.
closesodoo/odoo#58527
X-original-commit: 0262e33d32fa6b3364f4d9c4144879bf28a0869f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* Prior to this commit the dynamic snippet was flickering (destroy followed
by init) because the parallax option triggers a _refreshPublicWidgets
in the onFocus. As such each time the user clicks somewhere in the snippet
the snippet desapears and reappears which can be confusing for the user.
* After this commit, the parallax option will only trigger a refresh on snippets that
are using parallax. This commit also prevent the user from selecting an element of
the dynamic snippet as it is not customizable.
task-2339246
closesodoo/odoo#57693closesodoo/odoo#58525
X-original-commit: ac2d836af9a38687dd0c6d377212f49b102892af
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit :The notification message is not being sent when a message
that should be moderated is posted
After this commit:The notification message will be sent when a message that
should be moderated is posted
LINKS
Task-2282596
closesodoo/odoo#58512
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Currently, in demo data project's allow timesheet is set as False
even there is lots of timesheet entry exist in task's of that project.
So in this commit, when timesheet installed then default allow
timesheet should be set as True for the demo data projects
closesodoo/odoo#58224
Taskid: 2342606
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
* calender_sms, hr_expense, sale_project
PURPOSE
Enable the framework to define some of actions in the controlpanel,
as buttons similar to the 'create/edit/discard' buttons.
SPECIFICATIONS
Replace the below-mentioned dropdown actions with controlpanel buttons
- 'send sms to attendees' in Calendar > Calendar
- 'approve report' in Expenses > Expense Reports > To approve
- 'post entries' in Expenses > Expense Reports > To post
- 'register payment' in Expenses > Expenses Reports > To pay
- 'create invoice' in Field Service > All Tasks > To Invoice
LINKS
PR https://github.com/odoo/odoo/pull/57830
Task-2300426
closesodoo/odoo#57830
Related: odoo/enterprise#13272
Related: odoo/upgrade#1785
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, when there is modal dialog in website the header part of
the modal is hidden behind the navbar and the modal is not centered.
so in this commit, When the modal is in #wrapwrap, modal position
top should be size of the navbar.
closesodoo/odoo#56056
Taskid: 2320303
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
*: web, web_editor
Since the right-panelization made with [1], the modals were not
compensating the body scrollbar when opened anymore and the backdrop
was misplaced. This commit fixes the problems generically, to support
modals with non-body scrolling.
[1]: https://github.com/odoo/odoo/pull/57975closesodoo/odoo#58442
X-original-commit: ebd0c90a146145079061e79c2d4c37fa182a2975
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Removing the display of the Color Index measure in the menu of the graph view.
Task ID : 2302578
closesodoo/odoo#56846
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Bug
===
You can enter in a fullscreen mode in the frontend, of the slide channel.
In this view, the default website header should not be visible.
To do that, we play with z-index, but since 0f2cab4aeb ,
the z-index of the website header has been changed without changing the z-index
of the fullscreen view.
Task-2345016
closesodoo/odoo#58483
X-original-commit: 8d35540df6d21af6fe716f73aefa37bfb66c7ac2
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The o-scrollbar-overlay mixin was introduced for a fix on the enterprise
home menu (see related commit in enterprise that comes with this PR).
It was used on modal elements at the same time for no apparent reason:
the modal in the backend do not even scroll as this is their modal-body
that does.
This now introduced a bug in the frontend: some code which allows to
scroll to an element in a modal was not working on chrome because the
related code was checking for the element with 'overflow: auto'... which
it could not find since that element uses 'overflow: overlay'. As
overlay is a deprecated value, it seemed better to remove its use rather
than adapt the frontend code expecting the 'auto' value. This also solve
a design inconsistency between Chrome and Firefox (where the overlay
value is simply ignored).
closesodoo/odoo#58462
X-original-commit: 5ffb7bb2f461de2b3cf95ef0df6a24b668bf9bd3
Related: odoo/enterprise#13532
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The upload bill wizard is missing a field related to its _inherits
reference, which cause a warning regularly in the console.
This commit will add this field to fix that.
Task id #2338970closesodoo/odoo#58426
X-original-commit: dbc3d7cbb60e291079e0a1fd3dfa6600d6206228
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Expense header was displayed in all tree & kanban views.
This commit removes the header in other views than 'My Expenses' menus
because the expense header should only be visible in the 'My Expenses' menu
Task id: 2341766
closesodoo/odoo#58040
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Steps to reproduce the bug:
- Have a lot of res_partners (more than 100,000)
- Search for a customer
Bug:
The app freezes while searching
opw:2302765
closesodoo/odoo#58469
X-original-commit: 7c7269fa6152795ffaf6a0c8e9c2261d7ca8aaae
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Signed-off-by: backspac <backspac@users.noreply.github.com>
The 'paid' ribbon should not cover the 'receipts' stat button.
It's now displayed underneath.
closesodoo/odoo#58454
Taskid: 2343742
X-original-commit: b1a37e552d6ab5504f2ef8c52a7312fd5d025c79
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
In Timesheets module, in Configuration => Settings, when clicking on "Download on the App Store" or "Get it on Google Play",
a popup is displayed with a QR code.
This QR code is composed of an url with some strange data before it:
- 002
- 1
- <the url>
This commit removes datas that are before the url so only the url is displayed.
Task id: 2326324
closesodoo/odoo#58453
X-original-commit: 0bf7ac7539fa4fb7f912bbb6fd477795cb77eff8
Related: odoo/enterprise#13528
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Create a sale order
Put an optional product with long description (no line break)
Save and confirm
Log in the portal with the receiving user, add the optional product to
the order.
The customer can't see the quantity of the optional product.
The number is not showing in the quantity adjustment widet.
opw-2304224
closesodoo/odoo#58226
X-original-commit: 27f6522f43c38d8eeed32285ce03fd1bb218aab2
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
In case you don't have the trailing slash and are on your homepage, the indexOf
will return -1 and you will be redirectected to the pathname.substr(-1)
Now if you don't have trailing slash in your url after position 1, we don't
subtract anything.
domain.com/fr_BE
Before this commit:
=> redirect to domain.com/E
After thi comit
=> redirect to domain.com
task-2345490
closesodoo/odoo#58458
X-original-commit: ada2e2ce68dbc8b1df701691d9d3e958fef4ea31
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Also fix an issue with livechats not being considered in 'chat'
filter of messaging menu.
Task-Id 2282426
closesodoo/odoo#58468
X-original-commit: 631e52536964763bbfe857305f023e5e67084e95
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
due to breaking changes in https://github.com/odoo/odoo/commit/bf32b22ce247c19fda94ded74e37f7c6120ce2c4
and especially the part:
"NOTE 1. If the default_get within the onchange returns a value for
a field that is not in the view, we ignore it, and it won't be saved.
Before, that value was kept and sent upon save. This change in behavior
may prove problematic, although the overall risk is small. Decision has
been made to keep heavy comments and code snippets if we were to revert
back somehow to the previous situation."
the wizard to sending failures email was broken as the field partner_id
which is required was not present in the view and was thus ignored by
to web client when calling 'create'.
closesodoo/odoo#58461
Task: 2341593
Closes: https://github.com/odoo/odoo/pull/58299
X-original-commit: f2431535a84cf4475899c285d968618bdecca1fc
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
The affixed header was not properly repositioned in editor full screen
mode (introduced in 13.4).
closesodoo/odoo#58447
X-original-commit: 7502c8aa6e5422b1ecf446002e187fa2f7ca3aa7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Fine-tuning of #58062. This is not possible in v11, as the link for localization
modules is done through the description field, but doable in v12.
closesodoo/odoo#58438
X-original-commit: 207207d9dc1c2e0c18c6f3b48078314ced8b38cb
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Purpose
=======
A user without the group "Marketing User" might see the button
"Contact Track Speakers" in the event form view. If he click
on the button, an error is raised.
Task-2320370
closesodoo/odoo#58405
X-original-commit: cf69e172f3f22a477686a23be1c3575a19f70c05
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This reverts commit 8b8c26877a41e55eb0f3acb1909ac0c3abbf37d7.
While it fixes cases on colored background, it is ugly on black bg.
Waiting another colution, real white edge ?
closesodoo/odoo#58326
X-original-commit: b14694bc679280e99caad04676668462f4e8bdb2
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit on mobile when you come to odoo from a notification
url like:
https://my_domain/web#action=mail.action_discuss&active_id=1&menu_id=93
a traceback occurs on mobile discuss wasn't loaded correctly and the
content didn't appear.
With this commit, it's open the related discuss thread.
It's also ensure the return to the chat tab when you close a chat and
the return to the channel tab when you close a channel conversation.
We also ensure the loading of the inbox items when you navigating on
the mobile discuss button.
Steps to reproduce:
1. Open a chat from a mobile notification
2. A traceback occurs
opw-2310319
closesodoo/odoo#58431
X-original-commit: 8ca5024bef246c93bbb7522d77aca4c4ba7a33b4
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Robin Heinz