Before this PR, newly created direct message would be added at the bottom of the
list instead of the top.
This PR fix the issues by sorting the direct messages when creating a new direct
message channel.
Task-3566728
closesodoo/odoo#139960
X-original-commit: 60cf880102615a524f2fa89c71be7f1b08d931d1
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Steps to reproduce:
- Enable Storage locations
- Add two lots in stock:
- lot_shelf_2 in WH/Stock/Shelf 2
- lot_shelf_1 in WH/Stock/Shelf 1
- Enable the 'Closest Location' removal strategy on its product category
- Create a delivery using this product and mark it as todo
Issue:
lot_shelf_2 will be selected even though it should take the one from
Shelf 1.
When filtering on the location, we need to filter on the location name
instead of this is.
Also, when creating a new quant on a product using the 'closest'
location, the filter will create a traceback because it will try to
filter on a NewId.
closesodoo/odoo#140175
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Steps to reproduce:
- Enable product expiry
- Add two lots in stock:
- lot_1 expired in 5 days
- lot_2 expired in 2 days
- Enable the 'First Expiry First Out' removal strategy on its product
category
- Create a delivery using this product and mark is as todo
Issue:
lot_1 will be selected even though it will expire later.
Following 2151a34, _gather() can now use `self` to filter on itself
instead of performing a search() to save some time.
Problem is, no sort_key was defined for 'fefo' strategy.
Part-of: odoo/odoo#140175
[Context]
Sales Order can be connected to projects. Before this commit archived projects
were counted in the stat-button, but not in the related to stat-button project kanban view.
We want to show archived (i.e. "non active") projects in both.
[Reproduce behaviour before this commit]:
- run odoo 15 with: sale_management,project,timesheet_grid
- In Project, create:
- project A
- project B
- In Sales/Products/Products, create:
- product A (set: type="Service", Create on Order="Task", project="project A")
- product B (set: type="Service", Create on Order="Task", project="project B")
- In Salse/Orders/Quotations:
- Create Quotation
- add "product A" and "product B"
- save & Confirm
- OBSERVE: stat-button "projects" shows 2 projects
- Click on: stat-button "projects"
- OBSERVE: kanban view shows 2 projects
- Archive one of project
- go Project/"Project A"/Edit/Action/Archive (require debug mode)
- Go back to created Quotation
- OBSERVE (Desired): stat-button "projects" shows 2 projects
- Click on: stat-button "projects" and OBSERVE
- OBSERVE (Not-Desired): kanban view shows 1 projects (it excluded archived one)
[Fix]
Modified domain in the function/action related to the stat-button.
opw-3500711
closesodoo/odoo#140364
X-original-commit: eef4506f32f09dcda9990556e55131bc17855dcc
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Fixes 2 use cases:
- barcode redirect after picking is validated (should return to menu
instead of refreshing the validated picking). Issue was due to missing
renaming of "on_close" to "onClose" after refactor occured
- ensure the auto-print action during MO validation always has a context
because the "Shop Floor/MES" expects any returned actions from
validation to always have a context to add the extra context parameter
of "skip_redirection" to it
closesodoo/odoo#140352
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
The lot and product label wizards were refactored to have diff
variables, so the auto-printing parameters need to be updated to match
Part-of: odoo/odoo#140352
Before this commit:
On creating link in debug mode produces prop validation error, and link
dialog doesnot appear
After this commit:
Now the issue is resolved and link dailog appers.
task-3571940
closesodoo/odoo#140178
X-original-commit: 8519cbab2e22506b12a1d93066c2c4fd87e753fe
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Sanjay Sharma (shsa) <shsa@odoo.com>
Prior to this commit, when you removed a social link in the header,
there was an error.
This is because `website.header_social_links_no_color` targets selectors
that do not exist in this situation.
task-3572219
closesodoo/odoo#139883
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, the avatar next to composer in Discuss app
had the top aligned with the top of the text input of composer.
The avatar is smaller than the input, and the text in the input
is centered, so the alignment looks off.
This commit fixes the issue by offseting the avatar so that
when the composer has only 1 line, the avatar is vertically centered
with the input.
Note that this alignment should be fixed, i.e. if the input field has
more than 1 line, we want to keep the avatar in the same place, hence
why the avatar is just statically offset.
Also align composer avatar with message list, by removing the
`align-justify: self` that was moving avatar slightly towards the
discuss app sidebar.
closesodoo/odoo#140398
X-original-commit: 5fe4297f3d1a988ae65617c177046a223bc62890
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Prior to this commit, the Request for Quotations (RFQ) dashboard suffered
from a visibility issue. Specifically, the values displayed on the right
section of the dashboard were using a background color class that was not
correctly used leading to poor differentiation between the values and
their corresponding labels/titles.
This commit apply the correct background colors to these elements.
task-3573792
closesodoo/odoo#140395
X-original-commit: c46970dc773f8985acdb0d07ce9faa5e7d204641
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Xavier Luyckx (xlu) <xlu@odoo.com>
Before this commit, messages in livechat from visitor POV show
2 emoji icons in the quick actions. This is confusing and comes
from 2 actions sharing this exact same icon: "Add a reaction"
and "View reactions".
This commit fixes the issue by reducing the number of quick message
actions to 2 for the embed live chat. In other contexts there's
"Reply-to" and "Mark as Favorite" in quick actions, so the
"View reactions" item is always in expand menu.
Note that this "dirty" fix come from 2 actions with same icon.
Eventually we should fix that by clearly making icons unique.
This solution is decent for the time being, giving us more time
to make a dedicate icon for one of the emoji actions.
task-3498446
closesodoo/odoo#140335
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
There is an exact case where having a grid mode block inside a mega menu
item will fully bug: all elements will be on top of each other.
In order to reach this case, you need to:
- Create a mega menu
- Make the block inside this mega menu use grid mode
- Find a screen size where this mega menu will be part of the extra menu
items (hidden in the `+` entry)
- BUT the screen size should not toggle the mobile view
Point of attention when trying to replicate the issue:
When you enable grid mode, the result will depend on the available size.
So be sure to not enable the grid mode on a megamenu which is already
hidden in the extra items when you are in edit mode, in such a case,
there is no bug.
This commit simply disables the grid mode in such a case, it will thus
behave like the grid mode in mobile view and therefore be responsive
(disabled in mobile).
opw-3547405
closesodoo/odoo#139956
X-original-commit: fb209432049d9874308a2bdc3c9d2baa210ccced
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Step to reproduce:
- Create a pos session
- Create a new order
- Process the payment (the syncing has to be long to notice the issue)
Issue:
You can still click on buttons in the interface payment screen and
trigger tracebacks
Cause:
The ui is not blocked while syncing orders
Solution:
Block the ui while syncing orders
closesodoo/odoo#140342
X-original-commit: 61dd356e48e7d0bfe1c8758c3835b858e2aa8de0
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: fja-odoo <fja@odoo.com>
Since PR #137864
We do not have quantity done anymore and we use the picked field
to know if something is picked or not. But we remove the immediate
transfer wizard and we consider instead than if nothing is mark as
pick, everything is pick. We will do the same for repair because it
would confusing to have a different behavior
closesodoo/odoo#140322
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
*: test_website, web_editor, website_sale
The goal of this commit is to replace all Dialog in the Website Editor
flow with OWL Dialog. This uses the new `bindService` and `call` methods
available on legacy widgets. The replacements mainly use the
ConfirmationDialog component, but some had to have custom-made dialogs.
closesodoo/odoo#138947
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
This code was use in 14.0 to allow users to edit the Company Information
visible on the /contactus page. It is no longer needed as the page is
now fully editable and the t-field has been replaced with static text.
Part-of: odoo/odoo#138947
Issue:
======
- When a user attempt a certification it will count as 1st attempt and
then do retry directly it will count as second attempt : fine.
- When a user attempt a certification it will count as 1st attempt and
then exit the page and go to the certification again it will count as
1st attempt too. So the user can have unlimited number of attempts
like this.
Steps to reproduce the issue:
=============================
- Install survey , elearning
- Go to a course with a certification and do the certification, exit the
page and enter to it again.
- Go to the user page and see the certifications you will see they both
counted as 1st attempt.
Expected behavior:
==================
- when a user leaves a course (willingly or not) we remove the
relationship between the user_input and slide_partner_id.
- To get the remaining attempts we just get the user_input_ids of the
slide_partner because the old ones are removed.
opw-3498054
closesodoo/odoo#140305
X-original-commit: 74d2b551ae392fa20744fa22582b5b38b3babff7
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
Dark-mode colors have been adapted from MILK redesign in 16.3 [1].
Discuss badge colors were changed in 16.4 to match systray color [2].
Commit [1] adapted them to use primary color instead of intended
sytray color. Removing the override of style fixes the issue, as the
base style in `core.scss` (white theme) works in both themes.
[1]: https://github.com/odoo/odoo/pull/130991
[2]: https://github.com/odoo/odoo/pull/122946closesodoo/odoo#140300
X-original-commit: b46bded27349acd311682846c0a0416ce4898882
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Correct the view. Prior to this commit the buttons on the time off
popup are not alligned.
closesodoo/odoo#140284
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Make partner_id and guest_id properly exclusive.
Allow creating a channel member from its form view.
closesodoo/odoo#140272
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, when opening a thread in the Discuss app and
changing to another active thread from the Messaging Meu in the
systray, the new thread was mistakenly renamed to the previous
active thread name.
This happens because the component `AutoresizeInput`, which is used
to show the thread name in the header of Discuss app, also allows to
rename the thread. The code to trigger rename was too naïve, in that
a click away was considered as a rename operation on the current
thread.
This commit fixes the issue by triggering the editing of the value
in the `AutoresizeInput` component only when the click away happens
while the input had focus. The click in messaging menu will not
trigger it as the input is not focused.
Task-3570377
closesodoo/odoo#140208
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Currently, if a user has an active deferred entry whose account has been deprecated in the mean time,
we create a move line containing this deprecated account which raises an unclear error to the user.
Now, instead, we let the user create deferral entries for deprecated accounts.
We also add a test to check that old moves are not taken into account when generating deferral entries.
task-id 3544877
closesodoo/odoo#140155
X-original-commit: 47f97fb208ee6c6fc4ce522bc7ad648ea6bbe07c
Related: odoo/enterprise#49758
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>
This commit adds tests for the pos_self_order module. The tests are
written in javascript and use the odoo testing framework. The tests
cover the following scenarios:
- attribute selection
- combo selection
- kiosk mode
- mobile mode
closesodoo/odoo#140138
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
Before, error handling didn't work in point_of_sale when offline.
This was due to poor error handling.
Now, the "limited functionnalities" popup is displayed correctly.
closesodoo/odoo#140037
Related: odoo/enterprise#49705
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
The field date_order cas removed in a previous commit.
Thus, this line needs to be removed as well.
closesodoo/odoo#133654
Related: odoo/enterprise#46580
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
When the pr of the skip receipt was merged, the vat letter feature was missing.
This commit put it back to the point of sale module so we can inherit it again in other modules.
Signed-off-by: rhe-odoo <rhe@odoo.com>
m
Part-of: odoo/odoo#133654
There is a button in the header to register subcontracting process
(when needed). And there is an additional button in the view with
the purpose to correct data later after the encoding. However we
can't set button with optional="hide". We rename it with an edit
icon
Part-of: odoo/odoo#140307
It's bad practice to use the "extension" inheritance mode for a custom
component. In this case, inheritance is only necessary for the
"StockMoveX2ManyField" custom field.
In this commit, we will therefore use primary mode to generate a custom
template used only by "StockMoveX2ManyField".
closesodoo/odoo#140301
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Purpose:
-------
The "StockMoveX2ManyField" custom field has given rise to a new need,
that of being able to edit a record in an x2many directly or from a dialog.
This is the first use case to require the ability to do both at the same time.
This particular use case highlighted a bug preventing a change from being saved.
How to reproduce:
- Go to a form view with an x2m using a custom widget
- Open an x2m record in dialog mode
- Close the dialog
- No changes have been made to the record, so the save button is not displayed
- Edit a field in the same record
Before this commit:
The save button is not visible
After this commit:
The save button is visible.
closesodoo/odoo#140298
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This commit removes useless function from legacy/utils.js and removes it
from several backend bundles. The file is moved in wysiwyg and frontend
bundles as it is still used in these bundles.
task id: 3439226
closesodoo/odoo#140260
Related: odoo/enterprise#49812
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Before this commit, cliking on a popover that was open inside another
popover closed both of them.
After this commit, the popovers are not closed. them will close only if
we click out of them and the popovers they opened.
closesodoo/odoo#140258
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Purpose:
--------
Before this commit, if you edit a char field with an onchange in
an x2many, the FormStatusIndicator buttons will flicker.
How to reproduce:
-----------------
- Go to a form view with an x2many field in list mode
- Type a char in the char field of a record
- The FormStatusIndicator buttons are visible
- Click outside the char field
- An onchange is triggered
Before this commit:
The FormStatusIndicator buttons will disappear until the onchange returns.
After this commit:
The FormStatusIndicator buttons remain visible.
closesodoo/odoo#140179
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Fixes the receipt payment lines name (replacing "Bank" by the payment method name).
closesodoo/odoo#140098
Task-id: 3572422
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
In this commit, we add the mention of the service type on the ticket and
when the service is "table", we add the table stand number.
We also fix a problem with stripe and adyen where the ticket does not
print the order but an empty order with the kiosk.
closesodoo/odoo#140047
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Change the global filter icon from the `fa-search` to something more
filter-like.
Also use the same icon in shared dashboard.
closesodoo/odoo#139164
Task: 3560817
Related: odoo/enterprise#49166
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
In this commit, we will remove "closestScrollable", "compensateScrollbar"
and the last usage of "scrollFixedOffset" outside of dom.js.
closesodoo/odoo#140181
Part-of-task: 3439226
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Before this commit, the domain on ``employee_id`` and ``employee_ids``
would be computed in a computed method ``_compute_allowed_employee_ids``.
However, due this compute method not triggering for new records, the
domain was not correctly set.
Additionally, this way of computing the domain was not very efficient.
With this change, the domain is computed correctly and efficiently.
closesodoo/odoo#140146
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
The forms where we have ribbons do not provide a great user experience when the internal links are right below the ribbon. Because of the shape and size of the ribbon, the internal link button on the topmost fields gets behind the ribbon. Because the rectangular part of the ribbon is transparent, we can see the button, but cannot click or hover over it, because the ribbon element takes over. To resolve this, I set the pointer-events of ribbon to none. The ribbons already do not have any click events so this solution seems okay.
Steps to Reproduce:
1. Move a helpdesk ticket to the archive.
2. Try to move to the customer page using the internal link.
Current Behavior:
The link button cannot be hovered over and clicked.
Expected Behavior:
The link button should be above other elements and clickable.
OPW-3468153
closesodoo/odoo#140099
X-original-commit: c9aa5fb7645470c5a63784e58fdb4ee9acf7d5e8
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Signed-off-by: Simon Goffin (sig) <sig@odoo.com>
Didier (did)