Commit Graph
119468 Commits
Author SHA1 Message Date
Goffin Simon 73b4abfcbc [FIX] sale_mrp: Updating delivered qty
Steps to reproduce the bug:

- Create three stockable products: Kit, C1 and C2
- Create a phantom BOM for Kit with C1 and C2 as components
- Set the invoicing policy of the kit based on delivered qty
- Create an SO for the kit and validate it
- On the delivery order, just deliver C1 and create a backorder for C2
- Cancel the backorder and duplicate it
- Deliver the duplicated backorder and validate it

Bug:

The delivered qty on the SO line has not been updated to 1.

opw:1886315
2018-10-02 11:19:55 +02:00
Goffin Simon e764739d0d [FIX] sale_mrp: price unit of kit
- Create the following products in FIFO costing method and real-time
  valuation:
  Prod Final (F); Invoiced on Delivered Quantity
  Prod Comp1 (C1); Cost = 20
  Prod Comp2 (C2); Cost = 10
- Create the BOM Kit for F:
  2 Unit(s) of C1
  1 Unit(s) of C2
- Create a SO for 3 Unit(s) of F
- Validate SO and picking
- Create the invoice and validate

The price unit taken into account for F in the anglo-saxon accounting
entry is:
20 + 10 = 30
=> entry in Stock Output Account is 3 * 30 = 90

while it should be:
(2 * 20) + (1 * 10) = 50
=> entry in Stock Output Account is 3 * 50 = 150

This should finally fix issues corrected with:
9a7ed7c: price unit multiplied by the qty sold (*)
f1fdb97: price unit taking into account only 1 unit of each
component

(*) In the use case solved, the price unit was:
(6 * 20) + (3 * 10) = 150
=> entry in Stock Output Account is 3 * 150 = 450

opw:1886216
2018-10-01 14:05:58 +02:00
Christophe Simonis e980af9df0 [MERGE] forward port branch 11.0 up to a9a556178d 2018-10-01 10:44:38 +02:00
Lucas Perais (lpe) cbff00a5d2 [FIX] base_vat_autocomplete: support overload street fields
Install base_vat_autocomplete and base_address_extended.
Try to create a contact with VAT: BE0477472701 (or any valid one)

Before this commit, there was a traceback because the split of the address string into fields
contained a field that is set in base_adress_extended, and not handled by the current module

After this commit, there is no traceback

OPW 1887288
closes #27291
2018-10-01 09:35:51 +02:00
Lucas Perais (lpe) 1bd7adcc8b [FIX] web: debug_manager set defaults
On a form view, click on set defaults, select a value for a field,
then save

Before this commit, there was a traceback because the model on which we apply
the defaults was not found

After this commit, it works as expected

OPW 1887032
OPW 1888715

closes #27148
2018-10-01 09:31:15 +02:00
Odoo Translation Bot 4d46569766 [I18N] Update translation terms from Transifex 2018-10-01 02:39:15 +02:00
Nhomar Hernandez cc46bf97a4 [FIX] sale: Call the proper method in the test and not the partial one.
With this we can test the invoices properlly in other environments where
we do not depend on sale due to the fact of this incorrectly set test we
hade collateral damage in the localizationsfor example (also related to
doesn't have a new created field called correctly in invoice_open and
the method action_date_assign was not called propperly.

With this fix we do not need to make defensive programming in the
localizations in order to allow us to test it properlly.

closes odoo/odoo#27316
2018-09-30 08:09:48 +00:00
Odoo Translation Bot 0a94a766e6 [I18N] Update translation terms from Transifex 2018-09-30 00:29:10 +02:00
Christophe Simonis 88fa382664 [MERGE] forward port branch saas-14 up to 503c7a3d65 2018-09-28 19:14:45 +02:00
Christophe Simonis 503c7a3d65 [MERGE] forward port branch 10.0 up to baf3c5712d 2018-09-28 19:10:04 +02:00
Christophe Simonis baf3c5712d [MERGE] forward port branch 9.0 up to 70028701b3 2018-09-28 18:06:03 +02:00
Martin Trigaux 21f8ee0119 [FIX] account: fallback for entries with no name
The name of an account.move.line is not mandatory
If a line with no name but analytic tags is posted, the name for the analytic
line should be computed differently (the name of an anlytic line is required).

Apply changes from f2b2d87236 to the _prepare_analytic_distribution_line method

Fixes #27281
2018-09-28 14:55:13 +02:00
Gustavo Valverde a9a556178d [FIX] stock_account: Use product display_name in errors
When working with product variants, if the error which gets displayed does not include the product attributes, it's harder to identify the variant with the error.

closes odoo/odoo#27298
2018-09-28 12:38:34 +00:00
Christophe Simonis 56658ad8de [MERGE] forward port branch saas-15 up to 88fa382664 2018-09-28 19:17:24 +02:00
Gert Pellin 1b5f2ac420 [FIX] hw_scale: read values from Adam scale
with migration from python2 to python3 not all regexes where converted
to byte-array.

backport of b4bcf86f8e to 11.0

closes odoo/odoo#27252
2018-09-28 13:21:56 +00:00
Nicolas LempereurandWolfgang Taferner 46f2e1918f [FIX] base: access_token error handling correctly
When an attachment is requested with an access_token, a server error
would occur in some situation.

With this changeset when an access token is specified:

- returns a 404 error if the attachment does not exist
- returns a 403 error if the attachment has no access_token

Without this change, the added test would fail with:

```
 status = test_access(access_token='Secret')
 self.assertEqual(status, 403,
     "no access if access token for attachment without access token")
 | if not consteq(obj.access_token, access_token):
 | TypeError: unsupported operand types(s) or combination of types: 'bool' and 'str'

 status = test_access(access_token='Secret')
 self.assertEqual(status, 404,
     "no access with access token for deleted attachment")
 | if not consteq(obj.access_token, access_token):
 | odoo.exceptions.MissingError: ('Record does not exist or has been deleted.', None)
```

close #26647
opw-1884419
closes #27275

Co-authored-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
2018-09-28 10:42:51 +00:00
Nicolas Lempereur bedb3a1db0 [FIX] stock_account: visual ok product standard_price
The xml structure would display "$ 0.00Cost" instead of "Cost $ 0.00".

closes #27280
2018-09-28 12:31:41 +02:00
Olivier Colson 70028701b3 [IMP] l10n_lu: make 9.0 fix match the one done by mat in 11.5 2018-09-28 12:16:25 +02:00
Stefan Rijnhart 22cd49bafb [IMP] l10n_jp: reintroduce account 製品 with correct account code 2018-09-28 12:08:47 +02:00
Olivier Colson 7c9a3840f8 [FIX] l10n_jp: remove duplicate account code
Two account had the same account code. Because of that, one of them always failed to be created and logged a psql error. To fix that, we totally remove this account, as it never got created anyway.
2018-09-28 10:38:01 +02:00
Olivier Colson 51b7168d1b [FIX] l10n_lu: rename duplicate tax xml id
The second tax with the same xml id was never created, and caused a psql error to be logged.
2018-09-28 10:30:58 +02:00
Christophe Simonis 5d4ae94f4d [MERGE] forward port branch 11.0 up to d61a248523 2018-09-27 14:59:50 +02:00
Martin GeubelleandAaron Bohy f4b2060af5 [FIX] web: handle lazy load with previous actions
Before this rev. the lazy loading of views was correctly handled if there was
only one action in the action stack (which is usually the case when performing a
F5, the main use case of the view lazy loading).

Nevertheless, it might happen that the lazy-loading is used in top of other
actions (when performing a `doAction` with a form view for an action with
another view as first view, i.e. when leaving Studio while editing the form view).
The controller was `unshift` in the case (put in the first position of the
controller stack), which is not correct.

This causes the breadcrumb to be misordered and a traceback occured when trying
to access a breadcrumb element.

Co-authored-by: Aaron Bohy <aab@odoo.com>
2018-09-27 12:34:04 +02:00
len-odoo 2a697f1c5b [FIX] document: update environment before attachments update
Fine-tuning of commit:
b3a3ad8099
ac1e187eea

The environment should be updated before the call to _updateAttachments,
as it depends on the env active_id.

opw 1888651

closes odoo/odoo#27277
2018-09-27 10:11:12 +00:00
Xavier Morel 8eb8495710 [FIX] doc: backport of ac37ca39e
github_link compatibility with Sphinx 1.8

Backport to 11.0
2018-09-28 12:23:41 +02:00
Martin Trigaux b18a4cba0e [CLA] Inspur signs Odoo CCLA
Done at opw-1889259
2018-09-28 11:55:10 +02:00
Martin Trigaux cf50388d10 [FIX] product: correct bad translation
Already fixed on Transifex but saas-11.3 is no longer translated
opw-1888807
2018-09-27 11:17:43 +02:00
Christophe Simonis 5f08d82bcd [MERGE] forward port branch 11.0 up to fd122aec52 2018-09-26 19:37:29 +02:00
len-odoo fd122aec52 [FIX] website: fix image carousel
We fix a number of problems:
    - grayscale filter not being applied except on desktop Firefox
    - incorrect vertical-align on iOS
    - image sliders being displayed below the margin on iOS
    - carousel indicators flickering at initial load
    - very short indicator panel, almost unusable on mobile
    - misaligned indicators because of first margin
There are two modes on which these fixes apply:
    - image gallery in slideshow
    - slideshow in modal
       (e.g. obtained by clicking on the gallery set on masonry mode)
Note that due to a refactoring, the gallerySlider was not loaded in the modal,
completely breaking the indicators.

Coauthored by @nle-odoo

opw 1874274

closes odoo/odoo#27226
2018-09-26 14:14:14 +00:00
Christophe Simonis a0d832efdc [MERGE] forward port branch saas-14 up to 218eec5482 2018-09-26 12:09:18 +02:00
Jeremy Kersten b732ab3dc9 [FIX] base: fix dev mode for get_view_arch_from_file and inherits
Before this commits, dev mode crash in some case (see below) when you declare
a website_page without field name='arch'.
After this commit, we follow the view_id (limit: only into the same file)

Contactus works luckily before this commit, because compute field xml_id on
View return the first ir_model_data (order by name asc by default).

website.contactus
    is BEFORE
website.contactus_page_ir_ui_view

 -- while --

website.bs_debug_page_view
    is AFTER
website.contactus_page_ir_ui_view

closes odoo/odoo#27234
2018-09-26 09:32:11 +00:00
Goffin Simon 736f49baef [FIX] stock_account: float division by zero
Steps to reproduce:

- Create a stockable product P with 2 quantity on hand
- Choose a delivery order in state 'done', unlock it and add a line with P
- Try to set 2 as done quantity and confirm the wizard

Bug:

A ZeroDivisionError(float division by zero) was raised.

opw:1886735

closes odoo/odoo#27547
2018-10-09 07:45:59 +00:00
Lucas Perais (lpe) 798d21ee3f [FIX] website_sale_options: on webshop, display attributes
Before this commit, when the names and values of the attributes on an optional
product were too long (and it did not take that much)
The display was broken into lines

After this commit, the container of the attributes works in standalone and won't break
but, on very small devices, it is not ideal either

OPW 1888416

closes odoo/odoo#27279
2018-09-27 11:42:13 +00:00
Nicolas Lempereur 28d79fc939 [FIX] mrp: pdf preview shown before saved
In the current code, we only show a PDF previewer if a PDF is already
saved. When the PDF is changed we see the preview if it was previously
saved also.

This seems to be the expected behavior, but this changeset changes it so
we could always show a preview.

opw-1888399
closes #27393
2018-10-09 11:27:27 +00:00
Christophe Simonis 218eec5482 [MERGE] forward port branch 10.0 up to 854eb97b2e 2018-09-26 11:28:33 +02:00
len-odoo 09340bb7f0 [FIX] mail: set the thread_id when creating a new thread
After a refactoring for v11, the id of a newly created thread is not returned
anymore.
Therefore server actions weren't being executed on newly created records.

opw 1886383

closes odoo/odoo#27238
2018-09-26 08:36:14 +00:00
Christophe Simonis 854eb97b2e [MERGE] forward port branch 9.0 up to bc14f30ecc 2018-09-26 10:17:05 +02:00
Nicolas Martinelli 7b13888c8e [FIX] mrp: Cost & Structure
- Create the following BOM for 100 Units of A:
   15.0 kg of C1
    1.0 kg of C2
  500.0 g  of C3
- Click on 'Cost & Structure'

The quantities and costs of 100 Units are used for 1 Unit.

opw-1886959
2018-09-26 09:27:47 +02:00
Nicolas Martinelli a6bf3ef7d8 [FIX] point_of_sale: AccessError
Missing `sudo` which prevents a non-admin to close a POS session.

opw-1888252
opw-1888358
2018-09-26 08:05:29 +02:00
Rémi Rahir 2bf1af77fb [FIX] iap: fixing get() for non-amin users
closes odoo/odoo#27219
2018-09-25 16:11:26 +00:00
Christophe Simonis 6ce408c824 [MERGE] forward port branch saas-15 up to a0d832efdc 2018-09-26 12:41:31 +02:00
Toufik Benjaa f7d7eb06ab [FIX] account: avoid to rewrite product image when refunding invoice
- When refunding an invoice the field product_image is modified and
  tries to write on the product image field for no reason.
2018-09-26 12:15:09 +02:00
Olivier Colson bc14f30ecc [FIX] l10n_co, l10n_cr: make 'bank & cash' accounts not reconcilable
Accounts of this type should not be reconcilable. When making payments, only the counterpart line should be, in some receivable or payable account.
2018-09-25 17:31:55 +02:00
Olivier Colson 6b96e5024a [IMP] account: forbid making a 'bank & cash' account reconcilable
Making a bank account reconcilable is a very common mistake, and leads to confusing and useless data (the move lines made on this account) to be displayed in the reconciliation widget. With this commit, we make sure the user cannot make this mistake anymore.
2018-09-25 17:31:55 +02:00
Graeme Gellatly 9e9d8e3632 [FIX] purchase: add state field in form view
The inline tree view of the purchase order lines has a state field that is used
in attrs.
The popup form does not have the state view.
Even if the state field is not used in the form view, closing the form view
produces an error as the field state is not found.

This patch is a workaround to avoid the error.

The real issue should be fixed in the future but is more complex.

closes odoo/odoo#27208
2018-09-25 14:52:20 +00:00
len-odoo 31d2b49a78 [FIX] stock_account: updating price with negative quantity on hand divide by 0
In the case where the user forces a sale with a negative product quantity on
hand, then the average price update might divide by zero.
We guard against this case.

opw 1886967

closes odoo/odoo#27232
2018-09-25 15:10:44 +00:00
Romain Derie 9ef7763ecd [FIX] website: create ir.ui.view / website.page in the same record
Somehow, having theses 2 new `website.page` records created separately from
their `ir.ui.view` would throw an error in dev-xml when installing website
module.
A task has been created in website team to track the origin of this bug.

In the meantime, this commit will avoid the traceback by creating the view
inside the page record. As the page's view is not intented to be inherited, it
is the best way to write it anyway.

Step to reproduce:
  - Start odoo in dev xml
  - Install website app

Related to #27199

closes odoo/odoo#27210
2018-09-25 17:22:10 +00:00
Pedro M. Baeza d61a248523 [FIX] l10n_es: Correct prefix_code for group 6
closes odoo/odoo#27228
2018-09-25 14:05:48 +00:00
Nicolas Martinelli d5c16cdadf [FIX] project: copy project
- Create a project
- Create some tasks with followers
- Create an outgoing mail server with active = False
- Copy that project

When copied, the project tries to send emails to followers using the
inactive mail server. This leads to a traceback.

The addition of the context key dates back to 2009 with 853789d0aa.
The purpose was to copy all tasks, including the archived ones.

We keep this behavior, but without propagating the `active_test` during
the copy of the tasks.

opw-1887354

closes odoo/odoo#27192
2018-09-24 13:22:42 +00:00
Goffin Simon 66c125ae96 [FIX] stock: Picking validation
Steps to reproduce the bug:

- Create a picking
- Create a line with product "A"
- Validate Picking
- Duplicate Picking
- Add a new line for product "A"
- Validate Picking

Bug:

A missing error was raised.

PS: The function _action_done on model 'stock.move' calls the function _action_confirm
where some stock.move records could be unlinked by function _merge_moves
But the recordset was not updated afetwards.

opw:1885053

closes odoo/odoo#27209
2018-09-25 08:04:07 +00:00