Commit Graph
119468 Commits
Author SHA1 Message Date
Nicolas Martinelli 6e0afe864b [FIX] website: AccessError
The AccessError made sense when it was introduced back in v10, but
doesn't make sense anymore since there is only one setting wizard.
2018-09-14 12:40:06 +02:00
Martin Trigaux a307d4fc80 [FIX] account_asset: use the last day of fiscal year for depreciation date
The depreciation was hardcoded as starting the first of January.
If a user changed the configuration to set a different value than 31/12 it had
no impact.

In saas-11.3, this was improved to allow to configure the behaviour at 805f3a610

opw-1878927
2018-09-14 12:03:21 +02:00
Yannick Tivisse eb11665bfc [FIX] rating: Send rating if no override of rating_get_parent
Purpose
=======

Currently if the method rating_get_parent is not overriden, then
sending a rating on a record of the model leads to a traceback.
2018-09-14 11:43:15 +02:00
Martin Trigaux a47f7ee0e4 [FIX] product: do not translate at code import
Defined as this, the label of the selection field were translated during code
import, when building the python model, not when a user access the field values
as it should (and is already the case thanks to the ORM).

Trying to translate a string when no user-context is available is not only
useless but may cause bug on services with multiple databases (e.g. a SaaS).

In a multi-worker environment, when the code is imported, the _ method will use
multiple scenarios to detect the language and get a cursor.

As we have no available cursor in the frame (method _get_cr from GettextAlias),
the fallback is made on the cursor of the request.
In a multi-worker environment, this could be a cursor linked to a database in
another language than English.
In such scenario, the selections would be translated in the language of the
other database instead of displaying it in English

opw-1881956
2018-09-14 11:20:38 +02:00
Nicolas Martinelli 2e6c1aa5d1 [FIX] stock_account: return dropship
- Set a product with real-time valuation
- Create a SO, select the Drop Ship route
- Validate the SO, the PO, and receive the picking
  => an accounting entry is created
- Return the picking

The reversed accounting entry is not created.

This is because the return of a drop ship picking is not recognized as
some kind of dropshipping.

opw-1879117
2018-09-14 10:35:33 +02:00
Lucas Perais (lpe) 9511cb2bb0 [FIX] point_of_sale: param for reconcile orders and payment
It has been argued that a regression took place because of e2efec8e54
Before that commit, everything was reconciled together
After, only payments and orders with a partner set were

While that commit improved performances (there are much less move lines to reconcile),
it introduced an inconvenience business wise because of the noise created
by the unreconciled lines

This commit proposes to cut the pear in half by introducing an ir parameter
to choose between the two options

OPW 1883594
closes #26971
2018-09-14 10:10:38 +02:00
Lucas Perais (lpe) 148182bf91 [FIX] website: seo add words no freeze
On a website page, click on promote and add the keyword "DS1517"

before this commit, the javascript froze

after this commit, it doesn't freeze

OPW 1880341
closes #26771
2018-09-14 09:58:57 +02:00
len-odoo c8441a69c2 [FIX] project: remove group_by from the context
The group_by was passed from context from the action spawning a new view.
This meant that it could give a group_by a field that was not defined on the
destination view, causing a js traceback.

opw 1884035
2018-09-14 08:34:42 +02:00
Olivier Colson c568af83a2 [FIX] l10n_es: apply correct type to each account. 2018-09-13 16:28:46 +02:00
Olivier Colson 7dc13e237c [FIX] l10n_es: apply correct type to each account. 2018-09-13 15:49:58 +02:00
Toufik Benjaa 0c8a244e68 [FIX] mass_mailing: check duplicate recipients on mass mailing
- When checking if a recipient has already received a mass mailing, the
  record model for the recipient was not checked.

  Which leads to false positives.
2018-09-13 15:48:09 +02:00
Nicolas Lempereur 4ec9b55a79 [FIX] web: background layout landscape no +1 page
The report layout "background" has an image background from bottom to
top. When we transform the report in PDF, we have no idea in the
document of how many page, which orientation, width or height it will
take.

Thus to be able to have the background at the bottom of a page when
there is not enough content, we set a min-height for the body content.
This height was 1000px originally and has been decreased to 900px in
41c75ad0c3 because an empty page was possibly added (since the height of
body + header + footer was bigger than page size).

This issue is about getting a blank page when pdf is in landscape.
For example in A4 with 90ppi has a 1052px height in portrait, but 744px
height in landscape so we always get at least two pages with possibly a
blank one.

With this commit we lower it to 620px allowing 124px headers/footers.

opw-1881059
closes #26962
2018-09-13 12:44:53 +02:00
Christophe Simonis 1e0a92c996 [MERGE] forward port branch 11.0 up to 5cb9f8e9d5 2018-09-13 12:42:01 +02:00
Christophe Simonis 5cb9f8e9d5 [MERGE] forward port branch saas-15 up to a27a24c5ed 2018-09-13 12:11:17 +02:00
Nicolas Martinelli 52c89adef7 [FIX] sale_stock, stock_dropshipping: ordered qty
- Set a vendor on Product A
- Create a SO with 1 Unit of A, set the Drop Ship route
- Confirm the SO
  => a PO with 1 Unit is created
- Change the oredered quantity to 2

The PO is updated with a total quantity of 3 instead of 2.

Since the removal of procurements, the quantity is computed based on the
stock moves. However, in this case, no stock move has been created since
the PO is not yet confirmed.

In this specific case, we fall back on the PO line quantity. The logic
is similar to `_quantity_in_progress`.

opw-1879118
2018-09-13 11:52:15 +02:00
Nicolas Martinelli dee5ce3be1 [FIX] account: open balance account when partner change
`line.amount` is `undefined`, leading to an incorrect account selected.

opw-1878890
2018-09-13 11:44:21 +02:00
Nicolas Martinelli ad584540d4 [FIX] account: tax account
Use the cash basis account for cash basis taxes.

Follow-up of 1b47575372

opw-1858492
2018-09-13 11:43:12 +02:00
Christophe Simonis a27a24c5ed [MERGE] forward port branch saas-14 up to 7322b7ee56 2018-09-13 11:33:56 +02:00
Christophe Simonis 7322b7ee56 [MERGE] forward port branch 10.0 up to dd20539ffe 2018-09-13 11:32:43 +02:00
Christophe Simonis dd20539ffe [MERGE] forward port branch 9.0 up to cbdb7383e9 2018-09-13 11:07:53 +02:00
Richard Mathot cbdb7383e9 [REV] account: revert 8781286f1c
Causes a traceback "Expected singleton" when opening the Reconciliation
from the accounting dashboard
2018-09-13 11:00:15 +02:00
Christophe Simonis a651e8eed8 [MERGE] forward port branch saas-14 up to 72b2bab8c8 2018-09-13 10:58:54 +02:00
Christophe Simonis 72b2bab8c8 [MERGE] forward port branch 10.0 up to e6ca846c65 2018-09-13 10:54:06 +02:00
Goffin Simon daa6cea439 [FIX] mrp: Upating the quantity of a MO
Steps to reproduce the bug:

- Create three stockable products P1, P2, P3
- Create a BOM for P1 with P2 and P3 as components
- Create a MO with 5 P1
- Check the availability and plan it
- Go on the WO and process only 3 P1
- Go to the MO and update the quantity to 3

Bug:

From this point, it was impossible to pass the MO to the state= 'done'

With this fix, you can now, click on "Post inventory" and the button
"Mark as Done" will appear.

opw:1874227
2018-09-13 10:03:57 +02:00
Géry Debongnie cd62900878 [IMP] web: add fail fast feature to qunit test suite
With this commit, we introduce a new 'fail fast' feature to our qunit
test suite: when it is activated, the qunit test suite will immediately
stop after the first failed test.

It is accessible as a flag in the url (failfast), or by clicking the
checkbox in the UI. It is currently not activated by default.

Note that this commit also change the url for the runbot phantomjs test
in order to activate this feature.  This allows us to increase the global
timeout for the js test suite without fear!

Backport of 611c836a46
2018-09-13 08:56:08 +02:00
Joren Van Onder c8371261dc [FIX] l10n_co: commercial_partner_country_id no longer exists
Removed by b341b5ca73. This function
copied the check_vat constrains decorator before that commit. Instead
replace with country_id because the l10n_co check_vat function still
uses that field.
2018-09-12 20:14:56 -07:00
Christophe Simonis 5e4fdaf731 [FIX] mail: correct SyntaxError
Oversight of previous forward-port
2018-09-12 20:04:41 +02:00
len-odoo 83292e522a [FIX] doc: add documentation for widget formatter support in pivot view
Commit:
https://github.com/odoo/odoo/commit/8c1204954ef571e51e94ddf4070043ec2d5de3c6
put back support in v11 for formatter widgets in pivot views.
We document this feature.

opw 1876445
2018-09-12 19:46:40 +02:00
Christophe Simonis b1999a0e87 [MERGE] forward port branch 11.0 up to db0e84f3e3 2018-09-12 19:37:17 +02:00
Nicolas Lempereur db0e84f3e3 [FIX] web: revert ignore default_* on group creation
This reverts commit 4cb585ab4f.

When creating from the kanban view:
- crm.stage
- hr.recruitment.stage
- project.task.type
- helpdesk.type
- mrp.eco.stage

We go from a dashboard of eg. "GroupRecord" named "group_id" in the
record. And when a stage is created, "default_group_id" is used. With
the change the stage was not linked to the current "grouping".

We could probably use "search_default_group_id" instead but the behavior
may be present in existing customization.

opw-1884217
closes #26943
2018-09-12 17:43:39 +02:00
Jeremy Kersten e6ca846c65 [FIX] base_geolocalize, website_crm_partner_assign: API keys are now required
Google Important Updated: API keys are now required
We began enforcing the use of API keys, effective June 11th 2018.
Keyless usage will result in a degraded experience, or an error.

https://developers.google.com/maps/billing/important-updates
2018-09-12 17:07:23 +02:00
Mathieu Duckerts-Antoine 4cbc9b8d61 [FIX] account: translate default overdue_msg
opw-1880132

Closes #26852
2018-09-12 16:52:29 +02:00
Frederik Kramer 60c9742dfb [CLA] backport signature for initos
This is a backport of 5a53e5b8e9 as requested at #26638
Added Florian Kantelberg to our team of contributors
2018-09-12 16:25:04 +02:00
Christophe Simonis 87b3ca13bf [FIX] stock: correct tests to create pickings without using new() 2018-09-12 16:15:04 +02:00
Wolfgang Taferner 8e15dc87a4 [IMP] account: extract_payment_vals + explicit communication hand-over 2018-09-12 15:12:42 +02:00
Nicolas Lempereur 8e77632e58 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: this is the 11.0 version of #26912

opw-1877663
closes #26911
2018-09-12 13:18:35 +02:00
svs-odoo f339ed6ff6 [FIX] web: avoid annoying xdg-open prompt
Due to the route beginning with 'test: ', it was interpreted like a
protocol and on some OS (ubuntu for example), a xdg-open prompt pops up.
So, the window looses focus and some tests will fail because of that.
2018-09-12 13:17:54 +02:00
Nicolas Lempereur 72d7dd8994 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: for 10.0 up to not including 11.0 which is fixed by #26911

opw-1877663
closes #26912
2018-09-12 13:11:21 +02:00
Goffin Simon 561ee39356 [FIX] sale_timesheet: Validating an invoice with timesheets
Steps to reproduce the bug:

- Go to  Timesheets > Settings and set Invoicing policy to “Approved Timesheets Only”
- Create a expensable product P with Type "Service", Invoice based on
“Timesheets on tasks” and Service Tracking “Create a new project but no Task”
- Create a new SO using P and confirm it. A project PR will be created
- Add a task TA to PR
- Add two timesheets(T1, T2) to TA, one for the current date(T1) and one for a future date(+1 month, T2)
- Go to  timesheets and  validate”  the timesheet T1
- Go to the SO and now the delivered_qty is equal to 1, so create the invoice I
- Validate I

Bug:

T1 and T2 were linked to I instead of just T1 (because invoice based on
“Approved Timesheets Only”)

opw:1879051
2018-09-12 11:08:56 +02:00
Nicolas Martinelli a2acef42a0 [FIX] account: reconciliation models
The reconciliation models are not available in the Manual Reconciliation
widget. This is simply because they were not loaded.

opw-1878944
2018-09-12 10:24:24 +02:00
Gustavo Valverde 4ae13e68bf [FIX] account: Show receipt residual amount in invoice currency
When paying an invoice in USD, using EUR as payment. The residual amount was shown in the payment currency instead of the original invoice residual currency.

closes odoo/odoo#26916
2018-09-11 20:07:33 +00:00
Goffin Simon c2dfdc3081 [FIX] sale_mrp: Updating delivered qty
Steps to reproduce the bug:

- Create Product P: with BOM type - Kit and BOM components > Set - Invoicing: on delivered quantity
- Create SO with P and confirm - delivery 1 will be generated
- Cancel the SO - delivery 1 - will also get canceled
- Reset the canceled SO to quotation and confirm it - new delivery 2 will be generated
- Validate the delivery and receive product KIT

Bug:

Check SO - 'Delivered quantity' was not updated

opw:1888449

closes odoo/odoo#27358
2018-10-01 13:59:47 +00:00
Goffin Simon 1c6a7a1e58 [FIX] l10n_be_invoice_bba: Duplicating an existing in_invoice with BBA structured message
Steps to reproduce the bug:

- Create a partner P with communication type set to BBA

- Create an in_invoice I for P with a BBA structured communication

- Validate I and try to duplicate it

Bug:

A UserError was raised "Empty BBA Structured Communication!"

opw:1883982

closes odoo/odoo#27331
2018-10-01 09:21:18 +00:00
Nicolas Martinelli d3d3455e17 [FIX] web: lock handle when sorting on a different field
This makes runbot Enterprise fail. Reverts until a proper solution is
found.

This reverts commit f4f1480a3e.
2018-09-11 21:48:03 +02:00
Christophe Simonis 2b92f04289 [MERGE] forward port branch 11.0 up to cf7cb147f2 2018-09-11 19:50:13 +02:00
Christophe Simonis cf7cb147f2 [FIX] rating: remove useless header in icon title 2018-09-11 19:46:05 +02:00
Christophe Simonis 49a7295ce9 [MERGE] forward port branch saas-15 up to 48aac01c13 2018-09-11 19:06:22 +02:00
Christophe Simonis 48aac01c13 [MERGE] forward port branch saas-14 up to 55ab1ac691 2018-09-11 18:54:08 +02:00
Christophe Simonis 55ab1ac691 [MERGE] forward port branch 10.0 up to cd66b0984e 2018-09-11 17:44:14 +02:00
Christophe Simonis cd66b0984e [FIX] base: only sync partners when type change 2018-09-11 17:08:14 +02:00