Commit Graph
124195 Commits
Author SHA1 Message Date
Sébastien Theys 1fa10cbc5d [FIX] base,website_google_map: fix partner address not showing
Following commit 983c7e8152.

`_compute_display_name` is overridden in partner to force `show_adress` and some
other context variables to None. When those values are in the context, calling
`display_name` can give a different result than calling `name_get()[0][1]`.

This commit reverts the changes of the mentioned commit where the behavior is
actually different, that is, when `show_address` is in the context.

It also adds a comment on the `_compute_display_name` method to avoid further
mistakes.

closes odoo/odoo#29510
2018-12-13 11:17:23 +00:00
Romain Estievenart 287136b85e [FIX] web: empty kanban view on mobile
Due to the recent refactoring in control panel 40dd12193,
some css rules have been broken in mobile.

To fix this, we need to set 'o_current' class inside the
displayed column because we need to know which one to
display in mobile.

This issue doesn't occur in desktop because all kanban columns
are displayed.

closes odoo/odoo#29457
2018-12-13 09:03:23 +00:00
svs-odoo 4abdfc35d3 [FIX] web: wait many2many tags' fetches for rendering
Before this commit, we don't assure fetch's deferreds were resolved to
return _readGroup. Thus, in some conditions, kanban was rendered before
records data was updated so many2many tags could be missing.
Now, we return _readGroup when fetch's deferreds were resolved.

Task #1910805

closes odoo/odoo#29508
2018-12-13 10:44:32 +00:00
svs-odoo 1fef5c6b6e [FIX] web: delete duplicated search_filter_menu_tests.js
closes odoo/odoo#29500
2018-12-12 16:36:06 +00:00
Christophe Simonis 31d67119db [FIX] crm,pos_sale,sales_team: force empty domains and contexts
Theses records used to have a domain/context set [1]. Force a empty one
for updated databases.

[1] see 1da63f0ab0

closes odoo/odoo#29487
2018-12-12 18:30:22 +00:00
Geoffroy Larue e28ec7e22b [FIX] crm: restore original design
In task 1893160, we wanted to shorten the 'planned_revenue' and
'probability' fields on the crm.lead formview.

For simplicity's sake, we are reverting this change.

closes odoo/odoo#29476
2018-12-12 14:29:22 +00:00
Romain Derie 46d57e5600 [IMP] website: add key in ir.ui.view list view if multi-websites
With multi-website support, the key field is more important than ever as it
kind of replace the xml_id behavior.

Thus, on the ir.ui.view list view it is usefull to see the key.

closes odoo/odoo#29419
2018-12-12 15:45:09 +00:00
Andrius Laukavičius c7b4967adb [CLA] Corporate CLA: focusate
CLA signed by Andrius Laukavičius (Focusate).
2018-12-12 13:15:03 +00:00
Sébastien Theys 8ad348bf96 [FIX] (website_)sale: make test non-reliant on currency rate demo
Without this fix, the test does not work at the start of the year, because it is
reliant on a date that is hard-coded on the currency rate demo.

Instead of changing the demo, this commit will make the test stronger by not
depending on it.

PR: #29850
2019-01-02 12:03:26 +00:00
Swapnesh Shah 76e46b02a1 [FIX] base_setup: prevent using incompatible views
If a non-QWeb view is used, it would fail to render the template

closes odoo/odoo#27405
2018-12-31 14:06:48 +00:00
Jorge Pinna Puissant c6189f8c36 [FIX] mail: Wrong message when closing activities
opw-1916935

Before this commit, when a next activity was closed, the message said
that the action was performed by the assigned person.

Now, the message say that the action was performed by the person who
closed the activity.

closes odoo/odoo#29678
2018-12-31 08:07:53 +00:00
ivastanin 7425b8fdd4 [CLA] Stojan Ivastanin signs personal CLA
closes odoo/odoo#29821
2018-12-30 07:40:55 +00:00
Odoo Translation Bot 91382f691d [I18N] Update translation terms from Transifex 2018-12-30 01:30:16 +01:00
Yannick Tivisse 4b22f1ff5e [FIX] hr_holidays: Reset interface-based fields on leave type change
Purpose
=======

When changing the leave type on a leave request, reset the technical
fields that only have a visual purpose to avoid mismatch on the leave
duration compute method.

closes odoo/odoo#29789
2018-12-28 11:30:29 +00:00
Yannick Tivisse 765075ff47 [FIX] hr_holidays: Fix 6035112
1/ self.date_from on a for loop on self won't work
2/ When calling get_work_hours_count with self.date_from=False or self.date_to=False,
   this will lead to a traceback when looking the timezone on the date.

Closes #29697
2018-12-28 11:24:41 +00:00
Antoine Prieels (ANP) 186e70ad6c [FIX] partner_autocomplete: Remove companies from suggestions
We wanted to make it possible to manually mark records from the partner_autocomplete service as 'ignored' so that they wouldn't appear in suggestions.
Previously, this was done by removing, in the service, records that were marked as 'ignored' from returned suggestions.
The problem is that, since the record was not present in odooSuggestions, the data from this company was retrieved from clearbitSuggestions and the company was still present in the dropdown.
We fix this problem by also returning ignored companies from the service, marked as 'ignored', so that they can be filtered out after getting additional suggestions from clearbit.

closes odoo/odoo#29785
2018-12-28 08:49:17 +00:00
Swapnesh Shah 3c243afe94 [FIX] stock: Use current datetime when no Scheduled date
Same as the default get
This field should probably be set as required in master

Fixes #29778

closes odoo/odoo#29781
2018-12-28 09:52:09 +00:00
Swapnesh Shah d67658c043 [FIX] mail,web: link attachments & messages
The information of the active model and record was not given in the context
Records created from the Manage Messages and Manage Attachements in the debug
menu were not linked to the current records
Add context in test too

closes odoo/odoo#27766
2018-12-28 10:33:05 +00:00
Sébastien Theys ff873626ed [FIX] website_sale_wishlist: prevent flicker and make tour deterministic
Before this commit, there was a slight chance that the "add to wishlist" button
would flicker `disabled` off, which caused the tour to go next step too early.

The flicker was because the `_onChangeVariant` could be triggered by the
`website_sale` code before the variable `this.wishlistProductIDs` was actually
set, so it wrongly computed the state and enabled the button.

Now the RPC is done on the `willStart` instead of `start` to solve this issue.

The tour has been edited to check the button is actually disabled initially.

The view has been edited because the existing condition was too lazy: it checked
if any variant of the current template was in the wishlist, instead of checking
for the variant actually displayed. That also caused a flicker when the JS
correctly computed the state for the variant afterwards.

The widget has also been edited to trigger `input.product_id` instead of
`input.js_variant_change:checked` to avoid calling `get_combination_info` twice
from `website_sale` code.

PR: #29675
task-1920036
2018-12-26 11:12:16 +00:00
Sébastien Theys 20478ff12e [FIX] website_sale: remove click from tour when checking button
This step was meant to be "check" but did "click" instead because no empty
function was provided.

This caused a nondeterministic issues where an unwanted RPC generated a warning.
Indeed by clicking "add to cart" when checking if the button is disabled, that
called `create_product_variant` on non-dynamic product.

PR: #29675
task-1920036
2018-12-26 11:12:16 +00:00
Sébastien Theys f1c196e609 [FIX] portal: change width of portal modal to match backend
Some features are common to portal and backend, such as the sign modal in
enterprise.

This commit uniformize the width of the modal to make it more consistent between
the two by default. Of course themes can still customize this behavior.

closes odoo/odoo#29521
2018-12-24 15:03:29 +00:00
Yannick Tivisse 3b30f7ad05 [FIX] hr_holidays: Fix traceback on onchange
closes odoo/odoo#29773
2018-12-27 15:49:26 +00:00
William Henrotin 5d356b2b81 [FIX] stock: wrong location technical field
The commit a35df8d371 changes the odoo object
of "rules" from stock.location.path to stock.rule. The field on the first
object to store the destination location was location_dest_id but is location_id
in the second one.

This commit fix the variable name that refers to the destination location

opw : 1919655

closes odoo/odoo#29755
2018-12-26 15:17:28 +00:00
Antoine Prieels (ANP) c50f5da416 [FIX] snailmail: Avoid format errors when sending with Pingen
Pingen validates the format of documents before sending them. These are the elements that it checks and how when ensure that the constrains are validated:
    - The recipient's address should appear in a predefined area
	--> Move the address to this area and reduce the font-size if the address is too long
    - The destination country should be the last line of the address
	--> Sometimes, the Tax ID was in this zone, so we add a margin after the address
    - Above the Address Area, there should be a Postage Area that should be completely empty
	--> Make the background white to avoid having a background image in this area
	--> Crop the header if it takes too much space
    - There are margins of 5mm all around the document
	--> Crop the footer 5mm above the bottom of the page if it takes too much space
    - There is a square in the bottom left of the document that should be empty
	--> Add a margin on the left of the footer

closes odoo/odoo#29522
2018-12-26 10:11:05 +00:00
Antoine Prieels (ANP) 3edecd2aad [IMP] snailmail_account: Add tests to make sure that all default templates can be sent with Pingen
Add tests to make sure that, with sample data, the format of the invoices is accepted by Pingen.
2018-12-26 10:11:05 +00:00
Antoine Prieels (ANP) e338deb223 [IMP] base: Add context key to force the rendering of the pdf in 'test-enabled' mode
In `test_enable` mode, `render_qweb_pdf` fallbacked to `render_qweb_html`. We add a context key to be able to force the rendering of the pdf, even in `test-enable` mode.
2018-12-26 10:11:05 +00:00
Swapnesh Shah 595209a3e8 [FIX] purchase_requisition: Use correct field to access state
closes odoo/odoo#29715
2018-12-21 19:31:30 +00:00
Jorge Pinna Puissant 0377105304 [FIX] base_address_extended: Street in readonly
opw-1916148

The city, state and zip code are shown behind the street name and
street number, and not in a new line.
This only occurs in the read-only view.

This was changed to use the field 'street', which is a text of the
street name, number and door number in the street formatted in the
format of the partner's country. This only for the read-only view,
leaving the 3 fields separated for the edit.

closes odoo/odoo#29467
2018-12-12 12:02:52 +00:00
Jeremy Kersten 375c98ef16 [FIX] website_blog: fix select to comment
before this commit, the selected text was no more quoted in the comment.

This commit closes #29148

closes odoo/odoo#29486
2018-12-12 17:04:36 +00:00
Pedro M. Baeza e78af353fc [CLA] Include cristinamartinrod in CLA of Tecnativa
closes odoo/odoo#29454
2018-12-12 16:02:25 +00:00
Cristina Martin 6cb683ea94 [FIX] website_sale: Remove pricelist on Sitemap.XML 2018-12-12 16:00:44 +00:00
Lucas Perais (lpe) 6cd12694d8 [FIX] sale: prevent div by zero in sale.report
Backporting the behavior of v12 from e8f01b94ce

OPW 1916964

closes odoo/odoo#29472
2018-12-12 14:01:49 +00:00
Nicolas Martinelli a6d1353591 [FIX] l10n_be_intrastat, report_intrastat: date
The reference date for Intrastat should be the accounting date, not the
invoice date.

opw-1890240

closes odoo/odoo#29466
2018-12-12 12:03:54 +00:00
len-odoo 93807af6e0 [FIX] website_sale: fix overlapping text with product categories
If the price section goes on two lines because of crossed
prices or many icons, then it would overlap with the product title.

See before/after on the PR.

opw 1913521

closes odoo/odoo#29388
2018-12-11 14:21:54 +00:00
Christophe Simonis 7e5d5045bf [MERGE] forward port branch saas-15 up to 1ace2ed88b 2018-12-11 16:20:34 +01:00
Christophe Simonis 1ace2ed88b [MERGE] forward port branch saas-14 up to 5a147acf1b 2018-12-11 15:11:32 +01:00
Christophe Simonis 5a147acf1b [MERGE] forward port branch 10.0 up to f69c004795 2018-12-11 14:33:39 +01:00
Raphael Collet 3bd587ed4b [FIX] account: two m2m fields using the same table
The fields `analytic_tag_ids` and `second_analytic_tag_ids` on model
'account.reconcile.model' were accidentally using the same table and columns,
because of the automatic generation of the table name.  Make them explicitly
use distinct table names.

closes odoo/odoo#29376
2018-12-11 13:19:11 +00:00
Xavier Morel fe0a27d240 [FIX] doc: P2 bits forgotten in 758382b3a7
closes odoo/odoo#29438
2018-12-12 10:36:37 +00:00
Christophe Simonis 47dee16d65 [FIX] web: correct (another) forward-ported test 2018-12-12 14:35:12 +01:00
Christophe Simonis 151414f27b [FIX] web: correct forward-ported test 2018-12-12 12:21:33 +01:00
Christophe Simonis f351dd8cab [MERGE] forward port branch 12.0 up to 047e2b28de 2018-12-12 11:38:25 +01:00
qsm-odoo 1144235d06 [FIX] website_forum, *: remove underline on icon buttons hovering
* portal

In our default theme, when hovering links (or .btn-link elements), the
text is underlined. This effect is however not desired for links which
contain only an icon, especially in the forum.
This commit removes that underline effect for all icon buttons in the
frontend (at least by default, this is a theme choice). Icon buttons are
defined as link or .btn-link elements which directly use the "fa" class
on them.

This commit also solves the flag button of the forum which did not have
any effect because of bad bootstrap use.

closes odoo/odoo#29434
2018-12-11 14:31:42 +00:00
Géry Debongnie 13aae100e2 [FIX] web: do not render invisible filters in search view
In some cases, the web client may receive a search view with invisible
filters.  This is due to the way field_view_get works.  For
example, if there is a group on a filter, then this will be transformed
into an invisible attribute.

In that case, the search view should simply ignore the filter and not
display it.  This was broken in the recent control panel refactoring
(note that the search view lacked the possibility of testing that kind
of situation).

closes odoo/odoo#29430
2018-12-11 13:54:26 +00:00
Nicolas Martinelli 047e2b28de [FIX] mail: keep context when sending a message
When sending a message through the chatter, the user context (including
the language) is not sent to the server. This causes issues to render
the mail templates in the appropriate language.

closes odoo/odoo#29422
2018-12-11 13:32:37 +00:00
Christophe Simonis 34d35632b6 [FIX] sale: correct value in context used by test 2018-12-11 20:13:08 +01:00
Christophe Simonis 069278b652 [MERGE] forward port branch saas-11.3 up to 55dafc20f6 2018-12-11 18:51:05 +01:00
Christophe Simonis 55dafc20f6 [MERGE] forward port branch 11.0 up to 7e5d5045bf 2018-12-11 17:06:48 +01:00
Goffin Simon 43b86aa704 [FIX] website_sale_comparison: Tuple index out of range
Some product template with attributes never have variants because
the attributes have the field 'create_variant' set to 'no_variant'
So "Tuple index out of range" was raised due to these kind of products.

opw:1911962

closes odoo/odoo#29428
2018-12-11 13:35:53 +00:00
Géry Debongnie 6c1445b24e [FIX] base_import: adapt import client action
With the recent control panel refactoring, abstract actions had to be
adapted.  The base import action is actually quite
complicated, it relies on introspection and is fragile.  With this
commit, I attempt to make it work again.  The main issue is that now,
the root of the abstractaction is a div, which contains the root of the
content template, so most of the code was assuming that the $el of the
import action was the form tag, and not a parent.

Note that there are no meaningful tests for import actions, because
testing iframes are tricky.

closes odoo/odoo#29421
2018-12-11 13:06:09 +00:00