Commit Graph
124195 Commits
Author SHA1 Message Date
Jigar Vaghela 7c4fe6b3f2 [FIX] account: invoice validation with complex taxes with children
The field tax_ids on account.move.line created from an invoice was incorrect in case of a tax with children with type_tax_use!= 'none'. Hence, the tax_base_amount and the whole tax statement was wrong in that specific case.
Was part of (although not related) the PR #26262
2019-01-18 08:34:56 +00:00
Jigar Vaghela 86e90fcbea [REF] point_of_sale: refactoring of journal entries creation
* Allows to overwrite and change the account.move.line values that will be created upon a pos session closing for example to add additional data introduced by a localization module.
 * Small refactoring of _create_account_move() method: All the parameter values of _create_account_move could easily be found from pos.order recordset itself, hence removed them and adapted call to it everywhere.

Part of PR #26262 related to the indian GST
2019-01-18 08:34:32 +00:00
Martin Geubelle 212ca45660 [FIX] web, *: restore context key on search view field
Since the control panel refactoring, the `context` key on a `<field>` in the
search view was ignored (like <field name='pricelist' context="{'pricelist': self}".

The previous behaviour has been reintroduced and modified a little bit.

For way too long, an ugly hack was used to get a numerical value in self. This
ugly hack was still present but wasn't working since 8.0 (at least for the
numerical value). A counter hack (see odoo/odoo@4a81e8a) was then applied to
avoid really using a `selection` widget. To get even more confused, `self` was
replaced by the *last* user-specified value.

Well, it's time to clean this mess.

Now, the `self` key is replaced by an array of user-specified values (by value,
we mean the field value i.e. the `id` for a many2one, or the `key` for a
selection field).

Task 1902826

closes odoo/odoo#30368
2019-01-18 16:06:44 +00:00
Martin Geubelle 02d3655c7d [FIX] web: allow to build the doc
A wrong docstring was preventing the doc to build correctly.
2019-01-18 16:06:21 +00:00
Jeremy Kersten 199adbd0e1 [IMP] crm: revert renaming of subtype
Seems better to have wrong term for lead an correct for opportunity
that have not wrong for Lead an not wrong for Opportunity.

task-1932070 related to b6f4d97

closes odoo/odoo#30482
2019-01-23 13:59:00 +00:00
Jeremy Kersten b1f8d4fb6c [FIX] crm: track type on crm.lead
Until now, you cannot find easily if it is a lead or an opportunity that
 has been created.

"Opportunity created" is written in the log but it is in reality a Lead.

Now we track the change on the field type to know what was the type at the
creation AND when it has been converted to opportunity.

task:common-sense-in-real-life
2019-01-23 12:01:58 +00:00
Yannick Tivisse 3857473b57 [FIX] hr_contract: Reintroduce 'Contract Template' menuitem
closes odoo/odoo#30479
2019-01-23 14:03:23 +00:00
Jeremy Kersten 3a4b5164b1 [FIX] website: missing replace from type to redirect_type
website.redirect feature is broken since commit 2924b77

related to odoo/odoo#27599 and odoo/odoo#28112

closes odoo/odoo#30446
2019-01-22 15:02:58 +00:00
Odoo Translation Bot 0efff5f030 [I18N] Update translation terms from Transifex 2019-01-21 16:49:26 +01:00
Christophe Simonis 9d2e201692 [FIX] web: correct forward-port 2019-01-18 17:03:46 +01:00
Christophe Simonis d31306e07a [MERGE] forward port branch 12.0 up to 6e5ac01160
Also contains fixes for previous forward-port.
2019-01-18 16:18:17 +01:00
Christophe Simonis 7276e8203e [FIX] purchase: correct previous forward-port.
Domain was apply on the wrong model.
2019-01-18 14:37:51 +01:00
Christophe Simonis a337b9ec92 [MERGE] forward port branch 12.0 up to f854e01a98 2019-01-18 14:26:33 +01:00
Nicolas Seinlet f8e37d6a80 [IMP] improve overridden sql constraints support
If module A define an sql constraints and module B, which depends on 
module A, override the sql constraint, we must ensure having only the 
last definition in constraints list. Having the two versions in the list
makes the ORM continuously trying to drop the second version by the 
first one, then recreate the second version, when performing operations 
like an upgrade a module B.

An illustration of this is the login_key on res.users, which is unique
per login in base, but unique per (login, website) in website.

closes odoo/odoo#30334
2019-01-18 09:20:02 +00:00
pha-odoo 649ea4927e [FIX] hr: move print_employee_badge to the hr module
closes odoo/odoo#30302
2019-01-17 09:59:57 +00:00
RomainLibert 2f526dcd65 [FIX] hr_payroll: do not display conflicting leave button when no type
Basically you can have two types of error when using benefits, the
conflicting leave error and the no benefit type set error.
You can have either one of them or both of them at the same time.

The problem is that when there is an error, we currently have no way of
knowing which error it is.

To resolve this we only display one error at a time starting with the
no benefit type error and then if there is a conflicting leave we
display the next error

closes odoo/odoo#30259
2019-01-16 12:47:47 +00:00
RomainLibert dad7d80a93 [FIX] mail: fix typo in _onActivityUpdated
closes odoo/odoo#30260
2019-01-16 12:40:56 +00:00
Martin Trigaux bfe1e20d6b [I18N] export saas-12.1 source terms
To reflect fixes at ec2263080a and cd4080839f

closes odoo/odoo#30253
2019-01-16 10:35:49 +00:00
Romeo Fragomeli c72e5a8bc5 Revert "[FIX] web: empty kanban view on mobile"
Original commit breaking kanban view: 4cd379cf6e
Commit reverted: 287136b85e

Two fixes were added independently to fix this bug but only one is needed.

odoo/enterprise@c8fe86fa22 best fix
287136b85e other fix (now reverted)

Reverting this commit fix the following bugs:
- Swipe on kanban : Not able to swipe on empty column. it only works on cards
- Popup activity on kanban card is unusable
- On kanban separation, "Undefined" cards are before the kanban separation

closes odoo/odoo#30177
2019-01-16 11:00:38 +00:00
Christophe Simonis 38068f8151 [FIX] account: cherry-pick of 83f5dc8e35
do not set unknow field when creating invoice

The field `reference_type` has been removed with b5bb5bd421

Adapt newly forward-ported test to not use this field.

closes odoo/odoo#30255
2019-01-16 08:47:58 +00:00
Christophe Simonis b28788a8be [FIX] web_editor: remove wrongly inserted line during previous forward-port 2019-01-14 11:17:31 +01:00
Christophe Simonis ea51fe5130 [FIX] base: adapt forward-ported test to new version 2019-01-14 11:11:22 +01:00
Christophe Simonis 3cbc9dd6c0 [MERGE] forward port branch 12.0 up to 6a0675d36d 2019-01-14 10:34:50 +01:00
Pierre Masereel 976429c8c6 [FIX] base: fix demo data
Since changes made in this commit: https://github.com/odoo/odoo/commit/f598c3e597fa0b7f0e875dadf163ccea44a04e06
The address didn't work anymore for any of delivery tests

closes odoo/odoo#30156
2019-01-11 16:02:08 +00:00
Lucas Lefèvre 85cb3ffbf1 [FIX] hr_fleet: Fix access right on employee form
Purpose
======

Since commit 22ee6eb a user can't access an employee form if he is neither Fleet User nor Manager.
=> Access error: Document model: fleet.vehicle.assignation.log
The reason is the computation of the number of vehicule logs.
A regular user doesn't have access rights on this model.

This commit fixes this.

closes odoo/odoo#29835
2019-01-11 08:16:49 +00:00
Lucas Lefèvre f6b1e3144b [FIX] resource, hr_payroll: fix hours_per_day onchange
In resource, calendar.attendances with a resource_id specified
were taken into account to compute the average hours per day.
This is incorrect and could lead to hours_per_day being > 24h.

Also when hr_payroll is installed, attendance_ids is replaced
by normal attendance (those without a resource_id set) in the view.
The onchange method was not called to recompute the average hours per day.

This commit fixes both issues.

closes odoo/odoo#29951
2019-01-09 15:08:53 +00:00
Martin Geubelle d682137884 [FIX] web: correctly export all records in list
Before this rev. a traceback occured when trying to export all records in a list
view.

An old reference to `searchView` was still present in the list controller, which
is not used anymore since the control panel refactoring (see odoo/odoo#29106).

Task 1917628

closes odoo/odoo#30073
2019-01-09 13:34:27 +00:00
RomainLibert c76066402c [FIX] hr_holidays: add default filter on dashboard action
If you are holidays manager, you don't really want to see the leaves of
everybody, but are more interested in the leaves of the people you
manage and yours.

closes odoo/odoo#30066
2019-01-09 10:54:33 +00:00
Christophe Simonis 8aa8548d8a [MERGE] forward port branch 12.0 up to 3e4138deaa
closes odoo/odoo#30045
2019-01-09 15:56:53 +00:00
Yannick Tivisse 55a48e3415 [FIX] hr_fleet: Make 'Claim Report' work for employee without users
If an employee is not linked to an user, the claim report feature won't work.

With this commit, the report can be printed base on the user's partner or
the private employee address.

closes odoo/odoo#30065
2019-01-09 10:48:39 +00:00
Robot Odoo 671c45fbbf [REV] lunch: Revert changes introduced in f727b8f0b5
YOLO

closes odoo/odoo#30025
2019-01-08 14:02:06 +01:00
Yannick Tivisse 6ab800135f [REM] .tx/config: Remove 'lunch_hr' source terms 2019-01-08 13:15:46 +01:00
Yannick Tivisse d1c3948a05 Revert "[IMP] lunch: automatize lunch orders"
This reverts commit f727b8f0b5.
2019-01-08 13:12:33 +01:00
Yannick Tivisse 7eefa37583 Revert "[FIX] lunch_hr: remove deprecated pycompat helper"
This reverts commit 3671d41ab7.
2019-01-08 13:12:24 +01:00
Yannick Tivisse cb5541cacd Revert "[FIX] lunch: fix lunch_supplier test"
This reverts commit 37212fe655.
2019-01-08 13:11:03 +01:00
Yannick Tivisse 3729ebf34d Revert "[IMP] lunch: reintroduce lunch_alerts, change display of wizard"
This reverts commit 6f5dc5733f.
2019-01-08 13:10:55 +01:00
Thibault Delavallée 8ed2a7e68a [FIX] survey: allow debug parameter in testing route
Adding kwargs in test route of surveys allow notably to avoid crashing when
working in debug mode and testing surveys.

closes odoo/odoo#29996
2019-01-07 14:27:20 +00:00
Yannick Tivisse 77396a23ad [IMP] l10n_be_hr_payroll: Update withholding taxes computation up to 2019
Documentation: https://finances.belgium.be/fr/entreprises/personnel_et_remuneration/precompte_professionnel/calcul

closes odoo/odoo#29938
2019-01-04 12:54:18 +00:00
Arnold Moyaux e44040cd77 [FIX] mrp: generate lot remove qty reserved/to consumer
commit e1e0826eee introduced a button in
order to quickly add a lot number on the current production. However on
the produce wizard it will create the lot, save the wizard with the new
lot and reopen its view in edit mode. However the qty to consume and
reserved on the produce lines are readonly thus not saved and lost
during the process.

This commit add force-save on the qty to consume and reserved

closes odoo/odoo#29925
2019-01-04 09:42:28 +00:00
Martin Trigaux af69902ecc [I18N] export saas-12.1 source terms
closes odoo/odoo#29730
2018-12-24 11:07:31 +00:00
Alexandre Kühn fa756bc63d [FIX] mail: adapt discuss mobile from cp refactoring
Since a recent ControlPanel/Search view refactoring [1],
all client actions must be adapted [2]. Discuss was updated,
but not discuss mobile, which this commit fixes.

[1] https://github.com/odoo/odoo/commit/4cd379cf6ecffa00e0085a9833228128b484d48a
[2] https://github.com/odoo/odoo/commit/b1ef0001f61d29fc3d3be384422c0fb35a09806f

Task-ID 1918722

closes odoo/odoo#29601
2018-12-18 10:27:34 +00:00
Thanh Dodeur 73d9b9588f [IMP] mail: adds delete and upload to chatter
This commit adds the ability to upload and delete
attachments from the chatter.

Task: #1911277

closes odoo/odoo#29702
2018-12-21 15:25:27 +00:00
Aaron Bohy 5545787e2c [FIX] web: fetch toolbar info for target=current actions
The 'Actions' menu displayed in the control panel (aka sidebar, or
toolbar), wasn't displayed anymore since the control panel
refactoring of 4cd379cf6e. Rev. c1752b834 correctly made it appear
again in list and form views. However, there was another issue as
the additional model-related items (like Print, or custom actions)
weren't fetched anymore. Thus, the sidebar only contained the
default 'Export' and 'Delete' actions. This rev. fixes the second
issue.

fixes #29546

closes odoo/odoo#29633
2018-12-19 07:40:31 +00:00
Alexandre Kühn 906183ac0b [FIX] mail: bigger emojis in composer emoji menu
Before this commit, emojis from the emoji menu in the
composer were small. This is especially true in mobile.

The cause of this issue was the style of bootstrap button
links. This commit fixes the issue by no longer considering
each emojis as button for their style, so that they do not
inherit bootstrap styles.

Task-ID 1918767

closes odoo/odoo#29606
2018-12-18 12:14:15 +00:00
Martin Geubelle 243734e64b [FIX] web: backspace in empty searchbar input
Before this rev. a crash occurred when pressing backspace in the control panel
view searchbar input if there was no facet to remove.

The use case is now correctly handled and nothing happens.

Task 1902826

closes odoo/odoo#29602
2018-12-18 12:55:19 +00:00
Martin Geubelle ca89594215 [FIX] sale: correctly test all files
The rev. odoo/odoo@3aa6c94 has recently been forward-ported but was in conflict
with the rev odoo/odoo@856c2e9 ; both have created a inherited view to add their
test file in the qunit_suite view.

As both inherited views have the same id, one of the two files was not correctly
loaded in the test suite.

closes odoo/odoo#29586
2018-12-17 15:30:33 +00:00
Martin Geubelle ae2dbc60c5 [FIX] web: handle context in ControlPanel <filter>
The `context` key wasn't correctly taken into account when computing the search
query for `filter``tags.

It is now correctly handled.

Task 1917628

closes odoo/odoo#29529
2018-12-17 10:39:03 +00:00
qsm-odoo 0794a3c956 [FIX] website_forum: allow themes to customize navbar area
Before the forum redesign, the .container element which contains the
forum navbar had the 'website_forum' class. Now this class was moved
to encapsulate the whole forum page.

Problem is that themes were styling that container element specifically
and the `#wrap` element of the forum by respectively targeting
`.website_forum` and `.website_forum + #wrap`. This commit solves this
by adding a 'o_wforum_navbar_container' class on the element allowing
to modify the themes selector with `.o_wforum_navbar_container` and
`.website_forum #wrap`.

closes odoo/odoo#29581
2018-12-17 14:21:50 +00:00
Alexandre Kühn 1645b2f8e3 [FIX] mail, test_mail: fix mail_tour
This commit fixes the following issues regarding the mail tour:

1. Start from discuss app (not app switcher)
2. Adapt from recent changes on discuss app https://github.com/odoo/odoo/commit/9f6f9c71d3258ce3652b4a5793b7dcfef6f01d25

Note there is an error if we let runbot run this tour automatically:

```
Tour mail_tour failed at step Messages can be <b>starred</b> to remind you to check back later.
(trigger: .o_mail_discuss .o_mail_thread .o_thread_message_star)
```

This comes from the mail tour requiring longpolling to work, which is
intentionally disabled when running tours automatically on runbot.
We plan making this tour run without longpolling in the future, which
requires a design change from the client code (e.g. reduce reliance
on the longpolling).

Task-ID 1916093

closes odoo/odoo#29575
2018-12-17 12:48:10 +00:00
David Beguin f0741b3f3e [FIX] im_livechat : fix random operator and channel name mismatch
Before, the name of the channel was not always matching the real channel operator,
as a second random was made on operators.

This commit fix this.

Task ID : 1918350
Closes PR #29570
2018-12-17 09:54:08 +00:00