Steps:
- Open Field service
- Select planning then by user
- Group by project
- The trace back is coming
Issue:
- when we trying to group by projects the trace back is raised.
Cause:
- In '_search_on_comodel' method filtered_domain does't set perfectly,
The filtered_domain it is not set for the additional_domain , when we
given on additional_domain, on that time filter_domain does not consider
the additional_domain, because of that traceback will be coming.
Fix:
- By adding an 'if' condition for cases when you provide an additional
domain, it will work fine.
task-3522178
closesodoo/odoo#140661
Related: odoo/enterprise#48652
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Before this commit
===================
In MO if a line is deleted or line has its to consume quantity reduced so in
done state transfers return is creating.
After this commit
===================
Stopped creating the return on done state transfer when quantity is reduced or
a line is deleted.
closesodoo/odoo#133696
Task: 3283010
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Error 500 when accessing the shop page when not logged in. The error was
introduced by odoo@4069158c9 where we take the id of the id.
closesodoo/odoo#140675
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Steps to reproduce:
1. Open the "Amounts to Settle" view of either the Customers of Vendors menu
2. Click on the Studio button on the top right of the window
3. A traceback appears.
Issue/Feature this commits addresses:
When on the "Amounts to Settle" view, when clicking on the Studio button,
a traceback appears and the studio menu is not opened. This should not happen.
Desired behavior after this commit is merged:
This fix makes the event that would cause the error not possible anymore.
The studio menu should always open and not cause that traceback anymore.
closesodoo/odoo#140671
Signed-off-by: William André (wan) <wan@odoo.com>
Since [this PR], some headers have some preselected options. For
instance, by default the header_sales_one displays social icons without
colors and a CTA button with rounded sides. However, if one modifies the
option in the panel, it appears to be working, but upon save it goes
back to no_icon_color / rounded sides.
This happens because the option is forced by the header template. That
behavior takes the precedence over the user's option choice.
As there is no proper way to make it work without modifying the model,
this commit removes the forced option on the templates for Odoo 17.
It should be properly reintroduced in master.
[this PR]: https://github.com/odoo/odoo/pull/119650
task-3576074
closesodoo/odoo#140669
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, tours could be resumed AND started in the same
sequence, causing object mismatches in the tour service internals and
resulting in multiple tooltips being displayed at the same time.
This commit ensures that a tour instance can only be run once at a time.
closesodoo/odoo#140664
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Temporary fix to revert once it will be done correctly on
client side. The idea is to remove the variable after a record
editation in order to trigger the recompute of column width
closesodoo/odoo#140663
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Currently after confirmation on picking. The details operations button
is mixed in the trash icon. The view needs a refresh to be correct.
This is cleaned by moving all the buttons together and introducing the
custom column before the last buttons group.
Part-of: odoo/odoo#140663
This follows [commit 1], which introduced a way to separately reorder
columns on mobile and desktop.
This commit replaces the custom mobile order classes with the Bootstrap
`.order-x` classes.
It also ensures those orders are not used for mass mailing in case the
editor composes their email on a small window. The reorder would indeed
not have any effect for the end users in such a case.
[commit 1]: https://github.com/odoo/odoo/commit/710d000f1872fd99b41d52ec3d6923756bba7cba
task-3576046
closesodoo/odoo#140362
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
From the backend manufacturing order view, it was no longer possible
to specify batches/serial numbers for by-products.
Now it is.
closesodoo/odoo#140446
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Step to reproduce:
- Order a combo product in pos_restaurant
- Order the same combo product for the same table
- The second order will not be processed
Previously the getOrderChanges method was computing the orderline changes based on
a key composed of the product id, the full product name and the note. This was
done considering the fact that the merge orderline was working. Combo products
are not handled by the merge orderline. Because of this, if 2 orderlines of
combo product were the same, only the last orderline would be taken
into account. To prevent this, this commit changes the key to the uuid wich
is a unique identifier to an orderline.
closesodoo/odoo#140416
Related: odoo/enterprise#49893
Signed-off-by: David Monnom (moda) <moda@odoo.com>
This commit fixes some layout issues in the portal sale interface.
Before this commit, the sidebar layout was broken if the button `reorder`
is activated.
This is due to the layout of the xpath and the general layout of the
template.
This commit fixes this issue and also improves the layout of the sidebar.
We also fix an issue in the different sections displayed inside the page,
with a missing spacing between two of them.
task-3572209
closesodoo/odoo#139882
Signed-off-by: Chrysanthe Gomrée (chgo) <chgo@odoo.com>
Current behavior: if the user has no access to crm.lead, it shows the
error
You are not allowed to access 'Lead/Opportunity' (crm.lead) records.
This operation is allowed for the following groups:
- Extra Rights/Contact Creation
- Sales/Administrator
- Sales/User: Own Documents Only
- User types/Portal
Contact your administrator to request access if necessary.'
With this fix, First check the access to the model to count the records
or assign zero.
Related ticket #3546713closesodoo/odoo#140827
X-original-commit: d0f373ba5bd0f0aaa1f464158d02f1a25d781751
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
It's no longer necessary to interact with the orderlines in the order history
because it's showing already paid orders.
closesodoo/odoo#140754
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Since [1] when the layout of the theme options was reorganized, the
button's font-family option was not displayed anymore.
This commit restores the button's font-family inside the "Button"
section, before the button "Padding" options.
[1]: https://github.com/odoo/odoo/commit/388e4bb2bfcaebdd4ff30277fb49a034592d7086
task-3478355
closesodoo/odoo#140692
X-original-commit: 718ae15606fe452da26fe9c4fa9c90cc443fd8f1
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Steps to reproduce: (ETA API credentials required)
- Install l10n_eg_edi_eta
- Switch to an Egyptian company
- Configure ETA API Integration
- Create a tax with "Fixed" as "Tax Computation"
- Create an invoice with the created fixed tax
- Send the invoice to ETA
The invoice is rejected by ETA.
Cause:
The generated EDI document contains an entry looking like this:
"taxableItems": [{"taxType": "T1", "amount": 28.0, "subType": "V009", "rate": 14.0}]
where each element of "taxableItems" is a dict with the details of each applied tax.
However, for fixed taxes, the "rate" key should not be there.
Solution:
Only populate the "rate" key if the tax is not a fixed one.
opw-3436422
closesodoo/odoo#140850
X-original-commit: 07f6321f7fd64a394e348e37353f8300103a4a42
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Prior to this commit, there was no space between tags and the label.
This commit adapts the label margin to maintain layout consistency.
task-3575796
closesodoo/odoo#140764
X-original-commit: cf1383c15cbe7dd846b0bb8bc38f7afd93db61b5
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Add export to 'getDifferentParents' and 'triggerPointerEvent'.
It is useful for creating a custom drag and drop for example.
closesodoo/odoo#140542
Related: odoo/enterprise#49926
Signed-off-by: Ruben Gomes (rugo) <rugo@odoo.com>
Reproduce
Create some expense, approve some of them
Expected:
On journal dashboard, The Expense Journal need to display Number of
Expense to process
Actual:
number_expenses_to_pay does not display on The Expense Journal because
we haven't override the needed method yet
Also this PR aim to improve the open_expenses_action to display
correctly the number of expense on the journal dashboard
closesodoo/odoo#139971
X-original-commit: dd3e59a8c86dab6be6d01f776e6890fb9ad97605
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Before this commit:
When we try to click on element contenteditable=false then it is switch to
nearest editable area.
After this commit:
When we try to click on element contenteditable=false then it will not switch to
nearest editable area.
Task-2977246
closesodoo/odoo#139961
X-original-commit: 3b8e4bc123dd87857d6634b55ddaaa716a0729ce
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Antoine Guenet (age) <age@odoo.com>
Before this commit, there was an issue with the dropdowns in the editor
panel. When the selector was at the bottom of the panel, the dropdown
opened outside the viewport, requiring the user to scroll the editor
panel to see it.
After this commit, the dropdowns in the editor panel open above the
selector if there is not enough space below for it to be visible without
scrolling.
task-3500768
closesodoo/odoo#135788
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Steps to reproduce the bug:
- Open the Menu Editor.
- Add a menu item.
- Type a URL (which will trigger the autocomplete).
- Bug: You can't select the last URLs in the autocomplete dropdown
because it goes off screen and can't be scrolled.
This bug was introduced by the commit [1]. Since this commit, all modal
dialogs are vertically centered, which is why the bug fixed in this
commit occurred.
[1]: https://github.com/odoo/odoo/commit/dd141a22f44ea88af18448c4a6089252daeba8cc
task-3580373
closesodoo/odoo#140846
X-original-commit: 23272e38d822c734d1ea2fdb404ba2b1d6890cb3
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Task Adhoc: 32844
Task Latam: 1053
Description of the issue/feature this PR addresses:
1. If the date is changed in the payment wizard don't update the check amount.
2. Payment currency should be the same as the check currency.
3. Warning in the payment register for example if the currency of the check is different than the currency of the payment.
4. Check on companies without country. Company without country should not use checks.
5. Not possible pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created).
6. If the payment amount is changed and it does not match the check amount then a warning pops up.
Current behavior before PR:
1. If the date is changed in the payment wizard is updated the check amount.
2. Payment currency can be different than the check currency.
3. No warning in the payment register for example if the currency of the check is different than the currency of the payment.
4. Check on companies without country. Company without country can use checks.
5. Possible to pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created).
6. If the payment amount is changed and it does not match the check amount then a warning not pops up.
Desired behavior after PR is merged:
1. If the date is changed in the payment wizard the check amount is not updated.
2. Payment currency should be the same as the check currency.
3. Warning in the payment register for example if the currency of the check is different than the currency of the payment.
4. Check on companies without country. Company with country can`t use checks.
5. Not possible to pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created).
6. If the payment amount is changed and it does not match the check amount then a warning pops up.
closesodoo/odoo#140832
X-original-commit: 0c62f78759ee1a6447c7cacf857a9f45a702c3fb
Signed-off-by: William André (wan) <wan@odoo.com>
Whenever calling `_adapt` in `autoHideMenu`, whenever the odooEditor
is active, some mutations could trigger the unbreakable rollback of
the odoo editor. We should not check for unbreakable in `_adapt` as
the unbreakable mechanism is not meant to be used in that context.
task-3439226
closesodoo/odoo#139209
Related: odoo/enterprise#49220
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Previously, we attempted to debounce in what appeared to be an override
of the onWillStart method, but this method doesn't actually exist on the
parent classes and as such is never registered with the onWillStart
hook. This commit fixes that by registering it in an override of the
setup method instead.
task-3439226
Part-of: odoo/odoo#139209
*: mrp_subcontracting, project, test_website, web, web_editor,
website_slides
This commit removes jQueryUI autocomplete that was the last usage of
jQueryUI.
No longer usage of these features inside the codebase
task-3439226
Part-of: odoo/odoo#139209
Adapt the website industry selection autocomplete inside the
configurator to use the autocomplete owl component instead of jquery
autocomplete
task-3439226
Part-of: odoo/odoo#139209
*: web, website, website_form_project
Remove the jQuery UI Widget `urlautocomplete` by using made some
refactor to allow usage of the owl component.
task-3439226
Part-of: odoo/odoo#139209
When creating a sub company with l10n_ar, we
get a ValidationError due to the check on
existing accounting entries on root company.
Steps:
- Create a new company with l10n_ar, and
create some moves
- Create a branch for the company and save
-> ValidationError: "Could not change the AFIP
Responsibility of this company because there
are already accounting entries."
In `account.res_company._existing_accounting`,
we check if there are existing move lines in
both parent and child companies, while we would
like to check only new company when it is calling
from `l10n_ar.res_company._check_accounting_info`.
With this commit, we change just change the domain
and use `self.id` instead of `self.root_id.id` and
we call `_existing_accounting` with `root_id` where
needed.
opw-3572926
closesodoo/odoo#140795
X-original-commit: 575971458d454d546d967ec4141d8c47fc28e666
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>
Before this commit:
The logic used to count the number of RTC Sessions was incorrect. Which led to
multiple sounds being played sometimes. Etc, on start a meeting
After this commit:
Corrected the RTC Sessions counting logic.
closesodoo/odoo#140628
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
1. `searchPartnerSuggestions` uses`authorizedGroupFullName` to see
if the channel is public or not
2. `filteredThreads` and `getThreads` uses `hasSelfAsMember`
and `is_pinned` along with the channel type
3. search should use `displayName` otherwise the search on group
with default empty name will fail
4. fix tests.
closesodoo/odoo#140495
X-original-commit: b358c410988686610638e7ffbee1fbbbeff5f0ba
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Problem
---------
When creating and editing a bank account, a creation model pops-up to
edit the bank account information. The previously entered bank account
must be entered again which isn't user-friendly.
Objective
---------
The data entered on the bank account bank account should pre-fill
acc_number on partner bank pop-up.
Solution
---------
When create & edit, `name` could be used to pass (in the context) the
value input by the user. However, we want to set the default value of
`acc_number` variable instead. By overriding the default_get method,
we can get modify the context to do just that.
task-3557753
closesodoo/odoo#140725
X-original-commit: aa28b0fbba97b1528ad6a6ad27813c44125e8d48
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Signed-off-by: Antoine Boonen (aboo) <aboo@odoo.com>
This commit sets `s_text_cover` default color preset to `o_cc4` to make
it look more like the header of "Anelusia theme" that was the initial
reference for the design of this snippet.
It also fixes a typo in `o_ccx` class introduced in commit [1] at the
same time actually.
[1]: https://github.com/odoo/odoo/commit/5ac340b1b27c9527463e2eed65fe2e7768b36702
task-3568868
closesodoo/odoo#140721
X-original-commit: 66f63ab23159fae86ba81369287e1cf8aac66d87
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit fixes the issues related to the category selector. The issues are
very obvious when switching browser (e.g. Firefox or Safari). The width of the
container containing the category image thinks that its width should be the
original width of the contained image. This is a quick fix which sets a
max-width of 100px on the container (which is approximately 75% of the image
width matching the 75% height set on the image).
Additionally, we hide the image when the category panel becomes to thin.
Check the PR for screenshots of before and after the fix.
Original PR: https://github.com/odoo/odoo/pull/140720closesodoo/odoo#140720
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Since #104741, `Field.states` is no longer supported, remove the
documentation associated. We cannot remove the attribute
from Field because it is used in the migration script.
closesodoo/odoo#140694
Signed-off-by: Raphael Collet <rco@odoo.com>
Before this commit, the install prompt was half shifted out of screen.
After this commit, the install prompt is not shifted anymore.
closesodoo/odoo#140659
Signed-off-by: Luca Vitali (luvi) <luvi@odoo.com>
In this commit, we solve the issue that the tracking_number was not
showed on the ticket_screen when the order was in an other state than
paid. This is solved by computing the tracking number in the frontend
as we have all the informations needed for that.
closesodoo/odoo#140650
Related: odoo/enterprise#49997
Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
pos*: point_of_sale, pos_discount, pos_restaurant, pos_sale
In this commit, we add the special product list to pos_config. This
is done so that we can see if the db has any product other than the
special ones to display the message to the user to create product or
not in the PoS.
Part-of: odoo/odoo#140650
When validating a draft transfer. Currently it says that we don't
have quantity. So when validating a draft, set the quantity to
initial demand and validate
Also, if a move is created through RPC with a quantity, auto-confirm the
move, regardless of its initial demand.
closesodoo/odoo#140578
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
suresh badikala