Commit Graph
129746 Commits
Author SHA1 Message Date
Thibault Delavallée bb197b1f87 [MOV] portal: split portal chatter from composer
PURPOSE

Allow to manage attachments when updating a frontend review.

SPECIFICATIONS

As those widgets grow it is better to have them in separate files in order to
better understand code organization. Future commits will improve composer
behavior, notably in attachments management.

LINKS

Task 2066600 (manage attachments)
Task 2058595 (eLearning v13 testing)
2019-09-04 11:41:47 +00:00
Louis Baudoux a64476635e [FIX] account: fix main_attachment_id not set on attachment upload
When creating invoices via the 'Upload' button, the
'message_main_attachment_id' field wasn't set on the record. This
happened because the message posted in the chatter was linked to the
wrong 'res_model' which prevented it from being selected as the main
attachment.

This was causing a bug in the OCR module ('account.invoice.extract')
where we use this field to determine which attachment must be sent to
the OCR server.

closes odoo/odoo#36309

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
2019-09-05 11:22:36 +00:00
Olivier Colson 93fa283020 [FIX] account: don't set default taxes on exchange rate difference accounts
closes odoo/odoo#36332

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-05 10:01:57 +00:00
Andrea Ulliana 5eedaad33d [IMP] event: show total of reserved seats in list view
task-2066537

closes odoo/odoo#36417

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-09-05 08:59:58 +00:00
oco-odoo eeea511725 [FIX] account: only display "post" button of account.move when in draft state
closes odoo/odoo#36457

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-05 09:55:04 +00:00
Simon Lejeune c58341426f [FIX] hr_maintenance: falsy value in compute
closes odoo/odoo#36456

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-05 09:52:46 +00:00
wan 5112d04637 [FIX] account: prevent multiple event concurency
* When clicking on the partner m2o selection field before having clicked on the bank statement line, 2 events occured:
* the bank statement line expanded
* the partner selection showed

This could lead to unwanted behavior as the renderer could update
-> Stop the propagation of a click on .o_field_widget to prevent
flickering and possible update of the statement line widget

* Always recompute the create line as sometimes the value is not correct
when removing a proposition

closes odoo/odoo#36322

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-09-05 10:24:55 +00:00
svs-odoo ee14dc0302 [FIX] purchase: units purchased product button
Before this commit, user got a traceback when he clicks on Units
Purchased button from product view form.
The issue was we asked to the purchase report to be based on a field who
doesn't exist anymore.
The fix only replaces `unit_quantity` for `qty_ordered`.

closes odoo/odoo#36342

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-02 14:13:11 +00:00
qdp-odoo b70803dc04 [IMP] account: usability of journal items tree view
shortened the full_reconcile_id column by re-labelling it 'Matching #'. Asked in 2049120

closes odoo/odoo#36445

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-05 07:48:44 +00:00
Aaron Bohy 5dd1457ccd [FIX] web: kanban: global click and 'image' widget
Let's assume a kanban view with oe_kanban_global_click className
(i.e. clicks on the card open the record in a form view), and an
image with the 'image' widget. This is for instance the case of the
hr.employee kanban view.

Before this rev., clicking on the image didn't open the record in
form view.

closes odoo/odoo#36321

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-09-04 14:41:06 +00:00
William Henrotin d1efc107dd [FIX] stock: missing move's scheduled date in picking view
closes odoo/odoo#36312

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-05 06:39:56 +00:00
Luis Torres f266eff7c4 [FIX] l10n_mx: Revert change that remove tax data
The tags in the tax are created for the Mexican taxes (IVA, ISR & IEPS)

This was assigned in the taxes on 3efefd2171,
but in the commit 333c22edd9
was removed from the tax 0%.

Now was returned that data, to be consistent with the tax for 16%

closes odoo/odoo#36206

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-09-03 15:08:33 +00:00
Luis Torres b050712afd [IMP] l10n_mx: completed tags for second level in CoA
When is used the option to get the CoA reports based on groups, is
necessary set the tag in each group, then, is necessary load the tags
for second level in the SAT catalog for accounts.
2019-09-03 15:08:33 +00:00
Humberto Arocha 4f524dbad6 [IMP] account: Adding Accounting Tags for Indirect Method Cash Flow 2019-09-03 15:08:33 +00:00
Yannick Tivisse e6d1d36283 [FIX] hr_holidays: Harmonize action button display between form/kanban
closes odoo/odoo#36367

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-05 07:43:16 +00:00
Yannick Tivisse 370ad6e326 [FIX] hr_holidays: Fix typo + untranslated error messages 2019-09-05 07:43:16 +00:00
Yannick Tivisse 106ee9688c [FIX] hr_holidays: Fix untranslated error messages 2019-09-05 07:43:16 +00:00
Yannick Tivisse 1eb9177bb4 [FIX] hr_holidays: Allow time off users to approve leaves 2019-09-05 07:43:16 +00:00
Yannick Tivisse d1d4364320 [FIX] hr_holidays: Only allow time off users to be time off type responsible
This could responsibility is designed for that kind of users.

Without that it could lead to inconsistencies during the time off
validation flow. (ir.rule errors, ...)
2019-09-05 07:34:33 +00:00
Kevin Baptiste 2df9d021e1 [FIX] base: Fix zoom on image fields
The goal of this commit is to adapt the zoom on image to the new names
of the fields made by PR #4865.

TaskID: 2049581
2019-09-05 07:34:33 +00:00
Aaron Bohy f60db9b93a [FIX] web: kanban: global click and 'image' widget
Let's assume a kanban view with oe_kanban_global_click className
(i.e. clicks on the card open the record in a form view), and an
image with the 'image' widget. This is for instance the case of the
hr.employee kanban view.

Before this rev., clicking on the image didn't open the record in
form view.
2019-09-05 07:34:33 +00:00
Christophe Monniez 95fefe6cc5 [FIX] web: avoid some external links in click_all test
Since 78565b1dc9 , two menus with an act_url action drive the user to
external websites. This makes the click_all test very fragile.

With this commit the Apps menus "Theme Store" and "Third-Party Apps" are
black-listed in the click_all test.

Also, it happens that a filter which is not supposed to work in some
circumstances is simply hidden. Actually, the click_all test sets that
filter and leads to  a crash.

With this commit, for a more realistic use case, the click_all test does
not activate hidden filters.

closes odoo/odoo#36433

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-09-04 13:33:15 +00:00
Gorash 35829f2031 [FIX] website: the rte tour was undeterministic
The tour try to click on the language dropdown before the reloading of the
page if the server is slow.
To fix it, we avoid the reloading by the rte, and trigger the reload
in '_reload' method of editor menu who add the class 'o_wait_reload'.
We add a selector and trigger in the test to avoid undeterministic error.

closes odoo/odoo#36098

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2019-09-04 14:45:31 +00:00
Alexandre Kühn 66a0836974 [FIX] mail: odoobot onboarding canned_response_ids
Before this commit, when user follows odoobot chat onboarding and
sends a canned response at the canned response step, odoobot did
not validate the message with the canned response.

This is caused by RPC `message_post` that filters out values that
are not message fields, such as `canned_response_ids`.

This commit fixes the issue by adding a non-stored field
`canned_response_ids` to `mail.message`. This requires the reverse
relation too, `message_ids` in `mail.shortcodes` (= the model for
canned responses).

Task-Id 2058455

closes odoo/odoo#36411

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-09-04 13:03:20 +00:00
Alexandre Kühn e7aff236b8 [FIX] mail: no message attachment delete in discuss and chat window
Delete attachment from message makes only sense from chatter.

Task-Id 2058455
2019-09-04 10:29:07 +00:00
Odoo's Mergebot 3ec676be00 [IMP] hw_*: Remove "Shell=True" in subrpocess calls
In the IoT Box, most calls to subprocess used "Shell=True", which can
cause security issues.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#36088

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 17:07:59 +02:00
Odoo's Mergebot 24c93d3f7f [IMP] Customer Display as IoT Device
Linked to odoo/enterprise#5266

Move all the logic that was inside hw_screen into an IoT Driver
in order to have consistency between devices.
Move the configuration of screen_url from the IoT Box form to
the IoT Device.
If an URL different than the default one is used, refresh the
page every minute.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#36074

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 17:07:43 +02:00
Antoine Prieels 6cf30cb869 [IMP] hw_*: Remove "Shell=True" in subrpocess calls
In the IoT Box, most calls to subprocess used "Shell=True", which can
cause security issues.

TaskID: 1966417
2019-09-04 13:10:03 +00:00
Antoine Prieels 70006311d0 [IMP] hw_drivers, hw_posbox_homepage: get_ssid helper
Create a helper to get the ssid of the wifi to which the Box is
connected.
2019-09-04 13:10:03 +00:00
Antoine Prieels 5d0afddaf2 [FIX] point_of_sale: Too many display updates
Multiple updates were sent to the customer display for each
modification of the order lines.
2019-09-04 13:08:12 +00:00
Antoine Prieels c03d33b64a [IMP] point_of_sale: No new tab on url change
Change Firefox config to open external links in the active tab.
This avoids having multiple running tabs when changing the URL
showing on the Display device.
2019-09-04 13:08:12 +00:00
Antoine Prieels 98bebfbfa5 [IMP] point_of_sale: Per device screen_url
The screen URL is not linked to the Box anymore but to the Device.
We don't need to fetch a screen_url at the boot, it'll be done inside
each device.

TaskID: 1893493
2019-09-04 13:08:12 +00:00
Antoine Prieels f03026a3d7 [REF] hw_{drivers,screen}: Convert hw_screen into an IoT Driver
Move all the logic that was inside hw_screen into an IoT Driver
in order to have consistency between devices.

TaskID: 1933834
2019-09-04 13:08:10 +00:00
Antoine Prieels 75020a74e5 [REM] hw_posbox_homepage, hw_screen: remove unused code
Function get_hw_screen_message was still present but not called since commit 8b957b7e85
2019-09-04 13:07:35 +00:00
qdp-odoo f75fc4ed63 [FIX] account: journal items tree view not editable
Task 2008956

closes odoo/odoo#36205

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-04 09:00:03 +00:00
qdp-odoo 1b91747d05 [FIX] account: fixed view_mode on specialized journal items tree view
removed form,kanban from view_mode on specialized journal items tree views

Task 2008956
2019-09-04 09:00:03 +00:00
qdp-odoo 1eb931f84b [IMP] account: better display name for journal entries
Task 2008956
2019-09-04 09:00:03 +00:00
wan 0a5955bff6 [IMP] account: improve list and search view of account move line
Task 2008956

* Remove the sequence from the default order of account.move.line as it
  is only needed in the list view of the invoice form view; add it
  there.
* Allow to order by date on the grouped list view of account.move.line by
  setting an aggregate function
2019-09-04 09:00:03 +00:00
wan 737eaf9333 [IMP] account: add searchpanel on account.account and account.move.line
Task 2008956

* Add the root of an account (first 2 digits/char) as a searchable model.
* Create a custom searchpanel for this account root on account.move.line
* Add the account_root searchpanel to the account.account view too.
2019-09-04 09:00:03 +00:00
Antoine Prieels 16c32f0c25 [FIX] hw_drivers: Kill MPD server on start
The MPD server was not correctly killed when the IoTBox started without
six payment terminal configured. A warning was displayed.

closes odoo/odoo#36415

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 11:58:48 +00:00
lejeune quentin fd32139b0d [FIX] point_of_sale: Fix to execute eftdvs file for MPD server
We have a traceback when we put a wrong terminal id for SIX because
MPD server can not execute the eftdvs file.

Now we change the permission for this file

closes odoo/odoo#36355

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 11:43:39 +00:00
lejeune quentin f03a6cc7d4 [FIX] hw_posbox_homepage: Fix dead link in IoT Box home page
In home page of IoT Box the link "Manual" send to a 404 page.
Now we send to IoT Box documentation

closes odoo/odoo#36354

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 11:48:48 +00:00
Odoo's Mergebot 0387cfc8c5 [IMP] hw_{drivers, posbox_homepage}: Automatic load of drivers
Automatically load the IoT Drivers when Odoo starts on the IoT Box or
when the connection to the Odoo instance is done.

Allow to deactivate the automatic load to avoid overriding
modifications made on the Box.

TaskID: 2009683

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#36073

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-09-04 13:52:36 +02:00
Jairo Llopis 34cbbff7b3 [IMP] sale: Show untaxed and tax totals in tree views
This is **very** useful for B2B customers. 😊

closes odoo/odoo#36366

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-04 09:24:50 +00:00
Thibault Delavallée 4af08fad6e [FIX] crm: allow (again) phone widget to display SMS sending icon
Phone widget enabling SMS capabilities on lead / opportunities form views
seems to be lost. Option of this widget has probably be removed by mistake
when merging lead and opportunity views.

Task 2060220 (testing SMS integration)

closes odoo/odoo#36404

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-04 08:35:16 +00:00
Thibault Delavallée 3d034dafc6 [FIX] test_mail: fix some ordering issues in tests
In resend wizard tests

In some cases tuple comparison of states seems to fail. Indeed order seems
to change in some cases depending on installation order. With this commit
we correctly check partner / notification status one by one, avoiding
to rely on order / set length that is not guaranteed.

In mail gateway tests

Add a specific order on name to be clearer about what we mean when fetching
users as a fallback, until better heuristic. Using name is sufficient as
we have no need to rely on complex partner display_name.

Task 2060220 (testing SMS integration)
2019-09-04 08:34:24 +00:00
Julien Mougenot eea560060a [FIX] web: list width should not be calculated when invisible
Before this commit, the width of the headers in a list were frozen
only when the list was seen, but the calculation of the width might have
happened while it was invisible (thus giving the headers 0px).

Now, the freeze AND the calculation only occur when the list is visible
and can actually be evaluated.

Task 2061848

closes odoo/odoo#36175

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-09-04 08:19:32 +00:00
Julien Mougenot 52bd5fa461 [FIX] web: list view: allow buttons width
Before this commit, when entering an empty editable list with buttons,
their width would be set to 0px.

Now, they are considered as fields and given a name, allowing the renderer
to give them their proper width (if any) or a default one.
2019-09-04 07:11:01 +00:00
Julien Mougenot 7329014796 [FIX] web: editable list: ignore empty headers
Before this commit :
- resize handles were all attached at the right side of the list
- empty columns were given a resize handle, causing them to be larger than expected

Now :
- resize handles are attached to their corresponding header
- only non-empty columns are given a resize handle

Fix 2060807
2019-09-04 07:11:01 +00:00
Julien Mougenot 5718861b91 [FIX] web: editable list: invisible list width computed on interraction
Before this commit, if an x2many was in an inactive tab of the notebook,
its column headers widths were all set to 0px

Now, inactive x2many lists do not compute their width until they are visible
and interracted with (e.g. add/delete a record, sort columns, etc.)

Fix 2060418
2019-09-04 07:11:01 +00:00