Previously, 'company' field in the 'contact us' form was a required field
which wasn't ideal to accommodate B2C flow.
When applied this commit will make company field optional by default. Note
that users can customize the form to make it required again if necessary.
Linked to task 1965839
closesodoo/odoo#33005
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of this commit is to send a mail template to the user
who invited other user(s) in Odoo.
It informs the user about the details of user(s) who have been
invited by him but have still not registered after the given days
of creation (default set to -> 5days)
task-1912449
Closes#31582
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, when granting portal access to a res.partner through the
wizard, it would show all the partner + its child_ids, including shipping
addresses partner, billing addresses, private (hr) addresses etc, which makes
no sense.
This commit hide contact-address from the list.
Fixes#32848closesodoo/odoo#34522
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Xavier Brochard <xavier@alternatif.org>
When the system generate an activity the standard is to define it
as an exception type. Todo works as well but we would keep it for
the user and avoid a mix between exception from the system and created
manually.
Task-2007559
closesodoo/odoo#34006
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
As next activities are ordered by date, having the same date can implies
the order is not always the same.
closesodoo/odoo#34753
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
The invoice status of a sale order line depends on its product's
`invoice_policy` and `qty_delivered` fields.
`invoice_policy` is also used to compute the "anglo saxon price
unit" which is, once multipled by the invoiced quantity, the
amount we will take from the stock delivered account to put into
the cost of goods sold account if we are in anglo saxon mode.
The default `invoice_policy` is set as "ordered". In this mode and in
anglosaxon, the "anglo saxon price unit" will always be standard price
of the product, resulting in unbalanced accounts.
In this task, we chose to use the real delivered price if something was
delivered, whatever the value of `invoice_policy`. We fallback on the
standard price if nothing or not enough things were delivered.
test_dropship_fifo_perpetual_anglosaxon_ordered and
test_dropship_fifo_perpetual_anglosaxon_delivered do have the same
result now.
task-2003196
closesodoo/odoo#34644
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Let's assume an editable list with a row containing only readonly
fields. Before this rev., if the user clicked on this row and then
pressed TAB, it crashed. The crash occurred in historical code that
now seems to be useless, so we simply removed it.
closesodoo/odoo#34696
Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>
Previously to commit [1] notification emails were send using the after commit
hook (see [2] for related code move and [3] for original code). That commit
changed the parameter default value without any reason, meaning this mechanism
is not used anymore. This commit fixes that behavior.
[1] See commit 581a74143e: code cleaning
[2] See commit 7a6269719f: code move
[3] See commit 38e181ee2c: use of post-commit hook in mail
closesodoo/odoo#34681
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Commit f60825b439 moved phone validation addition on res.partner model
from a specific module to crm directly. However the inherit from the validation
mixin class was forgotten, leading to a crash when changing phone from the UI.
closesodoo/odoo#34545
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Removed classes "default-label" and "label" as they weren't required and
were giving a bad look to tag.
Task-2033286
closesodoo/odoo#34646
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
This commit adds some comments, clean linter error and remove unused
variable in the write method of stock.move
closesodoo/odoo#33624
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
In a move chain, if the scheduled date of a move N is updated, we would
like to create an alert on the move N+1.
This commit adds a boolean field on stock.rule that, if set to True, will
create a next activity on the stock.picking of the move that are created
from this rule, in case the previous move has its scheduled date changed.
The message will depends on the propagation of the schedule date between
the two moves:
- If the date is propagated, the message informs the picking user that
the transfer is delayed.
- If the date is not propagated and the new date of move N is after the
schedule date of move N+1, the message says that the scheduled date
will be outdated.
Task: 2001643
We still create a valuation layer for the traceability of what
happened though.
The rationale is that receiving free products is often requested by our
customers.
task-1985424
closesodoo/odoo#34683
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Rev. ee44d23 fixed a usability issue: when a doAction is performed
from a dialog, it automatically closes the dialog (as the action is
rendered in the background, behind the dialog).
However, it also closes dialogs when the action has target='new',
i.e. when it also opens in a dialog, which is not strictly
necessary in this case.
This is problematic in mobile for the product configurator widget:
in the sale.order form view, the order_line field is displayed as a
kanban, and in its form view, the product_(template_)id field has
widget product_configurator. When a value is set, it performs a
doAction (target="new") to configure the product. The widget listens
to the dialog's 'closed' event to update itself. However, with what
is done in ee44d23, the x2many form dialog is closed by the DoAction,
so the flow doesn't work.
This rev. reverts the attempt done in ee44d23, and does something a
bit more brutal: as soon as an action is pushed in target 'current'
(in the main part of the interface), all dialogs are automatically
closed.
closesodoo/odoo#34678
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Add a new behavior to numeric fields, possibility to enter value manually or to use a simple arithmetic expression that will be evaluated.
Example: =20+3*2
In order for the computation of the arithmetic expression to be done, the value needs to starts with = and then an expression can be entered. We only support the basics mathematical operations + - * / ( ) ^
User locale and digits separator are taken into account. If the value entered can't be evaluated to a numeric, the field will be displayed in error.
closesodoo/odoo#34538
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Default "type" key in the context leads to a traceback. Force the type
to be entry.
task-2033390
closesodoo/odoo#34665
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Now that an onchange set its result into the cache, we
cannot create a user because the onchange tries to put
the reified fields (eg: sel_4_7) into the cache.
As those field don't exist and are pseudo-fields used
to manage groups into the res user form view, we should
replace the values by ORM commands on the groups_id field,
as this is already the case in the create and the write
methods.
Note: Initially merged in saas-12.4, but was not
forward ported, I don't know why.
closesodoo/odoo#34487
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This commit add an action to merge and print the original vendor bills
through the field 'message_main_attachment_id'.
Was task 2006908
closesodoo/odoo#34023
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
This commit allows to merge, in a single pdf, different streams comming from both PDFs and images.
To achieve that, the dictionary save_in_attachment used in method render_qweb_pdf() has been changed to now store streams instead of ir.attachment records. That allows to process each of them equally to render them.
Was part of task 2006908
When creating a state from the Cities list, the country was not prefilled.
Use the parent record
Closes#30135
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The duration field ('real duration') only showed the duration spent
for the currently logged user; this was confusing to user.
We remove the domain on the user to show the same duration to all users.
opw 2029830
closesodoo/odoo#34649
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
don't show the 'Reconclied Entries' stat button if no reconciliation are linked to the move
task-1935597
closesodoo/odoo#31149
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Before this commit, each picking type had its `show_operation` field on
true if user actived multi locations, packaging or tracking.
Now, it still the case except for picking type for receipt.
Also, modifies onchange to reflect that when creating new picking type.
Task #2031313
Those 2 methods are used in enterprise (for now) in order to get employee
unavailabilities. This is used for planning and forecast gantt view. As we
didn't want to create a bridge module for those 2 methods, we place them
here as 'hr' is the only one common dependency between forecast and planning.
Task-2024216
closesodoo/odoo#34638
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
For now the sales team is only used on the pos.config and now on the invoices generated.
When you open the sale report, you'll see the sales team of the pos.order, but in reality it is the one of the related pos config.
That means that if you change the pos team on a config. It will change the pos team of all existing order.
We should store sales team on pos order, like on invoice and sale order
TASK-ID: 2011460
closesodoo/odoo#34246
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
reply_to field is not used (and not available) anywhere. Its use is completely replaced by
aliases you can set on teams. Let us therefore remove this field.
Related to task 1985539
Closes#33497
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of this commit is to remove of the legend_priority field in the crm
and project addons since they are not used anywhere.
Those were initially introduced at dd343c8633 . Purpose was to be able
to customize displayed label of priority field used in kanban view in
replacement of standard string. However kanban view does not support it
anymore since whatever web refactoring and this feature will not be
reintroduced. Let us therefore remove the fields.
Linked to task ID 1935620
closesodoo/odoo#33444
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
1/ base: use new avatar for administrator
As the current icon is white, we cannot see anything when
put on a white background, as this is the case on the chatter.
2/ mail: Remove the 'Bell' icon to edit subtypes
There are 2 different manners to edit the subtypes:
- The bell above the chatter
- The pencil next to your avatar on the followers dropdown.
It's better to have only one way to edit these subtypes.
As this is an advanced configuration that is not part of the
onboarding process, remove the most obvious way to edit it.
3/ mail: Move the attachment icon on the left
This is much better.
4/ mail: Display some tour popups on a better side
5/ mail: do not log note if note is empty
Because a note could be only False, not at least
"<p></br></p>"
TaskID: 2026295
closesodoo/odoo#34615
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
There are 2 different manners to edit the subtypes:
- The bell above the chatter
- The pencil next to your avatar on the followers dropdown.
It's better to have only one way to edit these subtypes.
As this is an advanced configuration that is not part of the
onboarding process, remove the most obvious way to edit it.
`api.one` has been deprecated since v9 because it often makes the code
less clear and behaves in ways developers and readers may not expect
since functions decorated with it usually expect a `list` of record(s)
instead of the recordset, whereas most modern Odoo code expects `self`
to be a recordset.
The function `aggregate` was solely being used by `api.one` thus it has
also been removed since there doesn't seem to be any other use for it
thus far.
closesodoo/odoo#34555
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Impacted modules: project, sale, sale_timesheet and project_timesheet_holidays.
Since a5b6f31cf2, the multi company environment is contextualized,
allowing people to see several company documents at the same time. This reveals
some problem in such env.
To solve this, we need to force the "company_id" field as required on some business
model, and to correctly propagate the company when a document generate another one.
The guidelines is to stop using company of current user, but the one of the document
itself.
See subcommits for more details.
Task-1999686
closesodoo/odoo#33739
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
In a multi company environment, some adjustment must be done:
- the company of an internal project of a company should be in that company
- the generate timesheet on holidays validation must be in the company the
task (or internal project)
The company should be correctly propagate to timesheets.
Task-1999686
When allowing timesheet on a project, the project generate
an analytic account if not given. When creating that account,
the company should be the one of the project (origin document)
rather than the one of the current user.
Task-1999686
On Sales order confirmation, a project can be create. The project
company is not correctly propagated: the created project should
be in the same company as the SO.
To stay consistent, during the sold quantity conversion into the
planned hours of a task, we need to use the SO company instead of
the one of current user.
Task-1999686
Hiral Bhavsar