Commit Graph
124481 Commits
Author SHA1 Message Date
William Henrotin abb95e4608 [FIX] mrp: finished moves become raw moves
A workorder has a one2Many to stock.move to represent the production raw moves. Putting 'workorder_id' on the production finished move will set it as raw moves in the workorders

closes odoo/odoo#31132
2019-02-28 14:32:06 +00:00
William Henrotin a5342daf9d [FIX] mrp: missing move reference
A manufacturing order creates its raw move in an onchange when saving the form
view. As the MO has no name at this stage, the raw moves reference stay 'New'
even when marked as done
This commit change the moves reference once the MO is confirmed
2019-02-28 14:32:06 +00:00
William Henrotin f3f9dd8cd7 [FIX] mrp: recordset have not pop() method
The pop() method is not implemented for Odoo recordset. This commit replace it by a simple 'for' loop
2019-02-28 14:32:06 +00:00
William Henrotin d2951fadcd [FIX] mrp: remove unused code
Commit 5ef46664a2 change the workorder
model but some of the old fields was not removed. This clean all
the occurence of these unused part of code.
2019-02-28 14:32:06 +00:00
RomainLibert 86c66273cf [FIX]: hr_holidays: fix typo
closes odoo/odoo#31505
2019-02-28 13:47:09 +00:00
Christophe Simonis 06898fac3c [MERGE] forward port branch saas-12.1 up to f9d3b5b7df 2019-02-28 13:47:09 +01:00
Xavier Morel f9d3b5b7df [FIX] core: order of fields in onchange of SSF
When calling the initial (create / default_get) onchange, the SSF
would send the list of fields in whatever order was provided by the
fields map of fields_view_get.

The web client uses view ordering, and it turns out some uses / tests
have dependencies between onchanges (e.g. _create_payment in
test_account_reports) which break on some orderings of the fields.

Send the initial onchange using view-ordered fields in the SSF as
well.

closes odoo/odoo#31494
2019-02-28 10:58:33 +00:00
Robot Odoo 012816f85f [MERGE] website_slides: review elearning widgets and templates
Main purpose of this merge is to lint and clean front-end templates and
widgets in eLearning.

Including
 * lint and clean JS and CSS for fullscreen widgets;
 * refactor reordering of slides and categories, handle void categories;
 * refactor category addition and slide archive widgets;
 * simplify progressbar;
 * lint slide like and crouse join widget;
 * improve course main page, restore review tab;
 * various fixes, improvements and lintings;

See sub commits for more details. Thanks to everyone involved in this
branch. So much people to tag, I have a bit la flemme.

Incoming in a near future: improved main slide page, cleaned fullscreen
widget, design-linted profile page, and probably more fixes.

Merge related to task ID 1941250 (basically, "fix eLearning post-merge").

closes odoo/odoo#31394
2019-02-27 17:47:45 +01:00
Jigar Vaghela 373afe2498 [FIX] l10n_in: opening and closing tag mismatch in file l10n_in_chart_data.xml
when forword port https://github.com/odoo/odoo/commit/93d736e905e0d3b110c36ee93af341021eba42c4#diff-8dfc8ecf49a86f02478f1f0a6188f253

closes odoo/odoo#31449
2019-02-27 05:13:32 +00:00
jem-odoo ed6bd2e9af [FIX] website_slides: use progressbar from bootstrap to avoid too much code
This commit replaces a widget with standard boostrap code: the progress bar
classes. Creating a widget was a little bit over engineered, and since the
progress animation is handle in CSS, this replacement does not cause any loss
of feature.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
jem-odoo 5d5810ace2 [FIX] website_slides: improve tab on main course page and restore review
The review tab exists on channel homepage, but does not show the reviews of
the channel. This commit makes the tab dynamic for homepage content and
reviews. Forum tab still redirects user to the forum page.

Layouting of course page is also improved to better match the new homepage
layouting.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
af25a34606 [FIX] website_slides: improve upload modal
Various fixes :

  * better label on upload modal;
  * upload always visible slide. When uploading a slide with the is_preview
    checkbox checked, it does not work as in the controller we are looking
    after a string when receiving a python boolean;
  * switch modal buttons in slide upload modal to have a correct order;
  * prevent auto scroll up. When clicking on the plus icon in drag'n'droppable
    list view of a course homepage, if the user has scroll down the page he
    will be automatically scroll up. This is very annoying and make some of
    my colleagues grumpy;
  * hide slide upload if not channel.can_upload. This commit hides the "+"
    icon next to the channel categories if the user doesn't have the rights to
    upload slides;

Commit linked to task ID 1942852 and PR #31394.

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Jerome Maes <jem@odoo.com>
Co-Authored-By: Aurélien Warnon <awa@odoo.com>
2019-02-26 16:13:19 +00:00
Thibault Delavallée 8993e9cfd2 [REF] website_slides: split course sidebar and move fullscreen templates
Moves

 * sidebar of course main template in its own template;
 * fullscreen templates in their own file;

It will ease future modification of this page layout.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
Aurélien Warnon 2524373688 [REF] website_slides: introduce a slide_icon template
Purpose
=======

This commit introduces an icon template to factorize some xml code.
It also correctly overrides this template in website_slides_survey to add
the 'certification' case.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
Thibault Delavallée ede6a90728 [REF] website_slides: lint slide like / dislike widget
Just apply some linting and naming convention.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
Thibault Delavallée a0f923c3a8 [REF] website_slides: lint course join widget
Just apply some linting and naming convention.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:13:19 +00:00
Aurélien Warnon 156976a9f5 [REF] website_slides: handle uncategorized slides in training course view
Purpose
=======

This commit adds the management and display of uncategorized slides
for both the frontend publishing management and the fullscreen
course views.

We add a "Uncategorized" section on top of all the categories that is
hidden for the student if it's empty.

Course publishers can drag and drop slides from and to that
new "Uncategorized" section to easily reorganize the course.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:08:35 +00:00
Aurélien Warnon 5fbfd2a7a4 [REF] website_slides: refactor the course reordering of slides and categories
Purpose
=======

This commit refactors the way slides and categories are reordered in the
frontend course view (training courses). The use of jqueryui's "sortable"
widget makes it easier and more user friendly to drag and drop both sections
and slides to reorganize your course.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:07:57 +00:00
Thibault Delavallée 76bfcef0b9 [FIX] website_slides: fix call to set_completed
Currently fullscreen widget calls a user-specific route as public user if
user is not logged. Purpose of this commit is to avoid JS crash. Some
code cleaning is also done. This small feature will have to be cleaned more
in-depth in a near future.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:07:48 +00:00
Aurélien Warnon 0e73de5dea [REF] website_slides: refactor the category add modal on frontend
Purpose
=======

This commits refactors the way slide.category are added on frontend:

 * JS now extends a standard Dialog widget;
 * added "required" name value on the form and handled validation;
 * controller adds the category at the bottom of the list (sequence+1);

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:07:33 +00:00
Aurélien Warnon 5db9ed0391 [REF] website_slides: refactor the slide archive modal on frontend
Purpose
=======

This commits refactors the slide archiving confirmation modal to make it a
standard Dialog (remove global selectors, remove most of useless xml, ...).

It also adds a new slide archive route to allow channel publishers to archive
slides in sudo mode. Indeed ACLs only website_publishers can write on slide
model. In some case people without real rights may update slides.

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:07:16 +00:00
David BeguinandAurélien Warnon 362271f35a [FIX] website_slides: fix some small model-related issues
* improve is_preview field string and help. 'Always visible' was not really
   clear and self speaking. A help string is added to describe what this field
   implies;
 * fix slide.channel invite button for 'invite' enroll mode. While renaming
   the "visibility" field to "enroll", a check was missed for the slide.channel
   invite feature. This commit fixes it by properly checking for enroll instead
   of visibility;

Commit linked to task ID 1942852 and PR #31394.

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Aurélien Warnon <awa@odoo.com>
2019-02-26 16:05:45 +00:00
Quentin Mourier 70add1c212 [REF] website_slides: apply linting and cleaning to elearning lesson pages and widgets
Purpose of this commit is to perform some linting and cleaning in lesson widget
JS and its related css. Notably for fullscreen widget of eLearning. Containing

 * better naming of css classes;
 * deleted sidebar file as it is now included directly in the fullscreen
   widget;
 * removed unused css;
 * apply JS linting;
 * clean some controllers;

Commit linked to task ID 1942852 and PR #31394.
2019-02-26 16:05:40 +00:00
Christophe Simonis fcb972db9d [FIX] test_website: skip broken test 2019-02-26 14:31:05 +01:00
Christophe Simonis 7f0a3101f5 [FIX] website{,_sale}: adapt tours to new html editor
See f296992317
2019-02-26 14:28:25 +01:00
Christophe Simonis 7e1935f0b4 [FIX] website{,_sale}: avoid tour dependence on portal
See 6521cf4f66
2019-02-26 10:39:09 +01:00
Aaron Bohy 6a8e1b53e3 [FIX] web: search more in many2one: filter on ids
Let's assume a many2one field with a lot of possible values. The
user clicks on 'Search More...'. In the opened dialog, only 160
records are available (their ids have been obtained with a
name_search, with the optional text the user could have typed in
the many2one input).

Before 4cd379cf, that extra domain on ids was removed automatically
as soon as the user interacted with the search view in the dialog.
This was especially useful when there were more than 160 records.
However, this was rather an happy coincidence than a designed
feature.

From 4cd379cf, the ids selection was added to the initial domain
of the list, so they couldn't be removed from the domain
afterwards. The user was thus stucked with its preselected 160
records.

This rev. doesn't restore the former behavior, but rather improves
the current one, as follows:
 - when there is no text in the many2one input (i.e. no value to
   filter on), we bypass the name_search, s.t. all records are
   available in the dialog
 - when there is some text in the input, we perform a name_search (as
   before) to get a list of record ids, and we add a special filter
   to the search view in the dialog (the filter on those ids), s.t.
   the user can remove it if he wants to access the remaining records.
 - finally, the limit is now set to 320, to mitigate the problem

Issue reported on the saas-12.1 migration pad.

closes odoo/odoo#31232
2019-02-26 08:26:51 +00:00
Aaron Bohy a76a958ca8 [FIX] board: clicking on a pivot cell in dashboard
Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c18b.

Issue reported on the saas-12.1 migration pad.

closes odoo/odoo#31367
2019-02-26 08:28:17 +00:00
Christophe Simonis b3766768f9 [FIX] website: correctly extract failed node in QWeb exceptions handling 2019-02-25 16:17:09 +01:00
Toufik Ben Jaa 397f2e6c50 [FIX] account: Use the correct journal on accounting dashboard
- When selecting "Unpaid invoices" or "Invoices to validate" on the
  accounting dashboard, the list view opened doesn't filter with the
  journal selected.

closes odoo/odoo#31397
2019-02-25 09:46:42 +00:00
Lucas Perais (lpe) 74bd66e1b5 [FIX] website_crm_partner_assign: portal edit activity change activity type
On the portal, edit a Lead in order to make/edit the
next activity
Change the activity type

Before this commit, the modal closed when clicking on the selection field
This was because the wrong method was called

After this commit, the modal stays and the activity type is changed

OPW 1943428

closes odoo/odoo#31349
2019-02-25 09:38:39 +00:00
Christophe Simonis b13305fddc [FIX] hr_payroll: call correct method
Oversight of previous forward-port
2019-02-22 17:00:17 +01:00
Christophe Simonis 0e7675847f [MERGE] forward port branch saas-12.1 up to 0f4abc5c22 2019-02-22 16:25:02 +01:00
Christophe Simonis 0f4abc5c22 [FIX] website_sale: adapt test to demo data update
`stock` module rename then main company, which forbid test to complete
successfully.
2019-02-22 14:26:54 +01:00
Christophe Simonis 9332e25195 [FIX] web: remove extra test added by forward-port
As related patch hasn't been forward-ported, this extra test (that isn't
execute for unknown reason) can be removed.
2019-02-22 11:14:43 +01:00
Christophe Simonis 7f9b7beed8 [MERGE] forward port branch 12.0 up to b2db72c9d1 2019-02-21 21:36:52 +01:00
Robot Odoo 1af67ffdfa [MERGE] website_slides: improve layout of courses main pages and apply various fixes
Purpose of this merge is to provide several fixes related to new elearning
application [1]. This is second batch of fixes [2]. Those are mainly fixes
and improvements for front-end templates: layouting, clean design. Some
other fixes are also included, notably links and search capabilities.

See sub commits for more details.

Thanks to @awa-odoo @jem-odoo @stefanorigano @qmo-odoo @dbeguin
for their work as most of code come from cherry-picks.

Merge linked to task ID 1941250.

[1] eLearning feature: see task ID 1902304
[2] First batch of fixes landed at 5cec06b179

closes odoo/odoo#31317
2019-02-21 18:29:32 +01:00
Christophe Simonis b2db72c9d1 [FIX] core: handle multiple m2o levels in Form
closes odoo/odoo#31335
2019-02-21 17:03:27 +00:00
Christophe Simonis 644aeb2cd6 [FIX] test_testing_utilities: correct on_change
Avoid searching `[('name', 'ilike', False)]` as it doesn't make any
sense (and behavior changed in saas~12.1)
2019-02-21 17:47:46 +01:00
jem-odoo 039df4a79e [FIX] website_slides: fix vote widget
Fix route of vote widget. Set it to auth=public so that instead of a crash
we have correct popup asking to login. Better than a SessionException, which
will not be displayed.

Another fix is done to avoid having one widget for all displayed like / dislike
buttons. Each slide should have its own vote widget.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:39:56 +00:00
Thibault Delavallée fdc36c5c37 [IMP] website_slides: improve main course page in documentation mode
Purpose is to clean a bit the card layout in documentation courses, notably

 * better layout for cards:
 * fetch (in controller as slides in course display are sudo-ed to display
   a card even if current user has no access) completion data and display it;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:20 +00:00
jem-odoo 95ab97c2f3 [FIX] website_slides: reload page when joining channel
When a user join a channel, the button 'join' changed and indicates
him that he is now member, but since the page is not refreshed, he
still can not access to slides displayed on the page.
This commit makes the widget trigger a page refresh.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:17 +00:00
jem-odoo 1a89a3fcc4 [FIX] website_slides: bad xml ids on fields
Having bad xml ids, even on groups fields, causes crashes, even
when duplicating a record.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:16 +00:00
jem-odoo 7d1af42c06 [FIX] website_slides: fix some rating issues
Last review should be a comment. When fetching the last message on a course
the returned message can be a system notification (like "Channel created").
This is not what we want, mostly with the feature allowing to modify the body
of a message. This commit add restriction on the domain fetch last message.

Fix default rating value on popup widget. The conversation ratio (rating 1-10
and 5 stars) was not applied everywhere. So, the number of displayed stars was
doubled. This is now fixed.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:14 +00:00
Aurélien Warnon 55f93a240f [FIX] website_slides: handle "My courses" to filter user's channels
Purpose: the "My courses" button on the slides home page now redirects the user
to the list of channels for which he is a member of.

In this commit we also clean a bit controller code to remove support of
category_id which makes no sense on a page displaying courses as categories
are not cross-courses, only course-specific.

A clear search icon is also added.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:11 +00:00
Aurélien Warnon 9f74ccf403 [FIX] website_slides: fix some styling issues on training course page
This commit do some small UI adjustment:

 * remove a potential doubled <hr/>;
 * remove a "mb8" to make views consistent whether you're a channel publisher
   or not;
 * add a specific parameter to see 'uncategorized' slides on a documentation
   channel as /category is a slug and does not allow Falsy values;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:04 +00:00
sri-odoo 0a73e14805 [REF] website_slides: improve design of "all courses" main pages
Containing notably

 * improve banners;
 * sidebar achievement design;
 * some sidebar adjustments;
 * adapt to circular rank progress the current user sidebar;
 * improve overall spacing;
 * improve cards design and size;
 * improve 'all courses' grid layout;
 * clean unused css and templates;

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:38:00 +00:00
sri-odoo 920a48b32f [REF] website_profile: add circular rank progress
Purpose of this commit is to add a circular progress around the rank of
a user when seing its profile. It allows to see at a glance advance for
next karma rank.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:58 +00:00
Fabrice Henrion 45bb68db0a [IMP] website_profile: improve wording and fix typos
Manual backport of commit done in master at 20e48b84f8. It is interesting
to have those fixes in 12.2.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:55 +00:00
Thibault Delavallée e85c99c145 [FIX] gamification: improve next rank icons
Background of icons should be transparent.

Commit linked to task ID 1941250 and PR #31317.
2019-02-21 16:37:52 +00:00