Before this commit, the description of the move was displayed on the
Delivery Slip report, even if the description is exaclty the same as the
product name (which is the case by default).
Now, as it's somehow ugly to have the repetition, they will not display
the description if it's the same as the product name.
opw-2205325
closesodoo/odoo#46550
X-original-commit: e6ee4824a6e422960c648e9a1f684e56e6dabd89
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
When there is no intersection between the allowed companies of the current user
and the target user, the `with_user` would lead to the company check always
failing.
opw-2197955
closesodoo/odoo#46606
X-original-commit: ceee2c05f8a4fc69b8ae34469ac56a055ba7b7cf
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
New categories will now we added at the end by default.
The sequence field is hidden in the form view.
It's still possible to order them from the list view.
Part of task-2002125
Closes#25535
Co-authored-by fja-odoo <fja@odoo.com>
Co-authored-by Sébastien Theys <seb@odoo.com>
closesodoo/odoo#46600
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>
The URL might not be set because it comes from `referer`, in that case match the
first rule with no `regex_url`.
It crashes before this commit because `re.search()` is expecting a string and
`headers.get()` is defaulting to `None`.
opw-2205202
closesodoo/odoo#46593
X-original-commit: e2f8caf07b2f749935df9184ded738cc1c482423
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Commit a4c0994 uses variable `qty` as input parameter but override it
at each loop iteration. The original value of `qty` is lost after the
the first pass and so give wrong results for all next iterations.
This commit uses another name to never lose the given value.
closesodoo/odoo#46587
X-original-commit: e1c30bceba6d47d8e087e540f995a02086fa6283
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
The date range picker works with 2 fields but we only listen on
the one that has the tip. If we change the field that doesn't have
the tip the event "tip_consumed" is not triggered. So we need to
listen on the 2 fields.
This issue is not met before 13.3 but we fix it from 13.0 when
daterangepicker was added.
Task with the issue: 2180175
closesodoo/odoo#46561
X-original-commit: e2c7498e05318b774badc3a93d0b31b955f15b2d
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit adds two buttons on the Theme side menu that allow users to
add custom XML to the head and to the footer of the website.
Part of #44633
task-2168391
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit moves the custom user css assets to a higher priority
so their custom css have ascendancy over the other rules.
Part of #44633
task-2168391
Dealing with newId is sometimes difficult.
closesodoo/odoo#46560
X-original-commit: 416d5ae6f7753c413b6981f9de3d24913943e9c2
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Issue
- Install Accounting
- Resize your window to have the more menu
- Refresh the page to make the JS working correctly
- Click on the item on the left of the more menu
- Do not close the menu just hover the more menu
=> It doesn't appears (the .show class is on the last <li> child instead of the parent)
Click on the more menu
=> It appears but small & with items broken
Cause
Without the :first, all the more menu dropdown where toggled
Issue
Add :first to the target to toggle
OPW-2178843
closesodoo/odoo#46553
X-original-commit: 55a4a834461446a070ad06d1b24d67fbc27799a1
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Co-authored-by: aab-odoo <aab@odoo.com>
Issue
- Time Off
- Managers > All > Time Off
- Any form > Schedule Activity > Any activity > Schedule
- Mark as Done > Done & Schedule Next
Traceback "field can_reset does not exist"
Cause
In ir.ui.view the postprocess_and_fields tries
to return an architecture and a description of all the fields
of mail model (with view=False) but as we have a context
key 'form_view_ref' with value hr_holidays.hr_leave_view_form_manager
It loads the field of this view's model too and then it compare
them to the mail model fields.
Solution
Move the view ref into view_ids
OPW-2205031
closes#46150closesodoo/odoo#46552
X-original-commit: 88104afaa07f80261d3198abd71b7bea7c1cf3f4
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
In the Colombian legal requirementqs for point_of_sale, a number should
be printed on the receipt, this number sequence must have no gap and no
duplicates.
As there is already a no gap 'ir.sequence' on each config, we allow the
edition of this sequence, and set set same ir.sequence on all pos
config, with their DIAN number as prefix.
closesodoo/odoo#46546
Task-id: 2169664
X-original-commit: 4ba07bb5a503b5d7dc1ad07cc05adac6309ab8c4
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
# Purpose
Improve the design and the usability.
# Specifications
- Replace fa-clock icon by fa-calendar-check-o icon on kanban view for consistency.
- Remove the dropdown header "Colour" for color picker.
- Increase the height of the iframe to edit the mail with the web_editor.
- Make sure that the html body is displayed next to the editor panel, when it's open in a modal.
task-2198656
closesodoo/odoo#45652
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The heigth of the iframe for editing a mail template
was to small, which makes it quite uncovenient.
The height has been raised to improve the usability
of the editing feature.
task-2198656
- Replace the fa-clock icon on the kanban view for
the fa-calendar-check-o icon to be consistent with
others modules.
- When you wanted to create/edit a mail template using
the web_editor, when it was open in a modal, a part of
the body was behind the editor panel. Now the body is
correctly display when opened in a modal.
task-2198656
The field 'type' in the account.move model has been renamed into 'move_type'
but the ir.rules of the sale module have not been updated.
The fix consists in renaming this field in ir.rules.
As another bug was due to this field renaming (see 51b70b6fc4), I have checked
that the old 'type' field is no more used in Odoo files.
closesodoo/odoo#46398
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this commit, a JS widget would be instanciated for every `.js_follow` on
the page.
Every widget would then perform a RPC to know if the object was followed.
That would be an issue if there was too many `.js_follow` on the DOM.
Eg: on the forum tag page (/forum/1/tag), there might be unlimited tags. This
is where the biggest issue is ATM, on Odoo.com we have over 5500 tags,
which performs 5500 RPC.
Your browser will most of the time just crash.
This commit improves that behavior by sending only one RPC to get the tags info
in once.
With 5000 tags, there was 5000 RPCs, now there will only be one for the tags.
Also, each RPC were doing 8 requests each, so this will bring requests from
40.000 to 80.
Fixes#45576closesodoo/odoo#46278
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Purpose
=======
A 'book icon' link to the documentation of a feature has been
added in its settings panel, when it is useful (complex feature).
Add a nightly test that parses all the res_config_settings views
from the base one and checks that all documentation links are still valid.
Add the o_doc_link class to all documentation links to be able to easily
catch them if needed.
closesodoo/odoo#45813
Taskid: 2180574
Related: odoo/enterprise#8601
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When we are using auto_print without iot box, the 'print()' function on
window is called, and if we are validating a invoiced order, the
download of invoice will let a blockUI over the receipt screen.
To avoid printing 'Loading' on the receipts, we are not displaying the
blockUI when we print, as it is never expected.
OPW-2199489
closesodoo/odoo#46528
X-original-commit: 54a3ef53e94a756c8635b708b9f187aefc8c5c8b
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Make the domain to match assets attachment more robust to avoid
deleting wrong files.
closesodoo/odoo#46523
X-original-commit: c92d63fa5baf09cb0969fcf4fbd5c28407af58ae
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Hide the date_invoice_timesheet field if 'down payment' is selected.
closesodoo/odoo#46265
Taskid: 2203363
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When a user is created, its partner_id shall not have any company_id.
A test has been added to check that in 'base/test'.
Update test_mail tests by setting a company to partner_id linked to users
as now, by default the partner linked to a new user has no company_id.
closes odoo/odoo#46515
Task: 2198688
Forward-port-of: #45900
X-original-commit: 187b12fc5715721efdd9af283e086dfc3f856fc2
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Since we now use native promises, the code in charge of alerting the
user of bundle compilation errors was opening both an alert and a
dialog (fwp of https://github.com/odoo/odoo/pull/46437).
In 13.0, the mention fwp is not enough. On the website, the JS is also
lazy loaded now so we need to wait for that lazy loading before being
able to open a modal.
The whole alerting code should be improved to not be defined in python.
Fixes https://github.com/odoo/odoo/issues/45447closesodoo/odoo#46482
X-original-commit: d5a2469b1edd0d22b366b44086d08c6f0b2247b2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
[IMP] sale_timesheet: add domain on sales order field
==========================================
A domain has been added to the Sales Order field
on project task so that the task and the so have the same
commercial_partner_id.
[IMP] sale: add kanban view for sale.order.line for better display on mobile
=========================================================
For a SO line on mobile it was displaying only the name of the line without
the SO number. It wasn't very practical for the users so we added this view
to display the display_name instead.
[IMP] web: change the default name of a column in kanban view
=================================================
This changes the name of the column in kanban view when the records
are grouped by date. The column name of the records with no date
went from false to Undefined.
Task-2188831
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#45646
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This changes the name of the column in kanban view when the records
are grouped by date. The column name of the records with no date
went from false to Undefined.
Task-2188831
Co-authored-by: jdoutreloux <jud@odoo.com>
A domain has been added to the Sales Order field
on project task so that the task and the so have the same
commercial_partner_id.
Task-2188831
Co-authored-by: jdoutreloux <jud@odoo.com>
For a SO line on mobile it was displaying only the name of the line without
the SO number. It wasn't very practical for the users so we added this view
to display the display_name instead.
Task-2188831
Co-authored-by: jdoutreloux <jud@odoo.com>
The 'name' field (Description) has been removed from the 'group by' definition in the allocation search view
because this is useless to group by this field as each value will be different from the others.
closesodoo/odoo#46478
X-original-commit: 2f6abba160b5e2dac73ba2c56dcb139d10f20273
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This issue was introduced with commit 251b880de1caeeef1f27447d4ad69e1abeffde19 : in case current user has no langage,
we should have a fallback case by retrieving the first langage installed in the database.
closesodoo/odoo#46487
X-original-commit: 67cf1150507b8092c32bf745e4c8620409fdc238
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
Reduce margin from o_portal_chatter_message_title (from 0.5 to 0.2rem)
Remove margin from the last line of the comment.
When you write a comment (not from demo data), each line become a paragraph
(which one have big bottom margin). After the comment you have a button
'comment' that is so far, that you don't know if you comment the previous
message, or the next one.
The css selector is precise, because you can have another p in the reply with
the class 'o_portal_chatter_puslished_date' that we don't want to impact.
(In case of none real comment with p inside, it become the last one)
Only the padding under the last p could be considered (fp & sbu) as bugged,
so we fixes it in css. Other pixel touch, required an update to got it.
task-2206171
closesodoo/odoo#46456
X-original-commit: 92ae84c132f3fb2dcf5364fd0e0e58edb04e894d
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
On crop dialog save, the image src is set to the base64.
We are creating an attachment for the cropped image if the user save the changes
and after that, we set the newly created image as the src of that image.
Meanwhile, when the user save the 'html' field, it is not creating
any attachment for the cropped image and also it leaves base64 as it is.
Due to that field store large data into the database.
this commit makes sure that attachment is created for cropped images
and update src before storing field value to the database.
closesodoo/odoo#46455
X-original-commit: 2bcaa25e67260e3013d4400d1b3ce380ba5cbd1d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Issue
- Install Forums
- Have at least 2 forums
- Go in one of them
- Go in a topic
- Click the button "All Forums" to go back
- You go back to the forum's app homepage
This is bad for UX, I should have been redirected
to the forum's topic list.
Cause
This behavior is not handled by Odoo.
Solution
Move All Forums in the navbar
Creating a smart "back" button based on browser history.
OPW-2198011
closesodoo/odoo#46454
X-original-commit: 307e6cd5b44b8f619a35056557f72aae241943b3
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Since formatBoolean returns a jQuery object, boolean fields were
displayed as [Object object] in pivot view.
so fix the issue of checkbox in the pivot view by not calling
fromatValue for boolean instead just set the checkbox element in
in template itself and added test case for checkbox in pivot view.
closes odoo/odoo#46445
Taskid: 2172258
Closes: #44299
X-original-commit: d7d0caf6f599f313687c958c5aff5764c0d23ffd
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
In address block there is extra space between label and field
so added class o_td_label with o_form_label in span tag
Wrong hover title on create company button when company_name is set
so direct use icon attrs instead of span
closes odoo/odoo#44695
Taskid: 2182637
Closes: #44695
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Create a demo fiscal position with automatic detection enabled and
country group assigned (ex. Europe).
Create a new Vendor with such fiscal position assigned.
Create a product in which the product category has an account which can
be mapped with the demo fiscal position
Create a new Vendor Bill, select the partner, create an invoice line,
fill in the product: no fiscal position will apply
In the process of auto detecting fiscal position the company_id may be
enforced by the context and this would conflict when the fiscal position
company is unset. Adding a default False condition fix
the issue
opw-2192733
closesodoo/odoo#46508
X-original-commit: 57a4038554b00a487bf7b176dd780192654b136a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
The function to convert an answer to a comment was creating a new
message with the create_uid of the current user instead of the original
poster, therefore creating a mismatch between the create_uid and the
user of the message author.
Since the template 'website_forum.author_box' was designed to work with
different objects (mail.message & forum.post), it displays the
information of the object.create_uid which is not the correct user in
this case.
This commit ensures that we create the message with the correct user to
avoid the mismatch.
closesodoo/odoo#46486
X-original-commit: 20800955257c4f871cc21f8e21cd22c1a3b0fe9f
Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
The signature of method Component.__patch has changed in the last
version of owl.
closesodoo/odoo#46499
X-original-commit: 2954aa3ecd235d5ed6f537be21882390e8fcb808
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit updates owl from v1.0.4 to v1.0.5.
This last version fixes an issue in the home menu (enterprise).
Issue's task: 2196878
X-original-commit: cce932b9179c5acb6845b895b04312c937f8de96
This allows detailed reporting in write overrides.
Expl:
When (un)archiving multiple records together (from a view list, or in batch call),
you will only see one record at a time in `write` overrides. This means you
won't be able to return meaningful and complete messages to the end user.
Before:
1) Archive A & B
2) "You cannot archive A"
3) Archive B
4) "You cannot archive B"
After:
1) Archive A & B
2) "You cannot archive A & B"
closesodoo/odoo#46358
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
PURPOSE
Improve layouts and usability for the host screens when using survey sessions.
We focus on the "host" screens, as the attendee screen is based on regular
survey flows/design.
SPECS
In short: copy mentimeter "wow effect".
Main points:
- Remove the "question" container (keep only "Results/Ranking")
- Remove the tabs concept, views are displayed in full screen
- Purpose is to have a "clean view"
- The display must be "full screen" with only relevant info
- Enable a easy keyboard navigation with left/right keyboard arrows
and spacebar
- Switching from results to ranking to next question is always linear
(next/previous instead of tabs)
- Improve charts
- Remove the pie chart : make bar charts instead for simple / multiple
choices
- Show the chart results "as people answer to it"
Only if question is not scored, otherwise show when all answers are
received / when user goes to "next"
- For free text/date/datetime: show small bubbles with attendees answers
- Add resize, fade in/out, ... animations for "wow effect"
LINKS
PR #45111
Upgrade PR odoo/upgrade#774
Task 2191924
Related: odoo/upgrade#774
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit improves the answers count in the context of survey sessions as
well as displayed answers to narrow them down to the "current session".
We simply use a custom domain to consider all user_inputs and user_input_lines
that have a create_date after the start of the session.
It will help users to be able to re-use the same survey multiple times and run
different sessions without having to duplicate the survey every time.
LINKS
PR #45111
Task 2191924
PURPOSE
Improve layouts and usability for the host screens when using survey sessions.
We focus on the "host" screens, as the attendee screen is based on regular
survey flows/design.
SPECS
In short: copy mentimeter "wow effect".
Main points:
- Remove the "question" container (keep only "Results/Ranking")
- Remove the tabs concept, views are displayed in full screen
- Purpose is to have a "clean view"
- The display must be "full screen" with only relevant info
- Enable a easy keyboard navigation with left/right keyboard arrows
and spacebar
- Switching from results to ranking to next question is always linear
(next/previous instead of tabs)
- Improve charts
- Remove the pie chart : make bar charts instead for simple / multiple
choices
- Show the chart results "as people answer to it"
Only if question is not scored, otherwise show when all answers are
received / when user goes to "next"
- For free text/date/datetime: show small bubbles with attendees answers
- Add resize, fade in/out, ... animations for "wow effect"
LINKS
PR #45111
Upgrade PR odoo/upgrade#774
Task 2191924
This commit adds a chartjs 'datalabel' plugin in the survey module.
It is a preparation commit for the general layout improvement of the survey
'live' session feature.
Task 2191924
PR #45111
svs-odoo