Commit Graph
166066 Commits
Author SHA1 Message Date
Gabriel de Paula Felix (gdpf) a4eaeb1bcb [FIX] microsoft_calendar: add security xml file to manifest
Before this commit, the security XML file of microsoft_calendar module was not added in manifest, ignoring rules previously defined there. After this commit, the security XML file is now properly added.

Issue from task-id: 3410651

closes odoo/odoo#138397

Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
2023-10-11 20:21:46 +00:00
Walid ad0555abbe [FIX] mrp: End date with lead time
Steps to reproduce:
- Enable manufacturing lead times in settings
- Create a BOM for product P with lead time 5 days
- Create and process an MO for product P
- End date is wrong
(add date_finished to the MO list view to check)

Bug:
when marking MO as done the end date is correctly set as today
but during the write the compute is triggered which delays it by
the lead time

Fix:
do not modify the end date of done MOs

opw-3536069

closes odoo/odoo#138431

X-original-commit: baa769a56a1236ec75a6042c56643464c2aabd3d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
2023-10-11 18:03:35 +00:00
vava-odoo 7202a632ca [FIX] sale: fix filter domain
Typo from commit: https://github.com/odoo/odoo/commit/216fa84fbe2c

closes odoo/odoo#138430

X-original-commit: 64ddd715af26efb2763bb255132f058036e0038e
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
2023-10-11 18:03:34 +00:00
hupo-odoo 211ad76fb0 [IMP] account: Change table title for VAT details
When issuing an invoice in foreign currency, a detailed table with the vat amounts in company currency is displayed. The table title was "Tax computation in XXX" and the translation was not optimal in other languages, for example French: "Calcul de la taxe dans EUR". We simplify the title to "Taxes XXX", with XXX being the currency code.

task-3501390

closes odoo/odoo#138429

X-original-commit: 99d408bbbc696e3ca139b6a1a14279fc13fa7f89
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
2023-10-11 18:03:33 +00:00
Nicolas Viseur (vin) dfd59627d2 [FIX] account: position of tax edit pencil on bills
The commit https://github.com/odoo/odoo/pull/128376 fixed an issue related to rtl languages,
but at the cost of the pencil position.
By making the span containing the value a display: block the pencil could no longer be placed
on the side of the value and was instead pushed on top.

This small fix will just place the pencil inside the span, in order to get it back aside the amount.

Task id # 3548687

closes odoo/odoo#138408

X-original-commit: 718fe9396aebec1c0a15c5064202f6350cdf346a
Signed-off-by: William André (wan) <wan@odoo.com>
2023-10-11 18:03:31 +00:00
Odoo 119771caa7 [FIX] web_editor: should be able to remove nested quote blocks (i.e. in a table)
Before this commit:

When a new element is added in a nested form i.e. inside a table <td>[]</td>
or inside a nested list, it is not deleted on immediate backspace.

After this commit:

When a new element is added in a nested form i.e. inside a table <td>[]</td>
or inside a nested list, it is now deleted on immediate backspace.

task-3339625

closes odoo/odoo#138382

X-original-commit: 263b8b4e2ff622f25dedef078e7d99c94c8f04b3
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2023-10-11 18:03:30 +00:00
oco-odoo ffa1979f7d [IMP] account: introduce sum_children keyword in aggregations
It is now possible for aggregations to be defined with the formula 'sum_children'. An expression using this formula will take all the expressions with the same label, belonging to child lines of the line this expression belongs to, and will sum their values. This is done as an improvement in stable, as this feature is needed for a cleaner upgrade of custom-made tax reports from 15.0 to 16.0, since the former tax report engine used to behave like that by default (no formula meant you had to sum the children).

Task 3499260

closes odoo/odoo#138358

X-original-commit: 276142f899e9050ccd39f52c502e6529bbaa0493
Related: odoo/enterprise#48784
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2023-10-11 18:03:26 +00:00
niyasraphy dd6cd1a82f [FIX] base: traceback after enabling profiling
before this commit, if profiling is enabled in the db,
and on trying to validate a sale order, a traceback is
shown

* enable profiling
* confirm a quotation

traceback:
Failed to render QWeb template : <div style="margin: 0px;
padding: 0px;">
    <p style="margin: 0px; padding: 0px; font-size: 13px;">

introduced in: https://github.com/odoo/odoo/commit/016f26a9315c693bdeb894725898c2cf725d8989

here the options['ref'] is coming as the email template
body and it is failing on try to do int of options['ref']

after this commit, no traceback wont be shown on
confirming sale order, when profiling is enabled

closes odoo/odoo#138357

X-original-commit: 01548aff72b031389a7563948bb12bc3abb07bfc
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
2023-10-11 18:03:25 +00:00
zel-odoo 37381a5cf0 [FIX] mail: missing dependency for icon in public
The right arrow icon on the public page relies on odoo-ui.
Currently, this file is not correctly imported into the public bundle, since
the icon is not showing.

This fix is to import the essential file into the public bundle.

closes odoo/odoo#138354

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-11 18:03:24 +00:00
Julien Van Roy 484ab5dfcb [FIX] account_edi_ubl_cii: fix peppol fields computes & update BE EAS
Replace every mentions of 9925 to 0208 for Belgian companies (public
administration also have this 10 digits number). The EAS 0208
corresponds to the company_registry.

Introduce a mechanism to validate the `peppol_endpoint` and refactor the
computes for the `peppol_endpoint` and `peppol_eas` fields.

See: https://openpeppol.atlassian.net/wiki/spaces/Belgium/overview

task-3297311

closes odoo/odoo#138343

X-original-commit: 744bfa9e5f087a2aa9d714351a559c3320ecfda4
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Julien Van Roy (juvr) <juvr@odoo.com>
2023-10-11 18:03:22 +00:00
Adrien Guilliams (adgu) 08a561d588 [IMP] pos_self_order, website_sale: add info popup to product card in self
This commit introduce the information button on the product card in the
self order mode. This button open a popup with the newly created field
"description_self_order" which is an HTML field allowing the user to
have a very customizable description for the product.

It also removes the description_ecommerce field from the product view
form as it is a field used in the website and not adapted for
the backend (css/js not compatible).

closes odoo/odoo#138216

Task-id: 3512835
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
2023-10-11 17:02:15 +00:00
Thibault Delavallée 84e2d6ea55 [REF] mail: remove 'alias_user_id'
'alias_user_id' field allows to set a user when creating records through the
mail gateway. This is however quite wrong and eases spoofing. The alias owner
is not the creator of any record, nor responsible.

Current possible ways of being owner / responsible of records created through
the mailgateway

  * when you send an email to an alias: if you are recognized you are already
    set as creating user and logged message author;
  * it is possible to use alias_defaults notably to set fields like 'user_id'
    if you want to be notified / responsible of records created through this
    specific alias;

Those usages are therefore sufficient, no need to have another way to spoof
users. Moreover it is hidden in technical view of aliases, no model allows
to configure it by default. Moreover since odoo/odoo@3edf181 no default
value is given to alias_user_id as it adds more (ACLs / creator) issues than
really helping setting up mail gateway flows.

Task-3453482
Prepares Task-36879 (Mail: Multi-Domain Aliases)

closes odoo/odoo#138213

Related: odoo/upgrade#5259
Related: odoo/enterprise#48692
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-10-11 17:02:14 +00:00
zel-odoo dea14bcd27 [FIX] mail: no duplicate content on message of type email
Fix the duplicate message in the discuss and search
when the message type is email. This was caused by a wrong
rebase of https://github.com/odoo/odoo/pull/118794 that
did not take into account the branching on message body
for message of type email by https://github.com/odoo/odoo/pull/131202

The search highlight feature was not working on these email
message, so this commit also fixes that.

closes odoo/odoo#138205

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-10-11 17:02:11 +00:00
Lucas Lefèvre (lul) 8600d5d363 [IMP] spreadsheet: update o_spreadsheet to latest version
### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/4dc340fc [REL] 16.5.0-alpha.10
https://github.com/odoo/o-spreadsheet/commit/c6e5d58e [IMP] dates: cache date parsing
https://github.com/odoo/o-spreadsheet/commit/38e44577 [IMP] range: don't spend time building a zone
https://github.com/odoo/o-spreadsheet/commit/7e491948 [IMP] cell: faster formula string
https://github.com/odoo/o-spreadsheet/commit/d6a498b4 [FIX] evaluation: don't build formula content for errors
https://github.com/odoo/o-spreadsheet/commit/5e2a7640 [IMP] evaluation: don't create useless Errors
https://github.com/odoo/o-spreadsheet/commit/d5ff0843 [IMP] Composer: highlight fuzzy matched letters in autocomplete dropdown
https://github.com/odoo/o-spreadsheet/commit/3562883e [IMP] Composer: always sort autocomplete elements
https://github.com/odoo/o-spreadsheet/commit/e8d76dd3 [IMP] Composer: Select autocomplete results on mouseover Task: 3387413
https://github.com/odoo/o-spreadsheet/commit/b6dc8877 [IMP] evaluation: don't spend time building formula string
https://github.com/odoo/o-spreadsheet/commit/078e888d [FIX] evaluation: compute cell only once

closes odoo/odoo#138145

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-10-11 17:02:10 +00:00
Pierre Pulinckx (pipu) 13b3f8af4b [REF] website, mass_mailing: remove getBundle usages
In this commit, we remove three usages of the getBundle function from
@web/core/assets.js. The final goal is to remove it totally to simplify
the understanding of assets's API. To replace the use of getBundle in
mobile preview dialog, an xml template has been created on the server
side and then called by http requests. During the request, we retrieve
the list of assets (server side getbundle) to inject these into
the xml template.

taskId : 3266441

closes odoo/odoo#138055

Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
2023-10-11 17:02:09 +00:00
Michael (mcm) d84fd5274b [FIX] website: fix autocompleteWithPages option
Since the PR [1], the function autocompleteWithPages does not receive
a widget anymore and does not trigger an event on it when an url is
selected. Instead it is replaced by an optional function property
"urlChosen" which is called if given.
The error is that the optional check is wrong. The check is done on
the "options" parameter, not on its optional property "urlChosen".
This commit simply fixes this check.

[1]: https://github.com/odoo/odoo/pull/136271

closes odoo/odoo#138047

Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
2023-10-11 17:02:08 +00:00
Michael (mcm) 7ebd785764 [IMP] *: rename quick_add into quick_create
This commit renames calendar's attribute quick_add to quick_create
to be more consistent with other views.

closes odoo/odoo#138042

Related: odoo/enterprise#48677
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2023-10-11 17:02:07 +00:00
Michael (mcm) 3846472e96 [REF] web,calendar: split calendar quick_add attr
Since the PR [1], quick_add can be both a boolean and an id:
0 = without quick create
1 = with quick create and simple dialog
other number = with quick create and custom form view dialog

This is not great to have both behavior in a same attribute so this
commit split them back in two attributes as it was before [1].
It's easier to understand when we want a quick create and which view
to use in the dialog.

[1]: https://github.com/odoo/odoo/pull/122923

Part-of: odoo/odoo#138042
2023-10-11 17:02:07 +00:00
Rob Coekaerts d3472415dd [IMP] hr: ad default searchpanel filter on act_employee_from_department
Before this commit, when redirecting to the employee list view from a
specific department, all the employees of all departments were shown.
With this commit, that list view has a default searchpanel filter of the
currently active department, making the flow more intuitive.

task-3539205

closes odoo/odoo#137862

X-original-commit: 81b72301c68fa3bffc91691540a3e4b00bc7de0a
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2023-10-11 17:02:04 +00:00
Joseph Caburnay d6c42bba00 [FIX] pos_self_order,*: modifying the splash screen images
**Steps to reproduce**

- Open general settings of pos.
- Select/Create a Point of Sale that is kiosk to see the `Splash screens` field.
  - The field is pre-filled with 3 images.
- ISSUE: Try removing the images and save, they won't be removed.

**FIX**

- This is because of the `write` operation made from the `res.config.settings`
  model to the `pos.config`.
  - When removing an image, the field will be given `link` commands, linking the
    remaining images. This is wrong because it won't unlink the images that are
    deleted.

- To ensure the deletion, we reinterpret the command to the splash screen images
  field if the command comes from the res.config.settings.
  - We introduce a context called 'from_settings_view' such that it's set to
    true when the write is from the `res.config.settings` view.
  - And specific to the pos_self_order, we compute the items that should be
    unlinked and we append the unlink commands to the original set of commands
    for the splash screen field.

closes odoo/odoo#137819

Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
2023-10-11 17:02:03 +00:00
Odoo's Mergebot 47651d6c6b [MERGE] base, event: "add properties" is now default, add properties to event
### 1. Move "Add Properties" button to cog menu by default
When the property field is added into a form view, the "add a property"
button is shown by default.
However, most of the time the users won't add properties when opening a
form view, making this button take up space for nothing.

To alleviate this issue, [this commit](https://github.com/odoo/odoo/commit/1f80810e39f811122a65e11cd8cac99aa39a7960) added an option that allows to hide
this button, and added actions to allow adding properties from the cog
menu instead.

Now that properties are being added into several views, one would like
this "add properties" button to be hidden by default, and show an entry
in the cogmenu allowing add properties by default, without needing to
create an action for every view using a property field.
Therefore, a new static action "Add Properties" has been added in form
controller that is available if a properties field has been encountered
during the parsing of the form view's arch.

The "hideAddButton" has been changed into "showAddButton" and now allows
to show the "Add a Property" by default.

### 2. Add properties (and related properties definitions) on the following models:
- analytic.account (analytic.plan)
- event.registration (event.event)
- hr.employee (hr.res_company)
- hr_recruitment.hr_applicant (hr_recruitment.hr_job)
- product.product (product.category)
- sale.sale_order (sale.crm_team)
- stock.picking (stock.picking_type)

Task-3458627

closes odoo/odoo#137589

Related: odoo/enterprise#48404
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-10-11 17:02:02 +00:00
Adrien Schoffeniels d245e87d5e [IMP] event: add properties fields
Purpose:
--------

This commit adds properties (and related properties definitions) on the
event model. Event stores the definition and it is used on its child
registrations.

Task-3458627

Part-of: odoo/odoo#137589
2023-10-11 17:02:02 +00:00
Adrien Schoffeniels 2d7a49dab1 [IMP] web: move properties field's "add a property" btn in the cog menu
Purpose:
--------
When the property field is added into a form view, the "add a property"
button is shown by default.
However, most of the time the users won't add properties when opening a
form view, making this button take up space for nothing.

To alleviate this issue, commit [1] added an option that allows to hide
this button, and added actions to allow adding properties from the cog
menu instead.

Now that properties are being added into several views, one would like
this "add properties" button to be hidden by default, and show an entry
in the cogmenu allowing add properties by default, without needing to
create an action for every view using a property field.
Therefore, a new static action "Add Properties" has been added in the form
controller that is available if a properties field has been encountered
during the parsing of the form view's arch.

The "hideAddButton" has been changed into "showAddButton" and now allows
to show the "Add a Property" by default.

Task-3458627

[1]: https://github.com/odoo/odoo/commit/1f80810e39f811122a65e11cd8cac99aa39a7960

Part-of: odoo/odoo#137589
2023-10-11 17:02:02 +00:00
Dylan Kiss (dyki) 5801ec664d [IMP] account{_peppol}: allow install via settings
Currently it is not easily discoverable that users can install the
PEPPOL module. They have to go to the Apps list and search for PEPPOL
there.

In order to make the installation easy and discoverable, we added a
checkbox to the Invoicing/Accounting settings to install the module and
afterwards show the checkbox to enable PEPPOL per company.

The install checkbox is only shown when editing the settings of a
company that is eligible for PEPPOL to avoid confusion. In order to do
that, we created a `PEPPOL_LIST` variable in `account` containing all
countries currently allowed to use PEPPOL. The code in `account_peppol`
formerly using the `EAS_MAPPING` variable of the `account_edi_ubl_cii`
module is now also using this new list.

task-3519564

closes odoo/odoo#137287

Signed-off-by: Laurent Smet (las) <las@odoo.com>
2023-10-11 17:02:00 +00:00
sofiagvaladze 0525c5b847 [FIX] hr_skills_survey: UX changes
Prior to this commit the required employee field was hidden
on hr.resume.line form view. Which lead to validation error.

Moreover, on the same form view, on create the survey_id field was not
certification by default. The survey_id field has the
domain [('certification', '=', True)] on this view and this caused
inconsistency. The survey that we created from this form, was
not listed as one of the options.

After this commit the employee_id field is shown on hr.resume.line
form view and the survey_id, created from this view, will be
certification by default.

task-3522917

closes odoo/odoo#136751

Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
2023-10-11 17:01:59 +00:00
vlst fb27d2b97e [ADD] l10n_es_pos: Spanish localization for POS
In Spain it's mandatory that POS systems generate a so called
"Factura simplificada". This is similar to a regular ticket
but has to comply with some special requirements.
Without this, POS isn't usable in Spain.

In this PR we introduce a spanish localisation for the pos
that handles the specific regulatory needs.

closes odoo/odoo#136008

Task: 3131769
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
2023-10-11 17:01:58 +00:00
Lucas Lefèvre (lul) aa118d7dc0 [IMP] spreadsheet_dashboard_edition: load dashboard with user locale
Currently, spreadsheet dashboards always display numbers with the en_US
format, no matter the user's lang.

That's because the locale is hardcoded in the spreadsheet source file, in
the source code (or it falls back to the default en_US locale if it's missing).

With this commit, we dynamically change the spreadsheet locale with the user's
locale when he loads a dashboard.

We can change the locale with every user because the dashboard is readonly.
It cannot create a giant mess with dates in various locales.

Limitation
----------
Since hardcoded date formats are not changed when the locale changes, dates
will keep the en_US format. However, most (if not all) dates in dashboards
are coming from ODOO.PIVOT and ODOO.LIST functions, which compute the formats
dynamically based on the current locale.

closes odoo/odoo#135119

Task: 3484002
Related: odoo/enterprise#47284
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-10-11 17:01:57 +00:00
Laurent Smet b99c147b63 [FIX] account: Use payment rate in reconciliation
In the specific case in which an invoice in company currency is paid by a payment in foreign currency,
in that case, perform the reconciliation in foreign currency but convert the residual amount of the invoice
to the foreign currency using the payment rate instead of the invoice one.

closes odoo/odoo#138289

X-original-commit: 2123278215befe22d3be4568812bfe7d028e2757
Related: odoo/enterprise#48744
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Laurent Smet (las) <las@odoo.com>
2023-10-11 15:45:31 +00:00
Antoine (ande)andThibault Delavallée 71eb903d59 [FIX] mail: issue when creating nameless contact
Current behaviour:
When creating a nameless contact,
while selecting delivery address type
for an existing company, there is a traceback

Steps to reproduce:
1. Install contacts,sale_management,crm
2. Settings > Sales > Quotations & Orders
3. Check "Customer Addresses"
4. Go to Contacts
5. Create a new contact
6. Check "individual"
7. Select a company
8. Select "Delivery" in Address type
9. Save => traceback

Cause of the issue:
Introduced by https://github.com/odoo/odoo/commit/9ef715fb994564af9e933ba31933a09eca97c24f
partner.name can be False

opw-3495748

closes odoo/odoo#138312

X-original-commit: baa731ac37818bcffcd7814b92456b37b8a97c61
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Antoine Demany (ande) <ande@odoo.com>
Co-authored-by: Thibault Delavallée <tde@odoo.com>
2023-10-11 12:08:59 +00:00
Pedro M. Baeza 3376ff9f0a [FIX] hr_holidays: Allow to duplicate refused/cancelled leaves
There's no reason to forbid the duplication of leaves that are refused
or cancelled, as the overlap check are excluding them.

This way, we allow an exit flow for users with "Time Off / All approver"
group, as once the holiday is refused, they can't back it to draft (only
administrators can do it). A usual need for these intermediates users
with people in their charge is to modify the leaves to extend or shorten
the initial asked period (for example, more/less paid time-off due to
varying workloads, or extended period by long disease).

Thus, they can duplicate the leave and use it as base for the new
period, only changing the end date without having to input all data.

TT44801

closes odoo/odoo#138303

X-original-commit: abfb21096b76a04fe167be28243187f64522c422
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
2023-10-11 12:08:58 +00:00
ravb-odoo b895fae4b2 [FIX] website: resolving traceback Issue when creating Tasks/Tickets
Issue:
A traceback error was observed when attempting to create a task or ticket using
 the website form.

Cause:
This issue arise as a result of converting RPC  to ORM  readSearch. The problem
lay in the domain being passed to the ORM. Not all fields had a defined domain,
causing 'undefined' to be passed to the ORM, leading to the traceback error.

Fix:
To address this, we have introduced an 'or' condition within the domain. Now, if
a field has a domain, it will be passed accordingly; otherwise, an empty array
is set as the domain. This modification resolves the traceback issue.

Task-3526887

closes odoo/odoo#137359

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2023-10-11 09:29:46 +00:00
Claire Bretton (clbr) 1c7dd1f01e [FIX] account: Send & Print should not be used on draft invoices
The Send/Send & Print button is accessible in list view, the wizard
should raise an error if it is opened with invoices in "draft" state.

closes odoo/odoo#138311

X-original-commit: cbc0972bb3eaddf88131b0153f364d1a65d0a968
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
2023-10-11 08:18:56 +00:00
Walid HANNICHE (waha) 52653a9d05 [FIX] sale_purchase: service product preserve variant
Steps to reproduce:
-Install sale_purchase_stock and sale_product_matrix
-Have a Service product that is subcontracted.
-Set a variant with a Specification Attribute that has a custom value.
-Create a sales order with the Service product,
add anything for the specification in the variant.
-Confirm the order, this generates a PO.

Bug:
The PO line only says the name of the product,
and doesn't include the specification in the variant.

Fix:
propagate the description same as:
"_prepare_procurement_values" and "_prepare_purchase_order_line_from_procurement"

opw-3438125

closes odoo/odoo#138310

X-original-commit: 5b3bcee8f7308621608d91e33bac808586e8c17f
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
2023-10-11 08:18:55 +00:00
Levi Siuzdak (sile) 33eb1b0fc2 [FIX] account: hide payment term placeholder on invoice
Versions:
---------
- saas-16.4+

Steps to reproduce:
-------------------
1. create a customer invoice;
2. set customer to be a person (not a company);
3. set a due date instead of payment terms;
4. click preview.

Issue:
------
The invoice will say "Payment within 30 calendar days" regardless of due
date selected.

Cause:
------
This is a placeholder string for a `t-field` that should be hidden when
viewing actual records.

Solution:
---------
Add `t-if="o.invoice_payment_term_id.note"` to the element so it won't
get rendered if there are no payment terms to be displayed.

opw-3523921

closes odoo/odoo#138275

X-original-commit: 1e729a0f1de87335a2c4517bb815bc5ab7d4bd01
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Levi Siuzdak <sile@odoo.com>
2023-10-11 08:18:53 +00:00
guva-odoo 963b8c4fe7 [FIX] account: journal dashboard with sub companies
When having a company with sub company.ies, if
we select only one of the branch, the number
of entries to reconcile is not reflected only
the entries from the selected branch but the one
from all the branches, therefore when opening the
reconciliation widget, the number of line to reconcile
is not the same as indicated.

With this commit, we only count the entries that belong
to the selected company.

Steps:

- Having a company with one branch (X and X.1)
- Having 1 statement line for X and 2 for X.1
- Select the two branches
- See that there are 3 entries to reconcile
  indicated on the bank journal
- Select X or X.1 only
-> There are still 3 entries to reconcile
   indicated instead of 1 for X and 2 for X.1

closes odoo/odoo#138257

X-original-commit: 023c97c21194e83eda2433e2fe3c32de1d3b320b
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>
2023-10-11 08:18:52 +00:00
Vraj Panchal 8852dc2fb9 [FIX] mrp: update workcenter with BOM
Before this commit
=================
While updating the Bill of Materials (BOM), the work center and operation name
remained unchanged in the manufacturing order.
When Archiving/Unarchiving the operation doesn't show the "Update BoM" button
in the appropriate MO.

Steps to Produce
================
- Create a BOM1 with operations
- Create a MO with BOM1 and confirm MO
- Goto BOM and change the workcenter and operation name
- In MO Click on the 'update BoM' button
- Now you see the operation name and workcenter are not updated in MO

After this commit
=================
With this commit the work center and operation name get updated with the update
BOM click. For Archiving/Unarchiving the operation results to the display of
the "Update BoM" button in the appropriate MO. Directly editing an
operation will also cause the "Update BoM" button to appear

task-3461985

closes odoo/odoo#138256

X-original-commit: c343ebf0a28f6404f7ad6fc892c4a42edd2bbbe0
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
2023-10-11 08:18:51 +00:00
Martin Trigaux 75858d3509 [IMP] *: use correct indentation in manifest summary
The summary is a short char field. It should not contain carriage
returns.
The description is the longer text field.
Remove unnecessary spaces in both.

Automatically dedent the description to avoid this issue poping up
again in future modules.

closes odoo/odoo#138214

Related: odoo/enterprise#48695
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2023-10-11 08:18:49 +00:00
Aaron Bohy dc2be03dba [IMP] web,*: lazy load jSignature lib and extension
The jSignature lib is only used by the NameAndSignature component,
which is not accessible on a many screens. This commit thus
removes the lib and its extension from the bundles, and makes the
NameAndSignature component load it on demand.

Part of task~3439226

closes odoo/odoo#138054

Related: odoo/enterprise#48633
Signed-off-by: Samuel Degueldre (sad) <sad@odoo.com>
2023-10-11 08:18:46 +00:00
Aaron Bohy 4bf1384e8b [REF] web,sale,portal: adapt SignatureForm to owl
This commit converts the SignatureForm widget into a Component.
This allows to remove the last usage of the legacy NameAndSignature
widget, which we thus remove.

Part of task~3439226

Part-of: odoo/odoo#138054
2023-10-11 08:18:46 +00:00
Aaron Bohy 634409188c [IMP] web: url utils: add redirect function
This function must be used to safely redirect to another url. It
ensures that we stay on the same origin, and thus that the url is
safe.

Part-of: odoo/odoo#138054
2023-10-11 08:18:46 +00:00
Damien Bouvy 7470797be7 [IMP] base,**: rewrite some error messages
Maintain the playful tone whilst avoiding nonsensical phrasing.

I will not take comment at this time, thank you.

Task-🤔🙃😬💅😐🤓

closes odoo/odoo#138302

Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
2023-10-11 06:59:49 +00:00
suresh badikala b04fc2fa5a [FIX] im_livechat: fix customer ratings open wrong form view
Steps:
- Install project and live chart applications
- In project reporting then
- Customer ratings
- Click on kanban card, task form view open

Issue:
- When we click on a Kanban card, it opens the 'project.task' form view instead
of the 'rating.rating' form view

Cause:
- This problem occurs when you install the 'Live Chat' application because,
in the 'Live Chat' application, they inherit the Kanban view from the 'rating'
module and insert some actions into the inherited view. This action affects
other modules where customer ratings are required, such as the project module
and others.

Fix:
-By creating a separate view for the Live Chat customer ratings,
the problem can be solved

task-3522178

closes odoo/odoo#138276

X-original-commit: f50e6dbbd46bf0d16c8f522d4f1d9b10445d1065
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
2023-10-11 04:48:51 +00:00
Pablo Montenegro 2f53d82d41 [IMP] l10n_ar: invoice report contact partner
Ticket Adhoc: 65383

closes odoo/odoo#138298

X-original-commit: d2cd7c4e8dfd1bc72d2500316ebf63fc28332f25
Signed-off-by: Josse Colpaert <jco@odoo.com>
2023-10-10 20:46:36 +00:00
Valentin Vallaeys (vava) 5188566444 [FIX] sale_loyalty: prevent partial reward with loyalty points
Before this commit, when using a loyalty reward with points, it is
possible to give partial rewards. This commit prevents partial rewards.

Example:
- Rule: Grant 1 point per product bought;
- Reward: 1.5$ per point in exchange of 2 points (3$)

Before this commit, if you buy 3 products, you get 4.5$ by using 3
points. After, you only use 2 points and get 3$ (no partial reward).

task-3300880

closes odoo/odoo#138277

X-original-commit: b3a2fb51bc48b83e821648b40f0dc7d86369ca7c
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
2023-10-10 19:34:06 +00:00
Paweł Fertyk d66ad74180 [FIX] product: fix duplicated barcode test
closes odoo/odoo#138217

Task: 3290154
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2023-10-10 18:31:05 +00:00
Adrien Minne (adrm) c39c329d6b [IMP] spreadsheet: allow to reorder global filters
This commit allows to reorder global filters via drag and drop. The
fact that global filters have a concept of order means that the
structure of the global filters in the core plugin need to change from
an Object<string, GlobalFilter> to an Array<GlobalFilter>.

closes odoo/odoo#135869

Task: 3502684
Related: odoo/enterprise#47583
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-10-10 18:31:02 +00:00
Adrien Minne (adrm) 5063e2a1e5 [REF] spreadsheet: de-duplicate filter id in cmds
The commands `ADD_GLOBAL_FILTER` and `EDIT_GLOBAL_FILTER` had the filter id
once in cmd.id, and once in cmd.filter.id. This made it possible to send
a command with 2 different ids, which can have arbitrary behaviour depending
on the implementation details of the command.

Changed it so we only use cmd.filter.id, and removed the cmd.id field. Also
simplified the commands helpers for the tests.

Task: 3502684
Part-of: odoo/odoo#135869
2023-10-10 18:31:02 +00:00
anhe-odoo 5b29e2cd21 [IMP] spreadsheet: Allow Odoo Chart domain edition
Task Description:

This PR aims to add the possibility to edit the evaluation domain of
an Odoo chart, the same way it can currently be done for other
datasources like `List` or `Pivot`. This revision ensures that the chart
datasources are properly reloaded their domain update.

closes odoo/odoo#135242

Task: 3384872
Related: odoo/enterprise#47336
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2023-10-10 17:26:35 +00:00
Rémi Rahir (rar) bc15b92272 [FIX] spreadsheet: Datasource - evaluate domain on-the-fly
PR [1] introduced the evaluation of ocntextual domain. However, this was
only evaluated once at the creation of the datasource. This revision
changes the flow to evaluate the context upon  the datasource loading.

[1] https://github.com/odoo/odoo/pull/131874

Part-of: odoo/odoo#135242
2023-10-10 17:26:35 +00:00
Katherine Zaoral f699071ba3 [IMP] l10n_uy: Multiple changes
* Chart of Accounts: we cleaned it, mapped it and kept the most important accounts
* Contacts: added the type of identification field and validation of the identification format
* Taxes: we kept what we had and mapped them with the correct accounts
* Added Legal document types in Uruguay.
* Valid contact identification types in Uruguay.
* Added fiscal position to auto compute taxes
* Frequently used default contacts already configured: DGI, Consumidor Final Anónimo.
* Translations: added translations for the module

closes odoo/odoo#133891

Signed-off-by: Josse Colpaert <jco@odoo.com>
2023-10-10 17:26:34 +00:00