Commit Graph
117975 Commits
Author SHA1 Message Date
Nicolas Martinelli 4a33db44b2 [FIX] account: crash if no currency in payment
- Register a payment on an invoice
- Do not set a journal, and do not set a currency
- Change the amount

It crashes.

opw-706807
2017-02-13 14:32:08 +01:00
Kinjal Mehta 9363b63a5c [IMP] sale, report: small fixes in sale onboarding 2017-02-13 14:25:42 +01:00
Nicolas Martinelli 3b42773e83 [FIX] product: crash on product search
- Go to Sales > Product Variants
- In the search field, type a letter (e.g. 'p'), then select a
  corresponding pricelist ('Public Pricelist' in demo data)

=> Crash

This is because `name_search` returns a list of tuple, not a browse
record.

Fixes #15443
2017-02-13 13:22:02 +01:00
Nicolas Lempereur 83b6b71e29 [FIX] gamification: user_domain issue with not all
The field user_domain allow to get the list of users for which a
challenge is applied. The javascript framework for a char_domain widget
sends a JSON list to the server, but the server saved it as a string in
a Char field.

Hence we can have a list (in values received by write or create) or a
string (when getting the field value of a record).

Since 0c649644db this caused an error when user_domain was not empty.

This commit solves it by having _get_challenger_users always receiving a
string.

opw-708177
2017-02-13 12:34:58 +01:00
Martin Trigaux 7c8a721a96 [FIX] point_of_sale: change the model description
a pos.order is not a point of sale, it is an order
2017-02-13 10:58:00 +01:00
Pedro M. Baeza defbe247e8 [FIX] product: method open_product_template duplicated
Introduced in 3befe66f43
Closes #15463
2017-02-13 10:39:22 +01:00
Nicolas Martinelli b5b4979dd1 [FIX] mrp: cancel raw materials procurements
To reproduce:
- Create a product A with the routes Manufacturing & Make to Order
- Create a product B with the routes Make to Order & a custom one "Move
  from Shelf 1" (see screenshot for the configuration detail)
- Create a BoM for product A which contains the component product B
- Sell product A in a SO and confirm it
- It creates a delivery order for product A, a manufacturing order for
  Product A & B and an internal transfer for product B
- The move for product B from WH/Stock/Shelf 1 to WH/Stock is indeed
  linked to the move for product B from WH/Stock to Virtual Location/Production
- Cancel the sales order
- All stock moves are cancelled, except the one related to the internal
  transfer (WH/Stock/Shelf 1 to WH/Stock)

When the manufacturing order is canceled, raw material as well as
finished moves are canceled. All procurements with finished moves as
"Destination Move" are canceled as well. However, in this use case, a
procurement has been created for a raw material.

The solution is to cancel procurements for raw materials as well, so it
cancels the internal transfer.

opw-706100
2017-02-13 09:01:10 +01:00
Nicolas Martinelli 2a08cbb8c6 [FIX] mass_mailing: Kanban crash on mobile view
In mobile view, the mass mailing kanban view crashes.

Commit eee1d8c159 aims to prevent drag and drop for mass mailing.
However, in mobile view, the the drag and dropd is by default
deactivated, and "sortable" is not initialized.

opw-708140
2017-02-13 08:53:36 +01:00
Nicolas Martinelli 7b74046200 [FIX] mail: action button translation
- Install a language other than English, set it to your user.
- On any model, send a message  (the recipient should be a user, not a
  simple portal user).
- The recipient receives a notification with a primary button half
  translated, for example "Vue Task".

When the call is performed to method `message_post`, the sessioon
context is not added to the RPC request. Therefore, when the model name
is read (method `_message_notification_recipients`), it is done in the
default language.

Note that this is the case for any RPC request using the `call` JS
function.

opw-707678
2017-02-13 08:45:27 +01:00
Odoo Translation Bot 4669c103cc [I18N] Update translation terms from Transifex 2017-02-12 04:30:17 +01:00
Odoo Translation Bot 78be4cd1de [I18N] Update translation terms from Transifex 2017-02-12 02:53:52 +01:00
Odoo Translation Bot 844916b653 [I18N] Update translation terms from Transifex 2017-02-12 00:31:19 +01:00
Fabien Pinckaers 6bfb8a1765 Merge branch 'master-automation-rem-fp' 2017-02-10 15:25:27 -08:00
Fabien Pinckaers c56b746221 [IMP] base_automation: default to write instead of python code 2017-02-10 15:22:45 -08:00
Fabien Pinckaers cbb7c2442a [IMP] base_automation: removing domains based on filters in automation
bad ux: it's difficult to understand why there is two way to do the
    same thing. (4 fields for domains, instead of 2)
    Example of confusion:
      What happens if you set both a filter and a domain?
      What happens if you change the filter? does it change the
      automation?
    The new domain widget is good enough. We don't need such extra fields.
2017-02-10 14:10:27 -08:00
Simon Lejeune f915a679fa [FIX] web: database selector and manager
The database manager and selector triggered an internal server error
according to the modules installed.

The issue is that some modules (like utm) overrode ir_http's dispatch
and openned a cursor before calling super. Following rev[1], the
database manager can tell you the incompatible databases. For that, it
opens a new cursor to each database and get back the Odoo's version.
After the information is fetched, the cursor is closed. Closing a cursor
does not release it from the connection pool, so the database cannot be
dropped and here comes the fix [2]: this commit removes all cursors to
`database` from the connection pool.

Now, if a module overrides the ir_http's dispatch and open a cursor
before calling `super`, the automatic commit/close done at the end of
a successful request cannot succeed in the database manager or
selector as the cursor is closed during the call to super, leading to
an internal server error.

To workaround this issue, we explicitely set the cursor to None, as it
will prevent the automatic commit/close at the end of the request.

This is similar to rev 5c6087e38e

[1] 96f703ff84
[2] 610036756a
2017-02-10 21:12:15 +01:00
Joren Van Onder 327b02547a [FIX] account_voucher: use currency rate at date for all amls
Without this the first account.move.line will be generated with the
currency rate valid at the time of validation. The following lines
however will be generated with the currency rate valid at 'date' of the
voucher. If these currency rates are different this results in an
unbalanced journal entry.

This ensures the first account.move.line will also use the currency rate
at 'date' of the voucher.
2017-02-10 11:43:48 -08:00
Joren Van Onder 57b4932c1c [FIX] account_voucher: set currency_id for amls in foreign currency
If not account.voucher will attempt to generate an account.move.line
record with a set amount_currency and an unset currency_id. This is
explicitly forbidden by account.move.line's _check_currency_and_amount
constraint.
2017-02-10 11:43:35 -08:00
Denis Vermylen d3703ecb4c [IMP] models: avoid searching by id in read_group
When using read_group() and grouping by many2one fields, the many2one groupby
fields get updated from an integer id to a tuple from name_get() at the end
of the method.

e.g.: {'user_id': 1, ...} -> {'user_id': (1, u'Administrator'), ...}

To do this, it reads the many2one field by browsing on self.

When self is a model with _auto = False (typically an SQL view), searching by
id can be costly as the id column may not have usual properties for performance
(in some cases a full computation of the table is required to look up 1 id).
2017-02-10 19:20:25 +01:00
Denis Vermylen 4e2ccaa054 [FIX] sales_team: dashboard display issue
Sales Group: "User: All Documents" saw half grey bottom blocks, not
matching the bottom of the graphs. Now the blocks' heights are matched.
2017-02-10 19:16:52 +01:00
Denis Vermylen 774ac2daff [FIX] sales_team: handle period=week, groupby=month
for graphs in the sales dashboard.
2017-02-10 19:16:51 +01:00
Denis Vermylen e1d609c387 [FIX] pos_sale: hide POS sales channel to non-pos users
Problem: Sales dashboard can contain a POS sales channel, but sales managers
do not have access to pos related models unless they are pos managers.

This commit hides the POS Sales Channel to non-pos managers.
2017-02-10 19:16:51 +01:00
Denis Vermylen bcc1efac48 [IMP] sale*: improve dashboard computation time
This commit improves crm.team compute methods and adds auto_join on:
payment.transaction: field sale_order_id
sale.order: field order_line

Also move the dashboard_graph_type field in invisible in the kanban view to
avoid triggering the computation of the graph when it's not needed.

DO NOT FORWARD-PORT: a different patch will be made for the master branch
2017-02-10 19:15:35 +01:00
Christophe Simonis a282d4ae7f [MERGE] forward port branch saas-14 up to be9dfb331f 2017-02-10 18:41:06 +01:00
Christophe Simonis be9dfb331f [MERGE] forward port branch 10.0 up to 9beca598d4 2017-02-10 17:33:06 +01:00
Christophe Simonis 9beca598d4 [MERGE] forward port branch saas-11 up to b5971e417f 2017-02-10 17:32:36 +01:00
Christophe Simonis 80c1d1e355 [FIX] website_forum: wait templates are loaded before binding events
This is required since a4dc9a8032
2017-02-10 16:45:34 +01:00
jpr-odoo b229e9cb8c [FIX] web_editor: Show only image tab in media dialog if field type is 'image'
Reproducible steps:

Select an icon instead of a picture -> it breaks it up
or a video, or a document. The tabs shouldn't be displayed at all.
2017-02-10 15:21:24 +01:00
jpr-odoo d1a8d54aca [IMP] website: Make company logo editable from frontend
Purpose
=======

Clicking the company logo takes to the backend's company settings. Users get lost and don't know how to go back to the website.

Specs
=====

It should be a picture selection wizard. If possible the default picture should be the company logo if already set.
2017-02-10 15:19:04 +01:00
qdp-odoo 765dd38ec1 [FIX] account: manual reconciliation wizard in batch.
Several fixes are addressed in this commit:
- displayed value of writeoff amount now give proper result accordingly to the selection (but that selection may still be wrong!). This is still not ideal but at least it reflects what users can see in the list selection.
- exclude from the reconciliation, entries that have already the boolean 'reconciled' set to True. They shouldn't be passed to reconcile() but are still needed to balance totally the reconciliation so users have to select them.
- avoid crash if no writeoff needed on batch reconcile: Even though the wizard might declare that a writeoff is needed, in batch mode it might not be the case since the reconciliation is done in multiple passes for each currency. If no write-off is needed, no write-off move is created and the code tried to add a boolean variable to a recordset and raised a fruit-salad error (mixing apples-oranges).
2017-02-10 15:03:28 +01:00
qdp-odoo 4bdf91a02d [FIX] account: fix 'Unreconciled' filter on account.move.line search view.
This revert commit 1e67069f60 and correctly fix the use case it was addressing (exclude lines with debit=credit=0 in the filter).
2017-02-10 15:03:28 +01:00
mmo 33b09d0d5e [IMP] generic: Open external links in a new tab by default
Purpose
=======

External links in the data sometimes open in the same tab, the users loses times as he has to come back (and looses the context).

Specification
=============

Any external links in data (planners, settings) should open in new tabs.
2017-02-10 14:29:29 +01:00
Parth Gajjar 3c9e6c89e7 [IMP] web_editor: improve LinkDialog widget design and usability
Specification
=============

- no boxes around fields
- use regular form style for input fields
- don't split page/URL into two fields, just do one URL field, with autocomplete
- Add alpha, beta, gamma, delta and epsilon color in color selection because they are used in mass mailing and themes also.
- Add a selection option with label "L" inside circle for link.
- Add Color selector for choosing button color
- Remov select2 page selector and used jquery autocomplete on same input
- Fix issue of page search in ir.http
2017-02-10 14:11:38 +01:00
Dhaval Panchal d3ff48533f [IMP] website_sale: Enable billing/delivery address on checkout process
Purpose
=======

Address management is not clear. If you use the eCommerce, you can set 2 different addresses (billing / shipping) in the checkout process while the related access right group is not activated (group_sale_delivery_address). So you don't see such dates in the backend, which leads to potential conflicts with customer (if the delivery address is different).

Functional spec
===============

- Hide shipping stuff in checkout if option is not activated:
- When eCommerce is installed, group_sale_delivery_address should be activated automatically.
- If you uncheck it from user access (already it is disable in sale settings) , it has to disappear in both the bakend AND the frontend.
2017-02-10 14:04:30 +01:00
Martin Trigaux d20fd7bdbb [FIX] web: display checked checkbox when printing
Fixes #15147
2017-02-10 13:34:31 +01:00
Christophe Simonis cbdd0b20dc [MERGE] forward port branch 10.0 up to ffd4442b06 2017-02-10 13:17:02 +01:00
Thibault Delavallée 18ce1c9215 [FIX] event: propagate use of correct default_auto_confirmation key
Fix a14bdbd4be made event correctly use
default_auto_confirmation key. However since commit bf82638bb0
tests were also not correctly using the ir values key.

This commit should fix all use of that key. Maybe.
2017-02-10 13:15:54 +01:00
Christophe Simonis ffd4442b06 [MERGE] forward port branch saas-11 up to 06e9e45d03 2017-02-10 11:49:35 +01:00
qsm-odoo b5971e417f [FIX] web: hide list readonly checkbox when entering edition
Forward-port of https://github.com/odoo/enterprise/commit/8a55b3f9f7a7524583effb8198c03ebf695131bd

There are multiple problems with the editable view list. It should be
solved once and for all in the work-in-progress master.

This commit fixes a bug with readonly checkboxes. When a field is
readonly, the table cell gets the "o_readonly" class which changes
its style and behavior. When entering edition, the cells are hidden
except the ones with this "o_readonly" class so that their style are
not affected. The "o_readonly" cell content however was hidden thanks
to a "color: transparent;" rule to let the form readonly field show
the value. The problem is that checkboxes... are not hidden with this
"color: transparent;" rule. Also, the "o_readonly" class is not toggled
during edition while the readonly status could be... so the right fix
would be to get rid of this "o_readonly" class and let the inline form
handle the behavior, but this would affect style and possibly break
unknown behavior.

This fix adds rules to handle the checkbox case correctly.
2017-02-10 11:49:05 +01:00
Christophe Simonis 06e9e45d03 [MERGE] forward port branch 9.0 up to 6f29e7307e 2017-02-10 11:21:14 +01:00
Christophe Simonis 6f29e7307e [MERGE] forward port branch saas-6 up to e60ba73e52 2017-02-10 11:12:03 +01:00
Christophe Simonis e60ba73e52 [MERGE] forward port branch 8.0 up to 8cb13c4e4c 2017-02-10 11:09:14 +01:00
Goffin Simon 2f328d3447 [FIX] web: Dashboards error
Steps to reproduce:
Go to any pivot view (for example Sales > Report > Sales) and add
the current view to your personnal dashboard (in the search view: Favourites > Add to my Dashboard)
Go to the dashboard, traceback because $buttons was not defined.

opw:707296
2017-02-10 11:01:03 +01:00
Thibault Delavallée a14bdbd4be [FIX] event: fix use of default ir.values auto_confirmation changed to default_auto_confirmation at bf82638bb0
As we now rely on the standard res.config behavior some ir.values
keys have been changed to default_<key>. This commit fixes the use
of auto_confirmation key.
2017-02-10 10:31:20 +01:00
Nicolas Martinelli 3f16ed9ef7 [FIX] mrp: crash onchange
In a MO, change a product in "Consumed Materials" by clicking on "Search
more...". It crashes.

Clicking on "Search more..." triggers the onchange since it empties the
line. Since there is no product on the line anymore, it crashes.

opw-705644
2017-02-09 15:51:08 +01:00
mge-odoo bf26445057 [IMP] base: use image_small on res_partner_view
Complement to https://github.com/odoo/odoo/commit/025fa4791c966cc35ad81f5664f25c8bd0502fb5
See #9731
2017-02-09 15:41:54 +01:00
Nicolas Martinelli d2b9e8aa03 [REF] base, mail: use new format_date method 2017-02-09 15:15:59 +01:00
Nicolas Martinelli b1eb344479 [IMP] tools: add format_date method
Add a method to format a date in a given language. This appears to be
useful since formatting is not always done by QWeb, but also:
- in mail templates
- in formatted strings (error messages, pre-filled text fields)
2017-02-09 15:15:59 +01:00
Freeman Helmuth 800a4b6728 [FIX] doc: CentOS spelling
Closes #15408
2017-02-09 15:07:47 +01:00
mmo 7bcd614427 [IMP] stock: Rename Reserve button on the picking form view
PURPOSE
=======

Clarify name of the buttons for the users. Two buttons doing the same thing shouldn't be named differently.

SPEC
====

Rename the button "reserve" to "check availability" to make it consistent with the button on MO.
2017-02-09 14:19:32 +01:00